ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity

fix: resolve N1-N3 consistency findings (plan structure + T034 audit count + quickstart audit note)

Browse Source
This commit is contained in:
Ahmed Darrazi 2026-02-22 15:28:48 +01:00
parent d67e2c84bc
commit 169a6a1198
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
specs/107-workspace-chooser/plan.md
View File

@ -67,6 +67,8 @@ ### Source Code (repository root)
```text ```text
app/ app/
├── Http/ ├── Http/
│ ├── Controllers/
│ │ └── SwitchWorkspaceController.php # MODIFY — WorkspaceRedirectResolver + audit (context_bar)
│ └── Middleware/ │ └── Middleware/
│ └── EnsureWorkspaceSelected.php # MODIFY — refactor to spec algorithm │ └── EnsureWorkspaceSelected.php # MODIFY — refactor to spec algorithm
├── Filament/ ├── Filament/
@ -87,6 +89,9 @@ ### Source Code (repository root)
└── pages/ └── pages/
└── choose-workspace.blade.php # MODIFY — metadata cards, empty state, manage link └── choose-workspace.blade.php # MODIFY — metadata cards, empty state, manage link
routes/
└── web.php # MODIFY — WorkspaceRedirectResolver integration
tests/ tests/
└── Feature/ └── Feature/
└── Workspaces/ └── Workspaces/

2
specs/107-workspace-chooser/quickstart.md
View File

@ -50,7 +50,7 @@ ### Phase D: User Menu Integration
### Phase E: Cleanup & Verification ### Phase E: Cleanup & Verification
12. **Replace inline tenant-branching** in `SwitchWorkspaceController` and `routes/web.php` with `WorkspaceRedirectResolver` 12. **Replace inline tenant-branching** in `SwitchWorkspaceController` and `routes/web.php` with `WorkspaceRedirectResolver`; add `WorkspaceAuditLogger::log()` for `context_bar` switch path in `SwitchWorkspaceController`
13. **Run full test suite** — verify no regressions 13. **Run full test suite** — verify no regressions
14. **Pint formatting** — `vendor/bin/sail bin pint --dirty` 14. **Pint formatting** — `vendor/bin/sail bin pint --dirty`
15. **Commit + push** 15. **Commit + push**

2
specs/107-workspace-chooser/tasks.md
View File

@ -156,7 +156,7 @@ ## Phase 8: User Story 6 — Audit Trail for Workspace Context Changes (Priority
### Implementation for User Story 6 ### Implementation for User Story 6
- [ ] T034 [US6] Write comprehensive audit payload verification test covering all three audit scenarios (auto/single_membership, auto/last_used, manual/chooser) with full metadata assertion (`method`, `reason`, `prev_workspace_id`, `resource_type`, `resource_id`) in `tests/Feature/Workspaces/WorkspaceAuditTrailTest.php` - [ ] T034 [US6] Write comprehensive audit payload verification test covering all four audit scenarios (auto/single_membership, auto/last_used, manual/chooser, manual/context_bar) with full metadata assertion (`method`, `reason`, `prev_workspace_id`, `resource_type`, `resource_id`) in `tests/Feature/Workspaces/WorkspaceAuditTrailTest.php`
- [ ] T035 [US6] Write test `it_includes_prev_workspace_id_when_switching_from_active_workspace` — verify previous workspace context is captured in audit metadata in `tests/Feature/Workspaces/WorkspaceAuditTrailTest.php` - [ ] T035 [US6] Write test `it_includes_prev_workspace_id_when_switching_from_active_workspace` — verify previous workspace context is captured in audit metadata in `tests/Feature/Workspaces/WorkspaceAuditTrailTest.php`
**Checkpoint**: All six user stories are implemented and tested. Audit trail is verified for compliance. **Checkpoint**: All six user stories are implemented and tested. Audit trail is verified for compliance.