diff --git a/specs/322-browser-no-drift-regression-guard/tasks.md b/specs/322-browser-no-drift-regression-guard/tasks.md index a5d9111a..a2257587 100644 --- a/specs/322-browser-no-drift-regression-guard/tasks.md +++ b/specs/322-browser-no-drift-regression-guard/tasks.md @@ -113,69 +113,79 @@ ## Phase 10: Validation - [x] T062 Run targeted Feature/static guards from `specs/322-browser-no-drift-regression-guard/test-plan.md`. - [x] T063 Run targeted Browser guards from `specs/322-browser-no-drift-regression-guard/test-plan.md`. -- [ ] T064 Run existing related regression filter command from `specs/322-browser-no-drift-regression-guard/test-plan.md`. - - The original combined command was attempted and then split for reviewability. The Unit/Feature slice completes with the Baseline Compare failures documented below. The Spec322 Browser slice completes green. The original combined command is not used as the merge gate because the mixed Feature/Browser run previously stalled behind a Playwright server after reporting Feature failures. +- [x] T064 Run existing related regression filter command from `specs/322-browser-no-drift-regression-guard/test-plan.md`. + - The original combined command was attempted during the Spec 322 branch validation and then split for reviewability. After Spec 319 was merged into `platform-dev`, the Unit/Feature slice completes green and the Spec 322 Browser slice completes green. The mixed Feature/Browser command is not used as the merge gate because the split commands isolate Feature/runtime regressions from browser harness runtime. - [x] T065 Run `cd apps/platform && ./vendor/bin/sail pint --dirty`. - [x] T066 Run `git diff --check` from the repository root. - [x] T067 Record exact commands, results, browser gaps, screenshots, full-suite status, and unrelated residual failures in the final implementation report. ### Broader Regression Note -Scope check: +Original Spec 322 scope check: - Branch: `322-browser-no-drift-regression-guard` - Diff scope: only Spec 322 spec artifacts, Spec 322 Feature tests, Spec 322 Browser tests, and `tests/Browser/Support/Spec322WorkspaceEnvironmentBrowserHarness.php`. -- No 319/320/321 artifacts are included in the current diff. +- No 319/320/321 artifacts were included in the Spec 322 diff. -Targeted Spec 322 gates: +Targeted Spec 322 gates on the original branch: - `./vendor/bin/sail artisan test tests/Feature/Navigation/Spec322AdminSurfaceScopeContractTest.php tests/Feature/Navigation/Spec322LegacyQueryAliasGuardTest.php tests/Feature/Navigation/Spec322EnvironmentCtaUrlContractTest.php --compact` - Result: 8 passed, 400 assertions. - `./vendor/bin/sail artisan test tests/Browser/Spec322WorkspaceHubNoDriftSmokeTest.php tests/Browser/Spec322EnvironmentOwnedSurfaceSmokeTest.php tests/Browser/Spec322WorkspaceOwnedAnalysisSmokeTest.php tests/Browser/Spec322AlertsAuditNoDriftSmokeTest.php --compact` - Result: 9 passed, 510 assertions. -Broader regression split: +Original broader regression split before Spec 319 was reopened: - `./vendor/bin/sail artisan test tests/Unit tests/Feature --filter='WorkspaceHub|EnvironmentFilter|ClearFilter|LegacyTenant|BaselineCompare|WorkspaceOwnedAnalysis|AlertsAudit' --compact --stop-on-failure` - Result: failed at the first Baseline Compare explanation failure before any Browser tests were involved. - `./vendor/bin/sail artisan test tests/Unit tests/Feature --filter='WorkspaceHub|EnvironmentFilter|ClearFilter|LegacyTenant|BaselineCompare|WorkspaceOwnedAnalysis|AlertsAudit' --compact` - Result: 5 failed, 237 passed, 1884 assertions. -Known remaining broader-regression failures: +Known broader-regression failures from the original Spec 322 pass: - `Tests\Feature\Baselines\BaselineCompareExplanationFallbackTest` - Test: `it shows an unavailable explanation before any baseline compare result exists` - - Individual rerun: fails. - Failure: expected page output to contain `A current baseline compare result is not available yet.` - `Tests\Feature\Filament\BaselineCompareExplanationSurfaceTest` - Test: `it renders suppressed baseline-compare results as explanation-first guidance` - - Individual rerun: fails. - Failure: expected page output to contain `The last compare finished, but normal result output was suppressed.` - `Tests\Feature\Filament\BaselineCompareSummaryConsistencyTest` - Test: `it keeps widget, landing, and banner equally cautious for the same limited-confidence result` - - Individual rerun: fails. - Failure: expected page output to contain `Needs review`. - `Tests\Feature\Filament\BaselineCompareSummaryConsistencyTest` - Test: `it keeps widget, landing, and banner aligned when overdue workflow makes the state action-required` - - Individual rerun: fails. - Failure: expected page output to contain `Action required`. - `Tests\Feature\Filament\BaselineCompareSummaryConsistencyTest` - Test: `it keeps widget, landing, and banner aligned while compare is still in progress` - - Individual rerun: fails. - Failure: expected page output to contain `In progress`. -Spec322-caused broader-regression issue found and fixed: +Spec 322-caused broader-regression issue found and fixed on the original branch: - `Tests\Feature\Guards\LegacyTenantPlatformContextCleanupTest` initially failed because `Spec322LegacyQueryAliasGuardTest.php` contained the retired literal `ensure-filament-tenant-selected` inside its own search pattern list. - Fixed by splitting the literal in the pattern construction while preserving the generated regex. - Individual rerun result: `LegacyTenantPlatformContextCleanupTest` passes, 6 tests, 19 assertions. -Out-of-scope assessment: +Post-319 integrated validation on `platform-dev`: -- The remaining 5 failures are in untouched Baseline Compare test files and reproduce when run individually. -- They are not Browser-harness failures and not Spec322 targeted guard failures. -- They are not proven pre-existing against a clean `dev` checkout in this working tree, but they are independent of the Spec322 diff: Spec322 changed only tests/spec artifacts and no Baseline Compare product code. -- Treat these as a separate Baseline Compare test-suite hygiene/runtime investigation, not as a Spec322 no-drift regression. +- Commit: `094fff87` (`319-environment-owned-surface-routing-shell-context-contract (#382)`), after Spec 322 (`#379`) and Spec 319 (`#382`) were both merged. +- `./vendor/bin/sail artisan test tests/Feature/Navigation/Spec322AdminSurfaceScopeContractTest.php tests/Feature/Navigation/Spec322LegacyQueryAliasGuardTest.php tests/Feature/Navigation/Spec322EnvironmentCtaUrlContractTest.php --compact` + - Result: 8 passed, 400 assertions. +- `./vendor/bin/sail artisan test tests/Unit tests/Feature --filter='WorkspaceHub|EnvironmentFilter|ClearFilter|LegacyTenant|BaselineCompare|WorkspaceOwnedAnalysis|AlertsAudit' --compact` + - Result: 242 passed, 1907 assertions. +- `./vendor/bin/sail artisan test tests/Browser/Spec322WorkspaceHubNoDriftSmokeTest.php tests/Browser/Spec322EnvironmentOwnedSurfaceSmokeTest.php tests/Browser/Spec322WorkspaceOwnedAnalysisSmokeTest.php tests/Browser/Spec322AlertsAuditNoDriftSmokeTest.php --compact` + - Result: 9 passed, 510 assertions. +- `./vendor/bin/sail pint --dirty` + - Result: pass, 0 files changed. +- `git diff --check` + - Result: pass. + +Post-319 assessment: + +- The five Baseline Compare failures were resolved by the Spec 319 test-alignment merge. +- They are no longer remaining failures on the integrated `platform-dev` stand. +- No Spec 322 targeted Feature/static guard failed. +- No Spec 322 targeted Browser guard failed. +- Full suite was not run. ## Phase 11: Non-Goals / Stop Conditions