From d57fc5994b68f94b3779a6f4058fd87b958de75f Mon Sep 17 00:00:00 2001 From: Ahmed Darrazi Date: Fri, 26 Dec 2025 23:49:57 +0100 Subject: [PATCH] spec: update 006 tasks checklist --- specs/006-sot-foundations-assignments/tasks.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/specs/006-sot-foundations-assignments/tasks.md b/specs/006-sot-foundations-assignments/tasks.md index cd68a2a..3540826 100644 --- a/specs/006-sot-foundations-assignments/tasks.md +++ b/specs/006-sot-foundations-assignments/tasks.md @@ -66,8 +66,8 @@ ## Phase 5: Conditional Access Preview-Only Enforcement **Purpose**: Keep CA restore preview-only even in execute mode. -- [ ] T016 Update `app/Services/Intune/RestoreService.php` to prevent CA execution (status skipped, reason preview_only) while keeping preview output. -- [ ] T017 Update restore UI to surface CA preview-only status in `resources/views/filament/infolists/entries/restore-preview.blade.php` and `resources/views/filament/infolists/entries/restore-results.blade.php`. +- [x] T016 Update `app/Services/Intune/RestoreService.php` to prevent CA execution (status skipped, reason preview_only) while keeping preview output. +- [x] T017 Update restore UI to surface CA preview-only status in `resources/views/filament/infolists/entries/restore-preview.blade.php` and `resources/views/filament/infolists/entries/restore-results.blade.php`. **Checkpoint**: CA items never execute; preview clearly signals preview-only. @@ -81,7 +81,7 @@ ## Phase 6: Tests and Verification - [x] T019 [P] Add unit tests for FoundationSnapshotService in `tests/Unit/FoundationSnapshotServiceTest.php`. - [x] T020 Add feature tests for foundations backup/restore preview and execute in `tests/Feature/FoundationBackupTest.php`, `tests/Feature/Filament/RestorePreviewTest.php`, `tests/Feature/Filament/RestoreExecutionTest.php`, `tests/Feature/RestoreScopeTagMappingTest.php`. - [x] T021 Add feature tests for assignment mapping and skip reasons in `tests/Feature/RestoreAssignmentApplicationTest.php`. -- [ ] T022 Add feature test for CA preview-only execution behavior in `tests/Feature/Filament/ConditionalAccessPreviewOnlyTest.php`. +- [x] T022 Add feature test for CA preview-only execution behavior in `tests/Feature/Filament/ConditionalAccessPreviewOnlyTest.php`. - [x] T023 Run tests: `./vendor/bin/sail artisan test tests/Unit/FoundationSnapshotServiceTest.php tests/Unit/FoundationMappingServiceTest.php tests/Unit/TenantPermissionServiceTest.php tests/Feature/FoundationBackupTest.php tests/Feature/Filament/RestoreExecutionTest.php tests/Feature/Filament/RestorePreviewTest.php tests/Feature/Filament/RestoreItemSelectionTest.php tests/Feature/RestoreAssignmentApplicationTest.php tests/Feature/RestoreScopeTagMappingTest.php tests/Feature/RestoreRunRerunTest.php` - [x] T024 Run Pint: `./vendor/bin/pint --dirty`