Compare commits

...

4 Commits

Author SHA1 Message Date
fb32e9bfa5 feat: canonical operation type source of truth (#276)
Some checks failed
Main Confidence / confidence (push) Failing after 49s
## Summary
- implement the canonical operation type source-of-truth slice across operation writers, monitoring surfaces, onboarding flows, and supporting services
- add focused contract and regression coverage for canonical operation type handling
- include the generated spec 239 artifacts for the feature slice

## Validation
- browser smoke PASS for `/admin` -> workspace overview -> operations -> operation detail -> tenant-scoped operations drilldown
- spec/plan/tasks/quickstart artifact analysis cleaned up to a no-findings state
- automated test suite not run in this session

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #276
2026-04-25 18:11:23 +00:00
58f9bb7355 chore: commit all workspace changes (#275)
Some checks failed
Main Confidence / confidence (push) Failing after 1m34s
Auto-generated PR: commit all workspace changes (includes .github/skills addition).

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #275
2026-04-25 09:13:54 +00:00
110245a9ec feat: neutralize provider connection target-scope surfaces (#274)
Some checks are pending
Main Confidence / confidence (push) Waiting to run
## Summary
- add a shared provider target-scope descriptor, normalizer, identity-context metadata, and surface-summary layer
- update provider connection list, detail, create, edit, and onboarding surfaces to use neutral target-scope vocabulary while keeping Microsoft identity contextual
- align provider connection audit and resolver output with the neutral target-scope contract and add focused guard/unit/feature coverage for regressions

## Validation
- browser smoke: opened the tenant-scoped provider connection list, drilled into detail, and verified the edit/create surfaces in local admin context

## Notes
- this PR comes from the session branch created for the active feature work
- no additional runtime or persistence layer was introduced in this slice

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #274
2026-04-25 09:07:40 +00:00
bd26e209de feat: harden provider boundaries (#273)
Some checks failed
Main Confidence / confidence (push) Failing after 57s
## Summary
- add the provider boundary catalog, boundary support types, and guardrails for platform-core versus provider-owned seams
- harden provider gateway, identity resolution, operation registry, and start-gate behavior to require explicit provider bindings
- add unit and feature coverage for boundary classification, runtime preservation, unsupported paths, and platform-core leakage guards
- add the full Spec Kit artifact set for spec 237 and update roadmap/spec-candidate tracking

## Validation
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Providers/ProviderBoundaryClassificationTest.php tests/Unit/Providers/ProviderBoundaryGuardrailTest.php tests/Feature/Providers/ProviderBoundaryHardeningTest.php tests/Feature/Providers/UnsupportedProviderBoundaryPathTest.php tests/Feature/Guards/ProviderBoundaryPlatformCoreGuardTest.php`
- `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Unit/Providers/ProviderGatewayTest.php tests/Unit/Providers/ProviderIdentityResolverTest.php tests/Unit/Providers/ProviderOperationStartGateTest.php`
- `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent`
- browser smoke: `http://localhost/admin/provider-connections?tenant_id=18000000-0000-4000-8000-000000000180` loaded with the local smoke user, the empty-state CTA reached the canonical create route, and cancel returned to the scoped list

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #273
2026-04-24 21:05:37 +00:00
142 changed files with 9104 additions and 435 deletions

View File

@ -250,6 +250,12 @@ ## Active Technologies
- Existing PostgreSQL tables only; no new table or schema migration is planned in the mainline slice (235-baseline-capture-truth) - Existing PostgreSQL tables only; no new table or schema migration is planned in the mainline slice (235-baseline-capture-truth)
- PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Pest v4, existing governance domain models and builders, existing Evidence Snapshot and Tenant Review infrastructure (236-canonical-control-catalog-foundation) - PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Pest v4, existing governance domain models and builders, existing Evidence Snapshot and Tenant Review infrastructure (236-canonical-control-catalog-foundation)
- PostgreSQL for existing downstream governance artifacts plus a product-seeded in-repo canonical control registry; no new DB-backed control authoring table in the first slice (236-canonical-control-catalog-foundation) - PostgreSQL for existing downstream governance artifacts plus a product-seeded in-repo canonical control registry; no new DB-backed control authoring table in the first slice (236-canonical-control-catalog-foundation)
- PHP 8.4.15, Laravel 12, Filament v5, Livewire v4 + existing provider seams under `App\Services\Providers` and `App\Services\Graph`, especially `ProviderGateway`, `ProviderIdentityResolver`, `ProviderIdentityResolution`, `PlatformProviderIdentityResolver`, `ProviderConnectionResolver`, `ProviderConnectionResolution`, `MicrosoftGraphOptionsResolver`, `ProviderOperationRegistry`, `ProviderOperationStartGate`, `GraphClientInterface`, Pest v4 (237-provider-boundary-hardening)
- Existing PostgreSQL tables such as `provider_connections` and `operation_runs`; one new in-repo config catalog for provider-boundary ownership; no new database tables (237-provider-boundary-hardening)
- PHP 8.4.15, Laravel 12, Filament v5, Livewire v4 + `ProviderConnectionResource`, `ManagedTenantOnboardingWizard`, `ProviderConnection`, `ProviderConnectionResolver`, `ProviderConnectionResolution`, `ProviderConnectionMutationService`, `ProviderConnectionStateProjector`, `ProviderIdentityResolver`, `ProviderIdentityResolution`, `PlatformProviderIdentityResolver`, `BadgeRenderer`, Pest v4 (238-provider-identity-target-scope)
- Existing PostgreSQL tables such as `provider_connections`, `provider_credentials`, and existing audit tables; no new database tables planned (238-provider-identity-target-scope)
- PHP 8.4.15, Laravel 12, Filament v5, Livewire v4 + existing `App\Support\OperationCatalog`, `App\Support\OperationRunType`, `App\Services\OperationRunService`, `App\Services\Providers\ProviderOperationRegistry`, `App\Services\Providers\ProviderOperationStartGate`, `App\Filament\Resources\OperationRunResource`, `App\Filament\Pages\Workspaces\ManagedTenantOnboardingWizard`, `App\Support\Filament\FilterOptionCatalog`, `App\Support\OpsUx\OperationUxPresenter`, `App\Support\References\Resolvers\OperationRunReferenceResolver`, `App\Services\Audit\AuditEventBuilder`, Pest v4 (239-canonical-operation-type-source-of-truth)
- PostgreSQL via existing `operation_runs.type` and `managed_tenant_onboarding_sessions.state->bootstrap_operation_types`, plus config-backed `tenantpilot.operations.lifecycle.covered_types` and `tenantpilot.platform_vocabulary`; no new tables (239-canonical-operation-type-source-of-truth)
- PHP 8.4.15 (feat/005-bulk-operations) - PHP 8.4.15 (feat/005-bulk-operations)
@ -284,9 +290,9 @@ ## Code Style
PHP 8.4.15: Follow standard conventions PHP 8.4.15: Follow standard conventions
## Recent Changes ## Recent Changes
- 236-canonical-control-catalog-foundation: Added PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Pest v4, existing governance domain models and builders, existing Evidence Snapshot and Tenant Review infrastructure - 239-canonical-operation-type-source-of-truth: Added PHP 8.4.15, Laravel 12, Filament v5, Livewire v4 + existing `App\Support\OperationCatalog`, `App\Support\OperationRunType`, `App\Services\OperationRunService`, `App\Services\Providers\ProviderOperationRegistry`, `App\Services\Providers\ProviderOperationStartGate`, `App\Filament\Resources\OperationRunResource`, `App\Filament\Pages\Workspaces\ManagedTenantOnboardingWizard`, `App\Support\Filament\FilterOptionCatalog`, `App\Support\OpsUx\OperationUxPresenter`, `App\Support\References\Resolvers\OperationRunReferenceResolver`, `App\Services\Audit\AuditEventBuilder`, Pest v4
- 235-baseline-capture-truth: Added PHP 8.4.15, Laravel 12, Filament v5, Livewire v4 + `BaselineCaptureService`, `CaptureBaselineSnapshotJob`, `BaselineReasonCodes`, `BaselineCompareStats`, `ReasonTranslator`, `GovernanceRunDiagnosticSummaryBuilder`, `OperationRunService`, `BaselineProfile`, `BaselineSnapshot`, `OperationRunOutcome`, existing Filament capture/compare surfaces - 238-provider-identity-target-scope: Added PHP 8.4.15, Laravel 12, Filament v5, Livewire v4 + `ProviderConnectionResource`, `ManagedTenantOnboardingWizard`, `ProviderConnection`, `ProviderConnectionResolver`, `ProviderConnectionResolution`, `ProviderConnectionMutationService`, `ProviderConnectionStateProjector`, `ProviderIdentityResolver`, `ProviderIdentityResolution`, `PlatformProviderIdentityResolver`, `BadgeRenderer`, Pest v4
- 234-dead-transitional-residue: Added PHP 8.4.15, Laravel 12, Filament v5, Livewire v4 + `App\Models\BaselineProfile`, `App\Support\Baselines\BaselineProfileStatus`, `App\Support\Badges\BadgeCatalog`, `App\Support\Badges\BadgeDomain`, `Database\Factories\TenantFactory`, `App\Console\Commands\SeedBackupHealthBrowserFixture`, existing tenant-truth and baseline-profile Pest tests - 237-provider-boundary-hardening: Added PHP 8.4.15, Laravel 12, Filament v5, Livewire v4 + existing provider seams under `App\Services\Providers` and `App\Services\Graph`, especially `ProviderGateway`, `ProviderIdentityResolver`, `ProviderIdentityResolution`, `PlatformProviderIdentityResolver`, `ProviderConnectionResolver`, `ProviderConnectionResolution`, `MicrosoftGraphOptionsResolver`, `ProviderOperationRegistry`, `ProviderOperationStartGate`, `GraphClientInterface`, Pest v4
<!-- MANUAL ADDITIONS START --> <!-- MANUAL ADDITIONS START -->
### Pre-production compatibility check ### Pre-production compatibility check

View File

@ -0,0 +1,398 @@
---
name: spec-kit-next-best-one-shot
description: Select the most suitable next TenantPilot/TenantAtlas spec from roadmap and spec-candidates, then run the GitHub Spec Kit preparation flow in one pass: specify, plan, tasks, and analyze. Use when the user wants the agent to choose the next best spec, execute the real Spec Kit workflow including branch/spec-directory mechanics, analyze the generated artifacts, and fix preparation issues before implementation. This skill must not implement application code.
---
# Skill: Spec Kit Next-Best One-Shot Preparation
## Purpose
Use this skill when the user wants the agent to select the most suitable next spec from existing product planning sources and then execute the real GitHub Spec Kit preparation flow in one pass:
1. select the next best spec candidate from roadmap and spec candidates
2. run the repository's Spec Kit `specify` flow for that selected candidate
3. run the repository's Spec Kit `plan` flow for the generated spec
4. run the repository's Spec Kit `tasks` flow for the generated plan
5. run the repository's Spec Kit `analyze` flow against the generated artifacts
6. fix issues in Spec Kit preparation artifacts only (`spec.md`, `plan.md`, `tasks.md`, and related Spec Kit metadata if required)
7. stop before implementation
8. provide a concise readiness summary for the user
This skill must use the repository's actual Spec Kit scripts, commands, templates, branch naming rules, and generated paths. It must not manually bypass Spec Kit by creating arbitrary spec folders or files. The only allowed fixes after `analyze` are preparation-artifact fixes, not application-code implementation.
The intended workflow is:
```text
roadmap.md + spec-candidates.md
→ select next best spec
→ run Spec Kit specify
→ run Spec Kit plan
→ run Spec Kit tasks
→ run Spec Kit analyze
→ fix preparation-artifact issues
→ explicit implementation step later
```
## When to Use
Use this skill when the user asks things like:
```text
Nimm die nächste sinnvollste Spec aus roadmap und spec-candidates und führe specify, plan, tasks und analyze aus.
```
```text
Wähle die nächste geeignete Spec und mach den Spec-Kit-Flow inklusive analyze in einem Rutsch.
```
```text
Schau in roadmap.md und spec-candidates.md und starte daraus specify, plan, tasks und analyze.
```
```text
Such die beste nächste Spec aus und bereite sie per GitHub Spec Kit vollständig vor.
```
```text
Nimm angesichts Roadmap und Spec Candidates das sinnvollste nächste Thema, aber nicht implementieren.
```
## Hard Rules
- Work strictly repo-based.
- Use the repository's actual GitHub Spec Kit workflow.
- Do not manually invent spec numbers, branch names, or spec paths if Spec Kit provides a script or command for that.
- Do not manually create `spec.md`, `plan.md`, or `tasks.md` when the Spec Kit workflow can generate them.
- Do not bypass Spec Kit branch mechanics.
- Run `analyze` after `tasks` when the repository supports it.
- Fix only issues found in Spec Kit preparation artifacts and planning metadata.
- Do not treat analyze findings as permission to implement product code.
- If analyze reports implementation work as missing, record it in `tasks.md` instead of implementing it.
- Do not implement application code.
- Do not modify production code.
- Do not modify migrations, models, services, jobs, Filament resources, Livewire components, policies, commands, or tests unless the user explicitly starts a later implementation task.
- Do not execute implementation commands.
- Do not run destructive commands.
- Do not invent roadmap priorities not supported by repository documents.
- Do not pick a spec only because it is listed first.
- Do not select broad platform rewrites when a smaller dependency-unlocking spec is more appropriate.
- Prefer specs that unlock roadmap progress, reduce architectural drift, harden foundations, or remove known blockers.
- Prefer small, reviewable, implementation-ready specs over large ambiguous themes.
- Preserve TenantPilot/TenantAtlas terminology.
- Follow the repository constitution and existing Spec Kit conventions.
- If repository truth conflicts with roadmap/candidate wording, keep repository truth and document the deviation.
- If no candidate is suitable, do not run Spec Kit commands and explain why.
## Required Repository Checks Before Selection
Before selecting the next spec, inspect:
1. `.specify/memory/constitution.md`
2. `.specify/templates/`
3. `.specify/scripts/`
4. existing Spec Kit command usage or repository instructions, if present
5. `specs/`
6. `docs/product/spec-candidates.md`
7. roadmap documents under `docs/product/`, especially `roadmap.md` if present
8. nearby existing specs related to top candidate areas
9. current branch and git status
10. application code only as needed to verify whether a candidate is already done, blocked, duplicated, or technically mis-scoped
Do not edit application code.
## Git and Branch Safety
Before running any Spec Kit command or script:
1. Check the current branch.
2. Check whether the working tree is clean.
3. If there are unrelated uncommitted changes, stop and report them. Do not continue.
4. If the working tree only contains user-intended planning edits for this operation, continue cautiously.
5. Let Spec Kit create or switch to the correct feature branch when that is how the repository workflow works.
6. Do not force checkout, reset, stash, rebase, merge, or delete branches.
7. Do not overwrite existing specs.
If the repo requires an explicit branch creation script for `specify`, use that script rather than manually creating the branch.
## Candidate Selection Criteria
Evaluate candidate specs using these criteria.
### 1. Roadmap Fit
Prefer candidates that directly support the current roadmap sequence or unlock the next roadmap layer.
Examples:
- governance foundations before advanced compliance views
- evidence/snapshot foundations before auditor packs
- control catalog foundations before CIS/NIS2 mappings
- decision/workflow surfaces before autonomous governance
- provider/platform boundary cleanup before multi-provider expansion
### 2. Foundation Value
Prefer candidates that strengthen reusable platform foundations:
- RBAC and workspace/tenant isolation
- auditability
- evidence and snapshot truth
- operation observability
- provider boundary neutrality
- canonical vocabulary
- baseline/control/finding semantics
- enterprise detail-page or decision-surface patterns
### 3. Dependency Unblocking
Prefer specs that unblock multiple later candidates.
A good next spec should usually make future specs smaller, safer, or more consistent.
### 4. Scope Size
Prefer a candidate that can be implemented as a narrow, testable slice.
Avoid selecting:
- broad platform rewrites
- vague product themes
- multi-feature bundles
- speculative future-provider frameworks
- large UX redesigns without a clear first slice
### 5. Repo Readiness
Prefer candidates where the repository already has enough structure to implement the next slice safely.
Check whether related models, services, UI pages, tests, or concepts already exist.
### 6. Risk Reduction
Prefer candidates that reduce current architectural or product risk:
- legacy dual-world semantics
- unclear truth ownership
- inconsistent operator UX
- missing audit/evidence boundaries
- repeated manual workflow friction
- false-positive calmness in governance surfaces
### 7. User/Product Value
Prefer specs that produce visible operator value or make the platform more sellable without creating heavy scope.
## Required Selection Output Before Spec Kit Execution
Before running the Spec Kit flow, identify:
- selected candidate title
- source location in roadmap/spec-candidates
- why it was selected
- why close alternatives were deferred
- roadmap relationship
- smallest viable implementation slice
- proposed concise feature description to feed into `specify`
The feature description must be product- and behavior-oriented. It should not be a low-level implementation plan.
## Spec Kit Execution Flow
After selecting the candidate, execute the real repository Spec Kit preparation sequence, including analysis and preparation-artifact fixes.
### Step 1: Determine the repository's Spec Kit command pattern
Inspect repository instructions and scripts to identify how this repo expects Spec Kit to be run.
Common locations to inspect:
```text
.specify/scripts/
.specify/templates/
.specify/memory/constitution.md
.github/prompts/
.github/skills/
README.md
specs/
```
Use the repo-specific mechanism if present.
### Step 2: Run `specify`
Run the repository's `specify` flow using the selected candidate and the smallest viable slice.
The `specify` input should include:
- selected candidate title
- problem statement
- operator/user value
- roadmap relationship
- out-of-scope boundaries
- key acceptance criteria
- important enterprise constraints
Let Spec Kit create the correct branch and spec location if that is the repo's configured behavior.
### Step 3: Run `plan`
Run the repository's `plan` flow for the generated spec.
The `plan` input should keep the scope tight and should require repo-based alignment with:
- constitution
- existing architecture
- workspace/tenant isolation
- RBAC
- OperationRun/observability where relevant
- evidence/snapshot/truth semantics where relevant
- Filament/Livewire conventions where relevant
- test strategy
### Step 4: Run `tasks`
Run the repository's `tasks` flow for the generated plan.
The generated tasks must be:
- ordered
- small
- testable
- grouped by phase
- limited to the selected scope
- suitable for later manual analysis before implementation
### Step 5: Run `analyze`
Run the repository's `analyze` flow against the generated Spec Kit artifacts.
Analyze must check:
- consistency between `spec.md`, `plan.md`, and `tasks.md`
- constitution alignment
- roadmap alignment
- whether the selected candidate was narrowed safely
- whether tasks are complete enough for implementation
- whether tasks accidentally require scope not described in the spec
- whether plan details conflict with repository architecture or terminology
- whether implementation risks are documented instead of silently ignored
Do not use analyze as a trigger to implement application code.
### Step 6: Fix preparation-artifact issues only
If analyze finds issues, fix only Spec Kit preparation artifacts such as:
- `spec.md`
- `plan.md`
- `tasks.md`
- generated Spec Kit metadata files, if the repository uses them
Allowed fixes include:
- clarify requirements
- tighten scope
- move out-of-scope work into follow-up candidates
- correct terminology
- add missing tasks
- remove tasks not backed by the spec
- align plan language with repository architecture
- add missing acceptance criteria or validation tasks
Forbidden fixes include:
- modifying application code
- creating migrations
- editing models, services, jobs, policies, Filament resources, Livewire components, tests, or commands
- running implementation or test-fix loops
- changing runtime behavior
### Step 7: Stop
After `analyze` has passed or preparation-artifact issues have been fixed, stop.
Do not implement.
Do not modify application code.
Do not run implementation tests unless the repository's Spec Kit preparation command requires a non-destructive validation.
## Failure Handling
If a Spec Kit command or analyze phase fails:
1. Stop immediately.
2. Report the failing command or phase.
3. Summarize the error.
4. Do not attempt implementation as a workaround.
5. Suggest the smallest safe next action.
If the branch or working tree state is unsafe:
1. Stop before running Spec Kit commands.
2. Report the current branch and relevant uncommitted files.
3. Ask the user to commit, stash, or move to a clean worktree.
## Final Response Requirements
After the Spec Kit preparation flow completes, respond with:
1. Selected candidate
2. Why this candidate was selected
3. Why close alternatives were deferred
4. Current branch after Spec Kit execution
5. Generated spec path
6. Files created or updated by Spec Kit
7. Analyze result summary
8. Preparation-artifact fixes applied after analyze
9. Assumptions made
10. Open questions, if any
11. Recommended next implementation prompt
12. Explicit statement that no application implementation was performed
Keep the response concise, but include enough detail for the user to continue immediately.
## Required Next Implementation Prompt
Always provide a ready-to-copy implementation prompt like this, adapted to the generated spec branch/path, but only after analyze has passed or preparation-artifact issues have been fixed:
```markdown
Du bist ein Senior Staff Software Engineer für TenantPilot/TenantAtlas.
Implementiere die vorbereitete Spec `<spec-branch-or-spec-path>` streng anhand von `tasks.md`.
Wichtig:
- Arbeite task-sequenziell.
- Ändere nur Dateien, die für die jeweilige Task notwendig sind.
- Halte dich an `spec.md`, `plan.md`, `tasks.md` und die Constitution.
- Keine Scope-Erweiterung.
- Keine Opportunistic Refactors.
- Führe passende Tests nach sinnvollen Task-Gruppen aus.
- Wenn eine Task unklar oder falsch ist, stoppe und dokumentiere den Konflikt statt frei zu improvisieren.
- Am Ende liefere geänderte Dateien, Teststatus, offene Risiken und nicht erledigte Tasks.
```
## Example Invocation
User:
```text
Nutze den Skill spec-kit-next-best-one-shot.
Wähle aus roadmap.md und spec-candidates.md die nächste sinnvollste Spec.
Führe danach GitHub Spec Kit specify, plan, tasks und analyze in einem Rutsch aus.
Behebe alle analyze-Issues in den Spec-Kit-Artefakten.
Keine Application-Implementierung.
```
Expected behavior:
1. Inspect constitution, Spec Kit scripts/templates, specs, roadmap, and spec candidates.
2. Check branch and working tree safety.
3. Compare candidate suitability.
4. Select the next best candidate.
5. Run the repository's real Spec Kit `specify` flow, letting it handle branch/spec setup.
6. Run the repository's real Spec Kit `plan` flow.
7. Run the repository's real Spec Kit `tasks` flow.
8. Run the repository's real Spec Kit `analyze` flow.
9. Fix analyze issues only in Spec Kit preparation artifacts.
10. Stop before application implementation.
11. Return selection rationale, branch/path summary, artifact summary, analyze summary, fixes applied, and next implementation prompt.
```

View File

@ -0,0 +1,294 @@
---
name: spec-kit-one-shot-prep
description: Describe what this skill does and when to use it. Include keywords that help agents identify relevant tasks.
---
<!-- Tip: Use /create-skill in chat to generate content with agent assistance -->
Define the functionality provided by this skill, including detailed instructions and examples
---
name: spec-kit-one-shot-prep
description: Create Spec Kit preparation artifacts in one pass for TenantPilot/TenantAtlas features: spec.md, plan.md, and tasks.md. Use for feature ideas, roadmap items, spec candidates, governance/platform improvements, UX improvements, cleanup candidates, and repo-based preparation before manual analysis or implementation. This skill must not implement application code.
---
# Skill: Spec Kit One-Shot Preparation
## Purpose
Use this skill to create a complete Spec Kit preparation package for a new TenantPilot/TenantAtlas feature in one pass:
1. `spec.md`
2. `plan.md`
3. `tasks.md`
This skill prepares implementation work, but it must not perform implementation.
The intended workflow is:
```text
feature idea / roadmap item / spec candidate
→ one-shot spec + plan + tasks preparation
→ manual repo-based analysis/review
→ explicit implementation step later
```
## When to Use
Use this skill when the user asks to create or prepare Spec Kit artifacts from:
- a feature idea
- a spec candidate
- a roadmap item
- a product or UX requirement
- a governance/platform improvement
- an architecture cleanup candidate
- a refactoring preparation request
- a TenantPilot/TenantAtlas implementation idea that should first become a formal spec
Typical user prompts:
```text
Mach daraus spec, plan und tasks in einem Rutsch.
```
```text
Erstelle daraus eine neue Spec Kit Vorbereitung, aber noch nicht implementieren.
```
```text
Nimm diesen spec candidate und bereite spec/plan/tasks vor.
```
```text
Erzeuge die Spec Kit Artefakte, danach mache ich die Analyse manuell.
```
## Hard Rules
- Work strictly repo-based.
- Do not implement application code.
- Do not modify production code.
- Do not modify migrations, models, services, jobs, Filament resources, Livewire components, policies, commands, or tests unless the user explicitly starts a later implementation task.
- Do not execute implementation commands.
- Do not run destructive commands.
- Do not expand scope beyond the provided feature idea.
- Do not invent architecture that conflicts with repository truth.
- Do not create broad platform rewrites when a smaller implementable spec is possible.
- Prefer small, reviewable, implementation-ready specs.
- Preserve TenantPilot/TenantAtlas terminology.
- Follow the repository constitution and existing Spec Kit conventions.
- If repository truth conflicts with the user-provided draft, keep repository truth and document the deviation.
- If the feature is too broad, split it into one primary spec and optional follow-up spec candidates.
## Required Inputs
The user should provide at least one of:
- feature title and short goal
- full spec candidate
- roadmap item
- rough problem statement
- UX or architecture improvement idea
If the input is incomplete, proceed with the smallest reasonable interpretation and document assumptions. Do not block on clarification unless the request is impossible to scope safely.
## Required Repository Checks
Before creating or updating Spec Kit artifacts, inspect the relevant repository sources.
Always check:
1. `.specify/memory/constitution.md`
2. `.specify/templates/`
3. `specs/`
4. `docs/product/spec-candidates.md`
5. relevant roadmap documents under `docs/product/`
6. nearby existing specs with related terminology or scope
Check application code only as needed to avoid wrong naming, wrong architecture, or duplicate concepts. Do not edit application code.
## Spec Directory Rules
Create a new spec directory using the next valid spec number and a kebab-case slug:
```text
specs/<number>-<slug>/
```
The exact number must be derived from the current repository state and existing numbering conventions.
Create or update only these preparation artifacts inside the selected spec directory:
```text
specs/<number>-<slug>/spec.md
specs/<number>-<slug>/plan.md
specs/<number>-<slug>/tasks.md
```
If the repository templates require additional preparation files, create them only when this is consistent with existing Spec Kit conventions. Do not create implementation files.
## `spec.md` Requirements
The spec must be product- and behavior-oriented. It should avoid premature implementation detail unless needed for correctness.
Include:
- Feature title
- Problem statement
- Business/product value
- Primary users/operators
- User stories
- Functional requirements
- Non-functional requirements
- UX requirements
- RBAC/security requirements
- Auditability/observability requirements
- Data/truth-source requirements where relevant
- Out of scope
- Acceptance criteria
- Success criteria
- Risks
- Assumptions
- Open questions
TenantPilot/TenantAtlas specs should preserve enterprise SaaS principles:
- workspace/tenant isolation
- capability-first RBAC
- auditability
- operation/result truth separation
- source-of-truth clarity
- calm enterprise operator UX
- progressive disclosure where useful
- no false positive calmness
## `plan.md` Requirements
The plan must be repo-aware and implementation-oriented, but still must not implement.
Include:
- Technical approach
- Existing repository surfaces likely affected
- Domain/model implications
- UI/Filament implications
- Livewire implications where relevant
- OperationRun/monitoring implications where relevant
- RBAC/policy implications
- Audit/logging/evidence implications where relevant
- Data/migration implications where relevant
- Test strategy
- Rollout considerations
- Risk controls
- Implementation phases
The plan should clearly distinguish:
- execution truth
- artifact truth
- backup/snapshot truth
- recovery/evidence truth
- operator next action
Use those distinctions only where relevant to the feature.
## `tasks.md` Requirements
Tasks must be ordered, small, and verifiable.
Include:
- checkbox tasks
- phase grouping
- tests before or alongside implementation tasks where practical
- final validation tasks
- documentation/update tasks if needed
- explicit non-goals where useful
Avoid vague tasks such as:
```text
Clean up code
Refactor UI
Improve performance
Make it enterprise-ready
```
Prefer concrete tasks such as:
```text
- [ ] Add a feature test covering workspace isolation for <specific behavior>.
- [ ] Update <specific Filament page/resource> to display <specific state>.
- [ ] Add policy coverage for <specific capability>.
```
If exact file names are not known yet, phrase tasks as repo-verification tasks first rather than inventing file paths.
## Scope Control
If the requested feature implies multiple independent concerns, create one primary spec for the smallest valuable slice and add a `Follow-up spec candidates` section.
Examples of follow-up candidates:
- assigned findings
- pending approvals
- personal work queue
- notification delivery settings
- evidence pack export hardening
- operation monitoring refinements
- autonomous governance decision surfaces
Do not force all follow-up candidates into the primary spec.
## Final Response Requirements
After creating or updating the artifacts, respond with:
1. Created or updated spec directory
2. Files created or updated
3. Important repo-based adjustments made
4. Assumptions made
5. Open questions, if any
6. Recommended next manual analysis prompt
7. Explicit statement that no implementation was performed
Keep the final response concise, but include enough detail for the user to continue immediately.
## Required Next Manual Analysis Prompt
Always provide a ready-to-copy prompt like this, adapted to the created spec number and slug:
```markdown
Du bist ein Senior Staff Software Architect und Enterprise SaaS Reviewer.
Analysiere die neu erstellte Spec `<spec-number>-<slug>` streng repo-basiert.
Ziel:
Prüfe, ob `spec.md`, `plan.md` und `tasks.md` vollständig, konsistent, implementierbar und constitution-konform sind.
Wichtig:
- Keine Implementierung.
- Keine Codeänderungen.
- Keine Scope-Erweiterung.
- Prüfe nur gegen Repo-Wahrheit.
- Benenne konkrete Konflikte mit Dateien, Patterns, Datenflüssen oder bestehenden Specs.
- Schlage nur minimale Korrekturen an `spec.md`, `plan.md` und `tasks.md` vor.
- Wenn alles passt, gib eine klare Implementierungsfreigabe.
```
## Example Invocation
User:
```text
Nimm diesen Spec Candidate und mach daraus spec, plan und tasks in einem Rutsch. Danach mache ich die Analyse manuell.
```
Expected behavior:
1. Inspect constitution, templates, specs, roadmap, and candidate docs.
2. Determine the next valid spec number.
3. Create `spec.md`, `plan.md`, and `tasks.md` in the new spec directory.
4. Keep scope tight.
5. Do not implement.
6. Return the summary and next manual analysis prompt.

View File

@ -1,28 +1,30 @@
<!-- <!--
Sync Impact Report Sync Impact Report
- Version change: 2.8.0 -> 2.9.0 - Version change: 2.9.0 -> 2.10.0
- Modified principles: - Modified principles:
- Added provider-boundary guardrail set under First Provider Is Not - Expanded Operations / Run Observability Standard so OperationRun
Platform Core (PROV-001 with sub-rules PROV-002 through PROV-005) start UX is shared-contract-owned instead of surface-owned
- Expanded Governance review expectations for provider-owned vs - Expanded Governance review expectations for OperationRun-starting
platform-core boundaries features, explicit queued-notification policy, and bounded
exceptions
- Added sections: - Added sections:
- First Provider Is Not Platform Core (PROV-001): keeps Microsoft as - OperationRun Start UX Contract (OPS-UX-START-001): centralizes
the current first provider without allowing provider-specific queued toast/link/event/message semantics, run/artifact deep links,
semantics to silently become platform-core truth; requires explicit queued DB-notification policy, and tenant/workspace-safe operation
review of provider-owned vs platform-core seams and prefers bounded URL resolution behind one shared OperationRun UX layer
extraction over speculative multi-provider frameworks
- Removed sections: None - Removed sections: None
- Templates requiring updates: - Templates requiring updates:
- .specify/templates/spec-template.md: add provider-boundary platform - .specify/templates/spec-template.md: add OperationRun UX Impact
core check ✅ section + start-contract prompts ✅
- .specify/templates/plan-template.md: add provider-boundary planning - .specify/templates/plan-template.md: add OperationRun UX Impact
fields + constitution check ✅ planning section + constitution checks ✅
- .specify/templates/tasks-template.md: add provider-boundary task - .specify/templates/tasks-template.md: add central start-UX reuse,
requirements ✅ queued-notification policy, and exception tasks ✅
- .specify/templates/checklist-template.md: add provider-boundary - .specify/templates/checklist-template.md: add OperationRun start
review checks ✅ UX review checks ✅
- docs/product/standards/README.md: refresh constitution index for
the new ops-UX contract ✅
- Commands checked: - Commands checked:
- N/A `.specify/templates/commands/*.md` directory is not present - N/A `.specify/templates/commands/*.md` directory is not present
- Follow-up TODOs: None - Follow-up TODOs: None
@ -307,24 +309,57 @@ ### Operations / Run Observability Standard
even if implemented by multiple jobs/steps (“umbrella run”). even if implemented by multiple jobs/steps (“umbrella run”).
- “Single-row” runs MUST still use consistent counters (e.g., `total=1`, `processed=0|1`) and outcome derived from success/failure. - “Single-row” runs MUST still use consistent counters (e.g., `total=1`, `processed=0|1`) and outcome derived from success/failure.
- Monitoring pages MUST be DB-only at render time (no external calls). - Monitoring pages MUST be DB-only at render time (no external calls).
- Start surfaces MUST NOT perform remote work inline; they only: authorize, create/reuse run (dedupe), enqueue work, - Start surfaces MUST NOT perform remote work inline and MUST NOT compose OperationRun start UX locally; they only:
confirm + “View run”. authorize, create/reuse run (dedupe), enqueue work, and hand queued/start-state feedback to the shared
OperationRun Start UX Contract.
### OperationRun Start UX Contract (OPS-UX-START-001)
- OperationRun UX MUST be contract-driven, not surface-driven.
- Any feature that creates, queues, deduplicates, resumes, blocks, completes, or links to an `OperationRun` MUST use
the central OperationRun Start UX Contract.
- Filament Pages, Resources, Widgets, Livewire Components, Actions, and Services MUST NOT independently compose
OperationRun start UX from local pieces.
- The shared OperationRun UX layer MUST own:
- local start notification / toast
- `Open operation` / `View run` link
- artifact link such as `View snapshot`, `View pack`, or `View restore`
- run-enqueued browser event
- queued DB-notification decision
- dedupe / already-available / already-running messaging
- blocked / failed-to-start messaging
- tenant/workspace-safe operation URL resolution
- Feature surfaces MAY initiate `OperationRun`s, but they MUST NOT define their own OperationRun UX semantics.
- `OperationRun` lifecycle state remains the canonical execution truth.
- Queued DB notifications MUST remain explicit opt-in unless the active spec defines a different policy.
- Terminal `OperationRun` notifications MUST be emitted through the central OperationRun lifecycle mechanism.
- Any exception MUST include:
1. an explicit spec decision,
2. a documented architecture note,
3. a test or guard-test exception with rationale,
4. a follow-up migration decision if the exception is temporary.
- New OperationRun-starting features MUST include an `OperationRun UX Impact` section in the active spec or plan.
### Operations UX — 3-Surface Feedback (OPS-UX-055) (NON-NEGOTIABLE) ### Operations UX — 3-Surface Feedback (OPS-UX-055) (NON-NEGOTIABLE)
If a feature creates/reuses `OperationRun`, it MUST use exactly three feedback surfaces — no others: If a feature creates/reuses `OperationRun`, its default feedback contract is exactly three surfaces.
Queued DB notifications are forbidden by default and MAY exist only when the active spec explicitly opts into them
through the OperationRun Start UX Contract:
1) Toast (intent only / queued-only) 1) Toast (intent only / queued-only)
- A toast MAY be shown only when the run is accepted/queued (intent feedback). - A toast MAY be shown only when the run is accepted/queued (intent feedback).
- The toast MUST use `OperationUxPresenter::queuedToast($operationType)->send()`. - The toast MUST use `OperationUxPresenter::queuedToast($operationType)->send()`.
- Feature code MUST NOT craft ad-hoc operation toasts. - Feature code MUST NOT craft ad-hoc operation toasts.
- A dedicated dedupe message MUST use the presenter (e.g., `alreadyQueuedToast(...)`), not `Notification::make()`. - A dedicated dedupe message MUST use the presenter (e.g., `alreadyQueuedToast(...)`), not `Notification::make()`.
- Queued toast copy, action links, artifact links, start-state browser events, and dedupe/start-failure messaging MUST be
produced by the shared OperationRun Start UX Contract, not by local surface code.
2) Progress (active awareness only) 2) Progress (active awareness only)
- Live progress MUST exist only in: - Live progress MUST exist only in:
- the global active-ops widget, and - the global active-ops widget, and
- Monitoring → Operation Run Detail. - Monitoring → Operation Run Detail.
- These surfaces MUST show only active runs (`queued|running`) and MUST never show terminal runs. - These surfaces MUST show only active runs (`queued|running`) and MUST never show terminal runs.
- Running DB notifications are forbidden.
- Determinate progress is allowed ONLY when `summary_counts.total` and `summary_counts.processed` are valid numeric values. - Determinate progress is allowed ONLY when `summary_counts.total` and `summary_counts.processed` are valid numeric values.
- Determinate progress MUST be clamped to 0100. Otherwise render indeterminate + elapsed time. - Determinate progress MUST be clamped to 0100. Otherwise render indeterminate + elapsed time.
- The widget MUST NOT show percentage text (optional `processed/total` is allowed). - The widget MUST NOT show percentage text (optional `processed/total` is allowed).
@ -365,6 +400,10 @@ ### Ops-UX regression guards are mandatory (OPS-UX-GUARD-001)
The repo MUST include automated guards (Pest) that fail CI if: The repo MUST include automated guards (Pest) that fail CI if:
- any direct `OperationRun` status/outcome transition occurs outside `OperationRunService`, - any direct `OperationRun` status/outcome transition occurs outside `OperationRunService`,
- feature code bypasses the central OperationRun Start UX Contract for queued/start-state operation UX where the repo's
guardable patterns can detect it,
- feature code emits queued DB notifications for operations without explicit spec-driven opt-in through the shared
OperationRun UX layer,
- jobs emit DB notifications for operation completion/abort (`OperationRunCompleted` is the single terminal notification), - jobs emit DB notifications for operation completion/abort (`OperationRunCompleted` is the single terminal notification),
- deprecated legacy operation notification classes are referenced again. - deprecated legacy operation notification classes are referenced again.
@ -1614,6 +1653,11 @@ ### Scope, Compliance, and Review Expectations
- Runtime-changing or test-affecting specs and PRs MUST include testing/lane/runtime impact covering actual test-purpose classification, affected lanes, fixture/helper/factory/seed/context cost changes, any heavy-family expansion, expected budget/baseline/trend effect, escalation decisions, and the minimal validation commands. - Runtime-changing or test-affecting specs and PRs MUST include testing/lane/runtime impact covering actual test-purpose classification, affected lanes, fixture/helper/factory/seed/context cost changes, any heavy-family expansion, expected budget/baseline/trend effect, escalation decisions, and the minimal validation commands.
- Specs, plans, task lists, and review checklists MUST surface the test-governance questions needed to catch lane drift, hidden defaults, and runtime-cost escalation before merge. - Specs, plans, task lists, and review checklists MUST surface the test-governance questions needed to catch lane drift, hidden defaults, and runtime-cost escalation before merge.
- Specs and PRs that touch shared provider/platform seams MUST classify the touched boundary as provider-owned or platform-core, keep provider-specific semantics out of platform-core contracts and vocabulary unless explicitly justified, and record whether any remaining hotspot is resolved in-feature or escalated as a follow-up spec. - Specs and PRs that touch shared provider/platform seams MUST classify the touched boundary as provider-owned or platform-core, keep provider-specific semantics out of platform-core contracts and vocabulary unless explicitly justified, and record whether any remaining hotspot is resolved in-feature or escalated as a follow-up spec.
- Specs and PRs that create, queue, deduplicate, resume, block, complete, or deep-link to an `OperationRun` MUST reuse the
central OperationRun Start UX Contract, keep queued DB notifications explicit opt-in unless the active spec states a
different policy, route terminal notifications through the lifecycle mechanism, include an `OperationRun UX Impact`
section in the active spec or plan, and document any temporary exception with an architecture note, test rationale,
and migration decision.
- Specs and PRs that change operator-facing surfaces MUST classify each - Specs and PRs that change operator-facing surfaces MUST classify each
affected surface under DECIDE-001 and justify any new Primary affected surface under DECIDE-001 and justify any new Primary
Decision Surface or workflow-first navigation change. Decision Surface or workflow-first navigation change.
@ -1631,4 +1675,4 @@ ### Versioning Policy (SemVer)
- **MINOR**: new principle/section or materially expanded guidance. - **MINOR**: new principle/section or materially expanded guidance.
- **MAJOR**: removing/redefining principles in a backward-incompatible way. - **MAJOR**: removing/redefining principles in a backward-incompatible way.
**Version**: 2.9.0 | **Ratified**: 2026-01-03 | **Last Amended**: 2026-04-23 **Version**: 2.10.0 | **Ratified**: 2026-01-03 | **Last Amended**: 2026-04-24

View File

@ -32,6 +32,13 @@ ## Shared Pattern Reuse
- [ ] CHK008 The change extends the shared path where it is sufficient, or the deviation is explicitly documented with product reason, preserved consistency, ownership cost, and spread-control. - [ ] CHK008 The change extends the shared path where it is sufficient, or the deviation is explicitly documented with product reason, preserved consistency, ownership cost, and spread-control.
- [ ] CHK009 The change does not create a parallel operator-facing UX language for the same interaction class unless a bounded exception is recorded. - [ ] CHK009 The change does not create a parallel operator-facing UX language for the same interaction class unless a bounded exception is recorded.
## OperationRun Start UX Contract
- [ ] CHK019 The change explicitly says whether it creates, queues, deduplicates, resumes, blocks, completes, or deep-links to an `OperationRun`, and the required `OperationRun UX Impact` section exists when applicable.
- [ ] CHK020 Queued toast/link/artifact-link/browser-event/dedupe-or-blocked messaging and tenant/workspace-safe operation URL resolution are delegated to the shared OperationRun UX contract instead of local surface code.
- [ ] CHK021 Any queued DB notification is explicit opt-in in the active spec or plan, running DB notifications remain absent, and terminal notifications still flow through the central lifecycle mechanism.
- [ ] CHK022 Any exception records the explicit spec decision, architecture note, test or guard-test rationale, and temporary migration follow-up decision.
## Provider Boundary And Vocabulary ## Provider Boundary And Vocabulary
- [ ] CHK010 The change states whether any touched shared seam is provider-owned, platform-core, or mixed, and provider-specific semantics do not silently spread into platform-core contracts, taxonomy, identifiers, compare semantics, or operator vocabulary. - [ ] CHK010 The change states whether any touched shared seam is provider-owned, platform-core, or mixed, and provider-specific semantics do not silently spread into platform-core contracts, taxonomy, identifiers, compare semantics, or operator vocabulary.

View File

@ -54,6 +54,18 @@ ## Shared Pattern & System Fit
- **Why the existing abstraction was sufficient or insufficient**: [Short explanation tied to current-release truth] - **Why the existing abstraction was sufficient or insufficient**: [Short explanation tied to current-release truth]
- **Bounded deviation / spread control**: [none / describe the exception boundary and containment rule] - **Bounded deviation / spread control**: [none / describe the exception boundary and containment rule]
## OperationRun UX Impact
> **Fill when the feature creates, queues, deduplicates, resumes, blocks, completes, or deep-links to an `OperationRun`. Docs-only or template-only work may use concise `N/A`.**
- **Touches OperationRun start/completion/link UX?**: [yes / no / N/A]
- **Central contract reused**: [shared OperationRun UX layer / `N/A`]
- **Delegated UX behaviors**: [queued toast / run link / artifact link / run-enqueued browser event / queued DB-notification decision / dedupe-or-blocked messaging / tenant/workspace-safe URL resolution / `N/A`]
- **Surface-owned behavior kept local**: [initiation inputs only / none / short explanation]
- **Queued DB-notification policy**: [explicit opt-in / spec override / `N/A`]
- **Terminal notification path**: [central lifecycle mechanism / `N/A`]
- **Exception path**: [none / spec decision + architecture note + test rationale + temporary migration follow-up]
## Provider Boundary & Portability Fit ## Provider Boundary & Portability Fit
> **Fill when the feature touches shared provider/platform seams, identity scope, governed-subject taxonomy, compare strategy selection, provider connection descriptors, or operator vocabulary that may leak provider-specific semantics into platform-core truth. Docs-only or template-only work may use concise `N/A`.** > **Fill when the feature touches shared provider/platform seams, identity scope, governed-subject taxonomy, compare strategy selection, provider connection descriptors, or operator vocabulary that may leak provider-specific semantics into platform-core truth. Docs-only or template-only work may use concise `N/A`.**
@ -79,7 +91,8 @@ ## Constitution Check
- RBAC-UX: global search is tenant-scoped; non-members get no hints; inaccessible results are treated as not found (404 semantics) - RBAC-UX: global search is tenant-scoped; non-members get no hints; inaccessible results are treated as not found (404 semantics)
- Tenant isolation: all reads/writes tenant-scoped; cross-tenant views are explicit and access-checked - Tenant isolation: all reads/writes tenant-scoped; cross-tenant views are explicit and access-checked
- Run observability: long-running/remote/queued work creates/reuses `OperationRun`; start surfaces enqueue-only; Monitoring is DB-only; DB-only <2s actions may skip runs but security-relevant ones still audit-log; auth handshake exception OPS-EX-AUTH-001 allows synchronous outbound HTTP on `/auth/*` without `OperationRun` - Run observability: long-running/remote/queued work creates/reuses `OperationRun`; start surfaces enqueue-only; Monitoring is DB-only; DB-only <2s actions may skip runs but security-relevant ones still audit-log; auth handshake exception OPS-EX-AUTH-001 allows synchronous outbound HTTP on `/auth/*` without `OperationRun`
- Ops-UX 3-surface feedback: if `OperationRun` is used, feedback is exactly toast intent-only + progress surfaces + exactly-once terminal `OperationRunCompleted` (initiator-only); no queued/running DB notifications - OperationRun start UX: any feature that creates, queues, deduplicates, resumes, blocks, completes, or links `OperationRun` reuses the central OperationRun Start UX Contract; no local composition of queued toast/link/event/start-state messaging; `OperationRun UX Impact` is present in the active spec or plan
- Ops-UX 3-surface feedback: if `OperationRun` is used, default feedback is toast intent-only + progress surfaces + exactly-once terminal `OperationRunCompleted` (initiator-only); queued DB notifications remain explicit opt-in through the shared start UX contract; running DB notifications stay disallowed
- Ops-UX lifecycle: `OperationRun.status` / `OperationRun.outcome` transitions are service-owned (only via `OperationRunService`); context-only updates allowed outside - Ops-UX lifecycle: `OperationRun.status` / `OperationRun.outcome` transitions are service-owned (only via `OperationRunService`); context-only updates allowed outside
- Ops-UX summary counts: `summary_counts` keys come from `OperationSummaryKeys::all()` and values are flat numeric-only - Ops-UX summary counts: `summary_counts` keys come from `OperationSummaryKeys::all()` and values are flat numeric-only
- Ops-UX guards: CI has regression guards that fail with actionable output (file + snippet) when these patterns regress - Ops-UX guards: CI has regression guards that fail with actionable output (file + snippet) when these patterns regress

View File

@ -47,6 +47,16 @@ ## Cross-Cutting / Shared Pattern Reuse *(mandatory when the feature touches not
- **Consistency impact**: [What must stay aligned across interaction structure, copy, status semantics, actions, and deep links] - **Consistency impact**: [What must stay aligned across interaction structure, copy, status semantics, actions, and deep links]
- **Review focus**: [What reviewers must verify to prevent parallel local patterns] - **Review focus**: [What reviewers must verify to prevent parallel local patterns]
## OperationRun UX Impact *(mandatory when the feature creates, queues, deduplicates, resumes, blocks, completes, or deep-links to an `OperationRun`; otherwise write `N/A - no OperationRun start or link semantics touched`)*
- **Touches OperationRun start/completion/link UX?**: [yes/no]
- **Shared OperationRun UX contract/layer reused**: [Name it or `N/A`]
- **Delegated start/completion UX behaviors**: [queued toast / `Open operation` or `View run` link / artifact link / run-enqueued browser event / queued DB-notification decision / dedupe-or-blocked messaging / tenant/workspace-safe URL resolution / `N/A`]
- **Local surface-owned behavior that remains**: [initiation inputs only / none / bounded explanation]
- **Queued DB-notification policy**: [explicit opt-in / spec override / `N/A`]
- **Terminal notification path**: [central lifecycle mechanism / `N/A`]
- **Exception required?**: [none / explicit spec decision + architecture note + test or guard-test rationale + temporary migration follow-up]
## Provider Boundary / Platform Core Check *(mandatory when the feature changes shared provider/platform seams, identity scope, governed-subject taxonomy, compare strategy selection, provider connection descriptors, or operator vocabulary that may leak provider-specific semantics into platform-core truth; otherwise write `N/A - no shared provider/platform boundary touched`)* ## Provider Boundary / Platform Core Check *(mandatory when the feature changes shared provider/platform seams, identity scope, governed-subject taxonomy, compare strategy selection, provider connection descriptors, or operator vocabulary that may leak provider-specific semantics into platform-core truth; otherwise write `N/A - no shared provider/platform boundary touched`)*
- **Shared provider/platform boundary touched?**: [yes/no] - **Shared provider/platform boundary touched?**: [yes/no]
@ -263,12 +273,21 @@ ## Requirements *(mandatory)*
- and the exact minimal validation commands reviewers should run. - and the exact minimal validation commands reviewers should run.
**Constitution alignment (OPS-UX):** If this feature creates/reuses an `OperationRun`, the spec MUST: **Constitution alignment (OPS-UX):** If this feature creates/reuses an `OperationRun`, the spec MUST:
- explicitly state compliance with the Ops-UX 3-surface feedback contract (toast intent-only, progress surfaces, terminal DB notification), - explicitly state compliance with the default Ops-UX 3-surface feedback contract (toast intent-only, progress surfaces, terminal DB notification) and whether any queued DB notification is explicitly opted into,
- state that `OperationRun.status` / `OperationRun.outcome` transitions are service-owned (only via `OperationRunService`), - state that `OperationRun.status` / `OperationRun.outcome` transitions are service-owned (only via `OperationRunService`),
- describe how `summary_counts` keys/values comply with `OperationSummaryKeys::all()` and numeric-only rules, - describe how `summary_counts` keys/values comply with `OperationSummaryKeys::all()` and numeric-only rules,
- clarify scheduled/system-run behavior (initiator null → no terminal DB notification; audit is via Monitoring), - clarify scheduled/system-run behavior (initiator null → no terminal DB notification; audit is via Monitoring),
- list which regression guard tests are added/updated to keep these rules enforceable in CI. - list which regression guard tests are added/updated to keep these rules enforceable in CI.
**Constitution alignment (OPS-UX-START-001):** If this feature creates, queues, deduplicates, resumes, blocks, completes, or links to an `OperationRun`, the spec MUST:
- include the `OperationRun UX Impact` section,
- name the shared OperationRun UX contract/layer being reused,
- delegate queued toast/link/artifact-link/browser-event/queued-DB-notification/dedupe-or-blocked messaging/tenant-safe URL resolution to that shared path,
- keep local surface code limited to initiation inputs and operation-specific data capture,
- keep queued DB notifications explicit opt-in unless the spec intentionally defines a different policy,
- route terminal notifications through the central lifecycle mechanism,
- and document any exception with an explicit spec decision, architecture note, test or guard-test rationale, and temporary follow-up migration decision.
**Constitution alignment (RBAC-UX):** If this feature introduces or changes authorization behavior, the spec MUST: **Constitution alignment (RBAC-UX):** If this feature introduces or changes authorization behavior, the spec MUST:
- state which authorization plane(s) are involved (tenant/admin `/admin` + tenant-context `/admin/t/{tenant}/...` vs platform `/system`), - state which authorization plane(s) are involved (tenant/admin `/admin` + tenant-context `/admin/t/{tenant}/...` vs platform `/system`),
- ensure any cross-plane access is deny-as-not-found (404), - ensure any cross-plane access is deny-as-not-found (404),

View File

@ -18,17 +18,22 @@ # Tasks: [FEATURE NAME]
- record budget, baseline, or trend follow-up when runtime cost shifts materially, - record budget, baseline, or trend follow-up when runtime cost shifts materially,
- and document whether the change resolves as `document-in-feature`, `follow-up-spec`, or `reject-or-split`. - and document whether the change resolves as `document-in-feature`, `follow-up-spec`, or `reject-or-split`.
**Operations**: If this feature introduces long-running/remote/queued/scheduled work, include tasks to create/reuse and update a **Operations**: If this feature introduces long-running/remote/queued/scheduled work, include tasks to create/reuse and update a
canonical `OperationRun`, and ensure “View run” links route to the canonical Monitoring hub. canonical `OperationRun`, and ensure “View run” links route to the canonical Monitoring hub through the shared OperationRun start UX path rather than local surface composition.
If security-relevant DB-only actions skip `OperationRun`, include tasks for `AuditLog` entries (before/after + actor + tenant). If security-relevant DB-only actions skip `OperationRun`, include tasks for `AuditLog` entries (before/after + actor + tenant).
Auth handshake exception (OPS-EX-AUTH-001): OIDC/SAML login handshakes may perform synchronous outbound HTTP on `/auth/*` endpoints Auth handshake exception (OPS-EX-AUTH-001): OIDC/SAML login handshakes may perform synchronous outbound HTTP on `/auth/*` endpoints
without an `OperationRun`. without an `OperationRun`.
If this feature creates/reuses an `OperationRun`, tasks MUST also include: If this feature creates/reuses an `OperationRun`, tasks MUST also include:
- reusing the central OperationRun Start UX Contract instead of composing local queued toast/link/event/dedupe/blocked/start-failure semantics,
- delegating `Open operation` / `View run`, artifact links, run-enqueued browser event, queued DB-notification policy, dedupe / already-available / already-running messaging, blocked / failed-to-start messaging, and tenant/workspace-safe URL resolution to the shared OperationRun UX layer,
- enforcing the Ops-UX 3-surface feedback contract (toast intent-only via `OperationUxPresenter`, progress only in widget + run detail, terminal notification is `OperationRunCompleted` exactly-once, initiator-only), - enforcing the Ops-UX 3-surface feedback contract (toast intent-only via `OperationUxPresenter`, progress only in widget + run detail, terminal notification is `OperationRunCompleted` exactly-once, initiator-only),
- ensuring no queued/running DB notifications exist anywhere for operations (no `sendToDatabase()` for queued/running/completion/abort in feature code), - keeping queued DB notifications explicit opt-in in the active spec unless a different policy is intentionally approved, and ensuring running DB notifications do not exist,
- routing terminal notifications through the central lifecycle mechanism rather than feature-local notification code,
- ensuring `OperationRun.status` / `OperationRun.outcome` transitions happen only via `OperationRunService`, - ensuring `OperationRun.status` / `OperationRun.outcome` transitions happen only via `OperationRunService`,
- ensuring `summary_counts` keys come from `OperationSummaryKeys::all()` and values are flat numeric-only, - ensuring `summary_counts` keys come from `OperationSummaryKeys::all()` and values are flat numeric-only,
- adding/updating Ops-UX regression guards (Pest) that fail CI with actionable output (file + snippet) when these patterns regress, - adding/updating Ops-UX regression guards (Pest) that fail CI with actionable output (file + snippet) when these patterns regress,
- clarifying scheduled/system-run behavior (initiator null → no terminal DB notification; audit via Monitoring; tenant-wide alerting via Alerts system). - clarifying scheduled/system-run behavior (initiator null → no terminal DB notification; audit via Monitoring; tenant-wide alerting via Alerts system),
- documenting any exception with an explicit spec decision, architecture note, test or guard-test rationale, and temporary migration follow-up decision,
- and ensuring the active spec or plan contains an `OperationRun UX Impact` section.
**RBAC**: If this feature introduces or changes authorization, tasks MUST include: **RBAC**: If this feature introduces or changes authorization, tasks MUST include:
- explicit Gate/Policy enforcement for all mutation endpoints/actions, - explicit Gate/Policy enforcement for all mutation endpoints/actions,
- explicit 404 vs 403 semantics: - explicit 404 vs 403 semantics:

View File

@ -4,6 +4,7 @@
use App\Models\Tenant; use App\Models\Tenant;
use App\Services\OperationRunService; use App\Services\OperationRunService;
use App\Support\OperationRunType;
use Carbon\CarbonImmutable; use Carbon\CarbonImmutable;
use Illuminate\Console\Command; use Illuminate\Console\Command;
@ -50,7 +51,7 @@ public function handle(): int
$opService = app(OperationRunService::class); $opService = app(OperationRunService::class);
$opRun = $opService->ensureRunWithIdentityStrict( $opRun = $opService->ensureRunWithIdentityStrict(
tenant: $tenant, tenant: $tenant,
type: 'entra_group_sync', type: OperationRunType::DirectoryGroupsSync->value,
identityInputs: [ identityInputs: [
'selection_key' => $selectionKey, 'selection_key' => $selectionKey,
'slot_key' => $slotKey, 'slot_key' => $slotKey,

View File

@ -11,6 +11,7 @@
use App\Models\PolicyVersion; use App\Models\PolicyVersion;
use App\Models\RestoreRun; use App\Models\RestoreRun;
use App\Models\Tenant; use App\Models\Tenant;
use App\Support\OperationRunType;
use Illuminate\Console\Command; use Illuminate\Console\Command;
use Illuminate\Support\Arr; use Illuminate\Support\Arr;
use Illuminate\Support\Facades\DB; use Illuminate\Support\Facades\DB;
@ -168,12 +169,12 @@ private function recordPurgeOperationRun(Tenant $tenant, array $counts): void
'tenant_id' => (int) $tenant->id, 'tenant_id' => (int) $tenant->id,
'user_id' => null, 'user_id' => null,
'initiator_name' => 'System', 'initiator_name' => 'System',
'type' => 'backup_schedule_purge', 'type' => OperationRunType::BackupSchedulePurge->value,
'status' => 'completed', 'status' => 'completed',
'outcome' => 'succeeded', 'outcome' => 'succeeded',
'run_identity_hash' => hash('sha256', implode(':', [ 'run_identity_hash' => hash('sha256', implode(':', [
(string) $tenant->id, (string) $tenant->id,
'backup_schedule_purge', OperationRunType::BackupSchedulePurge->value,
now()->toISOString(), now()->toISOString(),
Str::uuid()->toString(), Str::uuid()->toString(),
])), ])),

View File

@ -7,7 +7,9 @@
use App\Models\Tenant; use App\Models\Tenant;
use App\Services\OperationRunService; use App\Services\OperationRunService;
use App\Services\Operations\OperationLifecycleReconciler; use App\Services\Operations\OperationLifecycleReconciler;
use App\Support\OperationCatalog;
use App\Support\OperationRunOutcome; use App\Support\OperationRunOutcome;
use App\Support\OperationRunType;
use Illuminate\Console\Command; use Illuminate\Console\Command;
class TenantpilotReconcileBackupScheduleOperationRuns extends Command class TenantpilotReconcileBackupScheduleOperationRuns extends Command
@ -28,7 +30,7 @@ public function handle(
$dryRun = (bool) $this->option('dry-run'); $dryRun = (bool) $this->option('dry-run');
$query = OperationRun::query() $query = OperationRun::query()
->where('type', 'backup_schedule_run') ->whereIn('type', OperationCatalog::rawValuesForCanonical(OperationRunType::BackupScheduleExecute->value))
->whereIn('status', ['queued', 'running']); ->whereIn('status', ['queued', 'running']);
if ($olderThanMinutes > 0) { if ($olderThanMinutes > 0) {

View File

@ -21,6 +21,7 @@
use App\Support\Baselines\TenantGovernanceAggregate; use App\Support\Baselines\TenantGovernanceAggregate;
use App\Support\Baselines\TenantGovernanceAggregateResolver; use App\Support\Baselines\TenantGovernanceAggregateResolver;
use App\Support\OperationRunLinks; use App\Support\OperationRunLinks;
use App\Support\OperationRunType;
use App\Support\OpsUx\OperationUxPresenter; use App\Support\OpsUx\OperationUxPresenter;
use App\Support\OpsUx\OpsUxBrowserEvents; use App\Support\OpsUx\OpsUxBrowserEvents;
use App\Support\ReasonTranslation\ReasonPresenter; use App\Support\ReasonTranslation\ReasonPresenter;
@ -489,7 +490,7 @@ private function compareNowAction(): Action
OpsUxBrowserEvents::dispatchRunEnqueued($this); OpsUxBrowserEvents::dispatchRunEnqueued($this);
OperationUxPresenter::queuedToast($run instanceof OperationRun ? (string) $run->type : 'baseline_compare') OperationUxPresenter::queuedToast($run instanceof OperationRun ? (string) $run->type : OperationRunType::BaselineCompare->value)
->actions($run instanceof OperationRun ? [ ->actions($run instanceof OperationRun ? [
Action::make('view_run') Action::make('view_run')
->label('Open operation') ->label('Open operation')

View File

@ -18,6 +18,7 @@
use App\Support\Baselines\Compare\CompareStrategyRegistry; use App\Support\Baselines\Compare\CompareStrategyRegistry;
use App\Support\Navigation\CanonicalNavigationContext; use App\Support\Navigation\CanonicalNavigationContext;
use App\Support\OperationRunLinks; use App\Support\OperationRunLinks;
use App\Support\OperationRunType;
use App\Support\OpsUx\OperationUxPresenter; use App\Support\OpsUx\OperationUxPresenter;
use App\Support\OpsUx\OpsUxBrowserEvents; use App\Support\OpsUx\OpsUxBrowserEvents;
use App\Support\Rbac\WorkspaceUiEnforcement; use App\Support\Rbac\WorkspaceUiEnforcement;
@ -810,8 +811,8 @@ private function compareAssignedTenants(): void
OpsUxBrowserEvents::dispatchRunEnqueued($this); OpsUxBrowserEvents::dispatchRunEnqueued($this);
$toast = (int) $result['queuedCount'] > 0 $toast = (int) $result['queuedCount'] > 0
? OperationUxPresenter::queuedToast('baseline_compare') ? OperationUxPresenter::queuedToast(OperationRunType::BaselineCompare->value)
: OperationUxPresenter::alreadyQueuedToast('baseline_compare'); : OperationUxPresenter::alreadyQueuedToast(OperationRunType::BaselineCompare->value);
$toast $toast
->body($summary.' Open Operations for progress and next steps.') ->body($summary.' Open Operations for progress and next steps.')

View File

@ -21,6 +21,7 @@
use App\Support\Inventory\TenantCoverageTruth; use App\Support\Inventory\TenantCoverageTruth;
use App\Support\Inventory\TenantCoverageTruthResolver; use App\Support\Inventory\TenantCoverageTruthResolver;
use App\Support\OperationRunLinks; use App\Support\OperationRunLinks;
use App\Support\OperationRunType;
use App\Support\Ui\ActionSurface\ActionSurfaceDeclaration; use App\Support\Ui\ActionSurface\ActionSurfaceDeclaration;
use App\Support\Ui\ActionSurface\ActionSurfaceDefaults; use App\Support\Ui\ActionSurface\ActionSurfaceDefaults;
use App\Support\Ui\ActionSurface\Enums\ActionSurfaceProfile; use App\Support\Ui\ActionSurface\Enums\ActionSurfaceProfile;
@ -561,6 +562,6 @@ protected function coverageTruth(): ?TenantCoverageTruth
private function inventorySyncHistoryUrl(Tenant $tenant): string private function inventorySyncHistoryUrl(Tenant $tenant): string
{ {
return OperationRunLinks::index($tenant, operationType: 'inventory_sync'); return OperationRunLinks::index($tenant, operationType: OperationRunType::InventorySync->value);
} }
} }

View File

@ -16,7 +16,9 @@
use App\Support\Navigation\CanonicalNavigationContext; use App\Support\Navigation\CanonicalNavigationContext;
use App\Support\Navigation\RelatedNavigationResolver; use App\Support\Navigation\RelatedNavigationResolver;
use App\Support\OperateHub\OperateHubShell; use App\Support\OperateHub\OperateHubShell;
use App\Support\OperationCatalog;
use App\Support\OperationRunLinks; use App\Support\OperationRunLinks;
use App\Support\OperationRunType;
use App\Support\OpsUx\OperationUxPresenter; use App\Support\OpsUx\OperationUxPresenter;
use App\Support\OpsUx\OpsUxBrowserEvents; use App\Support\OpsUx\OpsUxBrowserEvents;
use App\Support\OpsUx\RunDetailPolling; use App\Support\OpsUx\RunDetailPolling;
@ -507,12 +509,14 @@ private function canResumeCapture(): bool
return false; return false;
} }
if (! in_array((string) $this->run->type, ['baseline_capture', 'baseline_compare'], true)) { $canonicalType = OperationCatalog::canonicalCode((string) $this->run->type);
if (! in_array($canonicalType, [OperationRunType::BaselineCapture->value, OperationRunType::BaselineCompare->value], true)) {
return false; return false;
} }
$context = is_array($this->run->context) ? $this->run->context : []; $context = is_array($this->run->context) ? $this->run->context : [];
$tokenKey = (string) $this->run->type === 'baseline_capture' $tokenKey = $canonicalType === OperationRunType::BaselineCapture->value
? 'baseline_capture.resume_token' ? 'baseline_capture.resume_token'
: 'baseline_compare.resume_token'; : 'baseline_compare.resume_token';
$token = data_get($context, $tokenKey); $token = data_get($context, $tokenKey);

View File

@ -42,6 +42,7 @@
use App\Support\Onboarding\OnboardingCheckpoint; use App\Support\Onboarding\OnboardingCheckpoint;
use App\Support\Onboarding\OnboardingDraftStage; use App\Support\Onboarding\OnboardingDraftStage;
use App\Support\Onboarding\OnboardingLifecycleState; use App\Support\Onboarding\OnboardingLifecycleState;
use App\Support\OperationCatalog;
use App\Support\OperationRunLinks; use App\Support\OperationRunLinks;
use App\Support\OperationRunOutcome; use App\Support\OperationRunOutcome;
use App\Support\OperationRunStatus; use App\Support\OperationRunStatus;
@ -51,6 +52,9 @@
use App\Support\Providers\ProviderConnectionType; use App\Support\Providers\ProviderConnectionType;
use App\Support\Providers\ProviderConsentStatus; use App\Support\Providers\ProviderConsentStatus;
use App\Support\Providers\ProviderReasonCodes; use App\Support\Providers\ProviderReasonCodes;
use App\Support\Providers\TargetScope\ProviderConnectionSurfaceSummary;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeDescriptor;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeNormalizer;
use App\Support\Providers\ProviderVerificationStatus; use App\Support\Providers\ProviderVerificationStatus;
use App\Support\Tenants\TenantInteractionLane; use App\Support\Tenants\TenantInteractionLane;
use App\Support\Tenants\TenantLifecyclePresentation; use App\Support\Tenants\TenantLifecyclePresentation;
@ -317,7 +321,7 @@ public function content(Schema $schema): Schema
Section::make('Tenant') Section::make('Tenant')
->schema([ ->schema([
TextInput::make('entra_tenant_id') TextInput::make('entra_tenant_id')
->label('Entra Tenant ID (GUID)') ->label('Tenant ID (GUID)')
->required() ->required()
->placeholder('xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx') ->placeholder('xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx')
->rules(['uuid']) ->rules(['uuid'])
@ -423,7 +427,8 @@ public function content(Schema $schema): Schema
->required() ->required()
->maxLength(255), ->maxLength(255),
TextInput::make('entra_tenant_id') TextInput::make('entra_tenant_id')
->label('Directory (tenant) ID') ->label('Target scope ID')
->helperText('Provider-owned Microsoft tenant detail for this selected target scope.')
->disabled() ->disabled()
->dehydrated(false), ->dehydrated(false),
Toggle::make('uses_dedicated_override') Toggle::make('uses_dedicated_override')
@ -461,6 +466,13 @@ public function content(Schema $schema): Schema
->required(fn (Get $get): bool => $get('connection_mode') === 'new') ->required(fn (Get $get): bool => $get('connection_mode') === 'new')
->maxLength(255) ->maxLength(255)
->visible(fn (Get $get): bool => $get('connection_mode') === 'new'), ->visible(fn (Get $get): bool => $get('connection_mode') === 'new'),
TextInput::make('new_connection.target_scope_id')
->label('Target scope ID')
->default(fn (): string => $this->currentManagedTenantRecord()?->tenant_id ?? '')
->disabled()
->dehydrated(false)
->visible(fn (Get $get): bool => $get('connection_mode') === 'new')
->helperText('The provider connection will point to this tenant target scope.'),
TextInput::make('new_connection.connection_type') TextInput::make('new_connection.connection_type')
->label('Connection type') ->label('Connection type')
->default('Platform connection') ->default('Platform connection')
@ -657,7 +669,7 @@ public function content(Schema $schema): Schema
UnorderedList::make([ UnorderedList::make([
'Tenant status will be set to Active.', 'Tenant status will be set to Active.',
'Backup, inventory, and compliance operations become available.', 'Backup, inventory, and compliance operations become available.',
'The provider connection will be used for all Graph API calls.', 'The provider connection will be used for provider API calls.',
]), ]),
]), ]),
Toggle::make('override_blocked') Toggle::make('override_blocked')
@ -756,7 +768,7 @@ private function normalizeBootstrapOperationTypes(array $operationTypes): array
foreach ($operationTypes as $key => $value) { foreach ($operationTypes as $key => $value) {
if (is_string($value)) { if (is_string($value)) {
$normalizedValue = trim($value); $normalizedValue = $this->normalizeBootstrapOperationType($value);
if ($normalizedValue !== '' && in_array($normalizedValue, $supportedTypes, true)) { if ($normalizedValue !== '' && in_array($normalizedValue, $supportedTypes, true)) {
$normalized[] = $normalizedValue; $normalized[] = $normalizedValue;
@ -776,7 +788,7 @@ private function normalizeBootstrapOperationTypes(array $operationTypes): array
default => false, default => false,
}; };
$normalizedKey = trim($key); $normalizedKey = $this->normalizeBootstrapOperationType($key);
if ($isSelected && in_array($normalizedKey, $supportedTypes, true)) { if ($isSelected && in_array($normalizedKey, $supportedTypes, true)) {
$normalized[] = $normalizedKey; $normalized[] = $normalizedKey;
@ -786,13 +798,24 @@ private function normalizeBootstrapOperationTypes(array $operationTypes): array
return array_values(array_unique($normalized)); return array_values(array_unique($normalized));
} }
private function normalizeBootstrapOperationType(string $operationType): string
{
$operationType = trim($operationType);
if ($operationType === '') {
return '';
}
return OperationCatalog::canonicalCode($operationType);
}
/** /**
* @return array<string, string> * @return array<string, string>
*/ */
private function supportedBootstrapCapabilities(): array private function supportedBootstrapCapabilities(): array
{ {
return [ return [
'inventory_sync' => Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD_BOOTSTRAP_INVENTORY_SYNC, 'inventory.sync' => Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD_BOOTSTRAP_INVENTORY_SYNC,
'compliance.snapshot' => Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD_BOOTSTRAP_POLICY_SYNC, 'compliance.snapshot' => Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD_BOOTSTRAP_POLICY_SYNC,
]; ];
} }
@ -1593,6 +1616,7 @@ private function initializeWizardData(): void
if ($tenant instanceof Tenant) { if ($tenant instanceof Tenant) {
$this->data['entra_tenant_id'] ??= (string) $tenant->tenant_id; $this->data['entra_tenant_id'] ??= (string) $tenant->tenant_id;
$this->data['new_connection']['target_scope_id'] ??= (string) $tenant->tenant_id;
$this->data['environment'] ??= (string) ($tenant->environment ?? 'other'); $this->data['environment'] ??= (string) ($tenant->environment ?? 'other');
$this->data['name'] ??= (string) $tenant->name; $this->data['name'] ??= (string) $tenant->name;
$this->data['primary_domain'] ??= (string) ($tenant->domain ?? ''); $this->data['primary_domain'] ??= (string) ($tenant->domain ?? '');
@ -1676,14 +1700,56 @@ private function providerConnectionOptions(): array
} }
return ProviderConnection::query() return ProviderConnection::query()
->with('tenant')
->where('workspace_id', (int) $this->workspace->getKey()) ->where('workspace_id', (int) $this->workspace->getKey())
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->orderByDesc('is_default') ->orderByDesc('is_default')
->orderBy('display_name') ->orderBy('display_name')
->pluck('display_name', 'id') ->get()
->mapWithKeys(fn (ProviderConnection $connection): array => [
(int) $connection->getKey() => sprintf(
'%s — %s',
(string) $connection->display_name,
$this->providerConnectionTargetScopeSummary($connection),
),
])
->all(); ->all();
} }
private function providerConnectionTargetScopeSummary(ProviderConnection $connection): string
{
try {
return ProviderConnectionSurfaceSummary::forConnection($connection)->targetScopeSummary();
} catch (InvalidArgumentException) {
return 'Target scope needs review';
}
}
/**
* @param array<string, mixed> $extra
* @return array<string, mixed>
*/
private function providerConnectionTargetScopeAuditMetadata(ProviderConnection $connection, array $extra = []): array
{
try {
return app(ProviderConnectionTargetScopeNormalizer::class)->auditMetadataForConnection($connection, $extra);
} catch (InvalidArgumentException) {
return array_merge([
'provider_connection_id' => (int) $connection->getKey(),
'provider' => (string) $connection->provider,
'target_scope' => [
'provider' => (string) $connection->provider,
'scope_kind' => ProviderConnectionTargetScopeDescriptor::SCOPE_KIND_TENANT,
'scope_identifier' => (string) $connection->entra_tenant_id,
'scope_display_name' => (string) ($connection->tenant?->name ?? $connection->display_name ?? $connection->entra_tenant_id),
'shared_label' => 'Target scope',
'shared_help_text' => 'The platform scope this provider connection represents.',
],
'provider_identity_context' => [],
], $extra);
}
}
private function verificationStatusLabel(): string private function verificationStatusLabel(): string
{ {
return BadgeCatalog::spec( return BadgeCatalog::spec(
@ -2599,12 +2665,11 @@ public function selectProviderConnection(int $providerConnectionId): void
workspace: $this->workspace, workspace: $this->workspace,
action: AuditActionId::ManagedTenantOnboardingProviderConnectionChanged->value, action: AuditActionId::ManagedTenantOnboardingProviderConnectionChanged->value,
context: [ context: [
'metadata' => [ 'metadata' => $this->providerConnectionTargetScopeAuditMetadata($connection, [
'workspace_id' => (int) $this->workspace->getKey(), 'workspace_id' => (int) $this->workspace->getKey(),
'tenant_db_id' => (int) $tenant->getKey(), 'tenant_db_id' => (int) $tenant->getKey(),
'provider_connection_id' => (int) $connection->getKey(),
'onboarding_session_id' => $this->onboardingSession?->getKey(), 'onboarding_session_id' => $this->onboardingSession?->getKey(),
], ]),
], ],
actor: $user, actor: $user,
status: 'success', status: 'success',
@ -2657,6 +2722,22 @@ public function createProviderConnection(array $data): void
abort(422); abort(422);
} }
$targetScope = app(ProviderConnectionTargetScopeNormalizer::class)->normalizeInput(
provider: 'microsoft',
scopeKind: ProviderConnectionTargetScopeDescriptor::SCOPE_KIND_TENANT,
scopeIdentifier: (string) $tenant->tenant_id,
scopeDisplayName: $displayName,
providerSpecificIdentity: [
'microsoft_tenant_id' => (string) $tenant->tenant_id,
],
);
if ($targetScope['status'] !== ProviderConnectionTargetScopeNormalizer::STATUS_NORMALIZED) {
throw ValidationException::withMessages([
'new_connection.target_scope_id' => $targetScope['message'],
]);
}
if ($usesDedicatedCredential) { if ($usesDedicatedCredential) {
$this->authorizeWorkspaceMutation($user, Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD_CONNECTION_MANAGE_DEDICATED); $this->authorizeWorkspaceMutation($user, Capabilities::WORKSPACE_MANAGED_TENANT_ONBOARD_CONNECTION_MANAGE_DEDICATED);
} }
@ -2733,14 +2814,11 @@ public function createProviderConnection(array $data): void
tenant: $tenant, tenant: $tenant,
action: 'provider_connection.created', action: 'provider_connection.created',
context: [ context: [
'metadata' => [ 'metadata' => $this->providerConnectionTargetScopeAuditMetadata($connection, [
'workspace_id' => (int) $this->workspace->getKey(), 'workspace_id' => (int) $this->workspace->getKey(),
'provider_connection_id' => (int) $connection->getKey(),
'provider' => (string) $connection->provider,
'entra_tenant_id' => (string) $connection->entra_tenant_id,
'connection_type' => $connection->connection_type->value, 'connection_type' => $connection->connection_type->value,
'source' => 'managed_tenant_onboarding_wizard.create', 'source' => 'managed_tenant_onboarding_wizard.create',
], ]),
], ],
actorId: $actorId, actorId: $actorId,
actorEmail: $actorEmail, actorEmail: $actorEmail,
@ -2756,15 +2834,12 @@ public function createProviderConnection(array $data): void
tenant: $tenant, tenant: $tenant,
action: 'provider_connection.connection_type_changed', action: 'provider_connection.connection_type_changed',
context: [ context: [
'metadata' => [ 'metadata' => $this->providerConnectionTargetScopeAuditMetadata($connection, [
'workspace_id' => (int) $this->workspace->getKey(), 'workspace_id' => (int) $this->workspace->getKey(),
'provider_connection_id' => (int) $connection->getKey(),
'provider' => (string) $connection->provider,
'entra_tenant_id' => (string) $connection->entra_tenant_id,
'from_connection_type' => $previousConnectionType->value, 'from_connection_type' => $previousConnectionType->value,
'to_connection_type' => $connection->connection_type->value, 'to_connection_type' => $connection->connection_type->value,
'source' => 'managed_tenant_onboarding_wizard.create', 'source' => 'managed_tenant_onboarding_wizard.create',
], ]),
], ],
actorId: $actorId, actorId: $actorId,
actorEmail: $actorEmail, actorEmail: $actorEmail,
@ -3280,7 +3355,7 @@ private function dispatchBootstrapJob(
OperationRun $run, OperationRun $run,
): void { ): void {
match ($operationType) { match ($operationType) {
'inventory_sync' => ProviderInventorySyncJob::dispatch( 'inventory.sync' => ProviderInventorySyncJob::dispatch(
tenantId: $tenantId, tenantId: $tenantId,
userId: $userId, userId: $userId,
providerConnectionId: $providerConnectionId, providerConnectionId: $providerConnectionId,
@ -4304,15 +4379,12 @@ public function updateSelectedProviderConnectionInline(int $providerConnectionId
tenant: $this->managedTenant, tenant: $this->managedTenant,
action: 'provider_connection.connection_type_changed', action: 'provider_connection.connection_type_changed',
context: [ context: [
'metadata' => [ 'metadata' => $this->providerConnectionTargetScopeAuditMetadata($connection, [
'workspace_id' => (int) $this->workspace->getKey(), 'workspace_id' => (int) $this->workspace->getKey(),
'provider_connection_id' => (int) $connection->getKey(),
'provider' => (string) $connection->provider,
'entra_tenant_id' => (string) $connection->entra_tenant_id,
'from_connection_type' => $existingType->value, 'from_connection_type' => $existingType->value,
'to_connection_type' => $targetType->value, 'to_connection_type' => $targetType->value,
'source' => 'managed_tenant_onboarding_wizard.inline_edit', 'source' => 'managed_tenant_onboarding_wizard.inline_edit',
], ]),
], ],
actorId: (int) $user->getKey(), actorId: (int) $user->getKey(),
actorEmail: (string) $user->email, actorEmail: (string) $user->email,
@ -4328,15 +4400,12 @@ public function updateSelectedProviderConnectionInline(int $providerConnectionId
tenant: $this->managedTenant, tenant: $this->managedTenant,
action: 'provider_connection.updated', action: 'provider_connection.updated',
context: [ context: [
'metadata' => [ 'metadata' => $this->providerConnectionTargetScopeAuditMetadata($connection, [
'workspace_id' => (int) $this->workspace->getKey(), 'workspace_id' => (int) $this->workspace->getKey(),
'provider_connection_id' => (int) $connection->getKey(), 'fields' => app(ProviderConnectionTargetScopeNormalizer::class)->auditFieldNames($changedFields),
'provider' => (string) $connection->provider,
'entra_tenant_id' => (string) $connection->entra_tenant_id,
'fields' => $changedFields,
'connection_type' => $targetType->value, 'connection_type' => $targetType->value,
'source' => 'managed_tenant_onboarding_wizard.inline_edit', 'source' => 'managed_tenant_onboarding_wizard.inline_edit',
], ]),
], ],
actorId: (int) $user->getKey(), actorId: (int) $user->getKey(),
actorEmail: (string) $user->email, actorEmail: (string) $user->email,

View File

@ -25,6 +25,7 @@
use App\Support\Filament\TablePaginationProfiles; use App\Support\Filament\TablePaginationProfiles;
use App\Support\OperationRunLinks; use App\Support\OperationRunLinks;
use App\Support\OperationRunOutcome; use App\Support\OperationRunOutcome;
use App\Support\OperationRunType;
use App\Support\OpsUx\OperationUxPresenter; use App\Support\OpsUx\OperationUxPresenter;
use App\Support\OpsUx\OpsUxBrowserEvents; use App\Support\OpsUx\OpsUxBrowserEvents;
use App\Support\Rbac\UiEnforcement; use App\Support\Rbac\UiEnforcement;
@ -457,7 +458,7 @@ public static function table(Table $table): Table
$nonce = (string) Str::uuid(); $nonce = (string) Str::uuid();
$operationRun = $operationRunService->ensureRunWithIdentity( $operationRun = $operationRunService->ensureRunWithIdentity(
tenant: $tenant, tenant: $tenant,
type: 'backup_schedule_run', type: OperationRunType::BackupScheduleExecute->value,
identityInputs: [ identityInputs: [
'backup_schedule_id' => (int) $record->getKey(), 'backup_schedule_id' => (int) $record->getKey(),
'nonce' => $nonce, 'nonce' => $nonce,
@ -528,7 +529,7 @@ public static function table(Table $table): Table
$nonce = (string) Str::uuid(); $nonce = (string) Str::uuid();
$operationRun = $operationRunService->ensureRunWithIdentity( $operationRun = $operationRunService->ensureRunWithIdentity(
tenant: $tenant, tenant: $tenant,
type: 'backup_schedule_run', type: OperationRunType::BackupScheduleExecute->value,
identityInputs: [ identityInputs: [
'backup_schedule_id' => (int) $record->getKey(), 'backup_schedule_id' => (int) $record->getKey(),
'nonce' => $nonce, 'nonce' => $nonce,
@ -755,7 +756,7 @@ public static function table(Table $table): Table
$nonce = (string) Str::uuid(); $nonce = (string) Str::uuid();
$operationRun = $operationRunService->ensureRunWithIdentity( $operationRun = $operationRunService->ensureRunWithIdentity(
tenant: $tenant, tenant: $tenant,
type: 'backup_schedule_run', type: OperationRunType::BackupScheduleExecute->value,
identityInputs: [ identityInputs: [
'backup_schedule_id' => (int) $record->getKey(), 'backup_schedule_id' => (int) $record->getKey(),
'nonce' => $nonce, 'nonce' => $nonce,
@ -852,7 +853,7 @@ public static function table(Table $table): Table
$nonce = (string) Str::uuid(); $nonce = (string) Str::uuid();
$operationRun = $operationRunService->ensureRunWithIdentity( $operationRun = $operationRunService->ensureRunWithIdentity(
tenant: $tenant, tenant: $tenant,
type: 'backup_schedule_run', type: OperationRunType::BackupScheduleExecute->value,
identityInputs: [ identityInputs: [
'backup_schedule_id' => (int) $record->getKey(), 'backup_schedule_id' => (int) $record->getKey(),
'nonce' => $nonce, 'nonce' => $nonce,

View File

@ -32,6 +32,8 @@
use App\Support\Navigation\CrossResourceNavigationMatrix; use App\Support\Navigation\CrossResourceNavigationMatrix;
use App\Support\Navigation\RelatedContextEntry; use App\Support\Navigation\RelatedContextEntry;
use App\Support\Navigation\RelatedNavigationResolver; use App\Support\Navigation\RelatedNavigationResolver;
use App\Support\OperationCatalog;
use App\Support\OperationRunType;
use App\Support\Rbac\WorkspaceUiEnforcement; use App\Support\Rbac\WorkspaceUiEnforcement;
use App\Support\ReasonTranslation\ReasonPresenter; use App\Support\ReasonTranslation\ReasonPresenter;
use App\Support\ReasonTranslation\ReasonResolutionEnvelope; use App\Support\ReasonTranslation\ReasonResolutionEnvelope;
@ -873,7 +875,7 @@ private static function latestBaselineCaptureEnvelope(BaselineProfile $profile):
{ {
$run = OperationRun::query() $run = OperationRun::query()
->where('workspace_id', (int) $profile->workspace_id) ->where('workspace_id', (int) $profile->workspace_id)
->where('type', 'baseline_capture') ->whereIn('type', OperationCatalog::rawValuesForCanonical(OperationRunType::BaselineCapture->value))
->where('context->baseline_profile_id', (int) $profile->getKey()) ->where('context->baseline_profile_id', (int) $profile->getKey())
->where('status', 'completed') ->where('status', 'completed')
->orderByDesc('completed_at') ->orderByDesc('completed_at')

View File

@ -17,6 +17,7 @@
use App\Support\Baselines\BaselineCaptureMode; use App\Support\Baselines\BaselineCaptureMode;
use App\Support\Baselines\BaselineReasonCodes; use App\Support\Baselines\BaselineReasonCodes;
use App\Support\OperationRunLinks; use App\Support\OperationRunLinks;
use App\Support\OperationRunType;
use App\Support\OpsUx\OperationUxPresenter; use App\Support\OpsUx\OperationUxPresenter;
use App\Support\OpsUx\OpsUxBrowserEvents; use App\Support\OpsUx\OpsUxBrowserEvents;
use App\Support\ReasonTranslation\ReasonPresenter; use App\Support\ReasonTranslation\ReasonPresenter;
@ -340,8 +341,8 @@ private function compareAssignedTenantsAction(): Action
OpsUxBrowserEvents::dispatchRunEnqueued($this); OpsUxBrowserEvents::dispatchRunEnqueued($this);
$toast = (int) $result['queuedCount'] > 0 $toast = (int) $result['queuedCount'] > 0
? OperationUxPresenter::queuedToast('baseline_compare') ? OperationUxPresenter::queuedToast(OperationRunType::BaselineCompare->value)
: OperationUxPresenter::alreadyQueuedToast('baseline_compare'); : OperationUxPresenter::alreadyQueuedToast(OperationRunType::BaselineCompare->value);
$toast $toast
->body($summary.' Open Operations for progress and next steps.') ->body($summary.' Open Operations for progress and next steps.')

View File

@ -15,6 +15,7 @@
use App\Support\Filament\CanonicalAdminTenantFilterState; use App\Support\Filament\CanonicalAdminTenantFilterState;
use App\Support\Inventory\InventoryPolicyTypeMeta; use App\Support\Inventory\InventoryPolicyTypeMeta;
use App\Support\OperationRunLinks; use App\Support\OperationRunLinks;
use App\Support\OperationRunType;
use App\Support\OpsUx\OperationUxPresenter; use App\Support\OpsUx\OperationUxPresenter;
use App\Support\OpsUx\OpsUxBrowserEvents; use App\Support\OpsUx\OpsUxBrowserEvents;
use App\Support\Rbac\UiEnforcement; use App\Support\Rbac\UiEnforcement;
@ -175,7 +176,7 @@ protected function getHeaderActions(): array
$opService = app(OperationRunService::class); $opService = app(OperationRunService::class);
$opRun = $opService->ensureRunWithIdentity( $opRun = $opService->ensureRunWithIdentity(
tenant: $tenant, tenant: $tenant,
type: 'inventory_sync', type: OperationRunType::InventorySync->value,
identityInputs: [ identityInputs: [
'selection_hash' => $computed['selection_hash'], 'selection_hash' => $computed['selection_hash'],
], ],

View File

@ -27,6 +27,7 @@
use App\Support\OperationRunLinks; use App\Support\OperationRunLinks;
use App\Support\OperationRunOutcome; use App\Support\OperationRunOutcome;
use App\Support\OperationRunStatus; use App\Support\OperationRunStatus;
use App\Support\OperationRunType;
use App\Support\OpsUx\OperationUxPresenter; use App\Support\OpsUx\OperationUxPresenter;
use App\Support\OpsUx\RunDurationInsights; use App\Support\OpsUx\RunDurationInsights;
use App\Support\OpsUx\SummaryCountsNormalizer; use App\Support\OpsUx\SummaryCountsNormalizer;
@ -230,7 +231,9 @@ public static function table(Table $table): Table
return $query; return $query;
} }
return $query->whereIn('type', OperationCatalog::rawValuesForCanonical($value)); return $query->whereIn('type', OperationCatalog::rawValuesForCanonical(
OperationCatalog::canonicalCode($value),
));
}), }),
Tables\Filters\SelectFilter::make('status') Tables\Filters\SelectFilter::make('status')
->options(BadgeCatalog::options(BadgeDomain::OperationRunStatus, OperationRunStatus::values())), ->options(BadgeCatalog::options(BadgeDomain::OperationRunStatus, OperationRunStatus::values())),
@ -411,7 +414,7 @@ private static function enterpriseDetailPage(OperationRun $record): \App\Support
); );
} }
if ((string) $record->type === 'baseline_compare') { if (OperationCatalog::canonicalCode((string) $record->type) === OperationRunType::BaselineCompare->value) {
$baselineCompareFacts = static::baselineCompareFacts($record, $factory); $baselineCompareFacts = static::baselineCompareFacts($record, $factory);
$baselineCompareEvidence = static::baselineCompareEvidencePayload($record); $baselineCompareEvidence = static::baselineCompareEvidencePayload($record);
$gapDetails = BaselineCompareEvidenceGapDetails::fromOperationRun($record); $gapDetails = BaselineCompareEvidenceGapDetails::fromOperationRun($record);
@ -466,7 +469,7 @@ private static function enterpriseDetailPage(OperationRun $record): \App\Support
} }
} }
if ((string) $record->type === 'baseline_capture') { if (OperationCatalog::canonicalCode((string) $record->type) === OperationRunType::BaselineCapture->value) {
$baselineCaptureEvidence = static::baselineCaptureEvidencePayload($record); $baselineCaptureEvidence = static::baselineCaptureEvidencePayload($record);
if ($baselineCaptureEvidence !== []) { if ($baselineCaptureEvidence !== []) {
@ -1446,7 +1449,7 @@ private static function reconciliationPayload(OperationRun $record): array
*/ */
private static function inventorySyncCoverageSection(OperationRun $record): ?array private static function inventorySyncCoverageSection(OperationRun $record): ?array
{ {
if ((string) $record->type !== 'inventory_sync') { if (OperationCatalog::canonicalCode((string) $record->type) !== OperationRunType::InventorySync->value) {
return null; return null;
} }

View File

@ -20,12 +20,15 @@
use App\Support\Badges\BadgeRenderer; use App\Support\Badges\BadgeRenderer;
use App\Support\Filament\TablePaginationProfiles; use App\Support\Filament\TablePaginationProfiles;
use App\Support\OperationRunLinks; use App\Support\OperationRunLinks;
use App\Support\OperationRunType;
use App\Support\OpsUx\OperationUxPresenter; use App\Support\OpsUx\OperationUxPresenter;
use App\Support\OpsUx\ProviderOperationStartResultPresenter; use App\Support\OpsUx\ProviderOperationStartResultPresenter;
use App\Support\OpsUx\OpsUxBrowserEvents; use App\Support\OpsUx\OpsUxBrowserEvents;
use App\Support\Providers\ProviderConnectionType; use App\Support\Providers\ProviderConnectionType;
use App\Support\Providers\ProviderReasonCodes; use App\Support\Providers\ProviderReasonCodes;
use App\Support\Providers\ProviderVerificationStatus; use App\Support\Providers\ProviderVerificationStatus;
use App\Support\Providers\TargetScope\ProviderConnectionSurfaceSummary;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeNormalizer;
use App\Support\Rbac\UiEnforcement; use App\Support\Rbac\UiEnforcement;
use App\Support\Ui\ActionSurface\ActionSurfaceDeclaration; use App\Support\Ui\ActionSurface\ActionSurfaceDeclaration;
use App\Support\Ui\ActionSurface\Enums\ActionSurfaceInspectAffordance; use App\Support\Ui\ActionSurface\Enums\ActionSurfaceInspectAffordance;
@ -50,6 +53,7 @@
use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Query\JoinClause; use Illuminate\Database\Query\JoinClause;
use Illuminate\Support\Str; use Illuminate\Support\Str;
use InvalidArgumentException;
use UnitEnum; use UnitEnum;
class ProviderConnectionResource extends Resource class ProviderConnectionResource extends Resource
@ -484,6 +488,62 @@ private static function verificationStatusLabelFromState(mixed $state): string
return BadgeRenderer::spec(BadgeDomain::ProviderVerificationStatus, $state)->label; return BadgeRenderer::spec(BadgeDomain::ProviderVerificationStatus, $state)->label;
} }
private static function targetScopeHelpText(): string
{
return 'The platform scope this provider connection represents. For Microsoft, use the tenant directory ID for that scope.';
}
private static function targetScopeSummary(?ProviderConnection $record): string
{
if (! $record instanceof ProviderConnection) {
return 'Target scope is set when this connection is saved.';
}
try {
return ProviderConnectionSurfaceSummary::forConnection($record)->targetScopeSummary();
} catch (InvalidArgumentException) {
return 'Target scope needs review';
}
}
private static function providerIdentityContext(?ProviderConnection $record): ?string
{
if (! $record instanceof ProviderConnection) {
return null;
}
try {
return ProviderConnectionSurfaceSummary::forConnection($record)->contextualIdentityLine();
} catch (InvalidArgumentException) {
return null;
}
}
/**
* @param array<string, mixed> $extra
* @return array<string, mixed>
*/
public static function targetScopeAuditMetadata(ProviderConnection $record, array $extra = []): array
{
try {
return app(ProviderConnectionTargetScopeNormalizer::class)->auditMetadataForConnection($record, $extra);
} catch (InvalidArgumentException) {
return array_merge([
'provider_connection_id' => (int) $record->getKey(),
'provider' => (string) $record->provider,
'target_scope' => [
'provider' => (string) $record->provider,
'scope_kind' => 'tenant',
'scope_identifier' => (string) $record->entra_tenant_id,
'scope_display_name' => (string) ($record->tenant?->name ?? $record->display_name ?? $record->entra_tenant_id),
'shared_label' => 'Target scope',
'shared_help_text' => static::targetScopeHelpText(),
],
'provider_identity_context' => [],
], $extra);
}
}
public static function form(Schema $schema): Schema public static function form(Schema $schema): Schema
{ {
return $schema return $schema
@ -496,11 +556,17 @@ public static function form(Schema $schema): Schema
->disabled(fn (): bool => ! static::hasTenantCapability(Capabilities::PROVIDER_MANAGE)) ->disabled(fn (): bool => ! static::hasTenantCapability(Capabilities::PROVIDER_MANAGE))
->maxLength(255), ->maxLength(255),
TextInput::make('entra_tenant_id') TextInput::make('entra_tenant_id')
->label('Entra tenant ID') ->label('Target scope ID')
->required() ->required()
->maxLength(255) ->maxLength(255)
->helperText(static::targetScopeHelpText())
->validationAttribute('target scope ID')
->disabled(fn (): bool => ! static::hasTenantCapability(Capabilities::PROVIDER_MANAGE)) ->disabled(fn (): bool => ! static::hasTenantCapability(Capabilities::PROVIDER_MANAGE))
->rules(['uuid']), ->rules(['uuid']),
Placeholder::make('target_scope_display')
->label('Target scope')
->content(fn (?ProviderConnection $record): string => static::targetScopeSummary($record))
->visible(fn (?ProviderConnection $record): bool => $record instanceof ProviderConnection),
Placeholder::make('connection_type_display') Placeholder::make('connection_type_display')
->label('Connection type') ->label('Connection type')
->content(fn (?ProviderConnection $record): string => static::providerConnectionTypeLabel($record)), ->content(fn (?ProviderConnection $record): string => static::providerConnectionTypeLabel($record)),
@ -563,8 +629,9 @@ public static function infolist(Schema $schema): Schema
->label('Display name'), ->label('Display name'),
Infolists\Components\TextEntry::make('provider') Infolists\Components\TextEntry::make('provider')
->label('Provider'), ->label('Provider'),
Infolists\Components\TextEntry::make('entra_tenant_id') Infolists\Components\TextEntry::make('target_scope')
->label('Entra tenant ID') ->label('Target scope')
->state(fn (ProviderConnection $record): string => static::targetScopeSummary($record))
->copyable(), ->copyable(),
Infolists\Components\TextEntry::make('connection_type') Infolists\Components\TextEntry::make('connection_type')
->label('Connection type') ->label('Connection type')
@ -614,6 +681,11 @@ public static function infolist(Schema $schema): Schema
->label('Migration review') ->label('Migration review')
->formatStateUsing(fn (ProviderConnection $record): string => static::migrationReviewLabel($record)) ->formatStateUsing(fn (ProviderConnection $record): string => static::migrationReviewLabel($record))
->tooltip(fn (ProviderConnection $record): ?string => static::migrationReviewDescription($record)), ->tooltip(fn (ProviderConnection $record): ?string => static::migrationReviewDescription($record)),
Infolists\Components\TextEntry::make('provider_identity_context')
->label('Provider identity details')
->state(fn (ProviderConnection $record): ?string => static::providerIdentityContext($record))
->placeholder('n/a')
->columnSpanFull(),
Infolists\Components\TextEntry::make('last_error_reason_code') Infolists\Components\TextEntry::make('last_error_reason_code')
->label('Last error reason') ->label('Last error reason')
->placeholder('n/a'), ->placeholder('n/a'),
@ -671,9 +743,15 @@ public static function table(Table $table): Table
return TenantResource::getUrl('view', ['record' => $tenant], panel: 'admin'); return TenantResource::getUrl('view', ['record' => $tenant], panel: 'admin');
}), }),
Tables\Columns\TextColumn::make('display_name')->label('Name')->searchable()->sortable(), Tables\Columns\TextColumn::make('display_name')->label('Name')->searchable()->sortable(),
Tables\Columns\TextColumn::make('provider')->label('Provider')->toggleable(isToggledHiddenByDefault: true), Tables\Columns\TextColumn::make('provider')
Tables\Columns\TextColumn::make('entra_tenant_id')->label('Entra tenant ID')->copyable()->toggleable(isToggledHiddenByDefault: true), ->label('Provider')
Tables\Columns\IconColumn::make('is_default')->label('Default')->boolean(), ->formatStateUsing(fn (?string $state): string => Str::headline((string) $state)),
Tables\Columns\TextColumn::make('target_scope')
->label('Target scope')
->state(fn (ProviderConnection $record): string => static::targetScopeSummary($record))
->copyable(),
Tables\Columns\TextColumn::make('entra_tenant_id')->label('Microsoft tenant ID')->copyable()->toggleable(isToggledHiddenByDefault: true),
Tables\Columns\IconColumn::make('is_default')->label('Default')->boolean()->toggleable(isToggledHiddenByDefault: true),
Tables\Columns\TextColumn::make('connection_type') Tables\Columns\TextColumn::make('connection_type')
->label('Connection type') ->label('Connection type')
->badge() ->badge()
@ -872,7 +950,7 @@ public static function makeInventorySyncAction(): Actions\Action
static::handleProviderOperationAction( static::handleProviderOperationAction(
record: $record, record: $record,
gate: $gate, gate: $gate,
operationType: 'inventory_sync', operationType: OperationRunType::InventorySync->value,
blockedTitle: 'Inventory sync blocked', blockedTitle: 'Inventory sync blocked',
dispatcher: function (Tenant $tenant, User $user, ProviderConnection $connection, OperationRun $operationRun): void { dispatcher: function (Tenant $tenant, User $user, ProviderConnection $connection, OperationRun $operationRun): void {
ProviderInventorySyncJob::dispatch( ProviderInventorySyncJob::dispatch(
@ -949,10 +1027,7 @@ public static function makeSetDefaultAction(): Actions\Action
tenant: $tenant, tenant: $tenant,
action: 'provider_connection.default_set', action: 'provider_connection.default_set',
context: [ context: [
'metadata' => [ 'metadata' => static::targetScopeAuditMetadata($record),
'provider' => $record->provider,
'entra_tenant_id' => $record->entra_tenant_id,
],
], ],
actorId: $actorId, actorId: $actorId,
actorEmail: $actorEmail, actorEmail: $actorEmail,
@ -1014,15 +1089,12 @@ public static function makeEnableDedicatedOverrideAction(string $source, ?string
tenant: $tenant, tenant: $tenant,
action: 'provider_connection.connection_type_changed', action: 'provider_connection.connection_type_changed',
context: [ context: [
'metadata' => [ 'metadata' => static::targetScopeAuditMetadata($record, [
'provider_connection_id' => (int) $record->getKey(),
'provider' => $record->provider,
'entra_tenant_id' => $record->entra_tenant_id,
'from_connection_type' => ProviderConnectionType::Platform->value, 'from_connection_type' => ProviderConnectionType::Platform->value,
'to_connection_type' => ProviderConnectionType::Dedicated->value, 'to_connection_type' => ProviderConnectionType::Dedicated->value,
'client_id' => (string) $data['client_id'], 'client_id' => (string) $data['client_id'],
'source' => $source, 'source' => $source,
], ]),
], ],
actorId: $actorId, actorId: $actorId,
actorEmail: $actorEmail, actorEmail: $actorEmail,
@ -1161,14 +1233,11 @@ public static function makeRevertToPlatformAction(string $source, ?string $modal
tenant: $tenant, tenant: $tenant,
action: 'provider_connection.connection_type_changed', action: 'provider_connection.connection_type_changed',
context: [ context: [
'metadata' => [ 'metadata' => static::targetScopeAuditMetadata($record, [
'provider_connection_id' => (int) $record->getKey(),
'provider' => $record->provider,
'entra_tenant_id' => $record->entra_tenant_id,
'from_connection_type' => ProviderConnectionType::Dedicated->value, 'from_connection_type' => ProviderConnectionType::Dedicated->value,
'to_connection_type' => ProviderConnectionType::Platform->value, 'to_connection_type' => ProviderConnectionType::Platform->value,
'source' => $source, 'source' => $source,
], ]),
], ],
actorId: $actorId, actorId: $actorId,
actorEmail: $actorEmail, actorEmail: $actorEmail,
@ -1233,14 +1302,12 @@ public static function makeEnableConnectionAction(): Actions\Action
tenant: $tenant, tenant: $tenant,
action: 'provider_connection.enabled', action: 'provider_connection.enabled',
context: [ context: [
'metadata' => [ 'metadata' => static::targetScopeAuditMetadata($record, [
'provider' => $record->provider,
'entra_tenant_id' => $record->entra_tenant_id,
'from_lifecycle' => $previousLifecycle ? 'enabled' : 'disabled', 'from_lifecycle' => $previousLifecycle ? 'enabled' : 'disabled',
'to_lifecycle' => 'enabled', 'to_lifecycle' => 'enabled',
'verification_status' => $verificationStatus->value, 'verification_status' => $verificationStatus->value,
'credentials_present' => $hadCredentials, 'credentials_present' => $hadCredentials,
], ]),
], ],
actorId: $actorId, actorId: $actorId,
actorEmail: $actorEmail, actorEmail: $actorEmail,
@ -1302,12 +1369,10 @@ public static function makeDisableConnectionAction(): Actions\Action
tenant: $tenant, tenant: $tenant,
action: 'provider_connection.disabled', action: 'provider_connection.disabled',
context: [ context: [
'metadata' => [ 'metadata' => static::targetScopeAuditMetadata($record, [
'provider' => $record->provider,
'entra_tenant_id' => $record->entra_tenant_id,
'from_lifecycle' => $previousLifecycle ? 'enabled' : 'disabled', 'from_lifecycle' => $previousLifecycle ? 'enabled' : 'disabled',
'to_lifecycle' => 'disabled', 'to_lifecycle' => 'disabled',
], ]),
], ],
actorId: $actorId, actorId: $actorId,
actorEmail: $actorEmail, actorEmail: $actorEmail,

View File

@ -9,9 +9,12 @@
use App\Support\Providers\ProviderConnectionType; use App\Support\Providers\ProviderConnectionType;
use App\Support\Providers\ProviderConsentStatus; use App\Support\Providers\ProviderConsentStatus;
use App\Support\Providers\ProviderReasonCodes; use App\Support\Providers\ProviderReasonCodes;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeDescriptor;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeNormalizer;
use App\Support\Providers\ProviderVerificationStatus; use App\Support\Providers\ProviderVerificationStatus;
use Filament\Notifications\Notification; use Filament\Notifications\Notification;
use Filament\Resources\Pages\CreateRecord; use Filament\Resources\Pages\CreateRecord;
use Illuminate\Validation\ValidationException;
class CreateProviderConnection extends CreateRecord class CreateProviderConnection extends CreateRecord
{ {
@ -28,6 +31,21 @@ protected function mutateFormDataBeforeCreate(array $data): array
} }
$this->shouldMakeDefault = (bool) ($data['is_default'] ?? false); $this->shouldMakeDefault = (bool) ($data['is_default'] ?? false);
$targetScope = app(ProviderConnectionTargetScopeNormalizer::class)->normalizeInput(
provider: 'microsoft',
scopeKind: ProviderConnectionTargetScopeDescriptor::SCOPE_KIND_TENANT,
scopeIdentifier: (string) ($data['entra_tenant_id'] ?? ''),
scopeDisplayName: (string) ($data['display_name'] ?? ''),
providerSpecificIdentity: [
'microsoft_tenant_id' => (string) ($data['entra_tenant_id'] ?? ''),
],
);
if ($targetScope['status'] !== ProviderConnectionTargetScopeNormalizer::STATUS_NORMALIZED) {
throw ValidationException::withMessages([
'entra_tenant_id' => $targetScope['message'],
]);
}
return [ return [
'workspace_id' => (int) $tenant->workspace_id, 'workspace_id' => (int) $tenant->workspace_id,
@ -70,11 +88,9 @@ protected function afterCreate(): void
tenant: $tenant, tenant: $tenant,
action: 'provider_connection.created', action: 'provider_connection.created',
context: [ context: [
'metadata' => [ 'metadata' => ProviderConnectionResource::targetScopeAuditMetadata($record, [
'provider' => $record->provider,
'entra_tenant_id' => $record->entra_tenant_id,
'connection_type' => $record->connection_type->value, 'connection_type' => $record->connection_type->value,
], ]),
], ],
actorId: $actorId, actorId: $actorId,
actorEmail: $actorEmail, actorEmail: $actorEmail,

View File

@ -19,6 +19,8 @@
use App\Support\OpsUx\OperationUxPresenter; use App\Support\OpsUx\OperationUxPresenter;
use App\Support\OpsUx\OpsUxBrowserEvents; use App\Support\OpsUx\OpsUxBrowserEvents;
use App\Support\Providers\ProviderConnectionType; use App\Support\Providers\ProviderConnectionType;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeDescriptor;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeNormalizer;
use App\Support\Rbac\UiEnforcement; use App\Support\Rbac\UiEnforcement;
use Filament\Actions; use Filament\Actions;
use Filament\Actions\Action; use Filament\Actions\Action;
@ -26,6 +28,7 @@
use Filament\Notifications\Notification; use Filament\Notifications\Notification;
use Filament\Resources\Pages\EditRecord; use Filament\Resources\Pages\EditRecord;
use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Model;
use Illuminate\Validation\ValidationException;
class EditProviderConnection extends EditRecord class EditProviderConnection extends EditRecord
{ {
@ -77,6 +80,22 @@ protected function mutateFormDataBeforeSave(array $data): array
$this->shouldMakeDefault = (bool) ($data['is_default'] ?? false); $this->shouldMakeDefault = (bool) ($data['is_default'] ?? false);
unset($data['is_default']); unset($data['is_default']);
$targetScope = app(ProviderConnectionTargetScopeNormalizer::class)->normalizeInput(
provider: 'microsoft',
scopeKind: ProviderConnectionTargetScopeDescriptor::SCOPE_KIND_TENANT,
scopeIdentifier: (string) ($data['entra_tenant_id'] ?? ''),
scopeDisplayName: (string) ($data['display_name'] ?? ''),
providerSpecificIdentity: [
'microsoft_tenant_id' => (string) ($data['entra_tenant_id'] ?? ''),
],
);
if ($targetScope['status'] !== ProviderConnectionTargetScopeNormalizer::STATUS_NORMALIZED) {
throw ValidationException::withMessages([
'entra_tenant_id' => $targetScope['message'],
]);
}
return $data; return $data;
} }
@ -119,11 +138,9 @@ protected function afterSave(): void
tenant: $tenant, tenant: $tenant,
action: 'provider_connection.updated', action: 'provider_connection.updated',
context: [ context: [
'metadata' => [ 'metadata' => ProviderConnectionResource::targetScopeAuditMetadata($record, [
'provider' => $record->provider, 'fields' => app(ProviderConnectionTargetScopeNormalizer::class)->auditFieldNames($changedFields),
'entra_tenant_id' => $record->entra_tenant_id, ]),
'fields' => $changedFields,
],
], ],
actorId: $actorId, actorId: $actorId,
actorEmail: $actorEmail, actorEmail: $actorEmail,
@ -139,10 +156,7 @@ protected function afterSave(): void
tenant: $tenant, tenant: $tenant,
action: 'provider_connection.default_set', action: 'provider_connection.default_set',
context: [ context: [
'metadata' => [ 'metadata' => ProviderConnectionResource::targetScopeAuditMetadata($record),
'provider' => $record->provider,
'entra_tenant_id' => $record->entra_tenant_id,
],
], ],
actorId: $actorId, actorId: $actorId,
actorEmail: $actorEmail, actorEmail: $actorEmail,

View File

@ -237,12 +237,12 @@ private function resolveTenantForCreateAction(): ?Tenant
public function getTableEmptyStateHeading(): ?string public function getTableEmptyStateHeading(): ?string
{ {
return 'No Microsoft connections found'; return 'No provider connections found';
} }
public function getTableEmptyStateDescription(): ?string public function getTableEmptyStateDescription(): ?string
{ {
return 'Start with a platform-managed Microsoft connection. Dedicated overrides are handled separately with stronger authorization.'; return 'Start with a platform-managed provider connection. Dedicated overrides are handled separately with stronger authorization.';
} }
public function getTableEmptyStateActions(): array public function getTableEmptyStateActions(): array

View File

@ -14,7 +14,9 @@
use App\Support\Inventory\InventoryKpiBadges; use App\Support\Inventory\InventoryKpiBadges;
use App\Support\Inventory\TenantCoverageTruth; use App\Support\Inventory\TenantCoverageTruth;
use App\Support\Inventory\TenantCoverageTruthResolver; use App\Support\Inventory\TenantCoverageTruthResolver;
use App\Support\OperationCatalog;
use App\Support\OperationRunLinks; use App\Support\OperationRunLinks;
use App\Support\OperationRunType;
use Filament\Widgets\StatsOverviewWidget; use Filament\Widgets\StatsOverviewWidget;
use Filament\Widgets\StatsOverviewWidget\Stat; use Filament\Widgets\StatsOverviewWidget\Stat;
use Illuminate\Support\Facades\Blade; use Illuminate\Support\Facades\Blade;
@ -56,7 +58,7 @@ protected function getStats(): array
$inventoryOps = (int) OperationRun::query() $inventoryOps = (int) OperationRun::query()
->where('tenant_id', (int) $tenant->getKey()) ->where('tenant_id', (int) $tenant->getKey())
->where('type', 'inventory_sync') ->whereIn('type', OperationCatalog::rawValuesForCanonical(OperationRunType::InventorySync->value))
->active() ->active()
->count(); ->count();

View File

@ -8,8 +8,10 @@
use App\Services\Intune\AuditLogger; use App\Services\Intune\AuditLogger;
use App\Services\OperationRunService; use App\Services\OperationRunService;
use App\Services\Settings\SettingsResolver; use App\Services\Settings\SettingsResolver;
use App\Support\OperationCatalog;
use App\Support\OperationRunOutcome; use App\Support\OperationRunOutcome;
use App\Support\OperationRunStatus; use App\Support\OperationRunStatus;
use App\Support\OperationRunType;
use Illuminate\Contracts\Queue\ShouldQueue; use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Queue\Queueable; use Illuminate\Foundation\Queue\Queueable;
use Illuminate\Support\Collection; use Illuminate\Support\Collection;
@ -36,10 +38,10 @@ public function handle(AuditLogger $auditLogger, SettingsResolver $settingsResol
'tenant_id' => (int) $schedule->tenant_id, 'tenant_id' => (int) $schedule->tenant_id,
'user_id' => null, 'user_id' => null,
'initiator_name' => 'System', 'initiator_name' => 'System',
'type' => 'backup_schedule_retention', 'type' => OperationRunType::BackupScheduleRetention->value,
'status' => OperationRunStatus::Running->value, 'status' => OperationRunStatus::Running->value,
'outcome' => OperationRunOutcome::Pending->value, 'outcome' => OperationRunOutcome::Pending->value,
'run_identity_hash' => hash('sha256', (string) $schedule->tenant_id.':backup_schedule_retention:'.$schedule->id.':'.Str::uuid()->toString()), 'run_identity_hash' => hash('sha256', (string) $schedule->tenant_id.':'.OperationRunType::BackupScheduleRetention->value.':'.$schedule->id.':'.Str::uuid()->toString()),
'context' => [ 'context' => [
'backup_schedule_id' => (int) $schedule->id, 'backup_schedule_id' => (int) $schedule->id,
], ],
@ -88,7 +90,7 @@ public function handle(AuditLogger $auditLogger, SettingsResolver $settingsResol
/** @var Collection<int, int> $keepBackupSetIds */ /** @var Collection<int, int> $keepBackupSetIds */
$keepBackupSetIds = OperationRun::query() $keepBackupSetIds = OperationRun::query()
->where('tenant_id', (int) $schedule->tenant_id) ->where('tenant_id', (int) $schedule->tenant_id)
->where('type', 'backup_schedule_run') ->whereIn('type', OperationCatalog::rawValuesForCanonical(OperationRunType::BackupScheduleExecute->value))
->where('status', OperationRunStatus::Completed->value) ->where('status', OperationRunStatus::Completed->value)
->where('context->backup_schedule_id', (int) $schedule->id) ->where('context->backup_schedule_id', (int) $schedule->id)
->whereNotNull('context->backup_set_id') ->whereNotNull('context->backup_set_id')
@ -103,7 +105,7 @@ public function handle(AuditLogger $auditLogger, SettingsResolver $settingsResol
/** @var Collection<int, int> $allBackupSetIds */ /** @var Collection<int, int> $allBackupSetIds */
$allBackupSetIds = OperationRun::query() $allBackupSetIds = OperationRun::query()
->where('tenant_id', (int) $schedule->tenant_id) ->where('tenant_id', (int) $schedule->tenant_id)
->where('type', 'backup_schedule_run') ->whereIn('type', OperationCatalog::rawValuesForCanonical(OperationRunType::BackupScheduleExecute->value))
->where('status', OperationRunStatus::Completed->value) ->where('status', OperationRunStatus::Completed->value)
->where('context->backup_schedule_id', (int) $schedule->id) ->where('context->backup_schedule_id', (int) $schedule->id)
->whereNotNull('context->backup_set_id') ->whereNotNull('context->backup_set_id')

View File

@ -452,6 +452,11 @@ private function logVerificationResult(
'verification_status' => $connection->verification_status?->value ?? $connection->verification_status, 'verification_status' => $connection->verification_status?->value ?? $connection->verification_status,
'credential_source' => $identity->credentialSource, 'credential_source' => $identity->credentialSource,
'effective_client_id' => $identity->effectiveClientId, 'effective_client_id' => $identity->effectiveClientId,
'target_scope' => $identity->targetScope?->toArray(),
'provider_identity_context' => array_map(
static fn ($detail): array => $detail->toArray(),
$identity->contextualIdentityDetails,
),
'reason_code' => $reasonCode, 'reason_code' => $reasonCode,
'operation_run_id' => (int) $run->getKey(), 'operation_run_id' => (int) $run->getKey(),
'previous_consent_status' => $previousConsentStatus, 'previous_consent_status' => $previousConsentStatus,

View File

@ -2,6 +2,8 @@
namespace App\Models; namespace App\Models;
use App\Support\OperationCatalog;
use App\Support\OperationRunType;
use App\Support\Concerns\DerivesWorkspaceIdFromTenant; use App\Support\Concerns\DerivesWorkspaceIdFromTenant;
use Illuminate\Database\Eloquent\Factories\HasFactory; use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model; use Illuminate\Database\Eloquent\Model;
@ -34,11 +36,11 @@ public function tenant(): BelongsTo
public function operationRuns(): HasMany public function operationRuns(): HasMany
{ {
return $this->hasMany(OperationRun::class, 'tenant_id', 'tenant_id') return $this->hasMany(OperationRun::class, 'tenant_id', 'tenant_id')
->whereIn('type', [ ->whereIn('type', array_values(array_unique(array_merge(
'backup_schedule_run', OperationCatalog::rawValuesForCanonical(OperationRunType::BackupScheduleExecute->value),
'backup_schedule_retention', OperationCatalog::rawValuesForCanonical(OperationRunType::BackupScheduleRetention->value),
'backup_schedule_purge', OperationCatalog::rawValuesForCanonical(OperationRunType::BackupSchedulePurge->value),
]) ))))
->where('context->backup_schedule_id', (int) $this->getKey()); ->where('context->backup_schedule_id', (int) $this->getKey());
} }
} }

View File

@ -98,7 +98,7 @@ public function scopeBaselineCompareForProfile(Builder $query, BaselineProfile|i
: (int) $profile; : (int) $profile;
return $query return $query
->where('type', OperationRunType::BaselineCompare->value) ->whereIn('type', OperationCatalog::rawValuesForCanonical(OperationRunType::BaselineCompare->value))
->where('context->baseline_profile_id', $profileId); ->where('context->baseline_profile_id', $profileId);
} }
@ -112,7 +112,7 @@ public function scopeLikelyStale(Builder $query, ?OperationLifecyclePolicy $poli
foreach ($policy->coveredTypeNames() as $type) { foreach ($policy->coveredTypeNames() as $type) {
$query->orWhere(function (Builder $typeQuery) use ($policy, $type): void { $query->orWhere(function (Builder $typeQuery) use ($policy, $type): void {
$typeQuery $typeQuery
->where('type', $type) ->whereIn('type', OperationCatalog::rawValuesForCanonical($type))
->where(function (Builder $stateQuery) use ($policy, $type): void { ->where(function (Builder $stateQuery) use ($policy, $type): void {
$stateQuery $stateQuery
->where(function (Builder $queuedQuery) use ($policy, $type): void { ->where(function (Builder $queuedQuery) use ($policy, $type): void {
@ -152,12 +152,18 @@ public function scopeHealthyActive(Builder $query, ?OperationLifecyclePolicy $po
return $query return $query
->active() ->active()
->where(function (Builder $query) use ($coveredTypes, $policy): void { ->where(function (Builder $query) use ($coveredTypes, $policy): void {
$query->whereNotIn('type', $coveredTypes); $coveredRawTypes = collect($coveredTypes)
->flatMap(static fn (string $type): array => OperationCatalog::rawValuesForCanonical($type))
->unique()
->values()
->all();
$query->whereNotIn('type', $coveredRawTypes);
foreach ($coveredTypes as $type) { foreach ($coveredTypes as $type) {
$query->orWhere(function (Builder $typeQuery) use ($policy, $type): void { $query->orWhere(function (Builder $typeQuery) use ($policy, $type): void {
$typeQuery $typeQuery
->where('type', $type) ->whereIn('type', OperationCatalog::rawValuesForCanonical($type))
->where(function (Builder $stateQuery) use ($policy, $type): void { ->where(function (Builder $stateQuery) use ($policy, $type): void {
$stateQuery $stateQuery
->where(function (Builder $queuedQuery) use ($policy, $type): void { ->where(function (Builder $queuedQuery) use ($policy, $type): void {
@ -343,7 +349,7 @@ public static function latestCompletedCoverageBearingInventorySyncForTenant(int
return static::query() return static::query()
->where('tenant_id', $tenantId) ->where('tenant_id', $tenantId)
->where('type', 'inventory_sync') ->whereIn('type', OperationCatalog::rawValuesForCanonical(OperationRunType::InventorySync->value))
->where('status', OperationRunStatus::Completed->value) ->where('status', OperationRunStatus::Completed->value)
->whereNotNull('completed_at') ->whereNotNull('completed_at')
->latest('completed_at') ->latest('completed_at')
@ -478,11 +484,11 @@ public function baselineGapEnvelope(): array
{ {
$context = is_array($this->context) ? $this->context : []; $context = is_array($this->context) ? $this->context : [];
return match ((string) $this->type) { return match ($this->canonicalOperationType()) {
'baseline_compare' => is_array(data_get($context, 'baseline_compare.evidence_gaps')) 'baseline.compare' => is_array(data_get($context, 'baseline_compare.evidence_gaps'))
? data_get($context, 'baseline_compare.evidence_gaps') ? data_get($context, 'baseline_compare.evidence_gaps')
: [], : [],
'baseline_capture' => is_array(data_get($context, 'baseline_capture.gaps')) 'baseline.capture' => is_array(data_get($context, 'baseline_capture.gaps'))
? data_get($context, 'baseline_capture.gaps') ? data_get($context, 'baseline_capture.gaps')
: [], : [],
default => [], default => [],

View File

@ -14,6 +14,7 @@
use App\Services\Providers\ProviderOperationStartGate; use App\Services\Providers\ProviderOperationStartGate;
use App\Services\Providers\ProviderOperationStartResult; use App\Services\Providers\ProviderOperationStartResult;
use App\Support\Auth\Capabilities; use App\Support\Auth\Capabilities;
use App\Support\OperationRunType;
use Carbon\CarbonImmutable; use Carbon\CarbonImmutable;
class EntraGroupSyncService class EntraGroupSyncService
@ -32,7 +33,7 @@ public function startManualSync(Tenant $tenant, User $user): ProviderOperationSt
return $this->providerStarts->start( return $this->providerStarts->start(
tenant: $tenant, tenant: $tenant,
connection: null, connection: null,
operationType: 'entra_group_sync', operationType: OperationRunType::DirectoryGroupsSync->value,
dispatcher: function (OperationRun $run) use ($tenant, $selectionKey): void { dispatcher: function (OperationRun $run) use ($tenant, $selectionKey): void {
$providerConnectionId = is_numeric($run->context['provider_connection_id'] ?? null) $providerConnectionId = is_numeric($run->context['provider_connection_id'] ?? null)
? (int) $run->context['provider_connection_id'] ? (int) $run->context['provider_connection_id']

View File

@ -14,6 +14,7 @@
use App\Services\Providers\ProviderOperationStartGate; use App\Services\Providers\ProviderOperationStartGate;
use App\Services\Providers\ProviderOperationStartResult; use App\Services\Providers\ProviderOperationStartResult;
use App\Support\Auth\Capabilities; use App\Support\Auth\Capabilities;
use App\Support\OperationRunType;
use Carbon\CarbonImmutable; use Carbon\CarbonImmutable;
class RoleDefinitionsSyncService class RoleDefinitionsSyncService
@ -32,7 +33,7 @@ public function startManualSync(Tenant $tenant, User $user): ProviderOperationSt
return $this->providerStarts->start( return $this->providerStarts->start(
tenant: $tenant, tenant: $tenant,
connection: null, connection: null,
operationType: 'directory_role_definitions.sync', operationType: OperationRunType::DirectoryRoleDefinitionsSync->value,
dispatcher: function (OperationRun $run) use ($tenant): void { dispatcher: function (OperationRun $run) use ($tenant): void {
$providerConnectionId = is_numeric($run->context['provider_connection_id'] ?? null) $providerConnectionId = is_numeric($run->context['provider_connection_id'] ?? null)
? (int) $run->context['provider_connection_id'] ? (int) $run->context['provider_connection_id']

View File

@ -44,6 +44,7 @@ public function collect(Tenant $tenant): array
'entries' => $runs->map(static fn (OperationRun $run): array => [ 'entries' => $runs->map(static fn (OperationRun $run): array => [
'id' => (int) $run->getKey(), 'id' => (int) $run->getKey(),
'type' => (string) $run->type, 'type' => (string) $run->type,
'operation_type' => $run->canonicalOperationType(),
'status' => (string) $run->status, 'status' => (string) $run->status,
'outcome' => (string) $run->outcome, 'outcome' => (string) $run->outcome,
'initiator_name' => $run->user?->name, 'initiator_name' => $run->user?->name,

View File

@ -6,6 +6,8 @@
use App\Models\OperationRun; use App\Models\OperationRun;
use App\Models\Tenant; use App\Models\Tenant;
use App\Services\BackupScheduling\PolicyTypeResolver; use App\Services\BackupScheduling\PolicyTypeResolver;
use App\Support\OperationCatalog;
use App\Support\OperationRunType;
use Illuminate\Database\Eloquent\Collection; use Illuminate\Database\Eloquent\Collection;
class InventoryMissingService class InventoryMissingService
@ -27,7 +29,7 @@ public function missingForSelection(Tenant $tenant, array $selectionPayload): ar
$latestRun = OperationRun::query() $latestRun = OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'inventory_sync') ->whereIn('type', OperationCatalog::rawValuesForCanonical(OperationRunType::InventorySync->value))
->where('status', 'completed') ->where('status', 'completed')
->where('context->selection_hash', $selectionHash) ->where('context->selection_hash', $selectionHash)
->orderByDesc('completed_at') ->orderByDesc('completed_at')

View File

@ -59,7 +59,7 @@ public function syncNow(Tenant $tenant, array $selectionPayload): OperationRun
'type' => OperationRunType::InventorySync->value, 'type' => OperationRunType::InventorySync->value,
'status' => OperationRunStatus::Running->value, 'status' => OperationRunStatus::Running->value,
'outcome' => OperationRunOutcome::Pending->value, 'outcome' => OperationRunOutcome::Pending->value,
'run_identity_hash' => hash('sha256', (string) $tenant->getKey().':inventory_sync:'.$selectionHash.':'.Str::uuid()->toString()), 'run_identity_hash' => hash('sha256', (string) $tenant->getKey().':'.OperationRunType::InventorySync->value.':'.$selectionHash.':'.Str::uuid()->toString()),
'context' => array_merge($normalizedSelection, [ 'context' => array_merge($normalizedSelection, [
'selection_hash' => $selectionHash, 'selection_hash' => $selectionHash,
]), ]),
@ -698,7 +698,7 @@ private function resolveFoundationPolicyAnchor(
private function selectionLockKey(Tenant $tenant, string $selectionHash): string private function selectionLockKey(Tenant $tenant, string $selectionHash): string
{ {
return sprintf('inventory_sync:tenant:%s:selection:%s', (string) $tenant->getKey(), $selectionHash); return sprintf('%s:tenant:%s:selection:%s', OperationRunType::InventorySync->value, (string) $tenant->getKey(), $selectionHash);
} }
private function mapGraphFailureToErrorCode(GraphResponse $response): string private function mapGraphFailureToErrorCode(GraphResponse $response): string

View File

@ -12,6 +12,7 @@
use App\Services\Tenants\TenantOperabilityService; use App\Services\Tenants\TenantOperabilityService;
use App\Support\Onboarding\OnboardingCheckpoint; use App\Support\Onboarding\OnboardingCheckpoint;
use App\Support\Onboarding\OnboardingLifecycleState; use App\Support\Onboarding\OnboardingLifecycleState;
use App\Support\OperationCatalog;
use App\Support\OperationRunOutcome; use App\Support\OperationRunOutcome;
use App\Support\OperationRunStatus; use App\Support\OperationRunStatus;
use App\Support\Verification\VerificationReportOverall; use App\Support\Verification\VerificationReportOverall;
@ -682,7 +683,7 @@ private function bootstrapOperationTypes(TenantOnboardingSession $draft): array
} }
return array_values(array_filter( return array_values(array_filter(
array_map(static fn (mixed $value): string => is_string($value) ? trim($value) : '', $types), array_map(static fn (mixed $value): string => is_string($value) ? OperationCatalog::canonicalCode($value) : '', $types),
static fn (string $value): bool => $value !== '', static fn (string $value): bool => $value !== '',
)); ));
} }
@ -709,7 +710,7 @@ private function bootstrapRunMap(TenantOnboardingSession $draft, array $selected
continue; continue;
} }
$runMap[trim($type)] = $normalizedRunId; $runMap[OperationCatalog::canonicalCode($type)] = $normalizedRunId;
} }
} }

View File

@ -1271,7 +1271,7 @@ private function writeTerminalAudit(OperationRun $run): void
action: $action, action: $action,
context: [ context: [
'metadata' => [ 'metadata' => [
'operation_type' => $run->type, 'operation_type' => $run->canonicalOperationType(),
'summary_counts' => $this->sanitizeSummaryCounts(is_array($run->summary_counts ?? null) ? $run->summary_counts : []), 'summary_counts' => $this->sanitizeSummaryCounts(is_array($run->summary_counts ?? null) ? $run->summary_counts : []),
'failure_summary' => $run->failure_summary, 'failure_summary' => $run->failure_summary,
'target_scope' => $executionLegitimacy['target_scope'] ?? ($context['target_scope'] ?? null), 'target_scope' => $executionLegitimacy['target_scope'] ?? ($context['target_scope'] ?? null),

View File

@ -13,6 +13,7 @@
use App\Services\Auth\CapabilityResolver; use App\Services\Auth\CapabilityResolver;
use App\Services\Auth\WorkspaceCapabilityResolver; use App\Services\Auth\WorkspaceCapabilityResolver;
use App\Services\Tenants\TenantOperabilityService; use App\Services\Tenants\TenantOperabilityService;
use App\Support\OperationCatalog;
use App\Support\Operations\ExecutionAuthorityMode; use App\Support\Operations\ExecutionAuthorityMode;
use App\Support\Operations\ExecutionDenialReasonCode; use App\Support\Operations\ExecutionDenialReasonCode;
use App\Support\Operations\OperationRunCapabilityResolver; use App\Support\Operations\OperationRunCapabilityResolver;
@ -27,9 +28,9 @@ class QueuedExecutionLegitimacyGate
* @var list<string> * @var list<string>
*/ */
private const SYSTEM_AUTHORITY_ALLOWLIST = [ private const SYSTEM_AUTHORITY_ALLOWLIST = [
'backup_schedule_run', 'backup.schedule.execute',
'backup_schedule_retention', 'backup.schedule.retention',
'backup_schedule_purge', 'backup.schedule.purge',
]; ];
public function __construct( public function __construct(
@ -134,6 +135,7 @@ public function evaluate(OperationRun $run): QueuedExecutionLegitimacyDecision
public function buildContext(OperationRun $run): QueuedExecutionContext public function buildContext(OperationRun $run): QueuedExecutionContext
{ {
$context = is_array($run->context) ? $run->context : []; $context = is_array($run->context) ? $run->context : [];
$operationType = OperationCatalog::canonicalCode((string) $run->type);
$authorityMode = ExecutionAuthorityMode::fromNullable($context['execution_authority_mode'] ?? null) $authorityMode = ExecutionAuthorityMode::fromNullable($context['execution_authority_mode'] ?? null)
?? ($run->user_id === null ? ExecutionAuthorityMode::SystemAuthority : ExecutionAuthorityMode::ActorBound); ?? ($run->user_id === null ? ExecutionAuthorityMode::SystemAuthority : ExecutionAuthorityMode::ActorBound);
$providerConnectionId = $this->resolveProviderConnectionId($context); $providerConnectionId = $this->resolveProviderConnectionId($context);
@ -141,26 +143,28 @@ public function buildContext(OperationRun $run): QueuedExecutionContext
return new QueuedExecutionContext( return new QueuedExecutionContext(
run: $run, run: $run,
operationType: (string) $run->type, operationType: $operationType,
workspaceId: $workspaceId, workspaceId: $workspaceId,
tenant: $run->tenant, tenant: $run->tenant,
initiator: $run->user, initiator: $run->user,
authorityMode: $authorityMode, authorityMode: $authorityMode,
requiredCapability: is_string($context['required_capability'] ?? null) requiredCapability: is_string($context['required_capability'] ?? null)
? $context['required_capability'] ? $context['required_capability']
: $this->operationRunCapabilityResolver->requiredExecutionCapabilityForType((string) $run->type), : $this->operationRunCapabilityResolver->requiredExecutionCapabilityForType($operationType),
providerConnectionId: $providerConnectionId, providerConnectionId: $providerConnectionId,
targetScope: [ targetScope: [
'workspace_id' => $workspaceId, 'workspace_id' => $workspaceId,
'tenant_id' => $run->tenant_id !== null ? (int) $run->tenant_id : null, 'tenant_id' => $run->tenant_id !== null ? (int) $run->tenant_id : null,
'provider_connection_id' => $providerConnectionId, 'provider_connection_id' => $providerConnectionId,
], ],
prerequisiteClasses: $this->prerequisiteClassesFor((string) $run->type, $providerConnectionId), prerequisiteClasses: $this->prerequisiteClassesFor($operationType, $providerConnectionId),
); );
} }
public function isSystemAuthorityAllowed(string $operationType): bool public function isSystemAuthorityAllowed(string $operationType): bool
{ {
$operationType = OperationCatalog::canonicalCode($operationType);
return in_array($operationType, self::SYSTEM_AUTHORITY_ALLOWLIST, true); return in_array($operationType, self::SYSTEM_AUTHORITY_ALLOWLIST, true);
} }

View File

@ -4,11 +4,19 @@
use App\Support\Providers\ProviderConnectionType; use App\Support\Providers\ProviderConnectionType;
use App\Support\Providers\ProviderReasonCodes; use App\Support\Providers\ProviderReasonCodes;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeDescriptor;
use App\Support\Providers\TargetScope\ProviderIdentityContextMetadata;
final class PlatformProviderIdentityResolver final class PlatformProviderIdentityResolver
{ {
public function resolve(string $tenantContext): ProviderIdentityResolution /**
{ * @param list<ProviderIdentityContextMetadata> $contextualIdentityDetails
*/
public function resolve(
string $tenantContext,
?ProviderConnectionTargetScopeDescriptor $targetScope = null,
array $contextualIdentityDetails = [],
): ProviderIdentityResolution {
$targetTenant = trim($tenantContext); $targetTenant = trim($tenantContext);
$clientId = trim((string) config('graph.client_id')); $clientId = trim((string) config('graph.client_id'));
$clientSecret = trim((string) config('graph.client_secret')); $clientSecret = trim((string) config('graph.client_secret'));
@ -22,6 +30,8 @@ public function resolve(string $tenantContext): ProviderIdentityResolution
credentialSource: 'platform_config', credentialSource: 'platform_config',
reasonCode: ProviderReasonCodes::ProviderConnectionInvalid, reasonCode: ProviderReasonCodes::ProviderConnectionInvalid,
message: 'Provider connection is missing target tenant scope.', message: 'Provider connection is missing target tenant scope.',
targetScope: $targetScope,
contextualIdentityDetails: $contextualIdentityDetails,
); );
} }
@ -32,6 +42,8 @@ public function resolve(string $tenantContext): ProviderIdentityResolution
credentialSource: 'platform_config', credentialSource: 'platform_config',
reasonCode: ProviderReasonCodes::PlatformIdentityMissing, reasonCode: ProviderReasonCodes::PlatformIdentityMissing,
message: 'Platform app identity is not configured.', message: 'Platform app identity is not configured.',
targetScope: $targetScope,
contextualIdentityDetails: $contextualIdentityDetails,
); );
} }
@ -42,6 +54,8 @@ public function resolve(string $tenantContext): ProviderIdentityResolution
credentialSource: 'platform_config', credentialSource: 'platform_config',
reasonCode: ProviderReasonCodes::PlatformIdentityIncomplete, reasonCode: ProviderReasonCodes::PlatformIdentityIncomplete,
message: 'Platform app identity is incomplete.', message: 'Platform app identity is incomplete.',
targetScope: $targetScope,
contextualIdentityDetails: $contextualIdentityDetails,
); );
} }
@ -53,6 +67,13 @@ public function resolve(string $tenantContext): ProviderIdentityResolution
clientSecret: $clientSecret, clientSecret: $clientSecret,
authorityTenant: $authorityTenant !== '' ? $authorityTenant : 'organizations', authorityTenant: $authorityTenant !== '' ? $authorityTenant : 'organizations',
redirectUri: $redirectUri, redirectUri: $redirectUri,
targetScope: $targetScope,
contextualIdentityDetails: $contextualIdentityDetails !== []
? array_values(array_merge($contextualIdentityDetails, array_filter([
ProviderIdentityContextMetadata::authorityTenant($authorityTenant !== '' ? $authorityTenant : 'organizations'),
ProviderIdentityContextMetadata::redirectUri($redirectUri),
])))
: [],
); );
} }
} }

View File

@ -26,7 +26,7 @@ public function enableDedicatedOverride(
$clientSecret = trim($clientSecret); $clientSecret = trim($clientSecret);
if ($clientId === '' || $clientSecret === '') { if ($clientId === '' || $clientSecret === '') {
throw new InvalidArgumentException('Dedicated client_id and client_secret are required.'); throw new InvalidArgumentException('Dedicated app (client) ID and client secret are required.');
} }
return DB::transaction(function () use ($connection, $clientId, $clientSecret): ProviderConnection { return DB::transaction(function () use ($connection, $clientId, $clientSecret): ProviderConnection {

View File

@ -4,25 +4,38 @@
use App\Models\ProviderConnection; use App\Models\ProviderConnection;
use App\Support\Providers\ProviderReasonCodes; use App\Support\Providers\ProviderReasonCodes;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeDescriptor;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeNormalizer;
use App\Support\Providers\TargetScope\ProviderIdentityContextMetadata;
final class ProviderConnectionResolution final class ProviderConnectionResolution
{ {
/**
* @param list<ProviderIdentityContextMetadata> $contextualIdentityDetails
*/
private function __construct( private function __construct(
public readonly bool $resolved, public readonly bool $resolved,
public readonly ?ProviderConnection $connection, public readonly ?ProviderConnection $connection,
public readonly ?string $reasonCode, public readonly ?string $reasonCode,
public readonly ?string $extensionReasonCode, public readonly ?string $extensionReasonCode,
public readonly ?string $message, public readonly ?string $message,
public readonly ?ProviderConnectionTargetScopeDescriptor $targetScope,
public readonly array $contextualIdentityDetails,
) {} ) {}
public static function resolved(ProviderConnection $connection): self public static function resolved(ProviderConnection $connection): self
{ {
/** @var ProviderConnectionTargetScopeNormalizer $normalizer */
$normalizer = app(ProviderConnectionTargetScopeNormalizer::class);
return new self( return new self(
resolved: true, resolved: true,
connection: $connection, connection: $connection,
reasonCode: null, reasonCode: null,
extensionReasonCode: null, extensionReasonCode: null,
message: null, message: null,
targetScope: $normalizer->descriptorForConnection($connection),
contextualIdentityDetails: $normalizer->contextualIdentityDetailsForConnection($connection),
); );
} }
@ -32,12 +45,29 @@ public static function blocked(
?string $extensionReasonCode = null, ?string $extensionReasonCode = null,
?ProviderConnection $connection = null, ?ProviderConnection $connection = null,
): self { ): self {
/** @var ProviderConnectionTargetScopeNormalizer $normalizer */
$normalizer = app(ProviderConnectionTargetScopeNormalizer::class);
$targetScope = null;
$contextualIdentityDetails = [];
if ($connection instanceof ProviderConnection) {
$normalization = $normalizer->normalizeConnection($connection);
$descriptor = $normalization['target_scope'] ?? null;
if ($descriptor instanceof ProviderConnectionTargetScopeDescriptor) {
$targetScope = $descriptor;
$contextualIdentityDetails = $normalizer->contextualIdentityDetailsForConnection($connection);
}
}
return new self( return new self(
resolved: false, resolved: false,
connection: $connection, connection: $connection,
reasonCode: ProviderReasonCodes::isKnown($reasonCode) ? $reasonCode : ProviderReasonCodes::UnknownError, reasonCode: ProviderReasonCodes::isKnown($reasonCode) ? $reasonCode : ProviderReasonCodes::UnknownError,
extensionReasonCode: $extensionReasonCode, extensionReasonCode: $extensionReasonCode,
message: $message, message: $message,
targetScope: $targetScope,
contextualIdentityDetails: $contextualIdentityDetails,
); );
} }

View File

@ -6,11 +6,13 @@
use App\Models\Tenant; use App\Models\Tenant;
use App\Support\Providers\ProviderConsentStatus; use App\Support\Providers\ProviderConsentStatus;
use App\Support\Providers\ProviderReasonCodes; use App\Support\Providers\ProviderReasonCodes;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeNormalizer;
final class ProviderConnectionResolver final class ProviderConnectionResolver
{ {
public function __construct( public function __construct(
private readonly ProviderIdentityResolver $identityResolver, private readonly ProviderIdentityResolver $identityResolver,
private readonly ProviderConnectionTargetScopeNormalizer $targetScopeNormalizer,
) {} ) {}
public function resolveDefault(Tenant $tenant, string $provider): ProviderConnectionResolution public function resolveDefault(Tenant $tenant, string $provider): ProviderConnectionResolution
@ -63,11 +65,19 @@ public function validateConnection(Tenant $tenant, string $provider, ProviderCon
); );
} }
if ($connection->entra_tenant_id === null || trim((string) $connection->entra_tenant_id) === '') { $targetScope = $this->targetScopeNormalizer->normalizeConnection($connection);
if ($targetScope['status'] !== ProviderConnectionTargetScopeNormalizer::STATUS_NORMALIZED) {
$failureCode = $targetScope['failure_code'] ?? ProviderConnectionTargetScopeNormalizer::FAILURE_MISSING_PROVIDER_CONTEXT;
return ProviderConnectionResolution::blocked( return ProviderConnectionResolution::blocked(
ProviderReasonCodes::ProviderConnectionInvalid, $failureCode === ProviderConnectionTargetScopeNormalizer::FAILURE_UNSUPPORTED_PROVIDER_SCOPE_COMBINATION
'Provider connection is missing target tenant scope.', ? ProviderReasonCodes::ProviderBindingUnsupported
'ext.connection_tenant_missing', : ProviderReasonCodes::ProviderConnectionInvalid,
$targetScope['message'] ?? 'Provider connection target scope is invalid.',
$failureCode === ProviderConnectionTargetScopeNormalizer::FAILURE_UNSUPPORTED_PROVIDER_SCOPE_COMBINATION
? 'ext.connection_scope_unsupported'
: 'ext.connection_scope_missing',
$connection, $connection,
); );
} }

View File

@ -6,10 +6,16 @@
use App\Services\Providers\Contracts\HealthResult; use App\Services\Providers\Contracts\HealthResult;
use App\Support\Providers\ProviderConsentStatus; use App\Support\Providers\ProviderConsentStatus;
use App\Support\Providers\ProviderReasonCodes; use App\Support\Providers\ProviderReasonCodes;
use App\Support\Providers\TargetScope\ProviderConnectionSurfaceSummary;
use App\Support\Providers\ProviderVerificationStatus; use App\Support\Providers\ProviderVerificationStatus;
final class ProviderConnectionStateProjector final class ProviderConnectionStateProjector
{ {
public function surfaceSummary(ProviderConnection $connection): ProviderConnectionSurfaceSummary
{
return ProviderConnectionSurfaceSummary::forConnection($connection);
}
/** /**
* @return array{ * @return array{
* consent_status: ProviderConsentStatus, * consent_status: ProviderConsentStatus,

View File

@ -5,6 +5,8 @@
use App\Models\ProviderConnection; use App\Models\ProviderConnection;
use App\Services\Graph\GraphClientInterface; use App\Services\Graph\GraphClientInterface;
use App\Services\Graph\GraphResponse; use App\Services\Graph\GraphResponse;
use Illuminate\Support\Str;
use RuntimeException;
final class ProviderGateway final class ProviderGateway
{ {
@ -53,6 +55,17 @@ public function request(ProviderConnection $connection, string $method, string $
*/ */
public function graphOptions(ProviderConnection $connection, array $overrides = []): array public function graphOptions(ProviderConnection $connection, array $overrides = []): array
{ {
return $this->identityResolver->resolve($connection)->graphOptions($overrides); $resolution = $this->identityResolver->resolve($connection);
if (! $resolution->resolved || $resolution->effectiveClientId === null || $resolution->clientSecret === null) {
throw new RuntimeException($resolution->message ?? 'Provider identity could not be resolved.');
}
return array_merge([
'tenant' => $resolution->tenantContext,
'client_id' => $resolution->effectiveClientId,
'client_secret' => $resolution->clientSecret,
'client_request_id' => (string) Str::uuid(),
], $overrides);
} }
} }

View File

@ -4,11 +4,14 @@
use App\Support\Providers\ProviderConnectionType; use App\Support\Providers\ProviderConnectionType;
use App\Support\Providers\ProviderReasonCodes; use App\Support\Providers\ProviderReasonCodes;
use Illuminate\Support\Str; use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeDescriptor;
use RuntimeException; use App\Support\Providers\TargetScope\ProviderIdentityContextMetadata;
final class ProviderIdentityResolution final class ProviderIdentityResolution
{ {
/**
* @param list<ProviderIdentityContextMetadata> $contextualIdentityDetails
*/
private function __construct( private function __construct(
public readonly bool $resolved, public readonly bool $resolved,
public readonly ProviderConnectionType $connectionType, public readonly ProviderConnectionType $connectionType,
@ -20,6 +23,8 @@ private function __construct(
public readonly ?string $redirectUri, public readonly ?string $redirectUri,
public readonly ?string $reasonCode, public readonly ?string $reasonCode,
public readonly ?string $message, public readonly ?string $message,
public readonly ?ProviderConnectionTargetScopeDescriptor $targetScope,
public readonly array $contextualIdentityDetails,
) {} ) {}
public static function resolved( public static function resolved(
@ -30,6 +35,8 @@ public static function resolved(
?string $clientSecret, ?string $clientSecret,
?string $authorityTenant, ?string $authorityTenant,
?string $redirectUri, ?string $redirectUri,
?ProviderConnectionTargetScopeDescriptor $targetScope = null,
array $contextualIdentityDetails = [],
): self { ): self {
return new self( return new self(
resolved: true, resolved: true,
@ -42,6 +49,10 @@ public static function resolved(
redirectUri: $redirectUri, redirectUri: $redirectUri,
reasonCode: null, reasonCode: null,
message: null, message: null,
targetScope: $targetScope ?? self::targetScopeFromContext($tenantContext),
contextualIdentityDetails: $contextualIdentityDetails !== []
? $contextualIdentityDetails
: self::contextualIdentityDetails($tenantContext, $authorityTenant, $redirectUri),
); );
} }
@ -51,6 +62,8 @@ public static function blocked(
string $credentialSource, string $credentialSource,
string $reasonCode, string $reasonCode,
?string $message = null, ?string $message = null,
?ProviderConnectionTargetScopeDescriptor $targetScope = null,
array $contextualIdentityDetails = [],
): self { ): self {
return new self( return new self(
resolved: false, resolved: false,
@ -63,29 +76,47 @@ public static function blocked(
redirectUri: null, redirectUri: null,
reasonCode: ProviderReasonCodes::isKnown($reasonCode) ? $reasonCode : ProviderReasonCodes::UnknownError, reasonCode: ProviderReasonCodes::isKnown($reasonCode) ? $reasonCode : ProviderReasonCodes::UnknownError,
message: $message, message: $message,
targetScope: $targetScope ?? (trim($tenantContext) !== '' ? self::targetScopeFromContext($tenantContext) : null),
contextualIdentityDetails: $contextualIdentityDetails !== []
? $contextualIdentityDetails
: self::contextualIdentityDetails($tenantContext),
); );
} }
/**
* @param array<string, mixed> $overrides
* @return array<string, mixed>
*/
public function graphOptions(array $overrides = []): array
{
if (! $this->resolved || $this->effectiveClientId === null || $this->clientSecret === null) {
throw new RuntimeException($this->message ?? 'Provider identity could not be resolved.');
}
return array_merge([
'tenant' => $this->tenantContext,
'client_id' => $this->effectiveClientId,
'client_secret' => $this->clientSecret,
'client_request_id' => (string) Str::uuid(),
], $overrides);
}
public function effectiveReasonCode(): string public function effectiveReasonCode(): string
{ {
return $this->reasonCode ?? ProviderReasonCodes::UnknownError; return $this->reasonCode ?? ProviderReasonCodes::UnknownError;
} }
private static function targetScopeFromContext(string $tenantContext): ProviderConnectionTargetScopeDescriptor
{
$identifier = trim($tenantContext) !== '' ? trim($tenantContext) : 'organizations';
return ProviderConnectionTargetScopeDescriptor::fromInput(
provider: 'microsoft',
scopeKind: ProviderConnectionTargetScopeDescriptor::SCOPE_KIND_TENANT,
scopeIdentifier: $identifier,
scopeDisplayName: $identifier,
);
}
/**
* @return list<ProviderIdentityContextMetadata>
*/
private static function contextualIdentityDetails(
string $tenantContext,
?string $authorityTenant = null,
?string $redirectUri = null,
): array {
$details = [
ProviderIdentityContextMetadata::microsoftTenantId($tenantContext),
ProviderIdentityContextMetadata::authorityTenant($authorityTenant),
ProviderIdentityContextMetadata::redirectUri($redirectUri),
];
return array_values(array_filter(
$details,
static fn (?ProviderIdentityContextMetadata $detail): bool => $detail instanceof ProviderIdentityContextMetadata,
));
}
} }

View File

@ -7,6 +7,8 @@
use App\Support\Providers\ProviderConnectionType; use App\Support\Providers\ProviderConnectionType;
use App\Support\Providers\ProviderCredentialSource; use App\Support\Providers\ProviderCredentialSource;
use App\Support\Providers\ProviderReasonCodes; use App\Support\Providers\ProviderReasonCodes;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeDescriptor;
use App\Support\Providers\TargetScope\ProviderConnectionTargetScopeNormalizer;
use InvalidArgumentException; use InvalidArgumentException;
use RuntimeException; use RuntimeException;
@ -15,12 +17,16 @@ final class ProviderIdentityResolver
public function __construct( public function __construct(
private readonly PlatformProviderIdentityResolver $platformResolver, private readonly PlatformProviderIdentityResolver $platformResolver,
private readonly CredentialManager $credentials, private readonly CredentialManager $credentials,
private readonly ProviderConnectionTargetScopeNormalizer $targetScopeNormalizer,
) {} ) {}
public function resolve(ProviderConnection $connection): ProviderIdentityResolution public function resolve(ProviderConnection $connection): ProviderIdentityResolution
{ {
$tenantContext = trim((string) $connection->entra_tenant_id); $tenantContext = trim((string) $connection->entra_tenant_id);
$connectionType = $this->resolveConnectionType($connection); $connectionType = $this->resolveConnectionType($connection);
$targetScopeResult = $this->targetScopeNormalizer->normalizeConnection($connection);
$targetScope = $targetScopeResult['target_scope'] ?? null;
$contextualIdentityDetails = $this->targetScopeNormalizer->contextualIdentityDetailsForConnection($connection);
if ($connectionType === null) { if ($connectionType === null) {
return ProviderIdentityResolution::blocked( return ProviderIdentityResolution::blocked(
@ -29,16 +35,20 @@ public function resolve(ProviderConnection $connection): ProviderIdentityResolut
credentialSource: 'unknown', credentialSource: 'unknown',
reasonCode: ProviderReasonCodes::ProviderConnectionTypeInvalid, reasonCode: ProviderReasonCodes::ProviderConnectionTypeInvalid,
message: 'Provider connection type is invalid.', message: 'Provider connection type is invalid.',
targetScope: $targetScope instanceof ProviderConnectionTargetScopeDescriptor ? $targetScope : null,
contextualIdentityDetails: $contextualIdentityDetails,
); );
} }
if ($tenantContext === '') { if ($targetScopeResult['status'] !== ProviderConnectionTargetScopeNormalizer::STATUS_NORMALIZED) {
return ProviderIdentityResolution::blocked( return ProviderIdentityResolution::blocked(
connectionType: $connectionType, connectionType: $connectionType,
tenantContext: 'organizations', tenantContext: 'organizations',
credentialSource: $connectionType === ProviderConnectionType::Platform ? 'platform_config' : ProviderCredentialSource::DedicatedManual->value, credentialSource: $connectionType === ProviderConnectionType::Platform ? 'platform_config' : ProviderCredentialSource::DedicatedManual->value,
reasonCode: ProviderReasonCodes::ProviderConnectionInvalid, reasonCode: ProviderReasonCodes::ProviderConnectionInvalid,
message: 'Provider connection is missing target tenant scope.', message: $targetScopeResult['message'] ?? 'Provider connection target scope is invalid.',
targetScope: $targetScope instanceof ProviderConnectionTargetScopeDescriptor ? $targetScope : null,
contextualIdentityDetails: $contextualIdentityDetails,
); );
} }
@ -49,14 +59,25 @@ public function resolve(ProviderConnection $connection): ProviderIdentityResolut
credentialSource: $connectionType === ProviderConnectionType::Platform ? 'platform_config' : ProviderCredentialSource::LegacyMigrated->value, credentialSource: $connectionType === ProviderConnectionType::Platform ? 'platform_config' : ProviderCredentialSource::LegacyMigrated->value,
reasonCode: ProviderReasonCodes::ProviderConnectionReviewRequired, reasonCode: ProviderReasonCodes::ProviderConnectionReviewRequired,
message: 'Provider connection requires migration review before use.', message: 'Provider connection requires migration review before use.',
targetScope: $targetScope instanceof ProviderConnectionTargetScopeDescriptor ? $targetScope : null,
contextualIdentityDetails: $contextualIdentityDetails,
); );
} }
if ($connectionType === ProviderConnectionType::Platform) { if ($connectionType === ProviderConnectionType::Platform) {
return $this->platformResolver->resolve($tenantContext); return $this->platformResolver->resolve(
tenantContext: $tenantContext,
targetScope: $targetScope instanceof ProviderConnectionTargetScopeDescriptor ? $targetScope : null,
contextualIdentityDetails: $contextualIdentityDetails,
);
} }
return $this->resolveDedicatedIdentity($connection, $tenantContext); return $this->resolveDedicatedIdentity(
connection: $connection,
tenantContext: $tenantContext,
targetScope: $targetScope instanceof ProviderConnectionTargetScopeDescriptor ? $targetScope : null,
contextualIdentityDetails: $contextualIdentityDetails,
);
} }
private function resolveConnectionType(ProviderConnection $connection): ?ProviderConnectionType private function resolveConnectionType(ProviderConnection $connection): ?ProviderConnectionType
@ -77,6 +98,8 @@ private function resolveConnectionType(ProviderConnection $connection): ?Provide
private function resolveDedicatedIdentity( private function resolveDedicatedIdentity(
ProviderConnection $connection, ProviderConnection $connection,
string $tenantContext, string $tenantContext,
?ProviderConnectionTargetScopeDescriptor $targetScope = null,
array $contextualIdentityDetails = [],
): ProviderIdentityResolution { ): ProviderIdentityResolution {
try { try {
$credentials = $this->credentials->getClientCredentials($connection); $credentials = $this->credentials->getClientCredentials($connection);
@ -89,6 +112,8 @@ private function resolveDedicatedIdentity(
? ProviderReasonCodes::DedicatedCredentialInvalid ? ProviderReasonCodes::DedicatedCredentialInvalid
: ProviderReasonCodes::DedicatedCredentialMissing, : ProviderReasonCodes::DedicatedCredentialMissing,
message: $exception->getMessage(), message: $exception->getMessage(),
targetScope: $targetScope,
contextualIdentityDetails: $contextualIdentityDetails,
); );
} }
@ -100,6 +125,8 @@ private function resolveDedicatedIdentity(
clientSecret: $credentials['client_secret'], clientSecret: $credentials['client_secret'],
authorityTenant: $tenantContext, authorityTenant: $tenantContext,
redirectUri: trim((string) route('admin.consent.callback')), redirectUri: trim((string) route('admin.consent.callback')),
targetScope: $targetScope,
contextualIdentityDetails: $contextualIdentityDetails,
); );
} }

View File

@ -7,44 +7,48 @@
final class ProviderOperationRegistry final class ProviderOperationRegistry
{ {
public const string BINDING_ACTIVE = 'active';
public const string BINDING_UNSUPPORTED = 'unsupported';
/** /**
* @return array<string, array{provider: string, module: string, label: string, required_capability: string}> * @return array<string, array{operation_type: string, module: string, label: string, required_capability: string}>
*/ */
public function all(): array public function definitions(): array
{ {
return [ return [
'provider.connection.check' => [ 'provider.connection.check' => [
'provider' => 'microsoft', 'operation_type' => 'provider.connection.check',
'module' => 'health_check', 'module' => 'health_check',
'label' => 'Provider connection check', 'label' => 'Provider connection check',
'required_capability' => Capabilities::PROVIDER_RUN, 'required_capability' => Capabilities::PROVIDER_RUN,
], ],
'inventory_sync' => [ 'inventory.sync' => [
'provider' => 'microsoft', 'operation_type' => 'inventory.sync',
'module' => 'inventory', 'module' => 'inventory',
'label' => 'Inventory sync', 'label' => 'Inventory sync',
'required_capability' => Capabilities::PROVIDER_RUN, 'required_capability' => Capabilities::PROVIDER_RUN,
], ],
'compliance.snapshot' => [ 'compliance.snapshot' => [
'provider' => 'microsoft', 'operation_type' => 'compliance.snapshot',
'module' => 'compliance', 'module' => 'compliance',
'label' => 'Compliance snapshot', 'label' => 'Compliance snapshot',
'required_capability' => Capabilities::PROVIDER_RUN, 'required_capability' => Capabilities::PROVIDER_RUN,
], ],
'restore.execute' => [ 'restore.execute' => [
'provider' => 'microsoft', 'operation_type' => 'restore.execute',
'module' => 'restore', 'module' => 'restore',
'label' => 'Restore execution', 'label' => 'Restore execution',
'required_capability' => Capabilities::TENANT_MANAGE, 'required_capability' => Capabilities::TENANT_MANAGE,
], ],
'entra_group_sync' => [ 'directory.groups.sync' => [
'provider' => 'microsoft', 'operation_type' => 'directory.groups.sync',
'module' => 'directory_groups', 'module' => 'directory_groups',
'label' => 'Directory groups sync', 'label' => 'Directory groups sync',
'required_capability' => Capabilities::TENANT_SYNC, 'required_capability' => Capabilities::TENANT_SYNC,
], ],
'directory_role_definitions.sync' => [ 'directory.role_definitions.sync' => [
'provider' => 'microsoft', 'operation_type' => 'directory.role_definitions.sync',
'module' => 'directory_role_definitions', 'module' => 'directory_role_definitions',
'label' => 'Role definitions sync', 'label' => 'Role definitions sync',
'required_capability' => Capabilities::TENANT_MANAGE, 'required_capability' => Capabilities::TENANT_MANAGE,
@ -52,19 +56,78 @@ public function all(): array
]; ];
} }
public function isAllowed(string $operationType): bool /**
* @return array<string, array{operation_type: string, module: string, label: string, required_capability: string}>
*/
public function all(): array
{ {
return array_key_exists($operationType, $this->all()); return $this->definitions();
} }
/** /**
* @return array{provider: string, module: string, label: string, required_capability: string} * @return array<string, array<string, array{operation_type: string, provider: string, binding_status: string, handler_notes: string, exception_notes: string}>>
*/
public function providerBindings(): array
{
return [
'provider.connection.check' => [
'microsoft' => $this->activeMicrosoftBinding(
operationType: 'provider.connection.check',
handlerNotes: 'Uses the current Microsoft Graph provider connection health-check workflow.',
exceptionNotes: 'Current-release provider binding remains Microsoft-only until a real second provider case exists.',
),
],
'inventory.sync' => [
'microsoft' => $this->activeMicrosoftBinding(
operationType: 'inventory.sync',
handlerNotes: 'Uses the current Microsoft Intune inventory sync workflow.',
exceptionNotes: 'Inventory collection is currently Microsoft Intune-specific provider behavior.',
),
],
'compliance.snapshot' => [
'microsoft' => $this->activeMicrosoftBinding(
operationType: 'compliance.snapshot',
handlerNotes: 'Uses the current Microsoft compliance snapshot workflow.',
exceptionNotes: 'Compliance snapshot runtime remains bounded to the Microsoft provider.',
),
],
'restore.execute' => [
'microsoft' => $this->activeMicrosoftBinding(
operationType: 'restore.execute',
handlerNotes: 'Uses the current Microsoft restore execution workflow.',
exceptionNotes: 'Restore execution remains Microsoft-only and must preserve dry-run and audit safeguards.',
),
],
'directory.groups.sync' => [
'microsoft' => $this->activeMicrosoftBinding(
operationType: 'directory.groups.sync',
handlerNotes: 'Uses the current Microsoft Entra group synchronization workflow.',
exceptionNotes: 'The operation type keeps current Entra vocabulary until the identity-neutrality follow-up.',
),
],
'directory.role_definitions.sync' => [
'microsoft' => $this->activeMicrosoftBinding(
operationType: 'directory.role_definitions.sync',
handlerNotes: 'Uses the current Microsoft directory role definition synchronization workflow.',
exceptionNotes: 'Directory role definitions are Microsoft-owned provider semantics.',
),
],
];
}
public function isAllowed(string $operationType): bool
{
return array_key_exists(trim($operationType), $this->definitions());
}
/**
* @return array{operation_type: string, module: string, label: string, required_capability: string}
*/ */
public function get(string $operationType): array public function get(string $operationType): array
{ {
$operationType = trim($operationType); $operationType = trim($operationType);
$definition = $this->all()[$operationType] ?? null; $definition = $this->definitions()[$operationType] ?? null;
if (! is_array($definition)) { if (! is_array($definition)) {
throw new InvalidArgumentException("Unknown provider operation type: {$operationType}"); throw new InvalidArgumentException("Unknown provider operation type: {$operationType}");
@ -72,4 +135,85 @@ public function get(string $operationType): array
return $definition; return $definition;
} }
/**
* @return array{operation_type: string, provider: string, binding_status: string, handler_notes: string, exception_notes: string}|null
*/
public function bindingFor(string $operationType, string $provider): ?array
{
$operationType = trim($operationType);
$provider = trim($provider);
if ($operationType === '' || $provider === '') {
return null;
}
$bindings = $this->providerBindings()[$operationType] ?? [];
return $bindings[$provider] ?? null;
}
/**
* @return array{operation_type: string, provider: string, binding_status: string, handler_notes: string, exception_notes: string}|null
*/
public function activeBindingFor(string $operationType): ?array
{
$operationType = trim($operationType);
$bindings = $this->providerBindings()[$operationType] ?? [];
foreach ($bindings as $binding) {
if (($binding['binding_status'] ?? null) === self::BINDING_ACTIVE) {
return $binding;
}
}
return null;
}
/**
* @return array{
* definition: array{operation_type: string, module: string, label: string, required_capability: string},
* binding: array{operation_type: string, provider: string, binding_status: string, handler_notes: string, exception_notes: string}
* }
*/
public function boundaryOperation(string $operationType, ?string $provider = null): array
{
$definition = $this->get($operationType);
$binding = is_string($provider) && trim($provider) !== ''
? $this->bindingFor($operationType, $provider)
: $this->activeBindingFor($operationType);
return [
'definition' => $definition,
'binding' => $binding ?? $this->unsupportedBinding($operationType, $provider ?? 'unknown'),
];
}
/**
* @return array{operation_type: string, provider: string, binding_status: string, handler_notes: string, exception_notes: string}
*/
public function unsupportedBinding(string $operationType, string $provider): array
{
return [
'operation_type' => trim($operationType),
'provider' => trim($provider) !== '' ? trim($provider) : 'unknown',
'binding_status' => self::BINDING_UNSUPPORTED,
'handler_notes' => 'No explicit provider binding exists for this operation/provider combination.',
'exception_notes' => 'Unsupported combinations must block explicitly instead of inheriting Microsoft behavior.',
];
}
/**
* @return array{operation_type: string, provider: string, binding_status: string, handler_notes: string, exception_notes: string}
*/
private function activeMicrosoftBinding(string $operationType, string $handlerNotes, string $exceptionNotes): array
{
return [
'operation_type' => $operationType,
'provider' => 'microsoft',
'binding_status' => self::BINDING_ACTIVE,
'handler_notes' => $handlerNotes,
'exception_notes' => $exceptionNotes,
];
}
} }

View File

@ -42,26 +42,47 @@ public function start(
array $extraContext = [], array $extraContext = [],
): ProviderOperationStartResult { ): ProviderOperationStartResult {
$definition = $this->registry->get($operationType); $definition = $this->registry->get($operationType);
$binding = $this->resolveProviderBinding($operationType, $connection);
if (($binding['binding_status'] ?? null) !== ProviderOperationRegistry::BINDING_ACTIVE) {
return $this->startBlocked(
tenant: $tenant,
operationType: $operationType,
provider: (string) ($binding['provider'] ?? 'unknown'),
module: (string) $definition['module'],
reasonCode: ProviderReasonCodes::ProviderBindingUnsupported,
extensionReasonCode: 'ext.provider_binding_missing',
reasonMessage: 'No explicit provider binding supports this operation/provider combination.',
connection: $connection,
initiator: $initiator,
extraContext: array_merge($extraContext, [
'provider_binding' => $this->bindingContext($binding),
]),
);
}
$resolution = $connection instanceof ProviderConnection $resolution = $connection instanceof ProviderConnection
? $this->resolver->validateConnection($tenant, (string) $definition['provider'], $connection) ? $this->resolver->validateConnection($tenant, (string) $binding['provider'], $connection)
: $this->resolver->resolveDefault($tenant, (string) $definition['provider']); : $this->resolver->resolveDefault($tenant, (string) $binding['provider']);
if (! $resolution->resolved || ! $resolution->connection instanceof ProviderConnection) { if (! $resolution->resolved || ! $resolution->connection instanceof ProviderConnection) {
return $this->startBlocked( return $this->startBlocked(
tenant: $tenant, tenant: $tenant,
operationType: $operationType, operationType: $operationType,
provider: (string) $definition['provider'], provider: (string) $binding['provider'],
module: (string) $definition['module'], module: (string) $definition['module'],
reasonCode: $resolution->effectiveReasonCode(), reasonCode: $resolution->effectiveReasonCode(),
extensionReasonCode: $resolution->extensionReasonCode, extensionReasonCode: $resolution->extensionReasonCode,
reasonMessage: $resolution->message, reasonMessage: $resolution->message,
connection: $resolution->connection ?? $connection, connection: $resolution->connection ?? $connection,
initiator: $initiator, initiator: $initiator,
extraContext: $extraContext, extraContext: array_merge($extraContext, [
'provider_binding' => $this->bindingContext($binding),
]),
); );
} }
return DB::transaction(function () use ($tenant, $operationType, $dispatcher, $initiator, $extraContext, $definition, $resolution): ProviderOperationStartResult { return DB::transaction(function () use ($tenant, $operationType, $dispatcher, $initiator, $extraContext, $definition, $binding, $resolution): ProviderOperationStartResult {
$connection = $resolution->connection; $connection = $resolution->connection;
if (! $connection instanceof ProviderConnection) { if (! $connection instanceof ProviderConnection) {
@ -114,6 +135,7 @@ public function start(
'required_capability' => $this->resolveRequiredCapability($operationType, $extraContext), 'required_capability' => $this->resolveRequiredCapability($operationType, $extraContext),
'provider' => $lockedConnection->provider, 'provider' => $lockedConnection->provider,
'module' => $definition['module'], 'module' => $definition['module'],
'provider_binding' => $this->bindingContext($binding),
'provider_connection_id' => (int) $lockedConnection->getKey(), 'provider_connection_id' => (int) $lockedConnection->getKey(),
'target_scope' => [ 'target_scope' => [
'entra_tenant_id' => $lockedConnection->entra_tenant_id, 'entra_tenant_id' => $lockedConnection->entra_tenant_id,
@ -235,6 +257,36 @@ private function invokeDispatcher(callable $dispatcher, OperationRun $run): void
$dispatcher(); $dispatcher();
} }
/**
* @return array{operation_type: string, provider: string, binding_status: string, handler_notes: string, exception_notes: string}
*/
private function resolveProviderBinding(string $operationType, ?ProviderConnection $connection): array
{
if ($connection instanceof ProviderConnection) {
$provider = trim((string) $connection->provider);
return $this->registry->bindingFor($operationType, $provider)
?? $this->registry->unsupportedBinding($operationType, $provider);
}
return $this->registry->activeBindingFor($operationType)
?? $this->registry->unsupportedBinding($operationType, 'unknown');
}
/**
* @param array{operation_type: string, provider: string, binding_status: string, handler_notes: string, exception_notes: string} $binding
* @return array{provider: string, binding_status: string, handler_notes: string, exception_notes: string}
*/
private function bindingContext(array $binding): array
{
return [
'provider' => (string) $binding['provider'],
'binding_status' => (string) $binding['binding_status'],
'handler_notes' => (string) $binding['handler_notes'],
'exception_notes' => (string) $binding['exception_notes'],
];
}
/** /**
* @param array<string, mixed> $extraContext * @param array<string, mixed> $extraContext
*/ */

View File

@ -597,7 +597,7 @@ private function dispatchFailureAlertSafely(OperationRun $run): void
'body' => 'A findings lifecycle backfill run failed.', 'body' => 'A findings lifecycle backfill run failed.',
'metadata' => [ 'metadata' => [
'operation_run_id' => (int) $run->getKey(), 'operation_run_id' => (int) $run->getKey(),
'operation_type' => (string) $run->type, 'operation_type' => $run->canonicalOperationType(),
'scope' => (string) data_get($run->context, 'runbook.scope', ''), 'scope' => (string) data_get($run->context, 'runbook.scope', ''),
'view_run_url' => SystemOperationRunLinks::view($run), 'view_run_url' => SystemOperationRunLinks::view($run),
], ],

View File

@ -14,10 +14,9 @@
final class OperationRunTriageService final class OperationRunTriageService
{ {
private const RETRYABLE_TYPES = [ private const RETRYABLE_TYPES = [
'inventory_sync', 'inventory.sync',
'policy.sync', 'policy.sync',
'policy.sync_one', 'directory.groups.sync',
'entra_group_sync',
'findings.lifecycle.backfill', 'findings.lifecycle.backfill',
'rbac.health_check', 'rbac.health_check',
'entra.admin_roles.scan', 'entra.admin_roles.scan',
@ -26,10 +25,9 @@ final class OperationRunTriageService
]; ];
private const CANCELABLE_TYPES = [ private const CANCELABLE_TYPES = [
'inventory_sync', 'inventory.sync',
'policy.sync', 'policy.sync',
'policy.sync_one', 'directory.groups.sync',
'entra_group_sync',
'findings.lifecycle.backfill', 'findings.lifecycle.backfill',
'rbac.health_check', 'rbac.health_check',
'entra.admin_roles.scan', 'entra.admin_roles.scan',
@ -46,7 +44,7 @@ public function canRetry(OperationRun $run): bool
{ {
return (string) $run->status === OperationRunStatus::Completed->value return (string) $run->status === OperationRunStatus::Completed->value
&& (string) $run->outcome === OperationRunOutcome::Failed->value && (string) $run->outcome === OperationRunOutcome::Failed->value
&& in_array((string) $run->type, self::RETRYABLE_TYPES, true); && in_array($run->canonicalOperationType(), self::RETRYABLE_TYPES, true);
} }
public function canCancel(OperationRun $run): bool public function canCancel(OperationRun $run): bool
@ -55,7 +53,7 @@ public function canCancel(OperationRun $run): bool
OperationRunStatus::Queued->value, OperationRunStatus::Queued->value,
OperationRunStatus::Running->value, OperationRunStatus::Running->value,
], true) ], true)
&& in_array((string) $run->type, self::CANCELABLE_TYPES, true); && in_array($run->canonicalOperationType(), self::CANCELABLE_TYPES, true);
} }
public function retry(OperationRun $run, PlatformUser $actor): OperationRun public function retry(OperationRun $run, PlatformUser $actor): OperationRun
@ -83,7 +81,7 @@ public function retry(OperationRun $run, PlatformUser $actor): OperationRun
'tenant_id' => $run->tenant_id !== null ? (int) $run->tenant_id : null, 'tenant_id' => $run->tenant_id !== null ? (int) $run->tenant_id : null,
'user_id' => null, 'user_id' => null,
'initiator_name' => $actor->name ?? 'Platform operator', 'initiator_name' => $actor->name ?? 'Platform operator',
'type' => (string) $run->type, 'type' => $run->canonicalOperationType(),
'status' => OperationRunStatus::Queued->value, 'status' => OperationRunStatus::Queued->value,
'outcome' => OperationRunOutcome::Pending->value, 'outcome' => OperationRunOutcome::Pending->value,
'run_identity_hash' => hash('sha256', 'retry|'.$run->getKey().'|'.now()->format('U.u').'|'.bin2hex(random_bytes(8))), 'run_identity_hash' => hash('sha256', 'retry|'.$run->getKey().'|'.now()->format('U.u').'|'.bin2hex(random_bytes(8))),
@ -100,7 +98,7 @@ public function retry(OperationRun $run, PlatformUser $actor): OperationRun
metadata: [ metadata: [
'source_run_id' => (int) $run->getKey(), 'source_run_id' => (int) $run->getKey(),
'new_run_id' => (int) $retryRun->getKey(), 'new_run_id' => (int) $retryRun->getKey(),
'operation_type' => (string) $run->type, 'operation_type' => $run->canonicalOperationType(),
], ],
run: $retryRun, run: $retryRun,
); );
@ -152,7 +150,7 @@ public function cancel(OperationRun $run, PlatformUser $actor, string $reason):
actor: $actor, actor: $actor,
action: 'platform.system_console.cancel', action: 'platform.system_console.cancel',
metadata: [ metadata: [
'operation_type' => (string) $run->type, 'operation_type' => $run->canonicalOperationType(),
'reason' => $reason, 'reason' => $reason,
], ],
run: $cancelledRun, run: $cancelledRun,
@ -192,7 +190,7 @@ public function markInvestigated(OperationRun $run, PlatformUser $actor, string
action: 'platform.system_console.mark_investigated', action: 'platform.system_console.mark_investigated',
metadata: [ metadata: [
'reason' => $reason, 'reason' => $reason,
'operation_type' => (string) $run->type, 'operation_type' => $run->canonicalOperationType(),
], ],
run: $run, run: $run,
); );

View File

@ -119,6 +119,11 @@ public function providerConnectionCheckUsingConnection(
'connection_type' => $identity->connectionType->value, 'connection_type' => $identity->connectionType->value,
'credential_source' => $identity->credentialSource, 'credential_source' => $identity->credentialSource,
'effective_client_id' => $identity->effectiveClientId, 'effective_client_id' => $identity->effectiveClientId,
'target_scope' => $identity->targetScope?->toArray(),
'provider_identity_context' => array_map(
static fn ($detail): array => $detail->toArray(),
$identity->contextualIdentityDetails,
),
], ],
]), ]),
); );

View File

@ -12,6 +12,7 @@
use App\Models\OperationRun; use App\Models\OperationRun;
use App\Models\Tenant; use App\Models\Tenant;
use App\Services\Baselines\BaselineSnapshotTruthResolver; use App\Services\Baselines\BaselineSnapshotTruthResolver;
use App\Support\OperationCatalog;
use App\Support\OperationRunStatus; use App\Support\OperationRunStatus;
use App\Support\OperationRunType; use App\Support\OperationRunType;
use App\Support\ReasonTranslation\ReasonPresenter; use App\Support\ReasonTranslation\ReasonPresenter;
@ -166,7 +167,7 @@ public static function forTenant(?Tenant $tenant): self
$latestRun = OperationRun::query() $latestRun = OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'baseline_compare') ->whereIn('type', OperationCatalog::rawValuesForCanonical(OperationRunType::BaselineCompare->value))
->latest('id') ->latest('id')
->first(); ->first();
@ -457,7 +458,7 @@ public static function forWidget(?Tenant $tenant): self
$latestRun = OperationRun::query() $latestRun = OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'baseline_compare') ->whereIn('type', OperationCatalog::rawValuesForCanonical(OperationRunType::BaselineCompare->value))
->where('context->baseline_profile_id', (string) $profile->getKey()) ->where('context->baseline_profile_id', (string) $profile->getKey())
->whereNotNull('completed_at') ->whereNotNull('completed_at')
->latest('completed_at') ->latest('completed_at')

View File

@ -121,17 +121,29 @@ public static function boundaryClassification(?PlatformVocabularyGlossary $gloss
} }
/** /**
* Read-side compatibility helper for historical rows only.
*
* Writers must emit the canonical code directly instead of translating a
* legacy alias through this method.
*
* @return list<string> * @return list<string>
*/ */
public static function rawValuesForCanonical(string $canonicalCode): array public static function rawValuesForCanonical(string $canonicalCode): array
{ {
return array_values(array_map( $canonicalCode = trim($canonicalCode);
$values = array_values(array_map(
static fn (OperationTypeAlias $alias): string => $alias->rawValue, static fn (OperationTypeAlias $alias): string => $alias->rawValue,
array_filter( array_filter(
self::operationAliases(), self::operationAliases(),
static fn (OperationTypeAlias $alias): bool => $alias->canonicalCode === trim($canonicalCode), static fn (OperationTypeAlias $alias): bool => $alias->canonicalCode === $canonicalCode,
), ),
)); ));
if (array_key_exists($canonicalCode, self::canonicalDefinitions()) && ! in_array($canonicalCode, $values, true)) {
$values[] = $canonicalCode;
}
return $values;
} }
/** /**
@ -191,6 +203,21 @@ public static function resolve(string $operationType): OperationTypeResolution
); );
} }
$definition = self::canonicalDefinitions()[$operationType] ?? null;
if ($definition instanceof CanonicalOperationType) {
return new OperationTypeResolution(
rawValue: $operationType,
canonical: $definition,
aliasesConsidered: array_values(array_filter(
$aliases,
static fn (OperationTypeAlias $alias): bool => $alias->canonicalCode === $operationType,
)),
aliasStatus: 'canonical',
wasLegacyAlias: false,
);
}
return new OperationTypeResolution( return new OperationTypeResolution(
rawValue: $operationType, rawValue: $operationType,
canonical: new CanonicalOperationType( canonical: new CanonicalOperationType(
@ -262,29 +289,29 @@ private static function operationAliases(): array
{ {
return [ return [
new OperationTypeAlias('policy.sync', 'policy.sync', 'canonical', true), new OperationTypeAlias('policy.sync', 'policy.sync', 'canonical', true),
new OperationTypeAlias('policy.sync_one', 'policy.sync', 'legacy_alias', true, 'Legacy single-policy sync values resolve to the canonical policy.sync operation.', 'Prefer policy.sync on platform-owned read paths.'), new OperationTypeAlias('policy.sync_one', 'policy.sync', 'legacy_alias', false, 'Legacy single-policy sync values resolve to the canonical policy.sync operation.', 'Prefer policy.sync on platform-owned read paths.'),
new OperationTypeAlias('policy.capture_snapshot', 'policy.snapshot', 'canonical', true), new OperationTypeAlias('policy.capture_snapshot', 'policy.snapshot', 'canonical', true),
new OperationTypeAlias('policy.delete', 'policy.delete', 'canonical', true), new OperationTypeAlias('policy.delete', 'policy.delete', 'canonical', true),
new OperationTypeAlias('policy.unignore', 'policy.restore', 'legacy_alias', true, 'Legacy policy.unignore values resolve to policy.restore for operator-facing wording.', 'Prefer policy.restore on new platform-owned read models.'), new OperationTypeAlias('policy.unignore', 'policy.restore', 'legacy_alias', false, 'Legacy policy.unignore values resolve to policy.restore for operator-facing wording.', 'Prefer policy.restore on new platform-owned read models.'),
new OperationTypeAlias('policy.export', 'policy.export', 'canonical', true), new OperationTypeAlias('policy.export', 'policy.export', 'canonical', true),
new OperationTypeAlias('provider.connection.check', 'provider.connection.check', 'canonical', true), new OperationTypeAlias('provider.connection.check', 'provider.connection.check', 'canonical', true),
new OperationTypeAlias('inventory_sync', 'inventory.sync', 'legacy_alias', true, 'Legacy inventory_sync storage values resolve to the canonical inventory.sync operation.', 'Preserve stored values during rollout while showing inventory.sync semantics on read paths.'), new OperationTypeAlias('inventory_sync', 'inventory.sync', 'legacy_alias', false, 'Legacy inventory_sync storage values resolve to the canonical inventory.sync operation.', 'Preserve stored values during rollout while showing inventory.sync semantics on read paths.'),
new OperationTypeAlias('provider.inventory.sync', 'inventory.sync', 'legacy_alias', false, 'Provider-prefixed historical inventory sync values share the same operator meaning as inventory sync.', 'Avoid emitting provider.inventory.sync on new platform-owned surfaces.'), new OperationTypeAlias('provider.inventory.sync', 'inventory.sync', 'legacy_alias', false, 'Provider-prefixed historical inventory sync values share the same operator meaning as inventory sync.', 'Avoid emitting provider.inventory.sync on new platform-owned surfaces.'),
new OperationTypeAlias('compliance.snapshot', 'compliance.snapshot', 'canonical', true), new OperationTypeAlias('compliance.snapshot', 'compliance.snapshot', 'canonical', true),
new OperationTypeAlias('provider.compliance.snapshot', 'compliance.snapshot', 'legacy_alias', false, 'Provider-prefixed compliance snapshot values resolve to the canonical compliance.snapshot operation.', 'Avoid emitting provider.compliance.snapshot on new platform-owned surfaces.'), new OperationTypeAlias('provider.compliance.snapshot', 'compliance.snapshot', 'legacy_alias', false, 'Provider-prefixed compliance snapshot values resolve to the canonical compliance.snapshot operation.', 'Avoid emitting provider.compliance.snapshot on new platform-owned surfaces.'),
new OperationTypeAlias('entra_group_sync', 'directory.groups.sync', 'legacy_alias', true, 'Historical entra_group_sync values resolve to directory.groups.sync.', 'Prefer directory.groups.sync on new platform-owned read models.'), new OperationTypeAlias('entra_group_sync', 'directory.groups.sync', 'legacy_alias', false, 'Historical entra_group_sync values resolve to directory.groups.sync.', 'Prefer directory.groups.sync on new platform-owned read models.'),
new OperationTypeAlias('backup_set.update', 'backup_set.update', 'canonical', true), new OperationTypeAlias('backup_set.update', 'backup_set.update', 'canonical', true),
new OperationTypeAlias('backup_set.delete', 'backup_set.archive', 'canonical', true), new OperationTypeAlias('backup_set.delete', 'backup_set.archive', 'canonical', true),
new OperationTypeAlias('backup_set.restore', 'backup_set.restore', 'canonical', true), new OperationTypeAlias('backup_set.restore', 'backup_set.restore', 'canonical', true),
new OperationTypeAlias('backup_set.force_delete', 'backup_set.delete', 'legacy_alias', true, 'Force-delete wording is normalized to the canonical delete label.', 'Use backup_set.delete for new platform-owned summaries.'), new OperationTypeAlias('backup_set.force_delete', 'backup_set.delete', 'legacy_alias', false, 'Force-delete wording is normalized to the canonical delete label.', 'Use backup_set.delete for new platform-owned summaries.'),
new OperationTypeAlias('backup_schedule_run', 'backup.schedule.execute', 'legacy_alias', true, 'Historical backup_schedule_run values resolve to backup.schedule.execute.', 'Prefer backup.schedule.execute on canonical read paths.'), new OperationTypeAlias('backup_schedule_run', 'backup.schedule.execute', 'legacy_alias', false, 'Historical backup_schedule_run values resolve to backup.schedule.execute.', 'Prefer backup.schedule.execute on canonical read paths.'),
new OperationTypeAlias('backup_schedule_retention', 'backup.schedule.retention', 'legacy_alias', true, 'Legacy backup schedule retention values resolve to backup.schedule.retention.', 'Prefer dotted canonical backup schedule naming on new read paths.'), new OperationTypeAlias('backup_schedule_retention', 'backup.schedule.retention', 'legacy_alias', false, 'Legacy backup schedule retention values resolve to backup.schedule.retention.', 'Prefer dotted canonical backup schedule naming on new read paths.'),
new OperationTypeAlias('backup_schedule_purge', 'backup.schedule.purge', 'legacy_alias', true, 'Legacy backup schedule purge values resolve to backup.schedule.purge.', 'Prefer dotted canonical backup schedule naming on new read paths.'), new OperationTypeAlias('backup_schedule_purge', 'backup.schedule.purge', 'legacy_alias', false, 'Legacy backup schedule purge values resolve to backup.schedule.purge.', 'Prefer dotted canonical backup schedule naming on new read paths.'),
new OperationTypeAlias('restore.execute', 'restore.execute', 'canonical', true), new OperationTypeAlias('restore.execute', 'restore.execute', 'canonical', true),
new OperationTypeAlias('assignments.fetch', 'assignments.fetch', 'canonical', true), new OperationTypeAlias('assignments.fetch', 'assignments.fetch', 'canonical', true),
new OperationTypeAlias('assignments.restore', 'assignments.restore', 'canonical', true), new OperationTypeAlias('assignments.restore', 'assignments.restore', 'canonical', true),
new OperationTypeAlias('ops.reconcile_adapter_runs', 'ops.reconcile_adapter_runs', 'canonical', true), new OperationTypeAlias('ops.reconcile_adapter_runs', 'ops.reconcile_adapter_runs', 'canonical', true),
new OperationTypeAlias('directory_role_definitions.sync', 'directory.role_definitions.sync', 'legacy_alias', true, 'Legacy directory_role_definitions.sync values resolve to directory.role_definitions.sync.', 'Prefer dotted role-definition naming on new read paths.'), new OperationTypeAlias('directory_role_definitions.sync', 'directory.role_definitions.sync', 'legacy_alias', false, 'Legacy directory_role_definitions.sync values resolve to directory.role_definitions.sync.', 'Prefer dotted role-definition naming on new read paths.'),
new OperationTypeAlias('restore_run.delete', 'restore_run.delete', 'canonical', true), new OperationTypeAlias('restore_run.delete', 'restore_run.delete', 'canonical', true),
new OperationTypeAlias('restore_run.restore', 'restore_run.restore', 'canonical', true), new OperationTypeAlias('restore_run.restore', 'restore_run.restore', 'canonical', true),
new OperationTypeAlias('restore_run.force_delete', 'restore_run.force_delete', 'canonical', true), new OperationTypeAlias('restore_run.force_delete', 'restore_run.force_delete', 'canonical', true),
@ -296,9 +323,9 @@ private static function operationAliases(): array
new OperationTypeAlias('alerts.deliver', 'alerts.deliver', 'canonical', true), new OperationTypeAlias('alerts.deliver', 'alerts.deliver', 'canonical', true),
new OperationTypeAlias('baseline.capture', 'baseline.capture', 'canonical', true), new OperationTypeAlias('baseline.capture', 'baseline.capture', 'canonical', true),
new OperationTypeAlias('baseline.compare', 'baseline.compare', 'canonical', true), new OperationTypeAlias('baseline.compare', 'baseline.compare', 'canonical', true),
new OperationTypeAlias('baseline_capture', 'baseline.capture', 'legacy_alias', true, 'Historical baseline_capture values resolve to baseline.capture.', 'Prefer baseline.capture on canonical read paths.'), new OperationTypeAlias('baseline_capture', 'baseline.capture', 'legacy_alias', false, 'Historical baseline_capture values resolve to baseline.capture.', 'Prefer baseline.capture on canonical read paths.'),
new OperationTypeAlias('baseline_compare', 'baseline.compare', 'legacy_alias', true, 'Historical baseline_compare values resolve to baseline.compare.', 'Prefer baseline.compare on canonical read paths.'), new OperationTypeAlias('baseline_compare', 'baseline.compare', 'legacy_alias', false, 'Historical baseline_compare values resolve to baseline.compare.', 'Prefer baseline.compare on canonical read paths.'),
new OperationTypeAlias('permission_posture_check', 'permission.posture.check', 'legacy_alias', true, 'Historical permission_posture_check values resolve to permission.posture.check.', 'Prefer dotted permission posture naming on new read paths.'), new OperationTypeAlias('permission_posture_check', 'permission.posture.check', 'legacy_alias', false, 'Historical permission_posture_check values resolve to permission.posture.check.', 'Prefer dotted permission posture naming on new read paths.'),
new OperationTypeAlias('entra.admin_roles.scan', 'entra.admin_roles.scan', 'canonical', true), new OperationTypeAlias('entra.admin_roles.scan', 'entra.admin_roles.scan', 'canonical', true),
new OperationTypeAlias('tenant.review_pack.generate', 'tenant.review_pack.generate', 'canonical', true), new OperationTypeAlias('tenant.review_pack.generate', 'tenant.review_pack.generate', 'canonical', true),
new OperationTypeAlias('tenant.review.compose', 'tenant.review.compose', 'canonical', true), new OperationTypeAlias('tenant.review.compose', 'tenant.review.compose', 'canonical', true),

View File

@ -108,7 +108,7 @@ public static function index(
} }
if (is_string($operationType) && $operationType !== '') { if (is_string($operationType) && $operationType !== '') {
$parameters['tableFilters']['type']['value'] = $operationType; $parameters['tableFilters']['type']['value'] = OperationCatalog::canonicalCode($operationType);
} }
return route('admin.operations.index', $parameters); return route('admin.operations.index', $parameters);
@ -145,17 +145,18 @@ public static function related(OperationRun $run, ?Tenant $tenant): array
} }
$providerConnectionId = $context['provider_connection_id'] ?? null; $providerConnectionId = $context['provider_connection_id'] ?? null;
$canonicalType = $run->canonicalOperationType();
if (is_numeric($providerConnectionId) && class_exists(ProviderConnectionResource::class)) { if (is_numeric($providerConnectionId) && class_exists(ProviderConnectionResource::class)) {
$links['Provider Connections'] = ProviderConnectionResource::getUrl('index', ['tenant' => $tenant], panel: 'admin'); $links['Provider Connections'] = ProviderConnectionResource::getUrl('index', ['tenant' => $tenant], panel: 'admin');
$links['Provider Connection'] = ProviderConnectionResource::getUrl('edit', ['tenant' => $tenant, 'record' => (int) $providerConnectionId], panel: 'admin'); $links['Provider Connection'] = ProviderConnectionResource::getUrl('edit', ['tenant' => $tenant, 'record' => (int) $providerConnectionId], panel: 'admin');
} }
if ($run->type === 'inventory_sync') { if ($canonicalType === 'inventory.sync') {
$links['Inventory'] = InventoryItemResource::getUrl('index', panel: 'tenant', tenant: $tenant); $links['Inventory'] = InventoryItemResource::getUrl('index', panel: 'tenant', tenant: $tenant);
} }
if (in_array($run->type, ['policy.sync', 'policy.sync_one'], true)) { if ($canonicalType === 'policy.sync') {
$links['Policies'] = PolicyResource::getUrl('index', panel: 'tenant', tenant: $tenant); $links['Policies'] = PolicyResource::getUrl('index', panel: 'tenant', tenant: $tenant);
$policyId = $context['policy_id'] ?? null; $policyId = $context['policy_id'] ?? null;
@ -164,15 +165,15 @@ public static function related(OperationRun $run, ?Tenant $tenant): array
} }
} }
if ($run->type === 'entra_group_sync') { if ($canonicalType === 'directory.groups.sync') {
$links['Directory Groups'] = EntraGroupResource::scopedUrl('index', tenant: $tenant); $links['Directory Groups'] = EntraGroupResource::scopedUrl('index', tenant: $tenant);
} }
if ($run->type === 'baseline_compare') { if ($canonicalType === 'baseline.compare') {
$links['Drift'] = BaselineCompareLanding::getUrl(panel: 'tenant', tenant: $tenant); $links['Drift'] = BaselineCompareLanding::getUrl(panel: 'tenant', tenant: $tenant);
} }
if ($run->type === 'baseline_capture') { if ($canonicalType === 'baseline.capture') {
$snapshotId = data_get($context, 'result.snapshot_id'); $snapshotId = data_get($context, 'result.snapshot_id');
if (is_numeric($snapshotId)) { if (is_numeric($snapshotId)) {
@ -180,7 +181,7 @@ public static function related(OperationRun $run, ?Tenant $tenant): array
} }
} }
if ($run->type === 'backup_set.update') { if ($canonicalType === 'backup_set.update') {
$links['Backup Sets'] = BackupSetResource::getUrl('index', panel: 'tenant', tenant: $tenant); $links['Backup Sets'] = BackupSetResource::getUrl('index', panel: 'tenant', tenant: $tenant);
$backupSetId = $context['backup_set_id'] ?? null; $backupSetId = $context['backup_set_id'] ?? null;
@ -189,11 +190,11 @@ public static function related(OperationRun $run, ?Tenant $tenant): array
} }
} }
if (in_array($run->type, ['backup_schedule_run', 'backup_schedule_retention', 'backup_schedule_purge'], true)) { if (in_array($canonicalType, ['backup.schedule.execute', 'backup.schedule.retention', 'backup.schedule.purge'], true)) {
$links['Backup Schedules'] = BackupScheduleResource::getUrl('index', panel: 'tenant', tenant: $tenant); $links['Backup Schedules'] = BackupScheduleResource::getUrl('index', panel: 'tenant', tenant: $tenant);
} }
if ($run->type === 'restore.execute') { if ($canonicalType === 'restore.execute') {
$links['Restore Runs'] = RestoreRunResource::getUrl('index', panel: 'tenant', tenant: $tenant); $links['Restore Runs'] = RestoreRunResource::getUrl('index', panel: 'tenant', tenant: $tenant);
$restoreRunId = $context['restore_run_id'] ?? null; $restoreRunId = $context['restore_run_id'] ?? null;
@ -202,7 +203,7 @@ public static function related(OperationRun $run, ?Tenant $tenant): array
} }
} }
if ($run->type === 'tenant.evidence.snapshot.generate') { if ($canonicalType === 'tenant.evidence.snapshot.generate') {
$snapshot = EvidenceSnapshot::query() $snapshot = EvidenceSnapshot::query()
->where('operation_run_id', (int) $run->getKey()) ->where('operation_run_id', (int) $run->getKey())
->latest('id') ->latest('id')
@ -213,7 +214,7 @@ public static function related(OperationRun $run, ?Tenant $tenant): array
} }
} }
if ($run->type === 'tenant.review.compose') { if ($canonicalType === 'tenant.review.compose') {
$review = TenantReview::query() $review = TenantReview::query()
->where('operation_run_id', (int) $run->getKey()) ->where('operation_run_id', (int) $run->getKey())
->latest('id') ->latest('id')
@ -224,7 +225,7 @@ public static function related(OperationRun $run, ?Tenant $tenant): array
} }
} }
if ($run->type === 'tenant.review_pack.generate') { if ($canonicalType === 'tenant.review_pack.generate') {
$pack = ReviewPack::query() $pack = ReviewPack::query()
->where('operation_run_id', (int) $run->getKey()) ->where('operation_run_id', (int) $run->getKey())
->latest('id') ->latest('id')

View File

@ -4,17 +4,16 @@
enum OperationRunType: string enum OperationRunType: string
{ {
case BaselineCapture = 'baseline_capture'; case BaselineCapture = 'baseline.capture';
case BaselineCompare = 'baseline_compare'; case BaselineCompare = 'baseline.compare';
case InventorySync = 'inventory_sync'; case InventorySync = 'inventory.sync';
case PolicySync = 'policy.sync'; case PolicySync = 'policy.sync';
case PolicySyncOne = 'policy.sync_one'; case DirectoryGroupsSync = 'directory.groups.sync';
case DirectoryGroupsSync = 'entra_group_sync';
case BackupSetUpdate = 'backup_set.update'; case BackupSetUpdate = 'backup_set.update';
case BackupScheduleExecute = 'backup_schedule_run'; case BackupScheduleExecute = 'backup.schedule.execute';
case BackupScheduleRetention = 'backup_schedule_retention'; case BackupScheduleRetention = 'backup.schedule.retention';
case BackupSchedulePurge = 'backup_schedule_purge'; case BackupSchedulePurge = 'backup.schedule.purge';
case DirectoryRoleDefinitionsSync = 'directory_role_definitions.sync'; case DirectoryRoleDefinitionsSync = 'directory.role_definitions.sync';
case RestoreExecute = 'restore.execute'; case RestoreExecute = 'restore.execute';
case EntraAdminRolesScan = 'entra.admin_roles.scan'; case EntraAdminRolesScan = 'entra.admin_roles.scan';
case ReviewPackGenerate = 'tenant.review_pack.generate'; case ReviewPackGenerate = 'tenant.review_pack.generate';
@ -29,24 +28,6 @@ public static function values(): array
public function canonicalCode(): string public function canonicalCode(): string
{ {
return match ($this) { return $this->value;
self::BaselineCapture => 'baseline.capture',
self::BaselineCompare => 'baseline.compare',
self::InventorySync => 'inventory.sync',
self::PolicySync, self::PolicySyncOne => 'policy.sync',
self::DirectoryGroupsSync => 'directory.groups.sync',
self::BackupSetUpdate => 'backup_set.update',
self::BackupScheduleExecute => 'backup.schedule.execute',
self::BackupScheduleRetention => 'backup.schedule.retention',
self::BackupSchedulePurge => 'backup.schedule.purge',
self::DirectoryRoleDefinitionsSync => 'directory.role_definitions.sync',
self::RestoreExecute => 'restore.execute',
self::EntraAdminRolesScan => 'entra.admin_roles.scan',
self::ReviewPackGenerate => 'tenant.review_pack.generate',
self::TenantReviewCompose => 'tenant.review.compose',
self::EvidenceSnapshotGenerate => 'tenant.evidence.snapshot.generate',
self::RbacHealthCheck => 'rbac.health_check',
default => $this->value,
};
} }
} }

View File

@ -4,6 +4,7 @@
namespace App\Support\Operations; namespace App\Support\Operations;
use App\Support\OperationCatalog;
use Illuminate\Support\Arr; use Illuminate\Support\Arr;
final class OperationLifecyclePolicy final class OperationLifecyclePolicy
@ -43,7 +44,8 @@ public function definition(string $operationType): ?array
return null; return null;
} }
$definition = $this->coveredTypes()[$operationType] ?? null; $canonicalType = OperationCatalog::canonicalCode($operationType);
$definition = $this->coveredTypes()[$canonicalType] ?? null;
if (! is_array($definition)) { if (! is_array($definition)) {
return null; return null;

View File

@ -4,6 +4,7 @@
use App\Models\OperationRun; use App\Models\OperationRun;
use App\Support\Auth\Capabilities; use App\Support\Auth\Capabilities;
use App\Support\OperationCatalog;
final class OperationRunCapabilityResolver final class OperationRunCapabilityResolver
{ {
@ -14,18 +15,18 @@ public function requiredCapabilityForRun(OperationRun $run): ?string
public function requiredCapabilityForType(string $operationType): ?string public function requiredCapabilityForType(string $operationType): ?string
{ {
$operationType = trim($operationType); $operationType = OperationCatalog::canonicalCode($operationType);
if ($operationType === '') { if ($operationType === '') {
return null; return null;
} }
return match ($operationType) { return match ($operationType) {
'inventory_sync' => Capabilities::TENANT_INVENTORY_SYNC_RUN, 'inventory.sync' => Capabilities::TENANT_INVENTORY_SYNC_RUN,
'entra_group_sync' => Capabilities::TENANT_SYNC, 'directory.groups.sync' => Capabilities::TENANT_SYNC,
'backup_schedule_run', 'backup_schedule_retention', 'backup_schedule_purge' => Capabilities::TENANT_BACKUP_SCHEDULES_RUN, 'backup.schedule.execute', 'backup.schedule.retention', 'backup.schedule.purge' => Capabilities::TENANT_BACKUP_SCHEDULES_RUN,
'restore.execute' => Capabilities::TENANT_MANAGE, 'restore.execute' => Capabilities::TENANT_MANAGE,
'directory_role_definitions.sync' => Capabilities::TENANT_MANAGE, 'directory.role_definitions.sync' => Capabilities::TENANT_MANAGE,
'alerts.evaluate', 'alerts.deliver' => Capabilities::ALERTS_VIEW, 'alerts.evaluate', 'alerts.deliver' => Capabilities::ALERTS_VIEW,
'tenant.review.compose' => Capabilities::TENANT_REVIEW_VIEW, 'tenant.review.compose' => Capabilities::TENANT_REVIEW_VIEW,
@ -40,15 +41,15 @@ public function requiredCapabilityForType(string $operationType): ?string
public function requiredExecutionCapabilityForType(string $operationType): ?string public function requiredExecutionCapabilityForType(string $operationType): ?string
{ {
$operationType = trim($operationType); $operationType = OperationCatalog::canonicalCode($operationType);
if ($operationType === '') { if ($operationType === '') {
return null; return null;
} }
return match ($operationType) { return match ($operationType) {
'provider.connection.check', 'provider.inventory.sync', 'provider.compliance.snapshot' => Capabilities::PROVIDER_RUN, 'provider.connection.check', 'inventory.sync', 'compliance.snapshot' => Capabilities::PROVIDER_RUN,
'policy.sync', 'policy.sync_one', 'tenant.sync' => Capabilities::TENANT_SYNC, 'policy.sync', 'tenant.sync' => Capabilities::TENANT_SYNC,
'policy.delete' => Capabilities::TENANT_MANAGE, 'policy.delete' => Capabilities::TENANT_MANAGE,
'assignments.restore', 'restore.execute' => Capabilities::TENANT_MANAGE, 'assignments.restore', 'restore.execute' => Capabilities::TENANT_MANAGE,
'tenant.review.compose' => Capabilities::TENANT_REVIEW_MANAGE, 'tenant.review.compose' => Capabilities::TENANT_REVIEW_MANAGE,

View File

@ -567,7 +567,7 @@ private static function terminalSupportingLines(OperationRun $run): array
private static function baselineTruthChangeLine(OperationRun $run): ?string private static function baselineTruthChangeLine(OperationRun $run): ?string
{ {
if ((string) $run->type !== 'baseline_capture') { if ($run->canonicalOperationType() !== 'baseline.capture') {
return null; return null;
} }

View File

@ -0,0 +1,194 @@
<?php
namespace App\Support\Providers\Boundary;
use InvalidArgumentException;
final class ProviderBoundaryCatalog
{
public const string STATUS_ALLOWED = 'allowed';
public const string STATUS_REVIEW_REQUIRED = 'review_required';
public const string STATUS_BLOCKED = 'blocked';
public const string VIOLATION_NONE = 'none';
public const string VIOLATION_PLATFORM_CORE_PROVIDER_LEAK = 'platform_core_provider_leak';
public const string VIOLATION_UNDECLARED_EXCEPTION = 'undeclared_exception';
public const string VIOLATION_MISSING_PROVIDER_BINDING = 'missing_provider_binding';
public const string VIOLATION_PROVIDER_BINDING_AS_PRIMARY_TRUTH = 'provider_binding_as_primary_truth';
/**
* @return array<string, ProviderBoundarySeam>
*/
public function all(): array
{
$seams = config('provider_boundaries.seams', []);
if (! is_array($seams)) {
throw new InvalidArgumentException('Provider boundary seam catalog must be an array.');
}
$catalog = [];
foreach ($seams as $key => $attributes) {
if (! is_string($key) || ! is_array($attributes)) {
throw new InvalidArgumentException('Provider boundary seam catalog entries must be keyed arrays.');
}
$catalog[$key] = ProviderBoundarySeam::fromConfig($key, $attributes);
}
ksort($catalog);
return $catalog;
}
public function get(string $key): ProviderBoundarySeam
{
$normalizedKey = trim($key);
$seam = $this->all()[$normalizedKey] ?? null;
if (! $seam instanceof ProviderBoundarySeam) {
throw new InvalidArgumentException("Unknown provider boundary seam: {$normalizedKey}");
}
return $seam;
}
public function has(string $key): bool
{
return array_key_exists(trim($key), $this->all());
}
/**
* @return array{
* status: string,
* seam_key: string,
* file_path: string,
* violation_code: string,
* message: string,
* suggested_follow_up: string
* }
*/
public function evaluateChange(
string $seamKey,
string $filePath,
ProviderBoundaryOwner|string $proposedOwner,
array $providerSpecificTerms = [],
bool $introducesNewBinding = false,
): array {
$seam = $this->get($seamKey);
$owner = is_string($proposedOwner)
? ProviderBoundaryOwner::tryFrom($proposedOwner)
: $proposedOwner;
if (! $owner instanceof ProviderBoundaryOwner) {
throw new InvalidArgumentException('Proposed provider boundary owner is invalid.');
}
$providerSpecificTerms = $this->normalizeTerms($providerSpecificTerms);
if ($introducesNewBinding && $seam->isPlatformCore() && $owner === ProviderBoundaryOwner::PlatformCore) {
return $this->result(
status: self::STATUS_BLOCKED,
seam: $seam,
filePath: $filePath,
violationCode: self::VIOLATION_PROVIDER_BINDING_AS_PRIMARY_TRUTH,
message: 'Provider binding metadata must stay explicit and secondary to the platform-core operation definition.',
suggestedFollowUp: ProviderBoundarySeam::FOLLOW_UP_DOCUMENT_IN_FEATURE,
);
}
if ($seam->isProviderOwned()) {
return $this->result(
status: self::STATUS_ALLOWED,
seam: $seam,
filePath: $filePath,
violationCode: self::VIOLATION_NONE,
message: 'Provider-specific semantics are allowed inside this provider-owned seam.',
suggestedFollowUp: ProviderBoundarySeam::FOLLOW_UP_NONE,
);
}
if ($providerSpecificTerms === []) {
return $this->result(
status: self::STATUS_ALLOWED,
seam: $seam,
filePath: $filePath,
violationCode: self::VIOLATION_NONE,
message: 'The platform-core seam does not introduce provider-specific terms.',
suggestedFollowUp: ProviderBoundarySeam::FOLLOW_UP_NONE,
);
}
$undocumentedTerms = array_values(array_filter(
$providerSpecificTerms,
static fn (string $term): bool => ! $seam->documentsProviderSemantic($term),
));
if ($undocumentedTerms !== []) {
return $this->result(
status: self::STATUS_BLOCKED,
seam: $seam,
filePath: $filePath,
violationCode: self::VIOLATION_PLATFORM_CORE_PROVIDER_LEAK,
message: 'Platform-core seam contains undocumented provider-specific terms: '.implode(', ', $undocumentedTerms).'.',
suggestedFollowUp: ProviderBoundarySeam::FOLLOW_UP_SPEC,
);
}
return $this->result(
status: self::STATUS_REVIEW_REQUIRED,
seam: $seam,
filePath: $filePath,
violationCode: self::VIOLATION_NONE,
message: 'Platform-core seam relies on documented current-release provider exception metadata.',
suggestedFollowUp: $seam->followUpAction,
);
}
/**
* @param array<mixed> $terms
* @return list<string>
*/
private function normalizeTerms(array $terms): array
{
return array_values(array_filter(
array_map(static fn (mixed $term): string => trim((string) $term), $terms),
static fn (string $term): bool => $term !== '',
));
}
/**
* @return array{
* status: string,
* seam_key: string,
* file_path: string,
* violation_code: string,
* message: string,
* suggested_follow_up: string
* }
*/
private function result(
string $status,
ProviderBoundarySeam $seam,
string $filePath,
string $violationCode,
string $message,
string $suggestedFollowUp,
): array {
return [
'status' => $status,
'seam_key' => $seam->key,
'file_path' => $filePath,
'violation_code' => $violationCode,
'message' => $message,
'suggested_follow_up' => $suggestedFollowUp,
];
}
}

View File

@ -0,0 +1,17 @@
<?php
namespace App\Support\Providers\Boundary;
enum ProviderBoundaryOwner: string
{
case ProviderOwned = 'provider_owned';
case PlatformCore = 'platform_core';
/**
* @return list<string>
*/
public static function values(): array
{
return array_map(static fn (self $case): string => $case->value, self::cases());
}
}

View File

@ -0,0 +1,149 @@
<?php
namespace App\Support\Providers\Boundary;
use InvalidArgumentException;
final class ProviderBoundarySeam
{
public const string FOLLOW_UP_NONE = 'none';
public const string FOLLOW_UP_DOCUMENT_IN_FEATURE = 'document-in-feature';
public const string FOLLOW_UP_SPEC = 'follow-up-spec';
/**
* @param list<string> $implementationPaths
* @param list<string> $neutralTerms
* @param list<string> $retainedProviderSemantics
*/
public function __construct(
public readonly string $key,
public readonly ProviderBoundaryOwner $owner,
public readonly string $description,
public readonly array $implementationPaths,
public readonly array $neutralTerms,
public readonly array $retainedProviderSemantics,
public readonly string $followUpAction,
) {
$this->validate();
}
/**
* @param array{
* owner?: string,
* description?: string,
* implementation_paths?: list<string>,
* neutral_terms?: list<string>,
* retained_provider_semantics?: list<string>,
* follow_up_action?: string
* } $attributes
*/
public static function fromConfig(string $key, array $attributes): self
{
$owner = ProviderBoundaryOwner::tryFrom((string) ($attributes['owner'] ?? ''));
if (! $owner instanceof ProviderBoundaryOwner) {
throw new InvalidArgumentException("Provider boundary seam [{$key}] has an invalid owner.");
}
return new self(
key: $key,
owner: $owner,
description: (string) ($attributes['description'] ?? ''),
implementationPaths: self::stringList($attributes['implementation_paths'] ?? []),
neutralTerms: self::stringList($attributes['neutral_terms'] ?? []),
retainedProviderSemantics: self::stringList($attributes['retained_provider_semantics'] ?? []),
followUpAction: (string) ($attributes['follow_up_action'] ?? self::FOLLOW_UP_NONE),
);
}
public function isProviderOwned(): bool
{
return $this->owner === ProviderBoundaryOwner::ProviderOwned;
}
public function isPlatformCore(): bool
{
return $this->owner === ProviderBoundaryOwner::PlatformCore;
}
public function retainsProviderSemantics(): bool
{
return $this->retainedProviderSemantics !== [];
}
public function documentsProviderSemantic(string $term): bool
{
return in_array($term, $this->retainedProviderSemantics, true);
}
public function coversPath(string $path): bool
{
$normalizedPath = $this->normalizePath($path);
foreach ($this->implementationPaths as $implementationPath) {
if ($normalizedPath === $this->normalizePath($implementationPath)) {
return true;
}
}
return false;
}
/**
* @param array<mixed> $values
* @return list<string>
*/
private static function stringList(array $values): array
{
return array_values(array_filter(
array_map(static fn (mixed $value): string => trim((string) $value), $values),
static fn (string $value): bool => $value !== '',
));
}
private function validate(): void
{
if (trim($this->key) === '') {
throw new InvalidArgumentException('Provider boundary seam key cannot be empty.');
}
if (trim($this->description) === '') {
throw new InvalidArgumentException("Provider boundary seam [{$this->key}] must include a description.");
}
if ($this->implementationPaths === []) {
throw new InvalidArgumentException("Provider boundary seam [{$this->key}] must include implementation paths.");
}
if ($this->isPlatformCore() && $this->neutralTerms === []) {
throw new InvalidArgumentException("Platform-core provider boundary seam [{$this->key}] must include neutral terms.");
}
if ($this->retainsProviderSemantics() && $this->followUpAction === self::FOLLOW_UP_NONE) {
throw new InvalidArgumentException("Provider boundary seam [{$this->key}] retains provider semantics without a follow-up action.");
}
if (! in_array($this->followUpAction, $this->validFollowUpActions(), true)) {
throw new InvalidArgumentException("Provider boundary seam [{$this->key}] has an invalid follow-up action.");
}
}
/**
* @return list<string>
*/
private function validFollowUpActions(): array
{
return [
self::FOLLOW_UP_NONE,
self::FOLLOW_UP_DOCUMENT_IN_FEATURE,
self::FOLLOW_UP_SPEC,
];
}
private function normalizePath(string $path): string
{
return trim(str_replace('\\', '/', $path), '/');
}
}

View File

@ -34,6 +34,8 @@ final class ProviderReasonCodes
public const string ProviderConnectionReviewRequired = 'provider_connection_review_required'; public const string ProviderConnectionReviewRequired = 'provider_connection_review_required';
public const string ProviderBindingUnsupported = 'provider_binding_unsupported';
public const string ProviderAuthFailed = 'provider_auth_failed'; public const string ProviderAuthFailed = 'provider_auth_failed';
public const string ProviderPermissionMissing = 'provider_permission_missing'; public const string ProviderPermissionMissing = 'provider_permission_missing';
@ -77,6 +79,7 @@ public static function all(): array
self::ProviderConsentFailed, self::ProviderConsentFailed,
self::ProviderConsentRevoked, self::ProviderConsentRevoked,
self::ProviderConnectionReviewRequired, self::ProviderConnectionReviewRequired,
self::ProviderBindingUnsupported,
self::ProviderAuthFailed, self::ProviderAuthFailed,
self::ProviderPermissionMissing, self::ProviderPermissionMissing,
self::ProviderPermissionDenied, self::ProviderPermissionDenied,
@ -139,6 +142,7 @@ public static function platformReasonFamily(string $reasonCode): PlatformReasonF
self::ProviderAuthFailed => PlatformReasonFamily::Availability, self::ProviderAuthFailed => PlatformReasonFamily::Availability,
self::ProviderConnectionTypeInvalid, self::ProviderConnectionTypeInvalid,
self::TenantTargetMismatch, self::TenantTargetMismatch,
self::ProviderBindingUnsupported,
self::ProviderConnectionReviewRequired => PlatformReasonFamily::Compatibility, self::ProviderConnectionReviewRequired => PlatformReasonFamily::Compatibility,
default => PlatformReasonFamily::Prerequisite, default => PlatformReasonFamily::Prerequisite,
}; };

View File

@ -141,6 +141,13 @@ public function translate(string $reasonCode, string $surface = 'detail', array
actionability: 'prerequisite_missing', actionability: 'prerequisite_missing',
nextSteps: $nextSteps, nextSteps: $nextSteps,
), ),
ProviderReasonCodes::ProviderBindingUnsupported => $this->envelope(
reasonCode: $normalizedCode,
operatorLabel: 'Provider binding unsupported',
shortExplanation: 'This operation does not have an explicit provider binding for the selected provider.',
actionability: 'permanent_configuration',
nextSteps: $nextSteps,
),
ProviderReasonCodes::ProviderAuthFailed => $this->envelope( ProviderReasonCodes::ProviderAuthFailed => $this->envelope(
reasonCode: $normalizedCode, reasonCode: $normalizedCode,
operatorLabel: 'Provider authentication failed', operatorLabel: 'Provider authentication failed',
@ -284,7 +291,8 @@ private function nextStepsFor(
ProviderReasonCodes::TenantTargetMismatch, ProviderReasonCodes::TenantTargetMismatch,
ProviderReasonCodes::PlatformIdentityMissing, ProviderReasonCodes::PlatformIdentityMissing,
ProviderReasonCodes::PlatformIdentityIncomplete, ProviderReasonCodes::PlatformIdentityIncomplete,
ProviderReasonCodes::ProviderConnectionReviewRequired => [ ProviderReasonCodes::ProviderConnectionReviewRequired,
ProviderReasonCodes::ProviderBindingUnsupported => [
NextStepOption::link( NextStepOption::link(
label: $connection instanceof ProviderConnection ? 'Review migration classification' : 'Manage Provider Connections', label: $connection instanceof ProviderConnection ? 'Review migration classification' : 'Manage Provider Connections',
destination: $connection instanceof ProviderConnection destination: $connection instanceof ProviderConnection

View File

@ -0,0 +1,119 @@
<?php
namespace App\Support\Providers\TargetScope;
use App\Models\ProviderConnection;
use App\Support\Badges\BadgeDomain;
use App\Support\Badges\BadgeRenderer;
use App\Support\Providers\ProviderConsentStatus;
use App\Support\Providers\ProviderVerificationStatus;
final class ProviderConnectionSurfaceSummary
{
/**
* @param list<ProviderIdentityContextMetadata> $contextualIdentityDetails
*/
public function __construct(
public readonly string $provider,
public readonly ProviderConnectionTargetScopeDescriptor $targetScope,
public readonly string $consentState,
public readonly string $verificationState,
public readonly string $readinessSummary,
public readonly array $contextualIdentityDetails = [],
) {}
public static function forConnection(ProviderConnection $connection): self
{
/** @var ProviderConnectionTargetScopeNormalizer $normalizer */
$normalizer = app(ProviderConnectionTargetScopeNormalizer::class);
$targetScope = $normalizer->descriptorForConnection($connection);
$consentState = self::stateValue($connection->consent_status);
$verificationState = self::stateValue($connection->verification_status);
return new self(
provider: trim((string) $connection->provider),
targetScope: $targetScope,
consentState: $consentState,
verificationState: $verificationState,
readinessSummary: self::readinessSummary(
isEnabled: (bool) $connection->is_enabled,
consentState: $consentState,
verificationState: $verificationState,
),
contextualIdentityDetails: $normalizer->contextualIdentityDetailsForConnection($connection),
);
}
public function targetScopeSummary(): string
{
return $this->targetScope->summary();
}
public function contextualIdentityLine(): ?string
{
if ($this->contextualIdentityDetails === []) {
return null;
}
return collect($this->contextualIdentityDetails)
->map(fn (ProviderIdentityContextMetadata $detail): string => sprintf('%s: %s', $detail->detailLabel, $detail->detailValue))
->implode("\n");
}
/**
* @return array{
* provider: string,
* target_scope: array<string, string>,
* consent_state: string,
* verification_state: string,
* readiness_summary: string,
* contextual_identity_details: list<array<string, string>>
* }
*/
public function toArray(): array
{
return [
'provider' => $this->provider,
'target_scope' => $this->targetScope->toArray(),
'consent_state' => $this->consentState,
'verification_state' => $this->verificationState,
'readiness_summary' => $this->readinessSummary,
'contextual_identity_details' => array_map(
static fn (ProviderIdentityContextMetadata $detail): array => $detail->toArray(),
$this->contextualIdentityDetails,
),
];
}
private static function stateValue(mixed $state): string
{
if ($state instanceof ProviderConsentStatus || $state instanceof ProviderVerificationStatus) {
return $state->value;
}
return trim((string) $state);
}
private static function readinessSummary(bool $isEnabled, string $consentState, string $verificationState): string
{
if (! $isEnabled) {
return 'Disabled';
}
if ($consentState !== ProviderConsentStatus::Granted->value) {
return sprintf(
'Consent %s',
strtolower(BadgeRenderer::spec(BadgeDomain::ProviderConsentStatus, $consentState)->label),
);
}
return match ($verificationState) {
ProviderVerificationStatus::Healthy->value => 'Ready',
ProviderVerificationStatus::Degraded->value => 'Ready with warnings',
ProviderVerificationStatus::Blocked->value => 'Verification blocked',
ProviderVerificationStatus::Error->value => 'Verification failed',
ProviderVerificationStatus::Pending->value => 'Verification pending',
default => 'Verification not run',
};
}
}

View File

@ -0,0 +1,103 @@
<?php
namespace App\Support\Providers\TargetScope;
use App\Models\ProviderConnection;
use InvalidArgumentException;
final class ProviderConnectionTargetScopeDescriptor
{
public const string SCOPE_KIND_TENANT = 'tenant';
public function __construct(
public readonly string $provider,
public readonly string $scopeKind,
public readonly string $scopeIdentifier,
public readonly string $scopeDisplayName,
public readonly string $sharedLabel = 'Target scope',
public readonly string $sharedHelpText = 'The platform scope this provider connection represents.',
) {
$this->validate();
}
public static function fromConnection(ProviderConnection $connection): self
{
$tenantName = is_string($connection->tenant?->name) && trim($connection->tenant->name) !== ''
? trim($connection->tenant->name)
: trim((string) $connection->display_name);
return new self(
provider: trim((string) $connection->provider),
scopeKind: self::SCOPE_KIND_TENANT,
scopeIdentifier: trim((string) $connection->entra_tenant_id),
scopeDisplayName: $tenantName !== '' ? $tenantName : trim((string) $connection->entra_tenant_id),
);
}
public static function fromInput(
string $provider,
string $scopeKind,
string $scopeIdentifier,
?string $scopeDisplayName = null,
): self {
$scopeIdentifier = trim($scopeIdentifier);
$displayName = trim((string) $scopeDisplayName);
return new self(
provider: trim($provider),
scopeKind: trim($scopeKind),
scopeIdentifier: $scopeIdentifier,
scopeDisplayName: $displayName !== '' ? $displayName : $scopeIdentifier,
);
}
public function summary(): string
{
if ($this->scopeDisplayName !== '' && $this->scopeDisplayName !== $this->scopeIdentifier) {
return sprintf('%s (%s)', $this->scopeDisplayName, $this->scopeIdentifier);
}
return $this->scopeIdentifier;
}
/**
* @return array{
* provider: string,
* scope_kind: string,
* scope_identifier: string,
* scope_display_name: string,
* shared_label: string,
* shared_help_text: string
* }
*/
public function toArray(): array
{
return [
'provider' => $this->provider,
'scope_kind' => $this->scopeKind,
'scope_identifier' => $this->scopeIdentifier,
'scope_display_name' => $this->scopeDisplayName,
'shared_label' => $this->sharedLabel,
'shared_help_text' => $this->sharedHelpText,
];
}
private function validate(): void
{
if ($this->provider === '') {
throw new InvalidArgumentException('Provider is required for target-scope descriptors.');
}
if ($this->scopeKind !== self::SCOPE_KIND_TENANT) {
throw new InvalidArgumentException('Unsupported provider connection target-scope kind.');
}
if ($this->scopeIdentifier === '') {
throw new InvalidArgumentException('Target scope identifier is required.');
}
if ($this->scopeDisplayName === '') {
throw new InvalidArgumentException('Target scope display name is required.');
}
}
}

View File

@ -0,0 +1,207 @@
<?php
namespace App\Support\Providers\TargetScope;
use App\Models\ProviderConnection;
use InvalidArgumentException;
final class ProviderConnectionTargetScopeNormalizer
{
public const string STATUS_NORMALIZED = 'normalized';
public const string STATUS_BLOCKED = 'blocked';
public const string FAILURE_NONE = 'none';
public const string FAILURE_UNSUPPORTED_PROVIDER_SCOPE_COMBINATION = 'unsupported_provider_scope_combination';
public const string FAILURE_MISSING_PROVIDER_CONTEXT = 'missing_provider_context';
/**
* @param array<string, string> $providerSpecificIdentity
* @return array{
* status: string,
* provider: string,
* scope_kind: string,
* target_scope?: ProviderConnectionTargetScopeDescriptor,
* contextual_identity_details?: list<ProviderIdentityContextMetadata>,
* preview_summary?: ?ProviderConnectionSurfaceSummary,
* failure_code: string,
* message: string
* }
*/
public function normalizeInput(
string $provider,
string $scopeKind,
string $scopeIdentifier,
?string $scopeDisplayName = null,
array $providerSpecificIdentity = [],
): array {
$provider = trim($provider);
$scopeKind = trim($scopeKind);
$scopeIdentifier = trim($scopeIdentifier);
if ($provider !== 'microsoft' || $scopeKind !== ProviderConnectionTargetScopeDescriptor::SCOPE_KIND_TENANT) {
return $this->blocked(
provider: $provider,
scopeKind: $scopeKind,
failureCode: self::FAILURE_UNSUPPORTED_PROVIDER_SCOPE_COMBINATION,
message: 'This provider and target-scope combination is not supported.',
);
}
if ($scopeIdentifier === '') {
return $this->blocked(
provider: $provider,
scopeKind: $scopeKind,
failureCode: self::FAILURE_MISSING_PROVIDER_CONTEXT,
message: 'A target scope identifier is required for this provider connection.',
);
}
$descriptor = ProviderConnectionTargetScopeDescriptor::fromInput(
provider: $provider,
scopeKind: $scopeKind,
scopeIdentifier: $scopeIdentifier,
scopeDisplayName: $scopeDisplayName,
);
return [
'status' => self::STATUS_NORMALIZED,
'provider' => $provider,
'scope_kind' => $scopeKind,
'target_scope' => $descriptor,
'contextual_identity_details' => $this->contextualIdentityDetails(
provider: $provider,
scopeIdentifier: $scopeIdentifier,
providerSpecificIdentity: $providerSpecificIdentity,
),
'preview_summary' => null,
'failure_code' => self::FAILURE_NONE,
'message' => 'Target scope normalized.',
];
}
/**
* @return array{
* status: string,
* provider: string,
* scope_kind: string,
* target_scope?: ProviderConnectionTargetScopeDescriptor,
* contextual_identity_details?: list<ProviderIdentityContextMetadata>,
* preview_summary?: ?ProviderConnectionSurfaceSummary,
* failure_code: string,
* message: string
* }
*/
public function normalizeConnection(ProviderConnection $connection): array
{
return $this->normalizeInput(
provider: trim((string) $connection->provider),
scopeKind: ProviderConnectionTargetScopeDescriptor::SCOPE_KIND_TENANT,
scopeIdentifier: trim((string) $connection->entra_tenant_id),
scopeDisplayName: $connection->tenant?->name ?? $connection->display_name,
providerSpecificIdentity: [
'microsoft_tenant_id' => trim((string) $connection->entra_tenant_id),
],
);
}
public function descriptorForConnection(ProviderConnection $connection): ProviderConnectionTargetScopeDescriptor
{
$result = $this->normalizeConnection($connection);
$descriptor = $result['target_scope'] ?? null;
if (! $descriptor instanceof ProviderConnectionTargetScopeDescriptor) {
throw new InvalidArgumentException($result['message']);
}
return $descriptor;
}
/**
* @return list<ProviderIdentityContextMetadata>
*/
public function contextualIdentityDetailsForConnection(ProviderConnection $connection): array
{
return $this->contextualIdentityDetails(
provider: trim((string) $connection->provider),
scopeIdentifier: trim((string) $connection->entra_tenant_id),
providerSpecificIdentity: [
'microsoft_tenant_id' => trim((string) $connection->entra_tenant_id),
],
);
}
/**
* @return array<string, mixed>
*/
public function auditMetadataForConnection(ProviderConnection $connection, array $extra = []): array
{
$summary = ProviderConnectionSurfaceSummary::forConnection($connection);
return array_merge([
'provider_connection_id' => (int) $connection->getKey(),
'provider' => (string) $connection->provider,
'target_scope' => $summary->targetScope->toArray(),
'provider_identity_context' => array_map(
static fn (ProviderIdentityContextMetadata $detail): array => $detail->toArray(),
$summary->contextualIdentityDetails,
),
], $extra);
}
/**
* @param list<string> $fields
* @return list<string>
*/
public function auditFieldNames(array $fields): array
{
return array_values(array_map(
static fn (string $field): string => $field === 'entra_tenant_id' ? 'target_scope_identifier' : $field,
$fields,
));
}
/**
* @param array<string, string> $providerSpecificIdentity
* @return list<ProviderIdentityContextMetadata>
*/
private function contextualIdentityDetails(string $provider, string $scopeIdentifier, array $providerSpecificIdentity = []): array
{
if ($provider !== 'microsoft') {
return [];
}
$details = [
ProviderIdentityContextMetadata::microsoftTenantId(
$providerSpecificIdentity['microsoft_tenant_id'] ?? $scopeIdentifier,
),
];
return array_values(array_filter(
$details,
static fn (?ProviderIdentityContextMetadata $detail): bool => $detail instanceof ProviderIdentityContextMetadata,
));
}
/**
* @return array{
* status: string,
* provider: string,
* scope_kind: string,
* failure_code: string,
* message: string
* }
*/
private function blocked(string $provider, string $scopeKind, string $failureCode, string $message): array
{
return [
'status' => self::STATUS_BLOCKED,
'provider' => $provider,
'scope_kind' => $scopeKind,
'failure_code' => $failureCode,
'message' => $message,
];
}
}

View File

@ -0,0 +1,91 @@
<?php
namespace App\Support\Providers\TargetScope;
final class ProviderIdentityContextMetadata
{
public const string VISIBILITY_CONTEXTUAL_ONLY = 'contextual_only';
public const string VISIBILITY_AUDIT_ONLY = 'audit_only';
public const string VISIBILITY_TROUBLESHOOTING_ONLY = 'troubleshooting_only';
public function __construct(
public readonly string $provider,
public readonly string $detailKey,
public readonly string $detailLabel,
public readonly string $detailValue,
public readonly string $visibility = self::VISIBILITY_CONTEXTUAL_ONLY,
) {}
public static function microsoftTenantId(?string $value, string $visibility = self::VISIBILITY_CONTEXTUAL_ONLY): ?self
{
$value = trim((string) $value);
if ($value === '') {
return null;
}
return new self(
provider: 'microsoft',
detailKey: 'microsoft_tenant_id',
detailLabel: 'Microsoft tenant ID',
detailValue: $value,
visibility: $visibility,
);
}
public static function authorityTenant(?string $value, string $visibility = self::VISIBILITY_TROUBLESHOOTING_ONLY): ?self
{
$value = trim((string) $value);
if ($value === '') {
return null;
}
return new self(
provider: 'microsoft',
detailKey: 'authority_tenant',
detailLabel: 'Authority tenant',
detailValue: $value,
visibility: $visibility,
);
}
public static function redirectUri(?string $value, string $visibility = self::VISIBILITY_TROUBLESHOOTING_ONLY): ?self
{
$value = trim((string) $value);
if ($value === '') {
return null;
}
return new self(
provider: 'microsoft',
detailKey: 'redirect_uri',
detailLabel: 'Redirect URI',
detailValue: $value,
visibility: $visibility,
);
}
/**
* @return array{
* provider: string,
* detail_key: string,
* detail_label: string,
* detail_value: string,
* visibility: string
* }
*/
public function toArray(): array
{
return [
'provider' => $this->provider,
'detail_key' => $this->detailKey,
'detail_label' => $this->detailLabel,
'detail_value' => $this->detailValue,
'visibility' => $this->visibility,
];
}
}

View File

@ -0,0 +1,115 @@
<?php
use App\Support\Providers\Boundary\ProviderBoundaryOwner;
use App\Support\Providers\Boundary\ProviderBoundarySeam;
return [
'seams' => [
'provider.gateway_runtime' => [
'owner' => ProviderBoundaryOwner::ProviderOwned->value,
'description' => 'Provider-owned runtime boundary that translates provider connection identity into Microsoft Graph request options and executes Graph calls.',
'implementation_paths' => [
'app/Services/Providers/ProviderGateway.php',
'app/Services/Providers/MicrosoftGraphOptionsResolver.php',
],
'neutral_terms' => [
'provider',
'provider connection',
'target scope',
'runtime request context',
],
'retained_provider_semantics' => [
'Microsoft Graph option keys',
'client_request_id',
'tenant',
'client_id',
'client_secret',
],
'follow_up_action' => ProviderBoundarySeam::FOLLOW_UP_DOCUMENT_IN_FEATURE,
],
'provider.identity_resolution' => [
'owner' => ProviderBoundaryOwner::PlatformCore->value,
'description' => 'Platform-core identity resolution contract that resolves provider connection identity without owning provider transport option shaping.',
'implementation_paths' => [
'app/Services/Providers/ProviderIdentityResolution.php',
'app/Services/Providers/ProviderIdentityResolver.php',
'app/Services/Providers/PlatformProviderIdentityResolver.php',
],
'neutral_terms' => [
'provider connection',
'target scope',
'credential source',
'effective client identity',
],
'retained_provider_semantics' => [
'entra_tenant_id',
'platform_config',
'graph.tenant_id',
'admin.consent.callback',
],
'follow_up_action' => ProviderBoundarySeam::FOLLOW_UP_SPEC,
],
'provider.connection_resolution' => [
'owner' => ProviderBoundaryOwner::PlatformCore->value,
'description' => 'Platform-core provider connection selection and validation path that keeps current Microsoft connection details as bounded exception metadata.',
'implementation_paths' => [
'app/Services/Providers/ProviderConnectionResolver.php',
'app/Services/Providers/ProviderConnectionResolution.php',
],
'neutral_terms' => [
'provider',
'provider connection',
'tenant scope',
'default binding',
'unsupported combination',
],
'retained_provider_semantics' => [
'microsoft',
'entra_tenant_id',
'consent_status',
],
'follow_up_action' => ProviderBoundarySeam::FOLLOW_UP_SPEC,
],
'provider.operation_registry' => [
'owner' => ProviderBoundaryOwner::PlatformCore->value,
'description' => 'Platform-core operation definition catalog with provider binding metadata kept explicit and secondary.',
'implementation_paths' => [
'app/Services/Providers/ProviderOperationRegistry.php',
],
'neutral_terms' => [
'operation type',
'operation module',
'required capability',
'provider binding',
'unsupported binding',
],
'retained_provider_semantics' => [
'microsoft',
'active provider binding',
'binding_status',
'handler_notes',
'exception_notes',
],
'follow_up_action' => ProviderBoundarySeam::FOLLOW_UP_DOCUMENT_IN_FEATURE,
],
'provider.operation_start_gate' => [
'owner' => ProviderBoundaryOwner::PlatformCore->value,
'description' => 'Platform-core operation start orchestration that consumes explicit provider bindings and records current Microsoft target-scope exceptions.',
'implementation_paths' => [
'app/Services/Providers/ProviderOperationStartGate.php',
],
'neutral_terms' => [
'operation',
'provider binding',
'target scope',
'execution authority',
'required capability',
],
'retained_provider_semantics' => [
'microsoft',
'target_scope.entra_tenant_id',
],
'follow_up_action' => ProviderBoundarySeam::FOLLOW_UP_SPEC,
],
],
];

View File

@ -20,7 +20,7 @@
'schedule_minutes' => (int) env('TENANTPILOT_OPERATION_RUN_RECONCILIATION_SCHEDULE_MINUTES', 5), 'schedule_minutes' => (int) env('TENANTPILOT_OPERATION_RUN_RECONCILIATION_SCHEDULE_MINUTES', 5),
], ],
'covered_types' => [ 'covered_types' => [
'baseline_capture' => [ 'baseline.capture' => [
'job_class' => \App\Jobs\CaptureBaselineSnapshotJob::class, 'job_class' => \App\Jobs\CaptureBaselineSnapshotJob::class,
'queued_stale_after_seconds' => 600, 'queued_stale_after_seconds' => 600,
'running_stale_after_seconds' => 1800, 'running_stale_after_seconds' => 1800,
@ -28,7 +28,7 @@
'direct_failed_bridge' => true, 'direct_failed_bridge' => true,
'scheduled_reconciliation' => true, 'scheduled_reconciliation' => true,
], ],
'baseline_compare' => [ 'baseline.compare' => [
'job_class' => \App\Jobs\CompareBaselineToTenantJob::class, 'job_class' => \App\Jobs\CompareBaselineToTenantJob::class,
'queued_stale_after_seconds' => 600, 'queued_stale_after_seconds' => 600,
'running_stale_after_seconds' => 1800, 'running_stale_after_seconds' => 1800,
@ -36,7 +36,7 @@
'direct_failed_bridge' => true, 'direct_failed_bridge' => true,
'scheduled_reconciliation' => true, 'scheduled_reconciliation' => true,
], ],
'inventory_sync' => [ 'inventory.sync' => [
'job_class' => \App\Jobs\RunInventorySyncJob::class, 'job_class' => \App\Jobs\RunInventorySyncJob::class,
'queued_stale_after_seconds' => 300, 'queued_stale_after_seconds' => 300,
'running_stale_after_seconds' => 1200, 'running_stale_after_seconds' => 1200,
@ -52,15 +52,7 @@
'direct_failed_bridge' => true, 'direct_failed_bridge' => true,
'scheduled_reconciliation' => true, 'scheduled_reconciliation' => true,
], ],
'policy.sync_one' => [ 'directory.groups.sync' => [
'job_class' => \App\Jobs\SyncPoliciesJob::class,
'queued_stale_after_seconds' => 300,
'running_stale_after_seconds' => 900,
'expected_max_runtime_seconds' => 180,
'direct_failed_bridge' => true,
'scheduled_reconciliation' => true,
],
'entra_group_sync' => [
'job_class' => \App\Jobs\EntraGroupSyncJob::class, 'job_class' => \App\Jobs\EntraGroupSyncJob::class,
'queued_stale_after_seconds' => 300, 'queued_stale_after_seconds' => 300,
'running_stale_after_seconds' => 900, 'running_stale_after_seconds' => 900,
@ -68,7 +60,7 @@
'direct_failed_bridge' => false, 'direct_failed_bridge' => false,
'scheduled_reconciliation' => true, 'scheduled_reconciliation' => true,
], ],
'directory_role_definitions.sync' => [ 'directory.role_definitions.sync' => [
'job_class' => \App\Jobs\SyncRoleDefinitionsJob::class, 'job_class' => \App\Jobs\SyncRoleDefinitionsJob::class,
'queued_stale_after_seconds' => 300, 'queued_stale_after_seconds' => 300,
'running_stale_after_seconds' => 900, 'running_stale_after_seconds' => 900,
@ -84,7 +76,7 @@
'direct_failed_bridge' => false, 'direct_failed_bridge' => false,
'scheduled_reconciliation' => true, 'scheduled_reconciliation' => true,
], ],
'backup_schedule_run' => [ 'backup.schedule.execute' => [
'job_class' => \App\Jobs\RunBackupScheduleJob::class, 'job_class' => \App\Jobs\RunBackupScheduleJob::class,
'queued_stale_after_seconds' => 300, 'queued_stale_after_seconds' => 300,
'running_stale_after_seconds' => 1200, 'running_stale_after_seconds' => 1200,

View File

@ -4,6 +4,8 @@
use App\Support\Governance\PlatformVocabularyGlossary; use App\Support\Governance\PlatformVocabularyGlossary;
use App\Support\OperationCatalog; use App\Support\OperationCatalog;
use App\Support\OperationRunType;
use App\Services\Providers\ProviderOperationRegistry;
it('keeps touched registry ownership metadata inside the allowed three-way boundary classification', function (): void { it('keeps touched registry ownership metadata inside the allowed three-way boundary classification', function (): void {
$classifications = collect(app(PlatformVocabularyGlossary::class)->registries()) $classifications = collect(app(PlatformVocabularyGlossary::class)->registries())
@ -26,3 +28,30 @@
->and($glossary->resolveAlias('policy_type', 'compare')?->termKey)->toBe('governed_subject') ->and($glossary->resolveAlias('policy_type', 'compare')?->termKey)->toBe('governed_subject')
->and(OperationCatalog::canonicalCode('baseline_capture'))->toBe('baseline.capture'); ->and(OperationCatalog::canonicalCode('baseline_capture'))->toBe('baseline.capture');
}); });
it('guards canonical operation type writers against raw alias reintroduction', function (): void {
$legacyAliases = [
'baseline_capture',
'baseline_compare',
'inventory_sync',
'entra_group_sync',
'backup_schedule_run',
'backup_schedule_retention',
'backup_schedule_purge',
'directory_role_definitions.sync',
];
$registry = app(ProviderOperationRegistry::class);
$registryTypes = array_merge(
array_keys($registry->definitions()),
collect($registry->definitions())->pluck('operation_type')->all(),
array_keys($registry->providerBindings()),
collect($registry->providerBindings())
->flatMap(static fn (array $bindings): array => collect($bindings)->pluck('operation_type')->all())
->all(),
OperationRunType::values(),
array_keys(config('tenantpilot.operations.lifecycle.covered_types', [])),
);
expect(array_values(array_intersect($legacyAliases, $registryTypes)))->toBe([]);
});

View File

@ -2,10 +2,14 @@
declare(strict_types=1); declare(strict_types=1);
use App\Filament\Resources\ProviderConnectionResource\Pages\CreateProviderConnection;
use App\Models\AuditLog; use App\Models\AuditLog;
use App\Models\ProviderConnection;
use App\Models\Tenant; use App\Models\Tenant;
use App\Models\User; use App\Models\User;
use Filament\Facades\Filament;
use Illuminate\Foundation\Testing\RefreshDatabase; use Illuminate\Foundation\Testing\RefreshDatabase;
use Livewire\Livewire;
uses(RefreshDatabase::class); uses(RefreshDatabase::class);
@ -63,3 +67,55 @@
]); ]);
} }
}); });
it('records provider connection create audits with neutral target-scope metadata', function (): void {
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
$this->actingAs($user);
$tenant->makeCurrent();
Filament::setTenant($tenant, true);
Livewire::actingAs($user)
->test(CreateProviderConnection::class)
->fillForm([
'display_name' => 'Audit target scope connection',
'entra_tenant_id' => '88888888-8888-8888-8888-888888888888',
'is_default' => true,
])
->call('create')
->assertHasNoFormErrors();
$connection = ProviderConnection::query()
->where('tenant_id', (int) $tenant->getKey())
->where('display_name', 'Audit target scope connection')
->firstOrFail();
$log = AuditLog::query()
->where('tenant_id', (int) $tenant->getKey())
->where('action', 'provider_connection.created')
->where('resource_id', (string) $connection->getKey())
->firstOrFail();
$metadata = is_array($log->metadata) ? $log->metadata : [];
expect($metadata)->toHaveKeys([
'provider_connection_id',
'provider',
'target_scope',
'provider_identity_context',
'connection_type',
])
->and($metadata)->not->toHaveKey('entra_tenant_id')
->and($metadata['target_scope'])->toMatchArray([
'provider' => 'microsoft',
'scope_kind' => 'tenant',
'scope_identifier' => '88888888-8888-8888-8888-888888888888',
'shared_label' => 'Target scope',
])
->and($metadata['provider_identity_context'][0] ?? [])->toMatchArray([
'provider' => 'microsoft',
'detail_key' => 'microsoft_tenant_id',
'detail_label' => 'Microsoft tenant ID',
'detail_value' => '88888888-8888-8888-8888-888888888888',
]);
});

View File

@ -82,7 +82,7 @@
$retentionRun = OperationRun::query() $retentionRun = OperationRun::query()
->where('tenant_id', (int) $tenant->id) ->where('tenant_id', (int) $tenant->id)
->where('type', 'backup_schedule_retention') ->where('type', 'backup.schedule.retention')
->latest('id') ->latest('id')
->first(); ->first();

View File

@ -37,7 +37,7 @@
expect(OperationRun::query() expect(OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->count())->toBe(1); ->count())->toBe(1);
Bus::assertDispatchedTimes(RunBackupScheduleJob::class, 1); Bus::assertDispatchedTimes(RunBackupScheduleJob::class, 1);
@ -45,7 +45,7 @@
Bus::assertDispatched(RunBackupScheduleJob::class, function (RunBackupScheduleJob $job) use ($tenant): bool { Bus::assertDispatched(RunBackupScheduleJob::class, function (RunBackupScheduleJob $job) use ($tenant): bool {
return $job->backupScheduleId !== null return $job->backupScheduleId !== null
&& $job->operationRun?->tenant_id === $tenant->getKey() && $job->operationRun?->tenant_id === $tenant->getKey()
&& $job->operationRun?->type === 'backup_schedule_run'; && $job->operationRun?->type === 'backup.schedule.execute';
}); });
}); });
@ -74,7 +74,7 @@
$operationRunService->ensureRunWithIdentityStrict( $operationRunService->ensureRunWithIdentityStrict(
tenant: $tenant, tenant: $tenant,
type: 'backup_schedule_run', type: 'backup.schedule.execute',
identityInputs: [ identityInputs: [
'backup_schedule_id' => (int) $schedule->id, 'backup_schedule_id' => (int) $schedule->id,
'scheduled_for' => CarbonImmutable::now('UTC')->startOfMinute()->toDateTimeString(), 'scheduled_for' => CarbonImmutable::now('UTC')->startOfMinute()->toDateTimeString(),
@ -94,7 +94,7 @@
expect(OperationRun::query() expect(OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->count())->toBe(1); ->count())->toBe(1);
$schedule->refresh(); $schedule->refresh();
@ -133,7 +133,7 @@
->and($result['scanned_schedules'])->toBe(0) ->and($result['scanned_schedules'])->toBe(0)
->and(OperationRun::query() ->and(OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->count())->toBe(0); ->count())->toBe(0);
Bus::assertNotDispatched(RunBackupScheduleJob::class); Bus::assertNotDispatched(RunBackupScheduleJob::class);

View File

@ -48,7 +48,7 @@
$operationRun = OperationRun::query() $operationRun = OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->first(); ->first();
expect($operationRun)->not->toBeNull(); expect($operationRun)->not->toBeNull();
@ -96,7 +96,7 @@
$runs = OperationRun::query() $runs = OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->pluck('id') ->pluck('id')
->all(); ->all();
@ -133,7 +133,7 @@
$operationRun = OperationRun::query() $operationRun = OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->first(); ->first();
expect($operationRun)->not->toBeNull(); expect($operationRun)->not->toBeNull();
@ -180,7 +180,7 @@
$runs = OperationRun::query() $runs = OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->pluck('id') ->pluck('id')
->all(); ->all();
@ -226,7 +226,7 @@
expect(OperationRun::query() expect(OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->whereIn('type', ['backup_schedule_run', 'backup_schedule_run']) ->whereIn('type', ['backup.schedule.execute'])
->count()) ->count())
->toBe(0); ->toBe(0);
}); });
@ -270,13 +270,13 @@
expect(OperationRun::query() expect(OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->count()) ->count())
->toBe(2); ->toBe(2);
expect(OperationRun::query() expect(OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->pluck('user_id') ->pluck('user_id')
->unique() ->unique()
->values() ->values()
@ -326,13 +326,13 @@
expect(OperationRun::query() expect(OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->count()) ->count())
->toBe(2); ->toBe(2);
expect(OperationRun::query() expect(OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->pluck('user_id') ->pluck('user_id')
->unique() ->unique()
->values() ->values()
@ -382,7 +382,7 @@
$operationRunService = app(OperationRunService::class); $operationRunService = app(OperationRunService::class);
$existing = $operationRunService->ensureRunWithIdentity( $existing = $operationRunService->ensureRunWithIdentity(
tenant: $tenant, tenant: $tenant,
type: 'backup_schedule_run', type: 'backup.schedule.execute',
identityInputs: [ identityInputs: [
'backup_schedule_id' => (int) $scheduleA->getKey(), 'backup_schedule_id' => (int) $scheduleA->getKey(),
'nonce' => 'existing', 'nonce' => 'existing',
@ -403,7 +403,7 @@
expect(OperationRun::query() expect(OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'backup_schedule_run') ->where('type', 'backup.schedule.execute')
->count()) ->count())
->toBe(3); ->toBe(3);

View File

@ -129,12 +129,12 @@
expect(OperationRun::query()->where('tenant_id', $tenantA->id)->count())->toBe(1); expect(OperationRun::query()->where('tenant_id', $tenantA->id)->count())->toBe(1);
expect(OperationRun::query() expect(OperationRun::query()
->where('tenant_id', $tenantA->id) ->where('tenant_id', $tenantA->id)
->where('type', 'backup_schedule_purge') ->where('type', 'backup.schedule.purge')
->exists())->toBeTrue(); ->exists())->toBeTrue();
$purgeRun = OperationRun::query() $purgeRun = OperationRun::query()
->where('tenant_id', $tenantA->id) ->where('tenant_id', $tenantA->id)
->where('type', 'backup_schedule_purge') ->where('type', 'backup.schedule.purge')
->latest('id') ->latest('id')
->first(); ->first();

View File

@ -39,7 +39,7 @@
$run = OperationRun::query() $run = OperationRun::query()
->where('tenant_id', (int) $tenant->getKey()) ->where('tenant_id', (int) $tenant->getKey())
->where('type', 'entra_group_sync') ->where('type', 'directory.groups.sync')
->latest('id') ->latest('id')
->first(); ->first();

View File

@ -25,7 +25,7 @@
$opRun = OperationRun::query() $opRun = OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'entra_group_sync') ->where('type', 'directory.groups.sync')
->where('context->slot_key', $slotKey) ->where('context->slot_key', $slotKey)
->first(); ->first();

View File

@ -31,7 +31,7 @@
$opRun = OperationRun::query() $opRun = OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'entra_group_sync') ->where('type', 'directory.groups.sync')
->latest('id') ->latest('id')
->first(); ->first();

View File

@ -203,6 +203,33 @@ function operationRunFilterIndicatorLabels($component): array
->assertCanNotSeeTableRecords([$otherRun]); ->assertCanNotSeeTableRecords([$otherRun]);
}); });
it('shows one canonical operation filter option for current and historical inventory values', function (): void {
[$user, $tenant] = createUserWithTenant(role: 'owner');
foreach (['inventory.sync', 'inventory_sync', 'provider.inventory.sync'] as $type) {
OperationRun::factory()->create([
'tenant_id' => (int) $tenant->getKey(),
'workspace_id' => (int) $tenant->workspace_id,
'type' => $type,
]);
}
Filament::setTenant($tenant, true);
$this->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id]);
session([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id]);
$component = Livewire::actingAs($user)
->test(Operations::class);
/** @var SelectFilter|null $filter */
$filter = $component->instance()->getTable()->getFilter('type');
expect($filter)->not->toBeNull();
expect($filter?->getOptions())->toBe([
'inventory.sync' => 'Inventory sync',
]);
});
it('clears tenant-sensitive persisted filters when the canonical tenant context changes', function (): void { it('clears tenant-sensitive persisted filters when the canonical tenant context changes', function (): void {
$tenantA = Tenant::factory()->create(); $tenantA = Tenant::factory()->create();
[$user, $tenantA] = createUserWithTenant(tenant: $tenantA, role: 'owner'); [$user, $tenantA] = createUserWithTenant(tenant: $tenantA, role: 'owner');

View File

@ -58,15 +58,18 @@
->all(); ->all();
expect($table->getPaginationPageOptions())->toBe(\App\Support\Filament\TablePaginationProfiles::resource()); expect($table->getPaginationPageOptions())->toBe(\App\Support\Filament\TablePaginationProfiles::resource());
expect($table->getEmptyStateHeading())->toBe('No Microsoft connections found'); expect($table->getEmptyStateHeading())->toBe('No provider connections found');
expect($table->getColumn('display_name')?->isSearchable())->toBeTrue(); expect($table->getColumn('display_name')?->isSearchable())->toBeTrue();
expect($table->getColumn('display_name')?->isSortable())->toBeTrue(); expect($table->getColumn('display_name')?->isSortable())->toBeTrue();
expect($visibleColumnNames)->toContain('is_enabled', 'consent_status', 'verification_status'); expect($visibleColumnNames)->toContain('provider', 'target_scope', 'is_enabled', 'consent_status', 'verification_status');
expect($visibleColumnNames)->not->toContain('status'); expect($visibleColumnNames)->not->toContain('status');
expect($visibleColumnNames)->not->toContain('health_status'); expect($visibleColumnNames)->not->toContain('health_status');
expect($visibleColumnNames)->not->toContain('entra_tenant_id');
expect($table->getColumn('status'))->toBeNull(); expect($table->getColumn('status'))->toBeNull();
expect($table->getColumn('health_status'))->toBeNull(); expect($table->getColumn('health_status'))->toBeNull();
expect($table->getColumn('provider')?->isToggledHiddenByDefault())->toBeTrue(); expect($table->getColumn('provider')?->isToggledHiddenByDefault())->toBeFalse();
expect($table->getColumn('target_scope')?->getLabel())->toBe('Target scope');
expect($table->getColumn('entra_tenant_id')?->getLabel())->toBe('Microsoft tenant ID');
expect($table->getColumn('entra_tenant_id')?->isToggledHiddenByDefault())->toBeTrue(); expect($table->getColumn('entra_tenant_id')?->isToggledHiddenByDefault())->toBeTrue();
expect($table->getColumn('migration_review_required'))->not->toBeNull(); expect($table->getColumn('migration_review_required'))->not->toBeNull();
expect(count($table->getVisibleColumns()))->toBeLessThanOrEqual(8); expect(count($table->getVisibleColumns()))->toBeLessThanOrEqual(8);

View File

@ -35,6 +35,24 @@
->assertDontSee('Unauthorized Tenant Connection'); ->assertDontSee('Unauthorized Tenant Connection');
}); });
test('non-members cannot reach provider connection detail target-scope metadata', function (): void {
$tenant = Tenant::factory()->create();
$otherTenant = Tenant::factory()->create();
[$user] = createUserWithTenant($otherTenant, role: 'owner');
$connection = ProviderConnection::factory()->create([
'tenant_id' => (int) $tenant->getKey(),
'workspace_id' => (int) $tenant->workspace_id,
'display_name' => 'Hidden Scope Connection',
'entra_tenant_id' => '77777777-7777-7777-7777-777777777777',
]);
$this->actingAs($user)
->get(ProviderConnectionResource::getUrl('view', ['record' => $connection], tenant: $tenant))
->assertNotFound();
});
test('members without capability see provider connection actions disabled with standard tooltip', function () { test('members without capability see provider connection actions disabled with standard tooltip', function () {
$tenant = Tenant::factory()->create(); $tenant = Tenant::factory()->create();
[$user] = createUserWithTenant($tenant, role: 'readonly'); [$user] = createUserWithTenant($tenant, role: 'readonly');
@ -99,3 +117,26 @@
->assertActionVisible('edit') ->assertActionVisible('edit')
->assertActionEnabled('edit'); ->assertActionEnabled('edit');
}); });
test('sensitive provider connection mutations remain confirmation and capability gated', function (): void {
$source = (string) file_get_contents(repo_path('apps/platform/app/Filament/Resources/ProviderConnectionResource.php'));
foreach ([
'makeSetDefaultAction',
'makeEnableDedicatedOverrideAction',
'makeRotateDedicatedCredentialAction',
'makeDeleteDedicatedCredentialAction',
'makeRevertToPlatformAction',
'makeEnableConnectionAction',
'makeDisableConnectionAction',
] as $method) {
$start = strpos($source, 'public static function '.$method);
expect($start)->not->toBeFalse();
$next = strpos($source, "\n public static function ", $start + 1);
$block = substr($source, $start, $next === false ? null : $next - $start);
expect($block)->toContain('->requiresConfirmation()')
->and($block)->toContain('->requireCapability(');
}
});

View File

@ -166,19 +166,21 @@ function spec125CriticalTenantContext(bool $ensureDefaultMicrosoftProviderConnec
expect($table->persistsSearchInSession())->toBeTrue(); expect($table->persistsSearchInSession())->toBeTrue();
expect($table->persistsSortInSession())->toBeTrue(); expect($table->persistsSortInSession())->toBeTrue();
expect($table->persistsFiltersInSession())->toBeTrue(); expect($table->persistsFiltersInSession())->toBeTrue();
expect($table->getEmptyStateHeading())->toBe('No Microsoft connections found'); expect($table->getEmptyStateHeading())->toBe('No provider connections found');
expect($table->getEmptyStateDescription())->toBe('Start with a platform-managed Microsoft connection. Dedicated overrides are handled separately with stronger authorization.'); expect($table->getEmptyStateDescription())->toBe('Start with a platform-managed provider connection. Dedicated overrides are handled separately with stronger authorization.');
expect($table->getColumn('display_name')?->isSearchable())->toBeTrue(); expect($table->getColumn('display_name')?->isSearchable())->toBeTrue();
expect($table->getColumn('display_name')?->isSortable())->toBeTrue(); expect($table->getColumn('display_name')?->isSortable())->toBeTrue();
expect($table->getColumn('provider')?->isToggleable())->toBeTrue(); expect($table->getColumn('provider')?->isToggleable())->toBeFalse();
expect($table->getColumn('provider')?->isToggledHiddenByDefault())->toBeTrue(); expect($table->getColumn('provider')?->isToggledHiddenByDefault())->toBeFalse();
expect($table->getColumn('target_scope')?->getLabel())->toBe('Target scope');
expect($table->getColumn('entra_tenant_id')?->getLabel())->toBe('Microsoft tenant ID');
expect($table->getColumn('entra_tenant_id')?->isToggleable())->toBeTrue(); expect($table->getColumn('entra_tenant_id')?->isToggleable())->toBeTrue();
expect($table->getColumn('entra_tenant_id')?->isToggledHiddenByDefault())->toBeTrue(); expect($table->getColumn('entra_tenant_id')?->isToggledHiddenByDefault())->toBeTrue();
expect($table->getColumn('last_error_reason_code')?->isToggleable())->toBeTrue(); expect($table->getColumn('last_error_reason_code')?->isToggleable())->toBeTrue();
expect($table->getColumn('last_error_reason_code')?->isToggledHiddenByDefault())->toBeTrue(); expect($table->getColumn('last_error_reason_code')?->isToggledHiddenByDefault())->toBeTrue();
expect($table->getColumn('last_error_message')?->isToggleable())->toBeTrue(); expect($table->getColumn('last_error_message')?->isToggleable())->toBeTrue();
expect($table->getColumn('last_error_message')?->isToggledHiddenByDefault())->toBeTrue(); expect($table->getColumn('last_error_message')?->isToggledHiddenByDefault())->toBeTrue();
expect(count($table->getVisibleColumns()))->toBeLessThanOrEqual(7); expect(count($table->getVisibleColumns()))->toBeLessThanOrEqual(8);
}); });
it('standardizes the findings list around open triage work with hidden forensic detail', function (): void { it('standardizes the findings list around open triage work with hidden forensic detail', function (): void {

View File

@ -3,6 +3,7 @@
declare(strict_types=1); declare(strict_types=1);
use Tests\Support\OpsUx\SourceFileScanner; use Tests\Support\OpsUx\SourceFileScanner;
use App\Support\OperationRunLinks;
/** /**
* @return array<string, string> * @return array<string, string>
@ -158,3 +159,10 @@ function operationRunLinkContractViolations(array $paths, array $allowlist = [])
->and($violations[0]['expectedHelper'])->toContain('OperationRunLinks::view') ->and($violations[0]['expectedHelper'])->toContain('OperationRunLinks::view')
->and($violations[0]['reason'])->toContain('bypasses the canonical admin link helper'); ->and($violations[0]['reason'])->toContain('bypasses the canonical admin link helper');
})->group('surface-guard'); })->group('surface-guard');
it('canonicalizes operation type query parameters for operation collection links', function (): void {
$url = OperationRunLinks::index(operationType: 'inventory_sync');
expect($url)->toContain('inventory.sync')
->not->toContain('inventory_sync');
})->group('surface-guard');

View File

@ -0,0 +1,47 @@
<?php
use App\Services\Providers\ProviderOperationRegistry;
use App\Support\Providers\Boundary\ProviderBoundaryCatalog;
it('blocks graph request option helpers from platform-core identity resolution seams', function (): void {
$root = base_path();
$catalog = app(ProviderBoundaryCatalog::class);
$seam = $catalog->get('provider.identity_resolution');
$hits = [];
foreach ($seam->implementationPaths as $relativePath) {
if ($relativePath !== 'app/Services/Providers/ProviderIdentityResolution.php') {
continue;
}
$path = $root.'/'.$relativePath;
$contents = file_get_contents($path);
if (! is_string($contents)) {
continue;
}
foreach (['graphOptions', 'client_request_id'] as $forbiddenTerm) {
if (str_contains($contents, $forbiddenTerm)) {
$hits[] = $relativePath.' contains '.$forbiddenTerm;
}
}
}
expect($hits)->toBeEmpty('Platform-core identity resolution must not shape Microsoft Graph request options.');
});
it('keeps provider bindings out of platform-core operation definitions', function (): void {
$registry = app(ProviderOperationRegistry::class);
foreach ($registry->definitions() as $operationType => $definition) {
expect($definition)
->not->toHaveKey('provider')
->not->toHaveKey('binding_status')
->not->toHaveKey('handler_notes')
->not->toHaveKey('exception_notes');
expect($registry->bindingFor($operationType, 'microsoft'))->toBeArray();
}
});

View File

@ -0,0 +1,36 @@
<?php
declare(strict_types=1);
it('blocks Microsoft-specific default labels and audit prose on shared provider connection surfaces', function (): void {
$root = repo_path('apps/platform');
$paths = [
'app/Filament/Resources/ProviderConnectionResource.php',
'app/Filament/Resources/ProviderConnectionResource/Pages/CreateProviderConnection.php',
'app/Filament/Resources/ProviderConnectionResource/Pages/EditProviderConnection.php',
'app/Filament/Resources/ProviderConnectionResource/Pages/ListProviderConnections.php',
'app/Filament/Pages/Workspaces/ManagedTenantOnboardingWizard.php',
'app/Services/Providers/ProviderConnectionMutationService.php',
'app/Services/Verification/StartVerification.php',
'app/Jobs/ProviderConnectionHealthCheckJob.php',
];
$forbiddenFragments = [
'Entra tenant ID',
'Entra Tenant ID',
'Directory (tenant) ID',
'No Microsoft connections found',
'Graph API calls',
"'entra_tenant_id' => \$record->entra_tenant_id",
"'entra_tenant_id' => (string) \$connection->entra_tenant_id",
];
foreach ($paths as $path) {
$contents = (string) file_get_contents($root.'/'.$path);
foreach ($forbiddenFragments as $fragment) {
expect($contents)
->not->toContain($fragment, sprintf('%s still contains shared-surface provider-specific default prose [%s].', $path, $fragment));
}
}
});

View File

@ -57,7 +57,7 @@ function providerDispatchGateSlice(string $source, string $startAnchor, ?string
'end' => 'public function sync(', 'end' => 'public function sync(',
'required' => [ 'required' => [
'return $this->providerStarts->start(', 'return $this->providerStarts->start(',
"operationType: 'entra_group_sync'", 'operationType: OperationRunType::DirectoryGroupsSync->value',
'EntraGroupSyncJob::dispatch(', 'EntraGroupSyncJob::dispatch(',
'->afterCommit()', '->afterCommit()',
], ],
@ -69,7 +69,7 @@ function providerDispatchGateSlice(string $source, string $startAnchor, ?string
'end' => 'public function sync(', 'end' => 'public function sync(',
'required' => [ 'required' => [
'return $this->providerStarts->start(', 'return $this->providerStarts->start(',
"operationType: 'directory_role_definitions.sync'", 'operationType: OperationRunType::DirectoryRoleDefinitionsSync->value',
'SyncRoleDefinitionsJob::dispatch(', 'SyncRoleDefinitionsJob::dispatch(',
'->afterCommit()', '->afterCommit()',
], ],

View File

@ -35,7 +35,7 @@
$opRun = OperationRun::query() $opRun = OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('user_id', $user->id) ->where('user_id', $user->id)
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->first(); ->first();
@ -70,7 +70,7 @@
$opRun = OperationRun::query() $opRun = OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->first(); ->first();
@ -101,7 +101,7 @@
$opRun = OperationRun::query() $opRun = OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->first(); ->first();
@ -132,7 +132,7 @@
$opRun = OperationRun::query() $opRun = OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->first(); ->first();
@ -189,7 +189,7 @@
$opRun = OperationRun::query() $opRun = OperationRun::query()
->where('tenant_id', $tenant->id) ->where('tenant_id', $tenant->id)
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->first(); ->first();
@ -216,7 +216,7 @@
Queue::assertNothingPushed(); Queue::assertNothingPushed();
expect(OperationRun::query()->where('tenant_id', $tenantB->id)->where('type', 'inventory_sync')->exists())->toBeFalse(); expect(OperationRun::query()->where('tenant_id', $tenantB->id)->where('type', 'inventory.sync')->exists())->toBeFalse();
expect(OperationRun::query()->where('tenant_id', $tenantB->id)->exists())->toBeFalse(); expect(OperationRun::query()->where('tenant_id', $tenantB->id)->exists())->toBeFalse();
}); });
@ -234,7 +234,7 @@
$opService = app(OperationRunService::class); $opService = app(OperationRunService::class);
$existing = $opService->ensureRunWithIdentity( $existing = $opService->ensureRunWithIdentity(
tenant: $tenant, tenant: $tenant,
type: 'inventory_sync', type: 'inventory.sync',
identityInputs: [ identityInputs: [
'selection_hash' => $computed['selection_hash'], 'selection_hash' => $computed['selection_hash'],
], ],
@ -253,7 +253,7 @@
->callAction('run_inventory_sync', data: ['policy_types' => $computed['selection']['policy_types']]); ->callAction('run_inventory_sync', data: ['policy_types' => $computed['selection']['policy_types']]);
Queue::assertNothingPushed(); Queue::assertNothingPushed();
expect(OperationRun::query()->where('tenant_id', $tenant->id)->where('type', 'inventory_sync')->count())->toBe(1); expect(OperationRun::query()->where('tenant_id', $tenant->id)->where('type', 'inventory.sync')->count())->toBe(1);
}); });
it('disables inventory sync start action for readonly users', function () { it('disables inventory sync start action for readonly users', function () {
@ -268,5 +268,5 @@
->assertActionDisabled('run_inventory_sync'); ->assertActionDisabled('run_inventory_sync');
Queue::assertNothingPushed(); Queue::assertNothingPushed();
expect(OperationRun::query()->where('tenant_id', $tenant->id)->where('type', 'inventory_sync')->exists())->toBeFalse(); expect(OperationRun::query()->where('tenant_id', $tenant->id)->where('type', 'inventory.sync')->exists())->toBeFalse();
}); });

View File

@ -116,7 +116,7 @@ function executeInventorySyncNow(Tenant $tenant, array $selection): array
$opRun = $opService->ensureRunWithIdentity( $opRun = $opService->ensureRunWithIdentity(
tenant: $tenant, tenant: $tenant,
type: 'inventory_sync', type: 'inventory.sync',
identityInputs: [ identityInputs: [
'selection_hash' => $computed['selection_hash'], 'selection_hash' => $computed['selection_hash'],
], ],
@ -617,7 +617,7 @@ function executeInventorySyncNow(Tenant $tenant, array $selection): array
]; ];
$hash = app(\App\Services\Inventory\InventorySelectionHasher::class)->hash($selection); $hash = app(\App\Services\Inventory\InventorySelectionHasher::class)->hash($selection);
$lock = Cache::lock("inventory_sync:tenant:{$tenant->id}:selection:{$hash}", 900); $lock = Cache::lock("inventory.sync:tenant:{$tenant->id}:selection:{$hash}", 900);
expect($lock->get())->toBeTrue(); expect($lock->get())->toBeTrue();
$run = executeInventorySyncNow($tenant, $selection); $run = executeInventorySyncNow($tenant, $selection);

View File

@ -40,7 +40,7 @@
$opRun = OperationRun::query() $opRun = OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->first(); ->first();

View File

@ -3,6 +3,7 @@
declare(strict_types=1); declare(strict_types=1);
use App\Filament\Pages\Workspaces\ManagedTenantOnboardingWizard; use App\Filament\Pages\Workspaces\ManagedTenantOnboardingWizard;
use App\Models\AuditLog;
use App\Models\OperationRun; use App\Models\OperationRun;
use App\Models\ProviderConnection; use App\Models\ProviderConnection;
use App\Models\Tenant; use App\Models\Tenant;
@ -10,6 +11,7 @@
use App\Models\User; use App\Models\User;
use App\Models\Workspace; use App\Models\Workspace;
use App\Models\WorkspaceMembership; use App\Models\WorkspaceMembership;
use App\Support\Audit\AuditActionId;
use App\Support\OperationRunOutcome; use App\Support\OperationRunOutcome;
use App\Support\OperationRunStatus; use App\Support\OperationRunStatus;
use App\Support\Providers\ProviderConnectionType; use App\Support\Providers\ProviderConnectionType;
@ -99,7 +101,7 @@
]); ]);
}); });
it('renders the Entra tenant id placeholder for onboarding input guidance', function (): void { it('renders neutral tenant id placeholder guidance for onboarding input', function (): void {
$workspace = Workspace::factory()->create(); $workspace = Workspace::factory()->create();
$user = User::factory()->create(); $user = User::factory()->create();
@ -114,9 +116,39 @@
$this->actingAs($user) $this->actingAs($user)
->get('/admin/onboarding') ->get('/admin/onboarding')
->assertSuccessful() ->assertSuccessful()
->assertSee('Tenant ID (GUID)')
->assertSee('xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx', false); ->assertSee('xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx', false);
}); });
it('uses target-scope wording in the onboarding provider setup step', function (): void {
$workspace = Workspace::factory()->create();
$user = User::factory()->create();
WorkspaceMembership::factory()->create([
'workspace_id' => (int) $workspace->getKey(),
'user_id' => (int) $user->getKey(),
'role' => 'owner',
]);
session()->put(WorkspaceContext::SESSION_KEY, (int) $workspace->getKey());
$entraTenantId = '34343434-3434-3434-3434-343434343434';
Livewire::actingAs($user)
->test(ManagedTenantOnboardingWizard::class)
->call('identifyManagedTenant', [
'entra_tenant_id' => $entraTenantId,
'environment' => 'prod',
'name' => 'Target Scope Tenant',
])
->set('data.connection_mode', 'new')
->assertSee('Target scope ID')
->assertSee('The provider connection will point to this tenant target scope.')
->assertSee($entraTenantId)
->assertDontSee('Directory (tenant) ID')
->assertDontSee('Graph API calls');
});
it('renders review summary guidance and activation consequences for ready onboarding sessions', function (): void { it('renders review summary guidance and activation consequences for ready onboarding sessions', function (): void {
$workspace = Workspace::factory()->create(); $workspace = Workspace::factory()->create();
$user = User::factory()->create(); $user = User::factory()->create();
@ -195,7 +227,7 @@
->assertSuccessful() ->assertSuccessful()
->assertSee('Skipped - No bootstrap actions selected') ->assertSee('Skipped - No bootstrap actions selected')
->assertSee('Tenant status will be set to Active.') ->assertSee('Tenant status will be set to Active.')
->assertSee('The provider connection will be used for all Graph API calls.'); ->assertSee('The provider connection will be used for provider API calls.');
}); });
it('renders selected bootstrap actions in the review summary before any bootstrap run starts', function (): void { it('renders selected bootstrap actions in the review summary before any bootstrap run starts', function (): void {
@ -354,7 +386,7 @@
$bootstrapRun = OperationRun::factory()->create([ $bootstrapRun = OperationRun::factory()->create([
'workspace_id' => (int) $workspace->getKey(), 'workspace_id' => (int) $workspace->getKey(),
'tenant_id' => (int) $tenant->getKey(), 'tenant_id' => (int) $tenant->getKey(),
'type' => 'inventory_sync', 'type' => 'inventory.sync',
'status' => OperationRunStatus::Completed->value, 'status' => OperationRunStatus::Completed->value,
'outcome' => OperationRunOutcome::Blocked->value, 'outcome' => OperationRunOutcome::Blocked->value,
'context' => [ 'context' => [
@ -490,7 +522,7 @@
$session->refresh(); $session->refresh();
expect($session->state['bootstrap_operation_types'] ?? null)->toBe(['inventory_sync', 'compliance.snapshot']); expect($session->state['bootstrap_operation_types'] ?? null)->toBe(['inventory.sync', 'compliance.snapshot']);
}); });
it('filters unsupported bootstrap selections from persisted onboarding drafts', function (): void { it('filters unsupported bootstrap selections from persisted onboarding drafts', function (): void {
@ -588,12 +620,12 @@
'restore.execute', 'restore.execute',
'entra_group_sync', 'entra_group_sync',
'directory_role_definitions.sync', 'directory_role_definitions.sync',
]))->toBe(['inventory_sync', 'compliance.snapshot']); ]))->toBe(['inventory.sync', 'compliance.snapshot']);
$optionsMethod = new \ReflectionMethod($component->instance(), 'bootstrapOperationOptions'); $optionsMethod = new \ReflectionMethod($component->instance(), 'bootstrapOperationOptions');
$optionsMethod->setAccessible(true); $optionsMethod->setAccessible(true);
expect(array_keys($optionsMethod->invoke($component->instance())))->toBe(['inventory_sync', 'compliance.snapshot']); expect(array_keys($optionsMethod->invoke($component->instance())))->toBe(['inventory.sync', 'compliance.snapshot']);
}); });
it('returns resumable drafts with missing provider connections to the provider connection step', function (): void { it('returns resumable drafts with missing provider connections to the provider connection step', function (): void {
@ -1434,7 +1466,7 @@
expect(OperationRun::query() expect(OperationRun::query()
->where('tenant_id', (int) $tenant->getKey()) ->where('tenant_id', (int) $tenant->getKey())
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->count())->toBe(1); ->count())->toBe(1);
expect(OperationRun::query() expect(OperationRun::query()
@ -1445,9 +1477,17 @@
$session->refresh(); $session->refresh();
$runs = $session->state['bootstrap_operation_runs'] ?? []; $runs = $session->state['bootstrap_operation_runs'] ?? [];
expect($runs)->toBeArray(); expect($runs)->toBeArray();
expect($runs['inventory_sync'] ?? null)->toBeInt(); expect($runs['inventory.sync'] ?? null)->toBeInt();
expect($runs['compliance.snapshot'] ?? null)->toBeNull(); expect($runs['compliance.snapshot'] ?? null)->toBeNull();
expect($session->state['bootstrap_operation_types'] ?? null)->toBe(['inventory_sync', 'compliance.snapshot']); expect($session->state['bootstrap_operation_types'] ?? null)->toBe(['inventory.sync', 'compliance.snapshot']);
$audit = AuditLog::query()
->where('action', AuditActionId::ManagedTenantOnboardingBootstrapStarted->value)
->latest('id')
->firstOrFail();
expect(data_get($audit->metadata, 'operation_types'))->toBe(['inventory.sync', 'compliance.snapshot'])
->and(data_get($audit->metadata, 'started_operation_type'))->toBe('inventory.sync');
}); });
it('starts the next pending bootstrap action after the prior one completes successfully', function (): void { it('starts the next pending bootstrap action after the prior one completes successfully', function (): void {
@ -1503,11 +1543,11 @@
]), ]),
]); ]);
$component->call('startBootstrap', ['inventory_sync', 'compliance.snapshot']); $component->call('startBootstrap', ['inventory.sync', 'compliance.snapshot']);
$inventoryRun = OperationRun::query() $inventoryRun = OperationRun::query()
->where('tenant_id', (int) $tenant->getKey()) ->where('tenant_id', (int) $tenant->getKey())
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->firstOrFail(); ->firstOrFail();
@ -1516,7 +1556,7 @@
'outcome' => 'succeeded', 'outcome' => 'succeeded',
])->save(); ])->save();
$component->call('startBootstrap', ['inventory_sync', 'compliance.snapshot']); $component->call('startBootstrap', ['inventory.sync', 'compliance.snapshot']);
Bus::assertDispatchedTimes(\App\Jobs\ProviderInventorySyncJob::class, 1); Bus::assertDispatchedTimes(\App\Jobs\ProviderInventorySyncJob::class, 1);
Bus::assertDispatchedTimes(\App\Jobs\ProviderComplianceSnapshotJob::class, 1); Bus::assertDispatchedTimes(\App\Jobs\ProviderComplianceSnapshotJob::class, 1);
@ -1528,7 +1568,7 @@
$session->refresh(); $session->refresh();
$runs = $session->state['bootstrap_operation_runs'] ?? []; $runs = $session->state['bootstrap_operation_runs'] ?? [];
expect($runs['inventory_sync'] ?? null)->toBeInt(); expect($runs['inventory.sync'] ?? null)->toBeInt();
expect($runs['compliance.snapshot'] ?? null)->toBeInt(); expect($runs['compliance.snapshot'] ?? null)->toBeInt();
}); });
@ -1562,7 +1602,7 @@
'tenant_id' => (int) $tenant->getKey(), 'tenant_id' => (int) $tenant->getKey(),
'user_id' => (int) $user->getKey(), 'user_id' => (int) $user->getKey(),
'initiator_name' => $user->name, 'initiator_name' => $user->name,
'type' => 'inventory_sync', 'type' => 'inventory.sync',
'status' => 'queued', 'status' => 'queued',
'outcome' => 'pending', 'outcome' => 'pending',
'run_identity_hash' => sha1('busy-'.(string) $connection->getKey()), 'run_identity_hash' => sha1('busy-'.(string) $connection->getKey()),

View File

@ -3,6 +3,8 @@
declare(strict_types=1); declare(strict_types=1);
use App\Models\AuditLog; use App\Models\AuditLog;
use App\Models\OperationRun;
use App\Services\Evidence\Sources\OperationsSummarySource;
use App\Services\OperationRunService; use App\Services\OperationRunService;
use App\Support\Audit\AuditOutcome; use App\Support\Audit\AuditOutcome;
use App\Support\OperationRunOutcome; use App\Support\OperationRunOutcome;
@ -15,7 +17,7 @@
$run = $service->ensureRunWithIdentity( $run = $service->ensureRunWithIdentity(
tenant: $tenant, tenant: $tenant,
type: 'inventory_sync', type: 'inventory.sync',
identityInputs: ['selection_hash' => 'abc123'], identityInputs: ['selection_hash' => 'abc123'],
context: ['selection_hash' => 'abc123'], context: ['selection_hash' => 'abc123'],
initiator: $user, initiator: $user,
@ -46,7 +48,7 @@
->and((string) $audit?->resource_id)->toBe((string) $run->getKey()) ->and((string) $audit?->resource_id)->toBe((string) $run->getKey())
->and($audit?->normalizedOutcome())->toBe(AuditOutcome::Success) ->and($audit?->normalizedOutcome())->toBe(AuditOutcome::Success)
->and($audit?->actorDisplayLabel())->toBe($user->name) ->and($audit?->actorDisplayLabel())->toBe($user->name)
->and(data_get($audit?->metadata, 'operation_type'))->toBe('inventory_sync'); ->and(data_get($audit?->metadata, 'operation_type'))->toBe('inventory.sync');
}); });
it('writes blocked terminal audit semantics for blocked runs', function (): void { it('writes blocked terminal audit semantics for blocked runs', function (): void {
@ -80,3 +82,23 @@
->and($audit?->normalizedOutcome())->toBe(AuditOutcome::Blocked) ->and($audit?->normalizedOutcome())->toBe(AuditOutcome::Blocked)
->and(data_get($audit?->metadata, 'failure_summary.0.reason_code'))->toBe('intune_rbac.not_configured'); ->and(data_get($audit?->metadata, 'failure_summary.0.reason_code'))->toBe('intune_rbac.not_configured');
}); });
it('emits canonical operation types in operations evidence summaries for historical rows', function (): void {
[$user, $tenant] = createUserWithTenant(role: 'owner');
OperationRun::factory()->create([
'tenant_id' => (int) $tenant->getKey(),
'workspace_id' => (int) $tenant->workspace_id,
'user_id' => (int) $user->getKey(),
'type' => 'inventory_sync',
'outcome' => OperationRunOutcome::Failed->value,
'created_at' => now()->subMinute(),
]);
$payload = app(OperationsSummarySource::class)->collect($tenant);
$entry = data_get($payload, 'summary_payload.entries.0');
expect($entry)->toBeArray()
->and($entry['operation_type'] ?? null)->toBe('inventory.sync')
->and($entry['type'] ?? null)->toBe('inventory_sync');
});

View File

@ -74,7 +74,7 @@ function () use (&$terminalInvoked): string {
->and($run->context['reason_code'] ?? null)->toBe('missing_capability') ->and($run->context['reason_code'] ?? null)->toBe('missing_capability')
->and($run->context['execution_legitimacy']['metadata']['required_capability'] ?? null)->toBe(Capabilities::PROVIDER_RUN); ->and($run->context['execution_legitimacy']['metadata']['required_capability'] ?? null)->toBe(Capabilities::PROVIDER_RUN);
})->with([ })->with([
'provider inventory sync' => ['inventory_sync', ProviderInventorySyncJob::class], 'provider inventory sync' => ['inventory.sync', ProviderInventorySyncJob::class],
'provider compliance snapshot' => ['compliance.snapshot', ProviderComplianceSnapshotJob::class], 'provider compliance snapshot' => ['compliance.snapshot', ProviderComplianceSnapshotJob::class],
]); ]);
@ -139,7 +139,7 @@ function () use (&$terminalInvoked): string {
$run = app(OperationRunService::class)->ensureRunWithIdentityStrict( $run = app(OperationRunService::class)->ensureRunWithIdentityStrict(
tenant: $tenant, tenant: $tenant,
type: 'backup_schedule_run', type: 'backup.schedule.execute',
identityInputs: [ identityInputs: [
'backup_schedule_id' => (int) $schedule->getKey(), 'backup_schedule_id' => (int) $schedule->getKey(),
'scheduled_for' => now()->toDateTimeString(), 'scheduled_for' => now()->toDateTimeString(),
@ -190,7 +190,7 @@ function () use (&$terminalInvoked): string {
$scheduleRun = app(OperationRunService::class)->ensureRunWithIdentityStrict( $scheduleRun = app(OperationRunService::class)->ensureRunWithIdentityStrict(
tenant: $tenant, tenant: $tenant,
type: 'backup_schedule_run', type: 'backup.schedule.execute',
identityInputs: [ identityInputs: [
'backup_schedule_id' => 99, 'backup_schedule_id' => 99,
'scheduled_for' => now()->toDateTimeString(), 'scheduled_for' => now()->toDateTimeString(),
@ -211,7 +211,7 @@ function () use (&$terminalInvoked): string {
$result = app(ProviderOperationStartGate::class)->start( $result = app(ProviderOperationStartGate::class)->start(
tenant: $tenant, tenant: $tenant,
connection: $connection, connection: $connection,
operationType: 'inventory_sync', operationType: 'inventory.sync',
dispatcher: static fn (OperationRun $run): null => null, dispatcher: static fn (OperationRun $run): null => null,
initiator: $user, initiator: $user,
); );

View File

@ -43,7 +43,7 @@ function runQueuedInventoryJobThroughMiddleware(object $job, Closure $terminal):
$opRun = OperationRun::query() $opRun = OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->first(); ->first();

View File

@ -15,3 +15,9 @@
expect(OperationCatalog::label('rbac.health_check')) expect(OperationCatalog::label('rbac.health_check'))
->toBe('RBAC health check'); ->toBe('RBAC health check');
})->group('ops-ux'); })->group('ops-ux');
it('does not normalize unknown values to nearby canonical operation labels', function (): void {
expect(OperationCatalog::label('inventory-sync'))
->toBe('Unknown operation')
->not->toBe(OperationCatalog::label('inventory.sync'));
})->group('ops-ux');

View File

@ -0,0 +1,114 @@
<?php
declare(strict_types=1);
use App\Filament\Resources\ProviderConnectionResource;
use App\Filament\Resources\ProviderConnectionResource\Pages\CreateProviderConnection;
use App\Filament\Resources\ProviderConnectionResource\Pages\ListProviderConnections;
use App\Models\ProviderConnection;
use App\Services\Providers\ProviderConnectionResolver;
use Filament\Facades\Filament;
use Livewire\Livewire;
it('renders create and edit flows with neutral target-scope labels', function (): void {
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
$connection = ProviderConnection::factory()->create([
'workspace_id' => (int) $tenant->workspace_id,
'tenant_id' => (int) $tenant->getKey(),
'display_name' => 'Neutral connection',
'entra_tenant_id' => '44444444-4444-4444-4444-444444444444',
]);
$this->actingAs($user)
->get(ProviderConnectionResource::getUrl('create', ['tenant_id' => $tenant->external_id], panel: 'admin'))
->assertOk()
->assertSee('Target scope ID')
->assertSee('Target scope')
->assertDontSee('Entra tenant ID');
$this->actingAs($user)
->get(ProviderConnectionResource::getUrl('edit', ['record' => $connection, 'tenant_id' => $tenant->external_id], panel: 'admin'))
->assertOk()
->assertSee('Target scope ID')
->assertSee('Target scope')
->assertDontSee('Entra tenant ID');
});
it('keeps list and detail surfaces default-visible around provider target scope consent and verification', function (): void {
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
$connection = ProviderConnection::factory()->create([
'workspace_id' => (int) $tenant->workspace_id,
'tenant_id' => (int) $tenant->getKey(),
'display_name' => 'Scope-visible connection',
'entra_tenant_id' => '55555555-5555-5555-5555-555555555555',
'consent_status' => 'granted',
'verification_status' => 'healthy',
]);
$tenant->makeCurrent();
Filament::setTenant($tenant, true);
$component = Livewire::actingAs($user)->test(ListProviderConnections::class);
$table = $component->instance()->getTable();
$visibleColumnNames = collect($table->getVisibleColumns())
->map(fn ($column): string => $column->getName())
->values()
->all();
expect($visibleColumnNames)->toContain('provider', 'target_scope', 'consent_status', 'verification_status')
->and($visibleColumnNames)->not->toContain('entra_tenant_id')
->and($table->getColumn('target_scope')?->getLabel())->toBe('Target scope')
->and($table->getColumn('entra_tenant_id')?->getLabel())->toBe('Microsoft tenant ID');
$this->actingAs($user)
->get(ProviderConnectionResource::getUrl('view', ['record' => $connection, 'tenant_id' => $tenant->external_id], panel: 'admin'))
->assertOk()
->assertSee('Target scope')
->assertSee('Provider identity details')
->assertSee('Microsoft tenant ID')
->assertSee('Consent')
->assertSee('Verification')
->assertDontSee('Entra tenant ID');
});
it('uses neutral validation attributes when the create flow misses target-scope context', function (): void {
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
$this->actingAs($user);
$tenant->makeCurrent();
Filament::setTenant($tenant, true);
Livewire::actingAs($user)
->test(CreateProviderConnection::class)
->fillForm([
'display_name' => 'Missing target scope',
'entra_tenant_id' => '',
'is_default' => true,
])
->call('create')
->assertHasFormErrors(['entra_tenant_id' => 'required']);
});
it('blocks unsupported provider target-scope combinations before provider execution', function (): void {
[$user, $tenant] = createUserWithTenant(role: 'owner', ensureDefaultMicrosoftProviderConnection: false);
$connection = ProviderConnection::factory()->consentGranted()->create([
'workspace_id' => (int) $tenant->workspace_id,
'tenant_id' => (int) $tenant->getKey(),
'provider' => 'contoso',
'display_name' => 'Unsupported provider connection',
'entra_tenant_id' => '66666666-6666-6666-6666-666666666666',
'is_enabled' => true,
]);
$resolution = app(ProviderConnectionResolver::class)
->validateConnection($tenant, 'contoso', $connection->fresh(['tenant']));
expect($user)->not->toBeNull()
->and($resolution->resolved)->toBeFalse()
->and($resolution->reasonCode)->toBe('provider_binding_unsupported')
->and($resolution->extensionReasonCode)->toBe('ext.connection_scope_unsupported')
->and($resolution->message)->toBe('This provider and target-scope combination is not supported.');
});

View File

@ -38,11 +38,14 @@
$this->get(ProviderConnectionResource::getUrl('edit', ['tenant' => $tenant->external_id, 'record' => $connection], panel: 'admin')) $this->get(ProviderConnectionResource::getUrl('edit', ['tenant' => $tenant->external_id, 'record' => $connection], panel: 'admin'))
->assertOk() ->assertOk()
->assertSee('Spec081 Connection') ->assertSee('Spec081 Connection')
->assertSee('Target scope')
->assertSee('Target scope ID')
->assertSee('Lifecycle') ->assertSee('Lifecycle')
->assertSee('Enabled') ->assertSee('Enabled')
->assertSee('Verification') ->assertSee('Verification')
->assertSee('Migration review') ->assertSee('Migration review')
->assertSee('Review required') ->assertSee('Review required')
->assertDontSee('Entra tenant ID')
->assertDontSee('Diagnostic status') ->assertDontSee('Diagnostic status')
->assertDontSee('Diagnostic health'); ->assertDontSee('Diagnostic health');
}); });

View File

@ -37,7 +37,7 @@
$inventoryRun = OperationRun::query() $inventoryRun = OperationRun::query()
->where('tenant_id', (int) $tenant->getKey()) ->where('tenant_id', (int) $tenant->getKey())
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->first(); ->first();

View File

@ -43,7 +43,7 @@
$opRun = OperationRun::query() $opRun = OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->first(); ->first();
@ -59,7 +59,7 @@
expect(OperationRun::query() expect(OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->count())->toBe(1); ->count())->toBe(1);
Queue::assertPushed(ProviderInventorySyncJob::class, 1); Queue::assertPushed(ProviderInventorySyncJob::class, 1);
@ -96,7 +96,7 @@
$opRun = OperationRun::query() $opRun = OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->first(); ->first();
@ -189,7 +189,7 @@
$inventoryRun = OperationRun::query() $inventoryRun = OperationRun::query()
->where('tenant_id', $tenant->getKey()) ->where('tenant_id', $tenant->getKey())
->where('type', 'inventory_sync') ->where('type', 'inventory.sync')
->latest('id') ->latest('id')
->first(); ->first();

View File

@ -0,0 +1,109 @@
<?php
use App\Models\ProviderConnection;
use App\Models\ProviderCredential;
use App\Models\Tenant;
use App\Services\Graph\GraphClientInterface;
use App\Services\Graph\GraphResponse;
use App\Services\Providers\MicrosoftGraphOptionsResolver;
use App\Services\Providers\ProviderGateway;
use Illuminate\Foundation\Testing\RefreshDatabase;
uses(RefreshDatabase::class);
it('preserves current Microsoft-backed gateway runtime behavior through the provider-owned seam', function (): void {
$tenant = Tenant::factory()->create();
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
'tenant_id' => $tenant->getKey(),
'workspace_id' => $tenant->workspace_id,
'provider' => 'microsoft',
'entra_tenant_id' => 'entra-tenant-id',
'is_default' => true,
]);
ProviderCredential::factory()->create([
'provider_connection_id' => $connection->getKey(),
'payload' => [
'client_id' => 'client-id',
'client_secret' => 'client-secret',
],
]);
$graph = new class implements GraphClientInterface
{
/** @var array<string, mixed> */
public array $options = [];
public function listPolicies(string $policyType, array $options = []): GraphResponse
{
$this->options = $options;
return new GraphResponse(true);
}
public function getPolicy(string $policyType, string $policyId, array $options = []): GraphResponse
{
return new GraphResponse(true);
}
public function getOrganization(array $options = []): GraphResponse
{
return new GraphResponse(true);
}
public function applyPolicy(string $policyType, string $policyId, array $payload, array $options = []): GraphResponse
{
return new GraphResponse(true);
}
public function getServicePrincipalPermissions(array $options = []): GraphResponse
{
return new GraphResponse(true);
}
public function request(string $method, string $path, array $options = []): GraphResponse
{
return new GraphResponse(true);
}
};
$gateway = app()->make(ProviderGateway::class, [
'graph' => $graph,
]);
$gateway->listPolicies($connection, 'deviceConfiguration', ['query' => ['$select' => 'id']]);
expect($graph->options)->toMatchArray([
'tenant' => 'entra-tenant-id',
'client_id' => 'client-id',
'client_secret' => 'client-secret',
'query' => ['$select' => 'id'],
]);
expect($graph->options['client_request_id'])->toBeString()->not->toBeEmpty();
});
it('preserves Microsoft graph option resolution for default provider connections', function (): void {
$tenant = Tenant::factory()->create();
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
'tenant_id' => $tenant->getKey(),
'workspace_id' => $tenant->workspace_id,
'provider' => 'microsoft',
'entra_tenant_id' => 'default-entra-tenant-id',
'is_default' => true,
]);
ProviderCredential::factory()->create([
'provider_connection_id' => $connection->getKey(),
'payload' => [
'client_id' => 'default-client-id',
'client_secret' => 'default-client-secret',
],
]);
$options = app(MicrosoftGraphOptionsResolver::class)->resolveForTenant($tenant);
expect($options['tenant'])->toBe('default-entra-tenant-id')
->and($options['client_id'])->toBe('default-client-id')
->and($options['client_secret'])->toBe('default-client-secret')
->and($options['client_request_id'])->toBeString()->not->toBeEmpty();
});

View File

@ -0,0 +1,45 @@
<?php
use App\Models\ProviderConnection;
use App\Models\Tenant;
use App\Services\Providers\MicrosoftGraphOptionsResolver;
use App\Services\Providers\ProviderConfigurationRequiredException;
use App\Services\Providers\ProviderGateway;
use App\Support\Providers\ProviderReasonCodes;
use Illuminate\Foundation\Testing\RefreshDatabase;
uses(RefreshDatabase::class);
it('fails explicitly when provider-owned graph option assembly cannot resolve identity', function (): void {
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
'entra_tenant_id' => 'entra-tenant-id',
]);
$call = fn (): array => app(ProviderGateway::class)->graphOptions($connection);
expect($call)->toThrow(RuntimeException::class, 'Provider credentials are missing.');
});
it('does not inherit Microsoft runtime behavior when a default provider connection is unsupported', function (): void {
$tenant = Tenant::factory()->create();
ProviderConnection::factory()->dedicated()->create([
'tenant_id' => $tenant->getKey(),
'workspace_id' => $tenant->workspace_id,
'provider' => 'microsoft',
'entra_tenant_id' => 'entra-tenant-id',
'is_default' => true,
'consent_status' => 'required',
]);
$call = fn (): array => app(MicrosoftGraphOptionsResolver::class)->resolveForTenant($tenant);
expect($call)->toThrow(ProviderConfigurationRequiredException::class);
try {
$call();
} catch (ProviderConfigurationRequiredException $exception) {
expect($exception->reasonCode)->toBe(ProviderReasonCodes::ProviderConsentMissing)
->and($exception->provider)->toBe('microsoft');
}
});

Some files were not shown because too many files have changed in this diff Show More