Compare commits
1 Commits
dev
...
174-eviden
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
7f2c82c26d |
4
.github/agents/copilot-instructions.md
vendored
4
.github/agents/copilot-instructions.md
vendored
@ -125,6 +125,8 @@ ## Active Technologies
|
||||
- PostgreSQL with existing `operation_runs`, `managed_tenant_onboarding_sessions`, tenant records, and workspace records; no schema changes (172-deferred-operator-surfaces-retrofit)
|
||||
- PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Pest v4, existing `TenantDashboard`, `DashboardKpis`, `NeedsAttention`, `BaselineCompareNow`, `RecentDriftFindings`, `RecentOperations`, `TenantGovernanceAggregateResolver`, `BaselineCompareStats`, `BaselineCompareSummaryAssessor`, `FindingResource`, `OperationRunLinks`, and canonical admin Operations page (173-tenant-dashboard-truth-alignment)
|
||||
- PostgreSQL unchanged; no new persistence, cache store, or durable dashboard summary artifac (173-tenant-dashboard-truth-alignment)
|
||||
- PHP 8.4, Laravel 12, Filament v5, Livewire v4, Blade + Filament v5, Livewire v4, Pest v4, Laravel Sail, existing `ArtifactTruthPresenter`, `ArtifactTruthEnvelope`, `TenantReviewReadinessGate`, `EvidenceSnapshotService`, `TenantReviewRegisterService`, and current evidence/review/review-pack resources and pages (174-evidence-freshness-publication-trust)
|
||||
- PostgreSQL with existing `evidence_snapshots`, `evidence_snapshot_items`, `tenant_reviews`, and `review_packs` tables using current summary JSON and timestamps; no schema change planned (174-evidence-freshness-publication-trust)
|
||||
|
||||
- PHP 8.4.15 (feat/005-bulk-operations)
|
||||
|
||||
@ -144,8 +146,8 @@ ## Code Style
|
||||
PHP 8.4.15: Follow standard conventions
|
||||
|
||||
## Recent Changes
|
||||
- 174-evidence-freshness-publication-trust: Added PHP 8.4, Laravel 12, Filament v5, Livewire v4, Blade + Filament v5, Livewire v4, Pest v4, Laravel Sail, existing `ArtifactTruthPresenter`, `ArtifactTruthEnvelope`, `TenantReviewReadinessGate`, `EvidenceSnapshotService`, `TenantReviewRegisterService`, and current evidence/review/review-pack resources and pages
|
||||
- 173-tenant-dashboard-truth-alignment: Added PHP 8.4.15 + Laravel 12, Filament v5, Livewire v4, Pest v4, existing `TenantDashboard`, `DashboardKpis`, `NeedsAttention`, `BaselineCompareNow`, `RecentDriftFindings`, `RecentOperations`, `TenantGovernanceAggregateResolver`, `BaselineCompareStats`, `BaselineCompareSummaryAssessor`, `FindingResource`, `OperationRunLinks`, and canonical admin Operations page
|
||||
- 172-deferred-operator-surfaces-retrofit: Added PHP 8.4, Laravel 12, Livewire v4, Filament v5, Tailwind CSS v4 + `laravel/framework`, `filament/filament`, `livewire/livewire`, `pestphp/pest`
|
||||
- 171-operations-naming-consolidation: Added PHP 8.4, Laravel 12, Livewire v4, Filament v5, Tailwind CSS v4 + `laravel/framework`, `filament/filament`, `livewire/livewire`, `pestphp/pest`
|
||||
<!-- MANUAL ADDITIONS START -->
|
||||
<!-- MANUAL ADDITIONS END -->
|
||||
|
||||
@ -7,9 +7,11 @@
|
||||
use App\Filament\Resources\EvidenceSnapshotResource;
|
||||
use App\Models\EvidenceSnapshot;
|
||||
use App\Models\Tenant;
|
||||
use App\Models\TenantReview;
|
||||
use App\Models\User;
|
||||
use App\Support\Badges\BadgeCatalog;
|
||||
use App\Support\Badges\BadgeDomain;
|
||||
use App\Support\TenantReviewStatus;
|
||||
use App\Support\Ui\ActionSurface\ActionSurfaceDeclaration;
|
||||
use App\Support\Ui\ActionSurface\Enums\ActionSurfaceInspectAffordance;
|
||||
use App\Support\Ui\ActionSurface\Enums\ActionSurfaceProfile;
|
||||
@ -90,14 +92,30 @@ public function mount(): void
|
||||
}
|
||||
|
||||
$snapshots = $query->get()->unique('tenant_id')->values();
|
||||
$currentReviewTenantIds = TenantReview::query()
|
||||
->where('workspace_id', $workspaceId)
|
||||
->whereIn('tenant_id', $snapshots->pluck('tenant_id')->map(static fn (mixed $tenantId): int => (int) $tenantId)->all())
|
||||
->whereIn('status', [
|
||||
TenantReviewStatus::Draft->value,
|
||||
TenantReviewStatus::Ready->value,
|
||||
TenantReviewStatus::Published->value,
|
||||
])
|
||||
->pluck('tenant_id')
|
||||
->mapWithKeys(static fn (mixed $tenantId): array => [(int) $tenantId => true])
|
||||
->all();
|
||||
|
||||
$this->rows = $snapshots->map(function (EvidenceSnapshot $snapshot): array {
|
||||
$this->rows = $snapshots->map(function (EvidenceSnapshot $snapshot) use ($currentReviewTenantIds): array {
|
||||
$truth = $this->snapshotTruth($snapshot);
|
||||
$freshnessSpec = BadgeCatalog::spec(BadgeDomain::GovernanceArtifactFreshness, $truth->freshnessState);
|
||||
$tenantId = (int) $snapshot->tenant_id;
|
||||
$hasCurrentReview = $currentReviewTenantIds[$tenantId] ?? false;
|
||||
$nextStep = ! $hasCurrentReview && $truth->contentState === 'trusted' && $truth->freshnessState === 'current'
|
||||
? 'Create a current review from this evidence snapshot'
|
||||
: $truth->nextStepText();
|
||||
|
||||
return [
|
||||
'tenant_name' => $snapshot->tenant?->name ?? 'Unknown tenant',
|
||||
'tenant_id' => (int) $snapshot->tenant_id,
|
||||
'tenant_id' => $tenantId,
|
||||
'snapshot_id' => (int) $snapshot->getKey(),
|
||||
'completeness_state' => (string) $snapshot->completeness_state,
|
||||
'generated_at' => $snapshot->generated_at?->toDateTimeString(),
|
||||
@ -114,7 +132,7 @@ public function mount(): void
|
||||
'color' => $freshnessSpec->color,
|
||||
'icon' => $freshnessSpec->icon,
|
||||
],
|
||||
'next_step' => $truth->nextStepText(),
|
||||
'next_step' => $nextStep,
|
||||
'view_url' => $snapshot->tenant
|
||||
? EvidenceSnapshotResource::getUrl('view', ['record' => $snapshot], tenant: $snapshot->tenant)
|
||||
: null,
|
||||
|
||||
@ -17,6 +17,7 @@
|
||||
use App\Services\Baselines\SnapshotRendering\FidelityState;
|
||||
use App\Support\Badges\BadgeCatalog;
|
||||
use App\Support\Badges\BadgeDomain;
|
||||
use App\Support\Evidence\EvidenceCompletenessState;
|
||||
use App\Support\OperationCatalog;
|
||||
use App\Support\OperationRunLinks;
|
||||
use App\Support\OperationRunOutcome;
|
||||
@ -349,7 +350,9 @@ private function buildEvidenceSnapshotEnvelope(EvidenceSnapshot $snapshot): Arti
|
||||
'required' => 'Refresh evidence before using this snapshot',
|
||||
'optional' => in_array($status, ['queued', 'generating'], true)
|
||||
? 'Wait for evidence generation to finish'
|
||||
: 'Review the evidence freshness before relying on this snapshot',
|
||||
: ($freshnessState === 'stale'
|
||||
? 'Refresh the stale evidence before relying on this snapshot'
|
||||
: 'Review the evidence freshness before relying on this snapshot'),
|
||||
default => null,
|
||||
},
|
||||
),
|
||||
@ -402,7 +405,7 @@ public function forTenantReviewFresh(TenantReview $review): ArtifactTruthEnvelop
|
||||
|
||||
private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthEnvelope
|
||||
{
|
||||
$review->loadMissing(['tenant', 'currentExportReviewPack']);
|
||||
$review->loadMissing(['tenant', 'currentExportReviewPack', 'evidenceSnapshot']);
|
||||
|
||||
$summary = is_array($review->summary) ? $review->summary : [];
|
||||
$publishBlockers = $review->publishBlockers();
|
||||
@ -410,6 +413,7 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
$completeness = $review->completenessEnum()->value;
|
||||
$sectionCounts = is_array($summary['section_state_counts'] ?? null) ? $summary['section_state_counts'] : [];
|
||||
$staleSections = (int) ($sectionCounts['stale'] ?? 0);
|
||||
$sourceEvidence = $this->evidenceTrustBurden($review->evidenceSnapshot);
|
||||
|
||||
$artifactExistence = match ($status) {
|
||||
TenantReviewStatus::Archived, TenantReviewStatus::Superseded => 'historical_only',
|
||||
@ -417,24 +421,27 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
default => 'created',
|
||||
};
|
||||
|
||||
$contentState = match ($completeness) {
|
||||
TenantReviewCompletenessState::Complete->value => 'trusted',
|
||||
TenantReviewCompletenessState::Partial->value => 'partial',
|
||||
TenantReviewCompletenessState::Missing->value => 'missing_input',
|
||||
TenantReviewCompletenessState::Stale->value => 'trusted',
|
||||
$contentState = match (true) {
|
||||
$completeness === TenantReviewCompletenessState::Missing->value => 'missing_input',
|
||||
$completeness === TenantReviewCompletenessState::Partial->value || $sourceEvidence['isPartial'] => 'partial',
|
||||
$sourceEvidence['isMissing'] => 'missing_input',
|
||||
$completeness === TenantReviewCompletenessState::Complete->value => 'trusted',
|
||||
$completeness === TenantReviewCompletenessState::Stale->value => 'trusted',
|
||||
default => 'partial',
|
||||
};
|
||||
|
||||
$freshnessState = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'stale',
|
||||
$completeness === TenantReviewCompletenessState::Stale->value || $staleSections > 0 => 'stale',
|
||||
$completeness === TenantReviewCompletenessState::Stale->value || $staleSections > 0 || $sourceEvidence['isStale'] => 'stale',
|
||||
default => 'current',
|
||||
};
|
||||
|
||||
$publicationReadiness = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'internal_only',
|
||||
$status === TenantReviewStatus::Published => 'publishable',
|
||||
$publishBlockers !== [] => 'blocked',
|
||||
$contentState === 'missing_input' => 'blocked',
|
||||
$freshnessState === 'stale' || $contentState === 'partial' => 'internal_only',
|
||||
$status === TenantReviewStatus::Published => 'publishable',
|
||||
$status === TenantReviewStatus::Ready => 'publishable',
|
||||
default => 'internal_only',
|
||||
};
|
||||
@ -442,16 +449,16 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
$actionability = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'none',
|
||||
$publicationReadiness === 'publishable' && $freshnessState === 'current' => 'none',
|
||||
$publicationReadiness === 'internal_only' && $contentState === 'trusted' => 'optional',
|
||||
$freshnessState === 'stale' && $publishBlockers === [] => 'optional',
|
||||
$publicationReadiness === 'blocked' => 'required',
|
||||
$publicationReadiness === 'internal_only' => 'optional',
|
||||
default => 'required',
|
||||
};
|
||||
|
||||
$reasonCode = match (true) {
|
||||
$publishBlockers !== [] => 'review_publish_blocked',
|
||||
$status === TenantReviewStatus::Failed => 'review_generation_failed',
|
||||
$completeness === TenantReviewCompletenessState::Missing->value => 'review_missing_sections',
|
||||
$completeness === TenantReviewCompletenessState::Stale->value => 'review_stale_sections',
|
||||
$contentState === 'missing_input' => 'review_missing_sections',
|
||||
$freshnessState === 'stale' => 'review_stale_sections',
|
||||
default => null,
|
||||
};
|
||||
$reason = $this->reasonPresenter->forArtifactTruth($reasonCode, 'artifact_truth');
|
||||
@ -470,7 +477,11 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
$publicationReadiness === 'internal_only' => [
|
||||
BadgeDomain::GovernanceArtifactPublicationReadiness,
|
||||
'internal_only',
|
||||
'This review exists and is useful internally, but it is not yet ready for stakeholder publication.',
|
||||
match (true) {
|
||||
$freshnessState === 'stale' => 'This review is useful internally, but stale evidence should be refreshed before stakeholder publication.',
|
||||
$contentState === 'partial' => 'This review is useful internally, but the evidence basis is partial and should be completed before stakeholder publication.',
|
||||
default => 'This review exists and is useful internally, but it is not yet ready for stakeholder publication.',
|
||||
},
|
||||
],
|
||||
$freshnessState === 'stale' => [
|
||||
BadgeDomain::GovernanceArtifactFreshness,
|
||||
@ -490,6 +501,8 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
|
||||
if ($publishBlockers !== [] && $review->tenant !== null) {
|
||||
$nextActionUrl = TenantReviewResource::tenantScopedUrl('view', ['record' => $review], $review->tenant);
|
||||
} elseif (($freshnessState === 'stale' || $contentState === 'partial') && $review->tenant !== null && $review->evidenceSnapshot !== null) {
|
||||
$nextActionUrl = EvidenceSnapshotResource::getUrl('view', ['record' => $review->evidenceSnapshot], tenant: $review->tenant);
|
||||
}
|
||||
|
||||
return $this->makeEnvelope(
|
||||
@ -514,9 +527,11 @@ private function buildTenantReviewEnvelope(TenantReview $review): ArtifactTruthE
|
||||
nextActionLabel: $this->nextActionLabel(
|
||||
$actionability,
|
||||
$reason,
|
||||
match ($actionability) {
|
||||
'required' => 'Resolve the review blockers before publication',
|
||||
'optional' => 'Complete the remaining review work before publication',
|
||||
match (true) {
|
||||
$publicationReadiness === 'blocked' => 'Resolve the review blockers before publication',
|
||||
$freshnessState === 'stale' => 'Refresh the evidence basis before publishing this review',
|
||||
$contentState === 'partial' => 'Complete the evidence basis before publishing this review',
|
||||
$actionability === 'optional' => 'Complete the remaining review work before publication',
|
||||
default => null,
|
||||
},
|
||||
),
|
||||
@ -568,14 +583,18 @@ public function forReviewPackFresh(ReviewPack $pack): ArtifactTruthEnvelope
|
||||
|
||||
private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelope
|
||||
{
|
||||
$pack->loadMissing(['tenant', 'tenantReview']);
|
||||
$pack->loadMissing(['tenant', 'tenantReview', 'evidenceSnapshot']);
|
||||
|
||||
$summary = is_array($pack->summary) ? $pack->summary : [];
|
||||
$status = (string) $pack->status;
|
||||
$evidenceResolution = is_array($summary['evidence_resolution'] ?? null) ? $summary['evidence_resolution'] : [];
|
||||
$sourceReview = $pack->tenantReview;
|
||||
$sourceReviewTruth = $sourceReview instanceof TenantReview
|
||||
? $this->forTenantReviewFresh($sourceReview)
|
||||
: null;
|
||||
$sourceBlockers = $sourceReview instanceof TenantReview ? $sourceReview->publishBlockers() : [];
|
||||
$sourceReviewStatus = $sourceReview instanceof TenantReview ? $sourceReview->statusEnum() : null;
|
||||
$sourceEvidence = $this->evidenceTrustBurden($pack->evidenceSnapshot);
|
||||
|
||||
$artifactExistence = match ($status) {
|
||||
ReviewPackStatus::Queued->value, ReviewPackStatus::Generating->value => 'not_created',
|
||||
@ -588,23 +607,31 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
$artifactExistence === 'not_created' => 'missing_input',
|
||||
$status === ReviewPackStatus::Failed->value => 'missing_input',
|
||||
($evidenceResolution['outcome'] ?? null) !== 'resolved' => 'missing_input',
|
||||
$sourceReview instanceof TenantReview && $sourceBlockers !== [] => 'partial',
|
||||
$sourceReviewTruth?->contentState === 'missing_input' => 'missing_input',
|
||||
$sourceReviewTruth?->contentState === 'partial' || $sourceEvidence['isPartial'] => 'partial',
|
||||
default => 'trusted',
|
||||
};
|
||||
|
||||
$freshnessState = $artifactExistence === 'historical_only' ? 'stale' : 'current';
|
||||
$freshnessState = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'stale',
|
||||
$sourceReviewTruth?->freshnessState === 'stale' || $sourceEvidence['isStale'] => 'stale',
|
||||
default => 'current',
|
||||
};
|
||||
|
||||
$publicationReadiness = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'internal_only',
|
||||
$artifactExistence === 'not_created' => 'blocked',
|
||||
$status === ReviewPackStatus::Failed->value => 'blocked',
|
||||
$sourceReview instanceof TenantReview && $sourceBlockers !== [] => 'blocked',
|
||||
$sourceReviewTruth?->publicationReadiness === 'blocked' => 'blocked',
|
||||
$sourceReviewTruth?->publicationReadiness === 'internal_only' => 'internal_only',
|
||||
$freshnessState === 'stale' || $contentState === 'partial' => 'internal_only',
|
||||
$sourceReviewStatus === TenantReviewStatus::Draft || $sourceReviewStatus === TenantReviewStatus::Failed => 'internal_only',
|
||||
default => $status === ReviewPackStatus::Ready->value ? 'publishable' : 'blocked',
|
||||
};
|
||||
|
||||
$actionability = match (true) {
|
||||
$artifactExistence === 'historical_only' => 'none',
|
||||
$publicationReadiness === 'publishable' => 'none',
|
||||
$publicationReadiness === 'publishable' && $freshnessState === 'current' => 'none',
|
||||
$publicationReadiness === 'internal_only' => 'optional',
|
||||
default => 'required',
|
||||
};
|
||||
@ -612,7 +639,7 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
$reasonCode = match (true) {
|
||||
$status === ReviewPackStatus::Failed->value => 'review_pack_generation_failed',
|
||||
($evidenceResolution['outcome'] ?? null) !== 'resolved' => 'review_pack_missing_snapshot',
|
||||
$sourceReview instanceof TenantReview && $sourceBlockers !== [] => 'review_pack_source_not_publishable',
|
||||
$sourceReviewTruth?->publicationReadiness === 'blocked' || $sourceReviewTruth?->publicationReadiness === 'internal_only' => 'review_pack_source_not_publishable',
|
||||
$artifactExistence === 'historical_only' => 'review_pack_expired',
|
||||
default => null,
|
||||
};
|
||||
@ -632,7 +659,11 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
$publicationReadiness === 'internal_only' => [
|
||||
BadgeDomain::GovernanceArtifactPublicationReadiness,
|
||||
'internal_only',
|
||||
'This pack can be reviewed internally, but the source review is not currently publishable.',
|
||||
match (true) {
|
||||
$freshnessState === 'stale' => 'This pack is downloadable, but the source review relies on stale evidence and should stay internal until refreshed.',
|
||||
$contentState === 'partial' => 'This pack is downloadable, but the source review relies on partial evidence and should stay internal until the evidence basis is completed.',
|
||||
default => 'This pack can be reviewed internally, but the source review is not currently publishable.',
|
||||
},
|
||||
],
|
||||
default => [
|
||||
BadgeDomain::GovernanceArtifactPublicationReadiness,
|
||||
@ -645,6 +676,8 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
|
||||
if ($sourceReview instanceof TenantReview && $pack->tenant !== null) {
|
||||
$nextActionUrl = TenantReviewResource::tenantScopedUrl('view', ['record' => $sourceReview], $pack->tenant);
|
||||
} elseif (($freshnessState === 'stale' || $contentState === 'partial') && $pack->tenant !== null && $pack->evidenceSnapshot !== null) {
|
||||
$nextActionUrl = EvidenceSnapshotResource::getUrl('view', ['record' => $pack->evidenceSnapshot], tenant: $pack->tenant);
|
||||
} elseif ($pack->operation_run_id !== null) {
|
||||
$nextActionUrl = OperationRunLinks::tenantlessView((int) $pack->operation_run_id);
|
||||
}
|
||||
@ -671,9 +704,11 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
nextActionLabel: $this->nextActionLabel(
|
||||
$actionability,
|
||||
$reason,
|
||||
match ($actionability) {
|
||||
'required' => 'Open the source review before sharing this pack',
|
||||
'optional' => 'Review the source review before sharing this pack',
|
||||
match (true) {
|
||||
$publicationReadiness === 'blocked' => 'Open the source review before sharing this pack',
|
||||
$freshnessState === 'stale' => 'Refresh the source review before sharing this pack',
|
||||
$contentState === 'partial' => 'Complete the source review before sharing this pack',
|
||||
$actionability === 'optional' => 'Review the source review before sharing this pack',
|
||||
default => null,
|
||||
},
|
||||
),
|
||||
@ -704,6 +739,30 @@ private function buildReviewPackEnvelope(ReviewPack $pack): ArtifactTruthEnvelop
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return array{isMissing: bool, isPartial: bool, isStale: bool}
|
||||
*/
|
||||
private function evidenceTrustBurden(?EvidenceSnapshot $snapshot): array
|
||||
{
|
||||
if (! $snapshot instanceof EvidenceSnapshot) {
|
||||
return [
|
||||
'isMissing' => false,
|
||||
'isPartial' => false,
|
||||
'isStale' => false,
|
||||
];
|
||||
}
|
||||
|
||||
$summary = is_array($snapshot->summary) ? $snapshot->summary : [];
|
||||
$completeness = $snapshot->completenessState();
|
||||
$staleDimensions = (int) ($summary['stale_dimensions'] ?? 0);
|
||||
|
||||
return [
|
||||
'isMissing' => $completeness === EvidenceCompletenessState::Missing,
|
||||
'isPartial' => $completeness === EvidenceCompletenessState::Partial,
|
||||
'isStale' => $completeness === EvidenceCompletenessState::Stale || $staleDimensions > 0,
|
||||
];
|
||||
}
|
||||
|
||||
public function forOperationRun(OperationRun $run): ArtifactTruthEnvelope
|
||||
{
|
||||
return $this->resolveEnvelope(
|
||||
@ -808,7 +867,7 @@ private function buildOperationRunEnvelope(OperationRun $run): ArtifactTruthEnve
|
||||
reason: ArtifactTruthCause::fromReasonResolutionEnvelope($reason, ReasonPresenter::GOVERNANCE_ARTIFACT_TRUTH_ARTIFACT),
|
||||
nextActionLabel: $reason?->firstNextStep()?->label
|
||||
?? ($actionability === 'required'
|
||||
? 'Inspect the blocked operation details before retrying'
|
||||
? 'Inspect the blocked run details before retrying'
|
||||
: 'Wait for the artifact-producing operation to finish'),
|
||||
nextActionUrl: null,
|
||||
relatedRunId: (int) $run->getKey(),
|
||||
|
||||
@ -0,0 +1,35 @@
|
||||
# Specification Quality Checklist: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
**Purpose**: Validate specification completeness and quality before proceeding to planning
|
||||
**Created**: 2026-04-04
|
||||
**Feature**: [spec.md](../spec.md)
|
||||
|
||||
## Content Quality
|
||||
|
||||
- [x] No implementation details (languages, frameworks, APIs)
|
||||
- [x] Focused on user value and business needs
|
||||
- [x] Written for non-technical stakeholders
|
||||
- [x] All mandatory sections completed
|
||||
|
||||
## Requirement Completeness
|
||||
|
||||
- [x] No [NEEDS CLARIFICATION] markers remain
|
||||
- [x] Requirements are testable and unambiguous
|
||||
- [x] Success criteria are measurable
|
||||
- [x] Success criteria are technology-agnostic (no implementation details)
|
||||
- [x] All acceptance scenarios are defined
|
||||
- [x] Edge cases are identified
|
||||
- [x] Scope is clearly bounded
|
||||
- [x] Dependencies and assumptions identified
|
||||
|
||||
## Feature Readiness
|
||||
|
||||
- [x] All functional requirements have clear acceptance criteria
|
||||
- [x] User scenarios cover primary flows
|
||||
- [x] Feature meets measurable outcomes defined in Success Criteria
|
||||
- [x] No implementation details leak into specification
|
||||
|
||||
## Notes
|
||||
|
||||
- Required repo contract references such as routes, capabilities, and affected operator surfaces are included because this repository's spec format requires them; the requirements and outcomes themselves remain user-facing and do not prescribe code structure.
|
||||
- No clarification markers remain. The feature is ready for `/speckit.plan`.
|
||||
@ -0,0 +1,396 @@
|
||||
openapi: 3.1.0
|
||||
info:
|
||||
title: Evidence Review Trust Surfaces Contract
|
||||
version: 1.0.0
|
||||
description: >-
|
||||
Internal reference contract for the rendered HTML surfaces affected by Spec 174.
|
||||
These routes continue to return HTML through Filament and Livewire. The vendor
|
||||
media types below document the structured truth payloads that must be derivable
|
||||
before rendering. This is not a public API commitment.
|
||||
paths:
|
||||
/admin/evidence/overview:
|
||||
get:
|
||||
summary: Canonical evidence overview
|
||||
description: >-
|
||||
Returns the rendered evidence overview for entitled tenants in the current workspace.
|
||||
The vendor media type documents the derived row contract used to communicate
|
||||
artifact truth, freshness, and next steps.
|
||||
responses:
|
||||
'200':
|
||||
description: Rendered evidence overview page
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.evidence-overview+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/EvidenceOverviewPage'
|
||||
'404':
|
||||
description: Workspace context is missing or the viewer is not entitled to the relevant scope
|
||||
/admin/reviews:
|
||||
get:
|
||||
summary: Canonical review register
|
||||
description: >-
|
||||
Returns the rendered review register for entitled tenants in the current workspace.
|
||||
The vendor media type documents the row-level trust and publication contract.
|
||||
responses:
|
||||
'200':
|
||||
description: Rendered review register page
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.review-register+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/ReviewRegisterPage'
|
||||
'404':
|
||||
description: Workspace context is missing or the viewer is not entitled to the relevant scope
|
||||
/admin/t/{tenant}/evidence/{snapshot}:
|
||||
get:
|
||||
summary: Tenant-scoped evidence snapshot detail
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
- name: snapshot
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: integer
|
||||
responses:
|
||||
'200':
|
||||
description: Rendered evidence snapshot detail page
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.evidence-snapshot-detail+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/EvidenceSnapshotDetailPage'
|
||||
'403':
|
||||
description: Viewer is in tenant scope but lacks the required manage capability for actions
|
||||
'404':
|
||||
description: Snapshot is not visible because it does not exist or tenant entitlement is missing
|
||||
/admin/t/{tenant}/reviews/{review}:
|
||||
get:
|
||||
summary: Tenant-scoped review detail
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
- name: review
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: integer
|
||||
responses:
|
||||
'200':
|
||||
description: Rendered tenant review detail page
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.tenant-review-detail+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/TenantReviewDetailPage'
|
||||
'403':
|
||||
description: Viewer is in tenant scope but lacks the required manage capability for actions
|
||||
'404':
|
||||
description: Review is not visible because it does not exist or tenant entitlement is missing
|
||||
/admin/t/{tenant}/review-packs/{pack}:
|
||||
get:
|
||||
summary: Tenant-scoped review pack detail
|
||||
parameters:
|
||||
- name: tenant
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: string
|
||||
- name: pack
|
||||
in: path
|
||||
required: true
|
||||
schema:
|
||||
type: integer
|
||||
responses:
|
||||
'200':
|
||||
description: Rendered review pack detail page
|
||||
content:
|
||||
text/html:
|
||||
schema:
|
||||
type: string
|
||||
application/vnd.tenantpilot.review-pack-detail+json:
|
||||
schema:
|
||||
$ref: '#/components/schemas/ReviewPackDetailPage'
|
||||
'403':
|
||||
description: Viewer is in tenant scope but lacks the required manage capability for actions
|
||||
'404':
|
||||
description: Review pack is not visible because it does not exist or tenant entitlement is missing
|
||||
components:
|
||||
schemas:
|
||||
ArtifactTruthSummary:
|
||||
type: object
|
||||
required:
|
||||
- primaryLabel
|
||||
- contentState
|
||||
- freshnessState
|
||||
- actionability
|
||||
properties:
|
||||
primaryLabel:
|
||||
type: string
|
||||
primaryExplanation:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
contentState:
|
||||
type: string
|
||||
freshnessState:
|
||||
type: string
|
||||
enum:
|
||||
- current
|
||||
- stale
|
||||
- unknown
|
||||
publicationReadiness:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
enum:
|
||||
- publishable
|
||||
- internal_only
|
||||
- blocked
|
||||
actionability:
|
||||
type: string
|
||||
enum:
|
||||
- none
|
||||
- optional
|
||||
- required
|
||||
nextActionLabel:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
nextActionUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
diagnosticLabel:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
Badge:
|
||||
type: object
|
||||
required:
|
||||
- label
|
||||
properties:
|
||||
label:
|
||||
type: string
|
||||
color:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
icon:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
EvidenceOverviewRow:
|
||||
type: object
|
||||
required:
|
||||
- tenantName
|
||||
- tenantId
|
||||
- snapshotId
|
||||
- completenessState
|
||||
- artifactTruth
|
||||
- freshness
|
||||
- nextStep
|
||||
properties:
|
||||
tenantName:
|
||||
type: string
|
||||
tenantId:
|
||||
type: integer
|
||||
snapshotId:
|
||||
type: integer
|
||||
completenessState:
|
||||
type: string
|
||||
generatedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
missingDimensions:
|
||||
type: integer
|
||||
staleDimensions:
|
||||
type: integer
|
||||
artifactTruth:
|
||||
$ref: '#/components/schemas/ArtifactTruthSummary'
|
||||
freshness:
|
||||
$ref: '#/components/schemas/Badge'
|
||||
nextStep:
|
||||
type: string
|
||||
viewUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
ReviewRegisterRow:
|
||||
type: object
|
||||
required:
|
||||
- tenantName
|
||||
- tenantId
|
||||
- reviewId
|
||||
- status
|
||||
- completenessState
|
||||
- artifactTruth
|
||||
- publication
|
||||
- nextStep
|
||||
properties:
|
||||
tenantName:
|
||||
type: string
|
||||
tenantId:
|
||||
type: integer
|
||||
reviewId:
|
||||
type: integer
|
||||
status:
|
||||
type: string
|
||||
completenessState:
|
||||
type: string
|
||||
generatedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
publishedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
artifactTruth:
|
||||
$ref: '#/components/schemas/ArtifactTruthSummary'
|
||||
publication:
|
||||
$ref: '#/components/schemas/Badge'
|
||||
nextStep:
|
||||
type: string
|
||||
viewUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
EvidenceOverviewPage:
|
||||
type: object
|
||||
required:
|
||||
- rows
|
||||
properties:
|
||||
rows:
|
||||
type: array
|
||||
items:
|
||||
$ref: '#/components/schemas/EvidenceOverviewRow'
|
||||
ReviewRegisterPage:
|
||||
type: object
|
||||
required:
|
||||
- rows
|
||||
properties:
|
||||
rows:
|
||||
type: array
|
||||
items:
|
||||
$ref: '#/components/schemas/ReviewRegisterRow'
|
||||
EvidenceSnapshotDetailPage:
|
||||
type: object
|
||||
required:
|
||||
- recordId
|
||||
- tenantId
|
||||
- completenessState
|
||||
- artifactTruth
|
||||
properties:
|
||||
recordId:
|
||||
type: integer
|
||||
tenantId:
|
||||
type: integer
|
||||
status:
|
||||
type: string
|
||||
completenessState:
|
||||
type: string
|
||||
generatedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
artifactTruth:
|
||||
$ref: '#/components/schemas/ArtifactTruthSummary'
|
||||
linkedReviewUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
linkedRunUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
TenantReviewDetailPage:
|
||||
type: object
|
||||
required:
|
||||
- recordId
|
||||
- tenantId
|
||||
- status
|
||||
- completenessState
|
||||
- artifactTruth
|
||||
properties:
|
||||
recordId:
|
||||
type: integer
|
||||
tenantId:
|
||||
type: integer
|
||||
status:
|
||||
type: string
|
||||
completenessState:
|
||||
type: string
|
||||
generatedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
publishedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
artifactTruth:
|
||||
$ref: '#/components/schemas/ArtifactTruthSummary'
|
||||
linkedEvidenceUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
linkedPackUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
ReviewPackDetailPage:
|
||||
type: object
|
||||
required:
|
||||
- recordId
|
||||
- tenantId
|
||||
- status
|
||||
- artifactTruth
|
||||
properties:
|
||||
recordId:
|
||||
type: integer
|
||||
tenantId:
|
||||
type: integer
|
||||
status:
|
||||
type: string
|
||||
generatedAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
expiresAt:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
format: date-time
|
||||
artifactTruth:
|
||||
$ref: '#/components/schemas/ArtifactTruthSummary'
|
||||
linkedReviewUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
linkedEvidenceUrl:
|
||||
type:
|
||||
- string
|
||||
- 'null'
|
||||
268
specs/174-evidence-freshness-publication-trust/data-model.md
Normal file
268
specs/174-evidence-freshness-publication-trust/data-model.md
Normal file
@ -0,0 +1,268 @@
|
||||
# Data Model: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
## Overview
|
||||
|
||||
This feature does not add or modify persisted domain entities. It strengthens the derived trust-propagation model that transforms existing evidence, review, and pack records into operator-facing truth across tenant-scoped detail pages and canonical summary pages.
|
||||
|
||||
The key design constraint is that freshness and publication trust remain derived from existing fields and relationships:
|
||||
|
||||
- evidence-source freshness signals
|
||||
- evidence snapshot completeness and summary state
|
||||
- tenant review completeness and publish blockers
|
||||
- review pack linkage back to a source review and source evidence snapshot
|
||||
- the existing `ArtifactTruthEnvelope` dimensions
|
||||
|
||||
## Existing Persistent Entities
|
||||
|
||||
### 1. EvidenceSnapshot
|
||||
|
||||
- Purpose: Immutable tenant-scoped evidence basis assembled from multiple evidence dimensions.
|
||||
- Key persisted fields used by this feature:
|
||||
- `id`
|
||||
- `workspace_id`
|
||||
- `tenant_id`
|
||||
- `status`
|
||||
- `completeness_state`
|
||||
- `summary`
|
||||
- `generated_at`
|
||||
- `expires_at`
|
||||
- `operation_run_id`
|
||||
- `fingerprint`
|
||||
- Key summary fields used by this feature:
|
||||
- `dimension_count`
|
||||
- `missing_dimensions`
|
||||
- `stale_dimensions`
|
||||
- `dimensions[]`
|
||||
- `finding_count`
|
||||
- `report_count`
|
||||
- `operation_count`
|
||||
- Relationships used by this feature:
|
||||
- `items`
|
||||
- `tenantReviews`
|
||||
- `reviewPacks`
|
||||
- `operationRun`
|
||||
- `tenant`
|
||||
|
||||
### 2. EvidenceSnapshotItem
|
||||
|
||||
- Purpose: Dimension-level evidence record inside one snapshot.
|
||||
- Key persisted fields used by this feature:
|
||||
- `evidence_snapshot_id`
|
||||
- `tenant_id`
|
||||
- `dimension_key`
|
||||
- `state`
|
||||
- `required`
|
||||
- `measured_at`
|
||||
- `freshness_at`
|
||||
- `source_kind`
|
||||
- `source_record_type`
|
||||
- `source_record_id`
|
||||
- `summary_payload`
|
||||
- `sort_order`
|
||||
- Relationships used by this feature:
|
||||
- `snapshot`
|
||||
- `tenant`
|
||||
|
||||
### 3. TenantReview
|
||||
|
||||
- Purpose: Tenant-scoped review artifact anchored to one evidence snapshot.
|
||||
- Key persisted fields used by this feature:
|
||||
- `id`
|
||||
- `workspace_id`
|
||||
- `tenant_id`
|
||||
- `evidence_snapshot_id`
|
||||
- `status`
|
||||
- `completeness_state`
|
||||
- `summary`
|
||||
- `generated_at`
|
||||
- `published_at`
|
||||
- `archived_at`
|
||||
- `current_export_review_pack_id`
|
||||
- `operation_run_id`
|
||||
- `fingerprint`
|
||||
- Key summary fields used by this feature:
|
||||
- `publish_blockers[]`
|
||||
- `section_state_counts.complete`
|
||||
- `section_state_counts.partial`
|
||||
- `section_state_counts.missing`
|
||||
- `section_state_counts.stale`
|
||||
- `section_count`
|
||||
- `finding_count`
|
||||
- `report_count`
|
||||
- `operation_count`
|
||||
- Relationships used by this feature:
|
||||
- `evidenceSnapshot`
|
||||
- `sections`
|
||||
- `currentExportReviewPack`
|
||||
- `reviewPacks`
|
||||
- `operationRun`
|
||||
- `tenant`
|
||||
|
||||
### 4. ReviewPack
|
||||
|
||||
- Purpose: Tenant-scoped export artifact derived from a review and evidence basis.
|
||||
- Key persisted fields used by this feature:
|
||||
- `id`
|
||||
- `workspace_id`
|
||||
- `tenant_id`
|
||||
- `tenant_review_id`
|
||||
- `evidence_snapshot_id`
|
||||
- `status`
|
||||
- `summary`
|
||||
- `generated_at`
|
||||
- `expires_at`
|
||||
- `file_disk`
|
||||
- `file_path`
|
||||
- `file_size`
|
||||
- `operation_run_id`
|
||||
- `fingerprint`
|
||||
- Key summary fields used by this feature:
|
||||
- `review_status`
|
||||
- `review_completeness_state`
|
||||
- `evidence_resolution.outcome`
|
||||
- `evidence_resolution.snapshot_id`
|
||||
- `evidence_resolution.snapshot_fingerprint`
|
||||
- `evidence_resolution.completeness_state`
|
||||
- `finding_count`
|
||||
- `report_count`
|
||||
- `operation_count`
|
||||
- Relationships used by this feature:
|
||||
- `tenantReview`
|
||||
- `evidenceSnapshot`
|
||||
- `operationRun`
|
||||
- `tenant`
|
||||
|
||||
## Existing Derived State Chain
|
||||
|
||||
### A. Evidence Freshness Derivation
|
||||
|
||||
Evidence freshness is already determined in the evidence domain before any UI surface is rendered.
|
||||
|
||||
1. Each evidence source provider returns a dimension payload with:
|
||||
- `state`
|
||||
- `required`
|
||||
- `measured_at`
|
||||
- `freshness_at`
|
||||
2. `EvidenceCompletenessEvaluator` rolls required dimension states into snapshot completeness:
|
||||
- `missing` wins first
|
||||
- then `stale`
|
||||
- then `partial`
|
||||
- otherwise `complete`
|
||||
3. `EvidenceSnapshotService` persists:
|
||||
- `completeness_state`
|
||||
- `summary.missing_dimensions`
|
||||
- `summary.stale_dimensions`
|
||||
- per-dimension summary state
|
||||
|
||||
This feature must reuse that chain instead of replacing it.
|
||||
|
||||
### B. Review Readiness Derivation
|
||||
|
||||
Tenant review readiness is already derived from section completeness and blockers.
|
||||
|
||||
1. `TenantReviewSectionFactory` and related composition logic produce section completeness states.
|
||||
2. `TenantReviewReadinessGate` derives:
|
||||
- `blockersForSections()`
|
||||
- `completenessForSections()`
|
||||
- `statusForSections()`
|
||||
3. `TenantReview.summary` persists:
|
||||
- `publish_blockers[]`
|
||||
- `section_state_counts.*`
|
||||
|
||||
This feature must reuse those publish blockers and section-state counts rather than adding a parallel publish-readiness source.
|
||||
|
||||
## Derived View Models
|
||||
|
||||
### 1. ArtifactTruthPropagationModel
|
||||
|
||||
This is the conceptual chain, not a new class.
|
||||
|
||||
| Stage | Inputs | Derived outputs |
|
||||
|---|---|---|
|
||||
| Evidence source item | source-specific timestamps and source-record state | per-dimension `state`, `freshness_at`, `required` |
|
||||
| Evidence snapshot | item states, snapshot status, summary counts | `artifactExistence`, `contentState`, `freshnessState`, `actionability` |
|
||||
| Tenant review | review status, review completeness, section-state counts, publish blockers, linked snapshot | `artifactExistence`, `contentState`, `freshnessState`, `publicationReadiness`, `actionability` |
|
||||
| Review pack | pack status, evidence resolution, linked review trust burden, linked snapshot burden | `artifactExistence`, `contentState`, `freshnessState`, `publicationReadiness`, `actionability` |
|
||||
| Canonical summary row | tenant label, record timestamps, derived artifact truth envelope | row-level artifact truth, publication signal, freshness signal, next step |
|
||||
|
||||
### 2. SnapshotTruthModel
|
||||
|
||||
Derived from `EvidenceSnapshot` plus `ArtifactTruthPresenter::buildEvidenceSnapshotEnvelope()`.
|
||||
|
||||
| Field | Meaning | Source |
|
||||
|---|---|---|
|
||||
| `artifactExistence` | whether a current or historical snapshot exists | snapshot `status` |
|
||||
| `contentState` | whether the evidence basis is trusted, partial, missing, or empty | snapshot `completeness_state`, `summary.dimension_count` |
|
||||
| `freshnessState` | whether the evidence basis is current or stale | snapshot `completeness_state`, `summary.stale_dimensions`, historical status |
|
||||
| `actionability` | whether the operator must act, may optionally act, or can do nothing | derived from freshness and completeness |
|
||||
| `nextStepText` | operator-facing refresh or wait guidance | existing presenter logic |
|
||||
|
||||
### 3. ReviewTruthModel
|
||||
|
||||
Derived from `TenantReview` plus `ArtifactTruthPresenter::buildTenantReviewEnvelope()`.
|
||||
|
||||
| Field | Meaning | Source |
|
||||
|---|---|---|
|
||||
| `artifactExistence` | whether the review is current, failed, or historical | review status |
|
||||
| `contentState` | whether the review body is complete enough or partial | review completeness |
|
||||
| `freshnessState` | whether the review evidence basis is stale | review completeness and `summary.section_state_counts.stale` |
|
||||
| `publicationReadiness` | whether the review is blocked, internal-only, or publishable | review status, publish blockers, and this feature's stricter freshness/partiality propagation |
|
||||
| `actionability` | whether the operator must resolve blockers, should refresh, or can leave the review alone | derived from publication and freshness burden |
|
||||
| `nextStepText` | resolve blockers, complete work, refresh evidence, or no action needed | existing presenter logic tightened by this feature |
|
||||
|
||||
### 4. PackTruthModel
|
||||
|
||||
Derived from `ReviewPack` plus `ArtifactTruthPresenter::buildReviewPackEnvelope()`.
|
||||
|
||||
| Field | Meaning | Source |
|
||||
|---|---|---|
|
||||
| `artifactExistence` | whether a current, failed, or historical pack exists | pack status |
|
||||
| `contentState` | whether the pack has a trustworthy source basis | evidence resolution and source review burden |
|
||||
| `freshnessState` | whether the pack should be treated as current or stale for operator trust | pack expiration plus propagated source review/evidence staleness |
|
||||
| `publicationReadiness` | whether the pack is blocked, internal-only, or publishable | pack status plus propagated review and evidence burden |
|
||||
| `actionability` | whether the operator must revisit the review or simply note caution | derived from the trust posture |
|
||||
| `nextStepText` | open source review, refresh evidence, or no action needed | existing presenter logic tightened by this feature |
|
||||
|
||||
### 5. CanonicalSummaryRowModel
|
||||
|
||||
Used conceptually by both `EvidenceOverview` and `ReviewRegister`.
|
||||
|
||||
| Field | Type | Purpose |
|
||||
|---|---|---|
|
||||
| `tenantName` | string | Maintain tenant context in canonical pages |
|
||||
| `recordId` | int | Link the summary row back to the tenant-scoped detail page |
|
||||
| `artifactTruth` | label + badge spec + explanation | Primary trust summary shown in the row |
|
||||
| `freshness` | badge spec | Evidence overview freshness summary |
|
||||
| `publication` | badge spec | Review register publication summary |
|
||||
| `nextStep` | string | Operator-facing follow-up guidance that matches detail surfaces |
|
||||
| `viewUrl` | string | Drill-through to the tenant-scoped detail page |
|
||||
|
||||
Rules:
|
||||
|
||||
- Canonical rows must never appear calmer than the corresponding detail pages.
|
||||
- `nextStep` may be shorter than detail guidance, but not contradictory.
|
||||
- Canonical rows must stay derived from the same truth envelope rather than page-local heuristics.
|
||||
|
||||
## Validation Rules
|
||||
|
||||
- A snapshot can be structurally complete and still stale; the derived truth must preserve that distinction.
|
||||
- A review can be internally useful while not being publishable; the derived truth must preserve that distinction.
|
||||
- A pack must not be calmer than its source review or source evidence basis.
|
||||
- Canonical overview and register rows must not contradict the tenant-scoped detail view for the same artifact.
|
||||
- Freshness, completeness, and publication readiness remain separate dimensions even when they jointly influence the primary label.
|
||||
|
||||
## State Notes
|
||||
|
||||
This feature introduces no new persisted state.
|
||||
|
||||
Existing state and badge families that remain canonical:
|
||||
|
||||
- `EvidenceCompletenessState`
|
||||
- `EvidenceSnapshotStatus`
|
||||
- `TenantReviewCompletenessState`
|
||||
- `TenantReviewStatus`
|
||||
- `ReviewPackStatus`
|
||||
- `BadgeDomain::GovernanceArtifactFreshness`
|
||||
- `BadgeDomain::GovernanceArtifactPublicationReadiness`
|
||||
|
||||
The feature only changes how these existing states combine into operator-facing trust across multiple related surfaces.
|
||||
294
specs/174-evidence-freshness-publication-trust/plan.md
Normal file
294
specs/174-evidence-freshness-publication-trust/plan.md
Normal file
@ -0,0 +1,294 @@
|
||||
# Implementation Plan: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
**Branch**: `174-evidence-freshness-publication-trust` | **Date**: 2026-04-04 | **Spec**: `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/174-evidence-freshness-publication-trust/spec.md`
|
||||
**Input**: Feature specification from `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/174-evidence-freshness-publication-trust/spec.md`
|
||||
|
||||
## Summary
|
||||
|
||||
Harden evidence freshness and publication trust across the existing evidence snapshot, tenant review, review pack, evidence overview, and canonical review register surfaces without adding new persistence, a new trust layer, or a new reporting subsystem. The implementation will reuse the source-derived stale semantics and their existing source-defined freshness thresholds, tighten propagation in `ArtifactTruthPresenter`, keep review readiness and publication readiness distinct, preserve the current tenant and canonical routes and action inventory, and close the existing cross-surface gap where stale or partial evidence can still look publishable.
|
||||
|
||||
Key approach: keep the work inside the current `EvidenceSnapshotService` freshness semantics, `TenantReviewReadinessGate`, `ArtifactTruthPresenter`, tenant-scoped Filament resources, and canonical summary pages. The slice is primarily about better derivation and consistent display, not about new models or new workflows.
|
||||
|
||||
## Technical Context
|
||||
|
||||
**Language/Version**: PHP 8.4, Laravel 12, Filament v5, Livewire v4, Blade
|
||||
**Primary Dependencies**: Filament v5, Livewire v4, Pest v4, Laravel Sail, existing `ArtifactTruthPresenter`, `ArtifactTruthEnvelope`, `TenantReviewReadinessGate`, `EvidenceSnapshotService`, `TenantReviewRegisterService`, and current evidence/review/review-pack resources and pages
|
||||
**Storage**: PostgreSQL with existing `evidence_snapshots`, `evidence_snapshot_items`, `tenant_reviews`, and `review_packs` tables using current summary JSON and timestamps; no schema change planned
|
||||
**Testing**: Pest feature tests and Livewire page tests run via Sail, plus existing governance-artifact fixture helpers
|
||||
**Target Platform**: Laravel web application in Sail locally and containerized Linux deployment in staging and production
|
||||
**Project Type**: Laravel monolith web application
|
||||
**Performance Goals**: Preserve DB-only render behavior on detail and canonical surfaces, avoid any render-time external calls, keep list-row truth derivation lightweight enough for canonical table scans, and keep operator trust signals readable within a 5-10 second scan on summary surfaces
|
||||
**Constraints**: No new tables, no new enum families, no new presenter or resolver subsystem, no route changes, no RBAC drift, no destructive-action placement drift, no global asset changes, and no new global freshness engine if existing source-derived stale semantics are sufficient
|
||||
**Scale/Scope**: Five operator-facing surfaces (`/admin/evidence/overview`, `/admin/reviews`, `/admin/t/{tenant}/evidence/{snapshot}`, `/admin/t/{tenant}/reviews/{review}`, `/admin/t/{tenant}/review-packs/{pack}`), one central truth presenter, existing readiness helpers, and focused regression coverage across fresh, stale, partial, blocked, internal-only, and publishable scenarios
|
||||
|
||||
## Constitution Check
|
||||
|
||||
*GATE: Passed before Phase 0 research. Re-checked after Phase 1 design and still passing.*
|
||||
|
||||
| Principle | Status | Notes |
|
||||
|-----------|--------|-------|
|
||||
| Inventory-first | Pass | Evidence freshness remains derived from the existing snapshot-item and source-evaluation chain; no new snapshot ownership semantics |
|
||||
| Read/write separation | Pass | This slice primarily changes truth derivation and display; existing mutate actions remain unchanged |
|
||||
| Graph contract path | Pass | No new Graph calls or contract-registry changes are introduced |
|
||||
| Deterministic capabilities | Pass | No new capability derivation or role mapping is added |
|
||||
| RBAC-UX planes and 404 vs 403 | Pass | Tenant-scoped resources remain tenant-scoped; canonical `/admin` pages stay workspace- and tenant-entitlement-safe |
|
||||
| Workspace isolation | Pass | Canonical summary pages continue to derive rows only from entitled tenants in the current workspace |
|
||||
| Tenant isolation | Pass | Drill-through links remain tenant-scoped and non-entitled users remain deny-as-not-found |
|
||||
| Destructive confirmation | Pass | Existing destructive actions (`Expire snapshot`, `Archive review`, `Expire pack`) already require confirmation and remain unchanged |
|
||||
| Global search safety | Pass | No global-search behavior is added or broadened; `EvidenceSnapshotResource`, `TenantReviewResource`, and `ReviewPackResource` already have view pages |
|
||||
| Run observability | Pass | Existing evidence, review, and pack generation flows keep their current `OperationRun` types and ownership; no new run type is introduced |
|
||||
| Ops-UX 3-surface feedback | Pass | No toast, progress, or terminal-notification behavior changes |
|
||||
| Ops-UX lifecycle ownership | Pass | No `OperationRun.status` or `outcome` transition logic is touched |
|
||||
| Ops-UX summary counts | Pass | No changes to `summary_counts` contracts are required |
|
||||
| Ops-UX guards | Pass | Existing operation lifecycle guards stay in place; this feature adds truth-surface regression tests instead |
|
||||
| Data minimization | Pass | No new payload exposure or raw-report surface is introduced |
|
||||
| Proportionality (PROP-001) | Pass | The implementation stays inside existing freshness, readiness, and truth layers rather than adding persistence or abstraction |
|
||||
| No premature abstraction (ABSTR-001) | Pass | No new resolver, gate, presenter family, registry, or taxonomy is planned |
|
||||
| Persisted truth (PERSIST-001) | Pass | All new semantics remain derived from existing timestamps, summary state, and linked records |
|
||||
| Behavioral state (STATE-001) | Pass | No new persisted states are introduced; existing stale/partial/publishable/internal-only semantics become stricter |
|
||||
| UI semantics (UI-SEM-001) | Pass | Existing badge and truth primitives are reused; no second interpretation framework is introduced |
|
||||
| V1 explicitness / few layers (V1-EXP-001, LAYER-001) | Pass | One central presenter and existing pages remain the implementation seam |
|
||||
| Badge semantics (BADGE-001) | Pass | Existing freshness, completeness, publication-readiness, and artifact-truth badge domains stay canonical |
|
||||
| Filament-native UI (UI-FIL-001) | Pass | Existing Filament resources, pages, badges, tables, and infolists are reused; no page-local status language is added |
|
||||
| UI/UX surface taxonomy (UI-CONST-001 / UI-SURF-001) | Pass | Evidence snapshot, tenant review, and review pack remain `CRUD / List-first Resource` surfaces with dedicated detail pages, while evidence overview and review register remain `Read-only Registry / Report Surface` surfaces |
|
||||
| UI/UX inspect model (UI-HARD-001) | Pass | Clickable-row inspect remains primary on the affected lists; no redundant view action is introduced |
|
||||
| UI/UX action hierarchy (UI-HARD-001 / UI-EX-001) | Pass | Existing one-inline-safe-shortcut patterns remain; no new row-level destructive actions are added |
|
||||
| UI/UX scope, truth, and naming (UI-HARD-001 / UI-NAMING-001 / OPSURF-001) | Pass | The feature strengthens default-visible trust truth while preserving canonical nouns and existing verbs |
|
||||
| List-surface review checklist (UI-STD-001) | Pass | The affected list and report surfaces will be reviewed against `docs/product/standards/list-surface-review-checklist.md` during implementation and final verification |
|
||||
| Filament Action Surface Contract | Pass | Current surface declarations already match the required list/detail behavior; the feature changes truth semantics, not action topology |
|
||||
| Filament UX-001 | Pass | Existing Infolist and table layouts remain; this slice strengthens the truth surfaces inside them |
|
||||
| Filament v5 / Livewire v4 compliance | Pass | The work remains inside the current Filament v5 + Livewire v4 stack |
|
||||
| Provider registration location | Pass | No panel/provider changes; Laravel 11+ provider registration remains in `bootstrap/providers.php` |
|
||||
| Asset strategy | Pass | No new panel or shared assets are required; deployment `filament:assets` behavior remains unchanged |
|
||||
|
||||
## Phase 0 Research
|
||||
|
||||
Research outcomes are captured in `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/174-evidence-freshness-publication-trust/research.md`.
|
||||
|
||||
Key decisions:
|
||||
|
||||
- Reuse the existing source-derived stale semantics from evidence providers and `EvidenceCompletenessEvaluator` instead of creating a new global freshness engine.
|
||||
- Tighten `ArtifactTruthPresenter` rather than introducing a new publication-trust resolver or freshness-trust gate.
|
||||
- Degrade tenant review and review pack publication trust when freshness is stale and downgrade partial evidence to `internal_only` unless stronger existing blockers already make the artifact `blocked`.
|
||||
- Make review packs inherit stale and partial burden from their linked review and evidence basis instead of treating pack freshness as `current` whenever the file itself is not expired.
|
||||
- Keep canonical register and overview surfaces aligned by reusing the same truth envelope and next-step language rather than adding page-local taxonomies or ad-hoc columns.
|
||||
- Expand existing Pest coverage and fixture builders rather than creating a new UI test harness.
|
||||
|
||||
## Phase 1 Design
|
||||
|
||||
Design artifacts are created under `/Users/ahmeddarrazi/Documents/projects/TenantAtlas/specs/174-evidence-freshness-publication-trust/`:
|
||||
|
||||
- `data-model.md`: derived trust-propagation model for evidence snapshots, tenant reviews, review packs, and canonical summary rows
|
||||
- `contracts/evidence-review-trust-surfaces.openapi.yaml`: internal page-contract schema for the affected rendered HTML surfaces and their structured truth payloads
|
||||
- `quickstart.md`: focused verification workflow for manual and automated validation
|
||||
|
||||
Design decisions:
|
||||
|
||||
- No schema migration is required; freshness remains derived from existing evidence-source timestamps and summary state.
|
||||
- The primary implementation seam is `ArtifactTruthPresenter`, supported by the current evidence and review readiness services and existing page row builders.
|
||||
- `TenantReviewReadinessGate` remains the publish-blocker authority for required stale or missing sections; this feature tightens how that burden is translated into operator-facing trust and publication surfaces.
|
||||
- `EvidenceOverview` and `ReviewRegister` continue to render read-only summary rows, but must no longer sound calmer than the corresponding tenant-scoped detail surfaces.
|
||||
- Existing destructive actions and capabilities remain unchanged; only truth presentation, next-step guidance, and consistency rules are hardened.
|
||||
|
||||
## Project Structure
|
||||
|
||||
### Documentation (this feature)
|
||||
|
||||
```text
|
||||
specs/174-evidence-freshness-publication-trust/
|
||||
├── spec.md
|
||||
├── plan.md
|
||||
├── research.md
|
||||
├── data-model.md
|
||||
├── quickstart.md
|
||||
├── contracts/
|
||||
│ └── evidence-review-trust-surfaces.openapi.yaml
|
||||
├── checklists/
|
||||
│ └── requirements.md
|
||||
└── tasks.md
|
||||
```
|
||||
|
||||
### Source Code (repository root)
|
||||
|
||||
```text
|
||||
app/
|
||||
├── Filament/
|
||||
│ ├── Pages/
|
||||
│ │ ├── Monitoring/
|
||||
│ │ │ └── EvidenceOverview.php
|
||||
│ │ └── Reviews/
|
||||
│ │ └── ReviewRegister.php
|
||||
│ └── Resources/
|
||||
│ ├── EvidenceSnapshotResource.php
|
||||
│ ├── ReviewPackResource.php
|
||||
│ ├── TenantReviewResource.php
|
||||
│ ├── EvidenceSnapshotResource/
|
||||
│ │ └── Pages/
|
||||
│ │ └── ViewEvidenceSnapshot.php
|
||||
│ ├── ReviewPackResource/
|
||||
│ │ └── Pages/
|
||||
│ │ └── ViewReviewPack.php
|
||||
│ └── TenantReviewResource/
|
||||
│ └── Pages/
|
||||
│ └── ViewTenantReview.php
|
||||
├── Models/
|
||||
│ ├── EvidenceSnapshot.php
|
||||
│ ├── EvidenceSnapshotItem.php
|
||||
│ ├── ReviewPack.php
|
||||
│ └── TenantReview.php
|
||||
├── Services/
|
||||
│ ├── Evidence/
|
||||
│ │ ├── EvidenceCompletenessEvaluator.php
|
||||
│ │ ├── EvidenceSnapshotService.php
|
||||
│ │ └── Sources/
|
||||
│ │ ├── BaselineDriftPostureSource.php
|
||||
│ │ ├── EntraAdminRolesSource.php
|
||||
│ │ ├── FindingsSummarySource.php
|
||||
│ │ ├── OperationsSummarySource.php
|
||||
│ │ └── PermissionPostureSource.php
|
||||
│ └── TenantReviews/
|
||||
│ ├── TenantReviewReadinessGate.php
|
||||
│ └── TenantReviewRegisterService.php
|
||||
└── Support/
|
||||
└── Ui/
|
||||
└── GovernanceArtifactTruth/
|
||||
├── ArtifactTruthEnvelope.php
|
||||
└── ArtifactTruthPresenter.php
|
||||
|
||||
resources/
|
||||
└── views/
|
||||
└── filament/
|
||||
├── infolists/
|
||||
│ └── entries/
|
||||
│ └── governance-artifact-truth.blade.php
|
||||
└── pages/
|
||||
├── monitoring/
|
||||
│ └── evidence-overview.blade.php
|
||||
└── reviews/
|
||||
└── review-register.blade.php
|
||||
|
||||
routes/
|
||||
└── web.php
|
||||
|
||||
tests/
|
||||
├── Feature/
|
||||
│ ├── Concerns/
|
||||
│ │ └── BuildsGovernanceArtifactTruthFixtures.php
|
||||
│ ├── Evidence/
|
||||
│ │ ├── EvidenceOverviewPageTest.php
|
||||
│ │ └── EvidenceSnapshotResourceTest.php
|
||||
│ ├── Monitoring/
|
||||
│ │ └── ArtifactTruthRunDetailTest.php
|
||||
│ ├── ReviewPack/
|
||||
│ │ └── ReviewPackResourceTest.php
|
||||
│ └── TenantReview/
|
||||
│ ├── TenantReviewLifecycleTest.php
|
||||
│ └── TenantReviewRegisterTest.php
|
||||
└── Pest.php
|
||||
```
|
||||
|
||||
**Structure Decision**: Standard Laravel monolith. The change is concentrated in one existing truth-presenter seam, current readiness helpers, a small set of existing Filament resources/pages, and focused Pest coverage. No new base directories, services, or presentation frameworks are required.
|
||||
|
||||
## Implementation Strategy
|
||||
|
||||
### Phase A — Preserve Source-Derived Freshness As The Canonical Input
|
||||
|
||||
**Goal**: Keep existing provider-level stale semantics as the source of truth and document them clearly in the implementation so the feature does not accidentally invent a second freshness system.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| A.1 | `app/Services/Evidence/EvidenceCompletenessEvaluator.php` | Confirm that source-level `stale` evaluation and snapshot completeness remain the canonical freshness input used by the UI truth layer |
|
||||
| A.2 | `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` | Keep evidence-snapshot truth derived from snapshot status, completeness, and `summary.stale_dimensions` rather than introducing new page-local age logic |
|
||||
| A.3 | `specs/174-evidence-freshness-publication-trust/research.md` and `data-model.md` | Record the source-derived freshness chain so implementation does not drift into a new threshold engine |
|
||||
|
||||
### Phase B — Downgrade Tenant Review Publication Trust When Freshness Or Completeness Weakens Confidence
|
||||
|
||||
**Goal**: Ensure tenant reviews can remain useful internally while no longer appearing publishable when their evidence basis is stale or partial.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| B.1 | `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` | Tighten `buildTenantReviewEnvelope()` so stale freshness and partial evidence degrade publication readiness and next-step guidance appropriately |
|
||||
| B.2 | `app/Services/TenantReviews/TenantReviewReadinessGate.php` | Reuse existing required-section stale and missing blocker semantics; do not create a second publish-blocker system |
|
||||
| B.3 | `app/Filament/Resources/TenantReviewResource.php` and `app/Filament/Resources/TenantReviewResource/Pages/ViewTenantReview.php` | Verify the tightened truth envelope is visible on list and detail surfaces without changing action topology or copy vocabulary |
|
||||
|
||||
### Phase C — Propagate Source Review And Evidence Burden Into Review Pack Trust
|
||||
|
||||
**Goal**: Prevent review packs from appearing calmer than the review or evidence basis they were generated from.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| C.1 | `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` | Tighten `buildReviewPackEnvelope()` so pack freshness and publication readiness inherit stale or partial burden from the source review and evidence resolution |
|
||||
| C.2 | `app/Filament/Resources/ReviewPackResource.php` and `app/Filament/Resources/ReviewPackResource/Pages/ViewReviewPack.php` | Ensure pack list/detail surfaces expose internal-only or cautionary trust and next-step caveats before download or sharing |
|
||||
| C.3 | `resources/views/filament/infolists/entries/governance-artifact-truth.blade.php` | Reuse the existing truth partial to surface freshness and publication dimensions with stronger consistency rather than new local markup |
|
||||
|
||||
### Phase D — Align Canonical Overview And Register Rows With Tenant-Scoped Detail Truth
|
||||
|
||||
**Goal**: Ensure `/admin/evidence/overview` and `/admin/reviews` summarize the same truth direction as the tenant-scoped detail pages.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| D.1 | `app/Filament/Pages/Monitoring/EvidenceOverview.php` | Keep row truth and next-step guidance sourced from the same envelope semantics used by snapshot detail |
|
||||
| D.2 | `app/Filament/Pages/Reviews/ReviewRegister.php` | Keep artifact truth, publication readiness, and next-step rows aligned with tenant review detail without adding new ad-hoc row taxonomy |
|
||||
| D.3 | `routes/web.php` and current navigation helpers | Preserve existing canonical route shape and tenant-prefilter continuity; no routing change |
|
||||
|
||||
### Phase E — Regression Protection And Focused Validation
|
||||
|
||||
**Goal**: Add the smallest useful test set that protects stale propagation, partial-evidence trust, review/pack consistency, and canonical summary alignment.
|
||||
|
||||
| Step | File | Change |
|
||||
|------|------|--------|
|
||||
| E.1 | `tests/Feature/Concerns/BuildsGovernanceArtifactTruthFixtures.php` | Add fixture helpers for stale and partial evidence scenarios so tests do not duplicate setup logic |
|
||||
| E.2 | `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php` | Add fresh-vs-stale snapshot truth assertions, including stale-dimension next-step behavior |
|
||||
| E.3 | `tests/Feature/TenantReview/TenantReviewLifecycleTest.php` | Add stale and partial review publication-trust assertions without changing lifecycle behavior |
|
||||
| E.4 | `tests/Feature/ReviewPack/ReviewPackResourceTest.php` | Add pack trust propagation assertions for stale or partial source review/evidence combinations |
|
||||
| E.5 | `tests/Feature/TenantReview/TenantReviewRegisterTest.php` and `tests/Feature/Evidence/EvidenceOverviewPageTest.php` | Add canonical row-alignment assertions so summary pages do not sound calmer than detail |
|
||||
| E.6 | `vendor/bin/sail bin pint --dirty --format agent` and focused Pest runs | Required formatting and targeted verification before task completion |
|
||||
|
||||
## Key Design Decisions
|
||||
|
||||
### D-001 — Source-specific stale evaluation stays canonical
|
||||
|
||||
Evidence sources already produce `stale` item states using their own domain-appropriate recency logic, and `EvidenceCompletenessEvaluator` already rolls those into snapshot completeness. The plan reuses that chain instead of inventing a separate global age-policy system.
|
||||
|
||||
### D-002 — `ArtifactTruthPresenter` remains the single trust-propagation seam
|
||||
|
||||
The current code already centralizes evidence snapshot, tenant review, and review pack trust in one presenter. Tightening that presenter is narrower and safer than introducing a new publication-trust resolver or freshness framework.
|
||||
|
||||
### D-003 — Publication readiness remains distinct from freshness and completeness
|
||||
|
||||
The feature must not collapse all trust dimensions into one vague `ready` state. Freshness, completeness, and publication readiness remain separate dimensions, but stale evidence downgrades share safety and partial evidence downgrades publication readiness to `internal_only` unless existing blockers already make the artifact `blocked`.
|
||||
|
||||
### D-004 — Canonical summary pages must reuse existing truth, not invent row-local semantics
|
||||
|
||||
`EvidenceOverview` and `ReviewRegister` already surface artifact truth, publication, and next-step information. The right fix is to align their inputs with the tightened truth envelope, not to add page-specific badges or prose.
|
||||
|
||||
### D-005 — No new persistence or reporting subsystem is justified
|
||||
|
||||
This is a current-release operator-trust problem, but it is still a derived-truth problem. Existing timestamps, summary state, and linked artifacts are enough to solve it without a StoredReport viewer, new export-governance model, or separate publication-trust entity.
|
||||
|
||||
## Risk Assessment
|
||||
|
||||
| Risk | Impact | Likelihood | Mitigation |
|
||||
|------|--------|------------|------------|
|
||||
| Review publication trust becomes too strict and downgrades healthy reviews | Medium | Medium | Base downgrades on existing stale/partial semantics already produced by evidence and review services rather than a new heuristic |
|
||||
| Review pack truth diverges from review truth because pack code and review code evolve separately | High | Medium | Centralize propagation in `ArtifactTruthPresenter` and add explicit review-vs-pack consistency tests |
|
||||
| Canonical summary pages become denser or harder to scan | Medium | Low | Reuse existing columns and next-step fields instead of adding more row furniture |
|
||||
| `fresh` versus non-`fresh` envelope variants diverge across surfaces | Medium | Low | Keep one truth-building path and only use `fresh` variants when cache bypass is genuinely needed |
|
||||
| Implementation accidentally introduces a new freshness policy or new abstraction | Medium | Low | Lock the design to current source-derived stale semantics and reject new persistence or resolver additions in review |
|
||||
|
||||
## Test Strategy
|
||||
|
||||
- Extend the current evidence, tenant review, review pack, and canonical summary Pest tests instead of adding a new testing layer.
|
||||
- Use `BuildsGovernanceArtifactTruthFixtures` and existing `composeTenantReviewForTest()` helpers to build fresh, stale, and partial scenarios consistently.
|
||||
- Add explicit assertions for fresh versus stale evidence snapshots, partial versus complete review evidence, review-pack versus review trust alignment, and canonical row truth alignment.
|
||||
- Preserve existing authorization semantics: non-entitled users remain `404`, in-scope users without manage capability remain `403` for actions, and summary truth remains visible only within entitled scope.
|
||||
- Keep destructive actions and operation-launch semantics unchanged; test additions should focus on trust consequences, not on unrelated lifecycle behavior.
|
||||
- Focused verification targets: `EvidenceSnapshotResourceTest`, `TenantReviewLifecycleTest`, `ReviewPackResourceTest`, `TenantReviewRegisterTest`, `EvidenceOverviewPageTest`, and fixture helpers.
|
||||
|
||||
## Complexity Tracking
|
||||
|
||||
No constitution violations or justified complexity exceptions were identified.
|
||||
|
||||
## Proportionality Review
|
||||
|
||||
Not triggered beyond the already-passed spec review. The plan introduces no new enum/status family, DTO/presenter family, persisted entity, registry, resolver, taxonomy, or cross-domain UI framework.
|
||||
141
specs/174-evidence-freshness-publication-trust/quickstart.md
Normal file
141
specs/174-evidence-freshness-publication-trust/quickstart.md
Normal file
@ -0,0 +1,141 @@
|
||||
# Quickstart: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
## Goal
|
||||
|
||||
Validate that stale and partial evidence now degrade review and pack trust consistently across tenant-scoped detail pages and canonical summary pages, without changing routes, authorization semantics, or the current action inventory.
|
||||
|
||||
## Prerequisites
|
||||
|
||||
1. Start Sail if it is not already running.
|
||||
2. Ensure the acting user is a valid workspace member and entitled to the target tenant or tenants.
|
||||
3. Prepare representative fixtures for these cases:
|
||||
- fresh and complete evidence snapshot
|
||||
- stale evidence snapshot
|
||||
- partial evidence snapshot or review with partial sections
|
||||
- review with publication blockers
|
||||
- ready review pack derived from a fresh review
|
||||
- ready review pack derived from a stale or partial review
|
||||
|
||||
## Focused Automated Verification
|
||||
|
||||
Run the smallest existing test set that guards the affected surfaces first:
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Evidence/EvidenceSnapshotResourceTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewLifecycleTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/ReviewPack/ReviewPackResourceTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewRegisterTest.php
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Evidence/EvidenceOverviewPageTest.php
|
||||
```
|
||||
|
||||
If implementation extends shared truth helpers or run-detail truth copy, also run:
|
||||
|
||||
```bash
|
||||
vendor/bin/sail artisan test --compact tests/Feature/Monitoring/ArtifactTruthRunDetailTest.php
|
||||
```
|
||||
|
||||
## Manual Validation Pass
|
||||
|
||||
Use one fresh tenant and one stale or partial tenant, or equivalent seeded records in the same tenant.
|
||||
|
||||
### 1. Evidence snapshot detail trust
|
||||
|
||||
Open the tenant-scoped evidence snapshot detail page for a fresh snapshot and a stale snapshot.
|
||||
|
||||
Confirm that:
|
||||
|
||||
- both snapshots can still exist structurally,
|
||||
- the stale snapshot is clearly shown as stale or cautionary,
|
||||
- the fresh snapshot remains current,
|
||||
- next-step guidance differs appropriately,
|
||||
- and no raw JSON is required to understand why the stale snapshot is less trustworthy.
|
||||
|
||||
### 2. Review detail trust
|
||||
|
||||
Open tenant reviews anchored to:
|
||||
|
||||
- fresh complete evidence,
|
||||
- stale evidence,
|
||||
- partial evidence.
|
||||
|
||||
Confirm that:
|
||||
|
||||
- review freshness and publication readiness remain separate concepts,
|
||||
- stale or partial reviews can still be useful internally,
|
||||
- but they do not present the same calm publishable posture as fresh complete reviews,
|
||||
- and next-step guidance points toward refresh or completion work when needed.
|
||||
|
||||
### 3. Review pack trust
|
||||
|
||||
Open the review pack list and review packs linked to the reviews above.
|
||||
|
||||
Confirm that:
|
||||
|
||||
- the review-pack list row already surfaces the same internal-only or publishable caveat before the operator opens detail or clicks `Download`,
|
||||
- a pack generated from stale or partial evidence no longer looks calmer than the source review,
|
||||
- any internal-only or cautionary posture is visible before download,
|
||||
- and the pack points back to the source review when corrective action is needed.
|
||||
|
||||
### 4. Canonical summary alignment
|
||||
|
||||
Open:
|
||||
|
||||
- `/admin/evidence/overview`
|
||||
- `/admin/reviews`
|
||||
|
||||
Confirm that:
|
||||
|
||||
- stale or partial artifacts are visible as such in the row summaries,
|
||||
- the next-step language is directionally the same as on detail pages,
|
||||
- a tenant with fresh evidence but no current review shows a next step that points toward review creation rather than implying review readiness already exists,
|
||||
- and drill-through links preserve tenant context and do not reveal non-entitled tenants.
|
||||
|
||||
### 5. Ten-second scan validation
|
||||
|
||||
Timebox the first visible scan of one snapshot detail page, one tenant review detail page, and one review pack detail page to 10 seconds each.
|
||||
|
||||
Confirm that within that time an operator can tell:
|
||||
|
||||
- whether the artifact is fresh enough,
|
||||
- whether it is only internally useful or publishable,
|
||||
- and what the next action is.
|
||||
|
||||
### 6. Authorization and action non-regression
|
||||
|
||||
Confirm that:
|
||||
|
||||
- view-only users can still inspect truth but not execute manage actions,
|
||||
- non-entitled users still receive deny-as-not-found behavior,
|
||||
- existing destructive actions still require confirmation,
|
||||
- touched refresh, publish, export, regenerate, or create-next-review handlers still dispatch the existing services and current `OperationRun` types where applicable,
|
||||
- and no new actions or route changes were introduced as part of the hardening.
|
||||
|
||||
### 7. Shared list-surface review checklist
|
||||
|
||||
Review `docs/product/standards/list-surface-review-checklist.md` against the touched list and report surfaces.
|
||||
|
||||
Confirm that:
|
||||
|
||||
- `/admin/evidence/overview` and `/admin/reviews` still use row click as the primary inspect model,
|
||||
- the tenant-scoped review-pack list keeps its row-level trust caveat visible before drill-through or download,
|
||||
- existing inline safe shortcuts and header actions remain in their established positions,
|
||||
- empty and filtered states still read clearly without hiding trust truth,
|
||||
- and default-visible row summaries still surface freshness, publishable posture, and next step without requiring drill-through.
|
||||
|
||||
### 8. Performance and render guardrails
|
||||
|
||||
Confirm from the implementation diff and final surface behavior that:
|
||||
|
||||
- the touched detail and canonical surfaces still render from existing database-backed truth inputs,
|
||||
- no new render-time external calls, background dispatches, or route changes were introduced,
|
||||
- and canonical row truth remains lightweight enough for a normal operator scan without adding a new per-row derivation layer.
|
||||
|
||||
## Formatting And Final Verification
|
||||
|
||||
Before finalizing implementation work:
|
||||
|
||||
```bash
|
||||
vendor/bin/sail bin pint --dirty --format agent
|
||||
```
|
||||
|
||||
Then rerun the smallest affected test set. If the user wants broader confidence afterward, offer the full suite.
|
||||
60
specs/174-evidence-freshness-publication-trust/research.md
Normal file
60
specs/174-evidence-freshness-publication-trust/research.md
Normal file
@ -0,0 +1,60 @@
|
||||
# Research: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
## Decision 1: Reuse the existing source-derived stale semantics instead of introducing a global freshness engine
|
||||
|
||||
- Decision: Treat provider-level `stale` evaluation and the existing `EvidenceCompletenessEvaluator` as the canonical source of temporal freshness for this feature.
|
||||
- Rationale: Evidence freshness is already derived upstream in the evidence domain. `EvidenceSnapshotService` collects per-dimension payloads, providers such as `BaselineDriftPostureSource` already mark data stale using domain-appropriate recency rules, and `EvidenceCompletenessEvaluator` already escalates any required stale dimension into snapshot completeness. A second global threshold engine would duplicate truth and risk disagreement with the evidence domain.
|
||||
- Alternatives considered:
|
||||
- Add a new global `freshness_threshold_hours` configuration and recompute staleness on the page layer. Rejected because the existing evidence sources already encode domain-aware freshness and the page layer should not create its own recency semantics.
|
||||
- Derive staleness purely from `generated_at` on snapshots and reviews. Rejected because the meaningful freshness signal already exists at the dimension level, and a snapshot can be freshly generated from stale inputs.
|
||||
|
||||
## Decision 2: Tighten `ArtifactTruthPresenter` instead of adding a new trust or publication resolver
|
||||
|
||||
- Decision: Keep `ArtifactTruthPresenter` as the single seam for evidence snapshot, tenant review, and review pack trust propagation.
|
||||
- Rationale: The presenter already builds envelopes for `EvidenceSnapshot`, `TenantReview`, and `ReviewPack`, including freshness, content, publication, actionability, and next-step guidance. The current bug is not the absence of a trust layer, but that stale and partial semantics are not fully propagated through the existing one.
|
||||
- Alternatives considered:
|
||||
- Create a dedicated `PublicationReadinessResolver` or `FreshnessTrustGate`. Rejected because the current architecture already centralizes the needed truth and a second layer would violate the repo's proportionality and few-layers rules.
|
||||
- Push the logic into page classes. Rejected because it would fragment truth across summary pages and detail resources.
|
||||
|
||||
## Decision 3: Tenant review publication readiness must degrade when freshness is stale
|
||||
|
||||
- Decision: Make stale review freshness capable of downgrading a review from publishable to an internal-only or cautionary posture even when the review status is `ready` or `published`.
|
||||
- Rationale: `TenantReviewReadinessGate` already treats stale required sections as publication blockers at composition time, and `buildTenantReviewEnvelope()` already calculates a `freshnessState` of `stale`. The current contradiction is that publication readiness still becomes `publishable` from status alone, which lets stale reviews sound calmer than the evidence basis justifies.
|
||||
- Rule: A stale review may remain internally useful, but it must not remain `publishable` solely because its lifecycle status is `ready` or `published`. If stronger blockers already exist, `blocked` still takes precedence.
|
||||
- Alternatives considered:
|
||||
- Leave publication readiness based only on status and blocker arrays. Rejected because it allows a stale review to look publishable even when the same presenter calls it stale.
|
||||
- Introduce a new persisted review trust field. Rejected because the stale condition is already derivable from review completeness and section counts.
|
||||
|
||||
## Decision 4: Partial evidence must lower publication confidence even when it does not fully block review use
|
||||
|
||||
- Decision: Distinguish between reviews that are usable internally and reviews that are truly publishable when the evidence basis is partial.
|
||||
- Rationale: The spec requires a meaningful difference between internal-use artifacts and publishable artifacts. The current truth model already supports separate `contentState`, `freshnessState`, `publicationReadiness`, and `actionability` dimensions, so the implementation can express this nuance without new state families.
|
||||
- Rule: Partial evidence downgrades publication readiness to `internal_only` unless stronger existing blockers already make the artifact `blocked`.
|
||||
- Alternatives considered:
|
||||
- Treat partial evidence exactly like complete evidence whenever hard blockers are absent. Rejected because that is the current trust problem.
|
||||
- Convert all partial evidence into hard publish blockers. Rejected because the spec wants internal-use versus publishable to remain distinct, not collapsed into blocked versus not blocked.
|
||||
|
||||
## Decision 5: Review packs must inherit stale and partial burden from the linked review and evidence basis
|
||||
|
||||
- Decision: Make `ReviewPack` truth inherit source review and evidence burden rather than treating a ready, non-expired file as inherently current and publishable.
|
||||
- Rationale: `buildReviewPackEnvelope()` currently treats pack freshness as `current` whenever the file is not expired, even if the source review or source evidence is stale. That allows packs to appear calmer than the review they were generated from, which is exactly the contradiction this spec is meant to close.
|
||||
- Rule: A pack is only `publishable` when its source review remains current and strong enough to publish. Stale or partial source burden must downgrade the pack to `internal_only`, unless stronger blockers already make it `blocked`.
|
||||
- Alternatives considered:
|
||||
- Keep pack freshness tied only to file expiration. Rejected because a current file can still be generated from stale governance evidence.
|
||||
- Persist a separate pack trust state. Rejected because the necessary source review and evidence inputs already exist.
|
||||
|
||||
## Decision 6: Canonical summary pages should reuse the same truth envelope and next-step semantics
|
||||
|
||||
- Decision: Keep `EvidenceOverview` and `ReviewRegister` aligned by reusing the same envelope semantics that power the tenant-scoped detail pages.
|
||||
- Rationale: Both canonical pages already display artifact truth and next-step or publication surfaces. The current risk is not missing UI slots, but summary rows sounding calmer than the detail pages because stale and partial burden are not fully represented in the underlying truth.
|
||||
- Alternatives considered:
|
||||
- Add new page-specific columns, banners, or taxonomy labels. Rejected because the repo already has canonical truth and badge primitives.
|
||||
- Leave canonical summary rows untouched and rely on drill-through. Rejected because the spec explicitly targets trust propagation on summary surfaces.
|
||||
|
||||
## Decision 7: Expand the current Pest test surfaces and fixture helpers instead of creating a new test harness
|
||||
|
||||
- Decision: Extend the current evidence, review, pack, review-register, and evidence-overview tests, and strengthen shared governance-artifact fixtures.
|
||||
- Rationale: The current suite already covers resource routing, basic artifact truth visibility, review publication blockers, and canonical row scoping. The missing coverage is specific: fresh versus stale propagation, partial-evidence publication trust, and review-versus-pack consistency.
|
||||
- Alternatives considered:
|
||||
- Rely on manual browser validation only. Rejected because this feature is about preventing semantic drift across multiple related surfaces.
|
||||
- Add a separate browser suite as the primary guard. Rejected because the existing Pest feature surfaces are already well aligned with the affected code paths and will be faster and cheaper to maintain.
|
||||
237
specs/174-evidence-freshness-publication-trust/spec.md
Normal file
237
specs/174-evidence-freshness-publication-trust/spec.md
Normal file
@ -0,0 +1,237 @@
|
||||
# Feature Specification: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
**Feature Branch**: `174-evidence-freshness-publication-trust`
|
||||
**Created**: 2026-04-04
|
||||
**Status**: Draft
|
||||
**Input**: User description: "Spec 174 — Evidence Temporal Freshness & Review Publication Trust"
|
||||
|
||||
## Spec Scope Fields *(mandatory)*
|
||||
|
||||
- **Scope**: tenant + canonical-view
|
||||
- **Primary Routes**:
|
||||
- `/admin/t/{tenant}/evidence` and `/admin/t/{tenant}/evidence/{snapshot}` for tenant-scoped evidence snapshot inspection
|
||||
- `/admin/t/{tenant}/reviews` and `/admin/t/{tenant}/reviews/{review}` for tenant-scoped review lifecycle and publication decisions
|
||||
- `/admin/t/{tenant}/review-packs` and `/admin/t/{tenant}/review-packs/{pack}` for tenant-scoped executive pack generation, download, and trust communication
|
||||
- `/admin/reviews` for the canonical review register across entitled tenants
|
||||
- `route('admin.evidence.overview')` for the canonical evidence overview across entitled tenants
|
||||
- **Data Ownership**:
|
||||
- Tenant-owned: stored reports, evidence snapshots, evidence snapshot items, tenant reviews, and review packs remain tenant-scoped artifacts anchored to one tenant's governance history
|
||||
- Workspace-owned but tenant-filtered: canonical register and overview pages aggregate only within the operator's entitled workspace and tenant set, without changing ownership of the underlying artifacts
|
||||
- This feature introduces no new persisted trust record, no new freshness record, and no new export-tracking entity; truth remains derived from existing timestamps, completeness states, and artifact links
|
||||
- **RBAC**:
|
||||
- Workspace membership and tenant entitlement remain required for all tenant-scoped evidence, review, and pack routes
|
||||
- Existing capabilities remain authoritative: `evidence.view` / `evidence.manage`, `tenant_review.view` / `tenant_review.manage`, and `review_pack.view` / `review_pack.manage`
|
||||
- Canonical review and evidence surfaces must preserve deny-as-not-found semantics for non-members and non-entitled users, and must not expose cross-tenant artifact existence, trust posture, or readiness hints outside the authorized tenant set
|
||||
|
||||
For canonical-view specs, the spec MUST define:
|
||||
|
||||
- **Default filter behavior when tenant-context is active**: When an operator opens the canonical review register or canonical evidence overview from a tenant-scoped surface, the destination opens prefiltered to that tenant through the existing tenant-prefilter mechanisms so the operator stays in the same tenant world they clicked from.
|
||||
- **Explicit entitlement checks preventing cross-tenant leakage**: Canonical review rows, evidence rows, artifact-truth badges, publication-readiness badges, next-step text, filters, and drill-through links must only be built after workspace membership and tenant-entitlement checks. Non-entitled users must not learn whether another tenant has a current review, a stale evidence snapshot, or an exportable pack.
|
||||
|
||||
## UI/UX Surface Classification *(mandatory when operator-facing surfaces are changed)*
|
||||
|
||||
Affected list and report surfaces in this spec MUST also be reviewed against `docs/product/standards/list-surface-review-checklist.md` before implementation sign-off so row-click behavior, inline action discipline, empty states, and summary truth remain aligned with the shared operator-surface standard.
|
||||
|
||||
| Surface | Surface Type | Primary Inspect/Open Model | Row Click | Secondary Actions Placement | Destructive Actions Placement | Canonical Collection Route | Canonical Detail Route | Scope Signals | Canonical Noun | Critical Truth Visible by Default | Exception Type |
|
||||
|---|---|---|---|---|---|---|---|---|---|---|---|
|
||||
| Evidence snapshot resource | CRUD / List-first Resource | Full-row click from list to snapshot detail | required | One `More` menu for non-primary list actions | `Expire snapshot` in `More` or detail header | `/admin/t/{tenant}/evidence` | `/admin/t/{tenant}/evidence/{snapshot}` | Tenant context and evidence completeness badges scope every row and action | Evidence / Evidence snapshot | Artifact truth, completeness, freshness pressure, and next step | none |
|
||||
| Tenant review resource | CRUD / List-first Resource | Full-row click from list to tenant review detail | required | One inline safe shortcut (`Export executive pack`) plus detail-header support actions | `Archive review` in detail header `More` group | `/admin/t/{tenant}/reviews` | `/admin/t/{tenant}/reviews/{review}` | Tenant context, review status, completeness, publication readiness, and evidence basis stay explicit | Reviews / Review | Artifact truth, completeness, publication readiness, and next step | none |
|
||||
| Canonical review register | Read-only Registry / Report Surface | Clickable row to the tenant-scoped review detail that matches the row | required | One inline safe shortcut (`Export executive pack`) plus header clear-filters action | none | `/admin/reviews` | Tenant-scoped review detail for the selected row | Tenant labels, publication badges, completeness badges, and tenant-prefilter state | Reviews / Review | Cross-tenant review truth, publication readiness, and next step | canonical-view registry |
|
||||
| Review pack resource | CRUD / List-first Resource | Full-row click from list to pack detail | required | One inline safe shortcut (`Download`) plus detail-header support actions | `Expire` in overflow or detail header | `/admin/t/{tenant}/review-packs` | `/admin/t/{tenant}/review-packs/{pack}` | Tenant context, linked review, review status, pack status, and artifact truth remain visible | Review Packs / Review pack | Publication readiness, freshness burden, and whether export is internal-only or publishable | none |
|
||||
| Evidence overview | Read-only Registry / Report Surface | Clickable row to the tenant-scoped evidence snapshot detail for the selected tenant | required | Header clear-filters action only | none | `route('admin.evidence.overview')` | `/admin/t/{tenant}/evidence/{snapshot}` for the selected row | Tenant labels, artifact truth, freshness badges, and next-step text keep the overview scoped | Evidence / Evidence snapshot | Freshness and completeness truth across entitled tenants | canonical-view registry |
|
||||
|
||||
## Operator Surface Contract *(mandatory when operator-facing surfaces are changed)*
|
||||
|
||||
| Surface | Primary Persona | Surface Type | Primary Operator Question | Default-visible Information | Diagnostics-only Information | Status Dimensions Used | Mutation Scope | Primary Actions | Dangerous Actions |
|
||||
|---|---|---|---|---|---|---|---|---|---|
|
||||
| Evidence snapshot detail | Tenant operator | Detail-first Operational Surface | Is this evidence basis complete enough, fresh enough, and trustworthy enough to use right now? | Artifact truth, completeness state, freshness pressure, missing or stale dimensions, and next-step guidance | Raw summary JSON, deep dimension payloads, fingerprints, source record IDs | artifact existence, content completeness, temporal freshness, actionability | TenantPilot evidence lifecycle only | Refresh evidence, view linked operation, inspect dimensions | Expire snapshot |
|
||||
| Tenant review detail | Tenant operator | Detail-first Operational Surface | Is this review merely stored, ready for internal use, or strong enough to publish externally? | Artifact truth, completeness, publication readiness, review blockers or warnings, evidence basis, and next-step guidance | Full section payloads, raw summary JSON, historical audit context, operation metadata | artifact existence, completeness, temporal freshness, publication readiness, actionability | TenantPilot review lifecycle and export initiation | Refresh review, publish review, export executive pack, create next review, open evidence | Archive review |
|
||||
| Canonical review register | Workspace auditor or operator | Read-only Registry / Report Surface | Which tenants currently have review artifacts that are fresh enough, publication-ready enough, or in need of follow-up? | Review status, artifact truth, completeness, publication readiness, and next-step text per tenant | Deep section content, raw evidence payloads, audit internals | review lifecycle, artifact truth, completeness, publication readiness | Read-only registry plus export initiation where already allowed | Open review, export executive pack | none |
|
||||
| Review pack detail | Tenant operator | Detail-first Operational Surface | Is this pack merely downloadable, or is it publishable enough to treat as a stakeholder-facing export? | Artifact truth, pack status, linked review, evidence basis summary, publication readiness, and download caveat when needed | Fingerprints, previous fingerprint, low-level generation metadata | artifact existence, freshness pressure, publication readiness, expiration state | TenantPilot export lifecycle only | Download, regenerate pack, open linked review | Expire pack |
|
||||
| Evidence overview | Workspace auditor or operator | Read-only Registry / Report Surface | Which entitled tenants currently have fresh, complete evidence and which require follow-up before review or publication? | Tenant, artifact truth, freshness state, missing or stale dimensions, and next step | Per-dimension detail payloads and raw summary JSON remain on snapshot detail | artifact truth, freshness, completeness | none | Open evidence snapshot | none |
|
||||
|
||||
## Proportionality Review *(mandatory when structural complexity is introduced)*
|
||||
|
||||
- **New source of truth?**: No. Evidence snapshots, review records, review packs, and the existing artifact-truth layer remain the authoritative truth sources.
|
||||
- **New persisted entity/table/artifact?**: No. This feature explicitly avoids new persistence and must derive freshness and publication trust from existing timestamps, completeness states, and links.
|
||||
- **New abstraction?**: No. The narrowest correct implementation is to harden the existing `ArtifactTruthPresenter`, readiness gates, and surface mappings rather than adding a second trust framework.
|
||||
- **New enum/state/reason family?**: No. Existing freshness and publication-readiness dimensions should be tightened, not replaced with a new persisted status family.
|
||||
- **New cross-domain UI framework/taxonomy?**: No. This is a surface-truth hardening slice inside the existing evidence/review/export chain.
|
||||
- **Current operator problem**: Structurally complete evidence can currently read as current enough and publishable enough even when it is too old or only partial, which risks operators exporting or publishing artifacts that are not decision-grade.
|
||||
- **Existing structure is insufficient because**: Completeness and publication surfaces already exist, but temporal freshness and partial-evidence burden are not strong enough in the artifact-truth and review-readiness chain to keep surfaces from sounding calmer than the underlying evidence basis.
|
||||
- **Narrowest correct implementation**: Tighten the existing artifact-truth and readiness evaluation to degrade stale or partial artifacts visibly on evidence, review, register, and pack surfaces, while preserving current resources and actions.
|
||||
- **Ownership cost**: The repo takes on a small amount of additional cross-surface regression coverage and ongoing maintenance for freshness-threshold and publication-caveat rules.
|
||||
- **Alternative intentionally rejected**: A new StoredReport resource, a new export governance table, or a separate portfolio-trust layer was rejected because the immediate product risk can be solved by tightening the current evidence/review/export truth chain.
|
||||
- **Release truth**: Current-release truth. Operators can already act on these surfaces today, so trust hardening cannot wait for a later reporting overhaul.
|
||||
|
||||
## User Scenarios & Testing *(mandatory)*
|
||||
|
||||
### User Story 1 - Detect Stale Evidence Before Reusing It (Priority: P1)
|
||||
|
||||
As a tenant operator, I want evidence, reviews, and packs to tell me when their underlying evidence basis is too old to rely on confidently, so that I do not make governance decisions on structurally complete but outdated artifacts.
|
||||
|
||||
**Why this priority**: Silent evidence aging is the highest trust risk in this domain because it can make calm-looking artifacts unsafe for real decisions.
|
||||
|
||||
**Independent Test**: Can be fully tested by seeding fresh and old evidence snapshots with the same structural completeness and verifying that only the fresh artifacts read as current enough for confident reuse.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** an evidence snapshot is structurally complete but one or more required evidence dimensions have aged past their canonical source-defined freshness thresholds, **When** an operator opens the snapshot, linked review, or linked pack surface, **Then** the artifact is shown as stale or cautionary rather than quietly current.
|
||||
2. **Given** an evidence snapshot is structurally complete and still within the freshness threshold, **When** an operator opens the snapshot, linked review, or linked pack surface, **Then** the freshness dimension allows the artifact to remain in a current or fresher state when no other trust limiter applies.
|
||||
3. **Given** a canonical register or overview lists both fresh and stale artifacts, **When** the operator scans the table, **Then** freshness burden is visible without opening every row.
|
||||
|
||||
---
|
||||
|
||||
### User Story 2 - Distinguish Internal-Use Reviews From Publishable Reviews (Priority: P1)
|
||||
|
||||
As a tenant operator, I want review and pack surfaces to distinguish between internally useful artifacts and truly publishable artifacts, so that I do not treat downloadability or technical readiness as proof that a report is publishable.
|
||||
|
||||
**Why this priority**: Export and publication are the moments where a misleadingly calm artifact becomes an external trust problem.
|
||||
|
||||
**Independent Test**: Can be fully tested by rendering reviews and packs built from complete evidence, partial evidence, and stale evidence, then verifying that their readiness and publication signals diverge appropriately.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** a tenant review is structurally ready but built on partial evidence, **When** the operator views the review, **Then** the surface shows a cautionary or internal-only publication posture rather than the same calm signal used for publishable reviews.
|
||||
2. **Given** a review pack is downloadable but derived from stale or partial evidence, **When** the operator opens or downloads the pack, **Then** the surface discloses that the pack is better suited to internal use or review refresh rather than quiet external sharing.
|
||||
3. **Given** a tenant review and its current export pack share the same stale or partial evidence burden, **When** the operator compares their surfaces, **Then** both surfaces communicate consistent trust and publication signals.
|
||||
|
||||
---
|
||||
|
||||
### User Story 3 - Recover The Evidence Basis Across Review Surfaces (Priority: P2)
|
||||
|
||||
As a workspace operator reviewing multiple tenants, I want canonical review and evidence surfaces to preserve the link between review status, evidence freshness, and next action, so that I can tell which tenants are review-ready and which need evidence refresh before publication.
|
||||
|
||||
**Why this priority**: Portfolio-level review work depends on summary surfaces carrying the same truth as the detail surfaces they summarize.
|
||||
|
||||
**Independent Test**: Can be fully tested by seeding tenants with mixed evidence freshness and review readiness and verifying that review-register and evidence-overview rows present the same trust direction as the underlying detail pages.
|
||||
|
||||
**Acceptance Scenarios**:
|
||||
|
||||
1. **Given** two tenants have reviews with different evidence freshness burdens, **When** the operator scans the review register, **Then** the table communicates which review is fresher and which needs follow-up.
|
||||
2. **Given** a tenant has fresh evidence but no current review, **When** the operator scans canonical surfaces, **Then** the surfaces show a next step that points toward review creation rather than implying review readiness already exists.
|
||||
3. **Given** a tenant has stale evidence and a previously generated pack, **When** the operator follows drill-through links between overview and detail pages, **Then** the trust explanation remains coherent across the journey.
|
||||
|
||||
### Edge Cases
|
||||
|
||||
- A run can complete and create an evidence snapshot, but the snapshot can later age past the acceptable freshness window without any structural completeness change.
|
||||
- A review can have all sections present yet still rely on partial sections whose evidence basis should reduce publication confidence.
|
||||
- A pack can remain downloadable after its linked review or evidence basis becomes stale; the surface must warn rather than silently remain calm.
|
||||
- A stored report referenced by an evidence item can be pruned by retention while the evidence snapshot still exists; this feature must not require a new raw-report viewer to remain truthful.
|
||||
- A user may be entitled to a tenant review but not to export or manage it; readiness and trust truth may still be visible, while actions remain capability-gated.
|
||||
- Canonical register and overview pages may be prefiltered from a tenant context; they must remain semantically consistent without leaking artifacts from non-entitled tenants.
|
||||
|
||||
## Requirements *(mandatory)*
|
||||
|
||||
**Constitution alignment (required):** This feature introduces no new Microsoft Graph calls and no new long-running flow. It hardens how existing evidence, review, and pack artifacts communicate trust. Existing review and pack actions continue to use their current services and current `OperationRun` types. No new contract registry entry or queued process is added.
|
||||
|
||||
**Constitution alignment (PROP-001 / ABSTR-001 / PERSIST-001 / STATE-001 / BLOAT-001):** This slice adds no persistence, no new abstraction layer, and no new persisted status family. The current operator problem is that structurally complete artifacts can look newer and safer than they are. Existing structure is insufficient because completeness and publication surfaces are not yet hard enough against age and partial evidence. The narrowest correct implementation is to strengthen the existing artifact-truth and readiness logic. Ownership cost is limited to regression coverage and threshold maintenance. A separate reporting or StoredReport framework is intentionally rejected in this slice.
|
||||
|
||||
**Constitution alignment (OPS-UX):** No new `OperationRun` type is added. Existing evidence snapshot generation, review composition, review refresh, and review-pack generation continue to own execution lifecycle through current services and current run types. This feature only changes how resulting artifacts communicate trust and next action after those runs complete.
|
||||
|
||||
**Constitution alignment (RBAC-UX):** The feature affects the tenant/admin plane for tenant-scoped evidence, reviews, and review packs, plus canonical admin pages for the review register and evidence overview. Non-members and non-entitled users remain `404`. In-scope members lacking `evidence.manage`, `tenant_review.manage`, or `review_pack.manage` remain `403` for the corresponding actions. Export and publication affordances must stay capability-aware while still allowing truth signals to appear for view-only users.
|
||||
|
||||
**Constitution alignment (OPS-EX-AUTH-001):** Not applicable. No authentication handshake behavior is changed.
|
||||
|
||||
**Constitution alignment (BADGE-001):** Existing centralized badge domains for tenant review status, tenant review completeness, evidence completeness, review pack status, governance artifact freshness, and related artifact-truth labels remain the semantic source. This feature may change when those badge families show caution or downgrade states, but must not introduce local page-only badge mappings.
|
||||
|
||||
**Constitution alignment (UI-FIL-001):** The feature reuses native Filament resources, infolists, tables, actions, badges, sections, and existing governance artifact-truth entry views. Local replacement markup for core truth surfaces should be avoided. Any stronger stale or internal-only emphasis should still be expressed through Filament props and central badge or truth primitives rather than page-local color languages.
|
||||
|
||||
**Constitution alignment (UI-NAMING-001):** The target objects are evidence snapshots, reviews, and review packs. Primary operator-facing vocabulary remains `Create snapshot`, `Refresh evidence`, `Create review`, `Refresh review`, `Publish review`, `Export executive pack`, `Generate first pack`, `Download`, and `Expire`. New or revised copy must preserve the difference between `current`, `stale`, `partial`, `internal use`, `publication ready`, and `blocked`, and must avoid implementation-first wording such as `snapshot age rule`, `trust envelope`, or `derived state` in primary operator labels.
|
||||
|
||||
**Constitution alignment (UI-CONST-001 / UI-SURF-001 / UI-HARD-001 / UI-EX-001 / UI-REVIEW-001):** The affected surfaces consist of `CRUD / List-first Resource` lists for snapshots, reviews, and review packs, `Read-only Registry / Report Surface` pages for the canonical overview and register, and dedicated `Detail-first Operational Surface` pages for artifact inspection and action context. Each keeps one primary inspect model: row-click for snapshot, review, register, and pack tables; detail-header actions for lifecycle mutations; and diagnostic subsections for raw summaries. Critical truth visible by default must include artifact truth, freshness burden, completeness burden, publication readiness, and next step where relevant. This feature does not introduce redundant `View` affordances or move destructive actions out of their current safe placements.
|
||||
|
||||
**Constitution alignment (OPSURF-001):** Operator-first content on evidence, review, and pack surfaces must separate execution truth, artifact existence, completeness, freshness, and publication readiness rather than flattening them into one vague `ready` state. Diagnostics such as raw summary JSON, fingerprints, and low-level IDs remain secondary. Mutating actions continue to act on TenantPilot-managed artifacts only.
|
||||
|
||||
**Constitution alignment (UI-SEM-001 / LAYER-001 / TEST-TRUTH-001):** Direct mapping from persisted artifact status alone is insufficient because artifact trust depends on cross-cutting freshness and completeness context. This feature must strengthen the existing artifact-truth layer rather than adding a parallel presenter family. Tests must verify business consequences such as stale artifacts not appearing publishable, partial evidence downgrading publication trust, and review/pack surfaces staying consistent.
|
||||
|
||||
**Constitution alignment (Filament Action Surfaces):** The Action Surface Contract remains satisfied. Evidence, review, and pack resources keep one primary inspect model per list, no redundant row-level view actions, and confirmation-gated destructive actions where applicable. Review register and evidence overview remain read-only registry surfaces. UI-FIL-001 remains satisfied with no new exception required.
|
||||
|
||||
**Constitution alignment (UX-001 — Layout & Information Architecture):** Existing detail screens remain sectioned Infolist-style pages. This feature strengthens the top-level truth and caveat zones on those screens rather than converting them into forms or custom layouts. Tables remain searchable, sortable, and filterable where already supported.
|
||||
|
||||
### Functional Requirements
|
||||
|
||||
- **FR-174-001**: Evidence snapshots and every artifact derived from them MUST distinguish structural completeness from temporal freshness. A structurally complete artifact MUST NOT automatically read as current enough solely because all expected dimensions are present.
|
||||
- **FR-174-002**: Temporal freshness MUST be evaluated from existing evidence timestamps using a clearly defined freshness policy for each evidence dimension. Where source-specific freshness thresholds are already canonical in the evidence domain, this feature MUST reuse them rather than inventing a second global threshold.
|
||||
- **FR-174-003**: When one or more required evidence dimensions exceed their canonical freshness policy, the snapshot, any review anchored to it, and any review pack anchored to that review or snapshot MUST visibly degrade into a stale or cautionary trust state.
|
||||
- **FR-174-004**: Stale evidence MUST influence the artifact-truth summary that operators see on evidence snapshot detail, tenant review detail, review register rows, review pack detail, review pack list rows, and evidence overview rows.
|
||||
- **FR-174-005**: A tenant review or review pack based on stale evidence MUST NOT present the same calm `current`, `ready`, or publishable impression as a fresh artifact.
|
||||
- **FR-174-006**: Partial evidence MUST materially affect review and pack trust. If a review or review pack is structurally complete but its evidence basis is partial, the surface MUST downgrade publication readiness to `internal_only`, unless existing stronger publish blockers already make it `blocked`, instead of using the same publishable posture used for stronger evidence.
|
||||
- **FR-174-007**: Review readiness and publication readiness MUST remain visibly distinct. An artifact may be ready for internal inspection while still requiring caution or restriction for external sharing.
|
||||
- **FR-174-008**: Download or export affordances for review packs MUST surface when a pack is safer for internal use than for external sharing. A technically downloadable pack MUST NOT silently imply publishable trust.
|
||||
- **FR-174-009**: Review and pack surfaces MUST explain the principal reason for trust reduction when freshness or evidence quality lowers confidence, including stale evidence, partial sections, or missing or stale dimensions where relevant.
|
||||
- **FR-174-010**: When an artifact is stale, partial, internal-only, or otherwise not publishable, the surface MUST provide a clear next step such as refreshing evidence, refreshing the review, resolving missing evidence, or generating a new pack.
|
||||
- **FR-174-011**: Canonical review and evidence registry surfaces MUST stay semantically aligned with their tenant-scoped detail surfaces. A row that reads stale, partial, or internal-only on a detail page MUST not read calm or publishable in its register row.
|
||||
- **FR-174-012**: Tenant review detail and review pack detail MUST not send contradictory publication or trust signals for artifacts that share the same stale or partial evidence burden.
|
||||
- **FR-174-013**: This feature MUST preserve existing tenant-scoped and canonical prefilter navigation semantics so operators can follow truth from snapshot to review to pack without losing tenant context.
|
||||
- **FR-174-014**: The feature MUST not require a new StoredReport surface, a new persistence model, or a new export-governance artifact in order to become truthful about stale or partial evidence.
|
||||
- **FR-174-015**: Existing evidence, review, and pack actions MUST keep their current capability checks, confirmation behavior, and run-launch semantics while the surrounding truth language becomes stricter.
|
||||
- **FR-174-016**: Regression coverage MUST verify fresh vs stale evidence behavior, complete vs partial evidence behavior, review vs pack truth consistency, and download or export caveat behavior without relying on a new schema artifact.
|
||||
|
||||
## UI Action Matrix *(mandatory when Filament is changed)*
|
||||
|
||||
| Surface | Location | Header Actions | Inspect Affordance (List/Table) | Row Actions (max 2 visible) | Bulk Actions (grouped) | Empty-State CTA(s) | View Header Actions | Create/Edit Save+Cancel | Audit log? | Notes / Exemptions |
|
||||
|---|---|---|---|---|---|---|---|---|---|---|
|
||||
| Evidence snapshot resource | `app/Filament/Resources/EvidenceSnapshotResource.php` | `Create snapshot` on list header | `recordUrl()` clickable row to snapshot detail | `More` group currently carries `Expire snapshot` | none | `Create first snapshot` | `Refresh evidence`, `Expire snapshot`, existing related links | n/a | existing evidence lifecycle audit remains | This spec changes truth presentation and next-step guidance, not the action inventory |
|
||||
| Tenant review resource | `app/Filament/Resources/TenantReviewResource.php` and `Pages/ViewTenantReview.php` | `Create review` on list header | `recordUrl()` clickable row to review detail | `Export executive pack` inline shortcut on list | none | `Create first review` | `Open operation`, `View executive pack`, `View evidence snapshot`, `Refresh review`, `Publish review`, `Export executive pack`, `Create next review`, `Archive review` | n/a | existing review lifecycle audit remains | Publication-trust hardening must apply consistently across list and detail |
|
||||
| Canonical review register | `app/Filament/Pages/Reviews/ReviewRegister.php` | `Clear filters` | `recordUrl()` clickable row to tenant-scoped review detail | `Export executive pack` safe row action where currently allowed | none | `Clear filters` | n/a | n/a | no new audit behavior | Canonical registry remains read-only apart from the existing export shortcut |
|
||||
| Review pack resource | `app/Filament/Resources/ReviewPackResource.php` | `Generate pack` on list header | `recordUrl()` clickable row to pack detail | `Download` | none | `Generate first pack` | `Download`, `Regenerate`, `Expire`, and existing related links | n/a | existing pack lifecycle audit remains | Download remains allowed where currently allowed, but its trust caveat must become explicit |
|
||||
| Evidence overview | `app/Filament/Pages/Monitoring/EvidenceOverview.php` | `Clear filters` when tenant-prefilter is active | Clickable row to tenant-scoped evidence snapshot detail | none | none | `Clear filters` in the empty state | n/a | n/a | no new audit behavior | Read-only canonical overview; this spec makes freshness truth stronger here |
|
||||
|
||||
### Key Entities *(include if feature involves data)*
|
||||
|
||||
- **StoredReport**: Raw tenant-scoped point-in-time source data such as permission posture or Entra admin roles captures. It is an input to evidence, not itself a review-grade artifact.
|
||||
- **EvidenceSnapshot**: Immutable tenant-scoped evidence basis composed from multiple dimensions and evaluated for completeness and freshness.
|
||||
- **EvidenceSnapshotItem**: A dimension-level evidence record linking an evidence snapshot to its source kind, source record, fingerprint, measured time, and completeness state.
|
||||
- **TenantReview**: A review artifact anchored to one evidence snapshot and evaluated for completeness, publication readiness, and next action.
|
||||
- **ReviewPack**: A tenant-scoped export artifact derived from a review or evidence basis, intended for download and potential sharing, with integrity and lifecycle metadata.
|
||||
- **Artifact truth**: The operator-facing evaluation of artifact existence, completeness, freshness, publication readiness, and actionability that determines whether an artifact is merely stored, internally useful, or safe enough to publish.
|
||||
|
||||
## Success Criteria *(mandatory)*
|
||||
|
||||
### Measurable Outcomes
|
||||
|
||||
- **SC-174-001**: In seeded review exercises, operators can determine within 10 seconds whether an evidence snapshot, tenant review, or review pack is fresh enough, stale, partial, or publishable without opening raw JSON or source records.
|
||||
- **SC-174-002**: In regression coverage, every scenario built on stale evidence or partial evidence shows a more cautious trust or publication state than the equivalent fresh-and-complete scenario across snapshot, review, and pack surfaces.
|
||||
- **SC-174-003**: In regression coverage, review-register rows, evidence-overview rows, tenant review detail, and review-pack detail agree on the trust direction of the same underlying artifact in 100% of covered stale and partial scenarios.
|
||||
- **SC-174-004**: In operator validation, downloadable but internal-only or cautionary packs are recognizably different from publishable packs before the operator clicks `Download`.
|
||||
- **SC-174-005**: The feature ships without a required schema migration, a new persisted trust artifact, or a new raw StoredReport resource.
|
||||
|
||||
## Assumptions
|
||||
|
||||
- Existing evidence snapshot timestamps and item timestamps are sufficient to derive temporal freshness without creating a new persistence model.
|
||||
- Existing artifact-truth and review-readiness logic are the right places to strengthen stale and partial-evidence semantics.
|
||||
- Existing review-pack download behavior can remain technically available while its trust and sharing guidance becomes more explicit.
|
||||
- StoredReport observability and source-liveness follow-up work may still be useful later, but are not prerequisites for this truth-hardening slice.
|
||||
|
||||
## Non-Goals
|
||||
|
||||
- Creating a dedicated StoredReport resource or raw report viewer
|
||||
- Building a live-state-versus-historical-state diff engine for published reviews
|
||||
- Adding stakeholder-delivery tracking or external-share audit semantics
|
||||
- Rebuilding Evidence Overview or Review Register into a new portfolio application
|
||||
- Introducing new tables, new status enums, or a second artifact-truth framework
|
||||
|
||||
## Dependencies
|
||||
|
||||
- Existing `EvidenceSnapshotResource`, `TenantReviewResource`, `ReviewPackResource`, `ReviewRegister`, and `EvidenceOverview` surfaces
|
||||
- Existing `ArtifactTruthPresenter`, `ArtifactTruthEnvelope`, review readiness logic, and review-pack generation services
|
||||
- Existing capability and tenant-entitlement enforcement for evidence, reviews, and packs
|
||||
- Existing evidence-domain, tenant-review, and review-pack foundational specs already implemented in the repo
|
||||
|
||||
## Follow-up Spec Candidates
|
||||
|
||||
- **StoredReport Observability & Source Liveness** for explicit raw-report diagnostics and pruned-source visibility
|
||||
- **Evidence / Review Portfolio Cross-Linking** for tighter canonical navigation between evidence overview and review register
|
||||
- **Published Review Drift & Superseded Evidence Signals** for signaling when a published review no longer reflects the current evidence basis
|
||||
|
||||
## Definition of Done
|
||||
|
||||
Spec 174 is complete when:
|
||||
|
||||
- structurally complete artifacts no longer read as current enough when their evidence basis is too old,
|
||||
- partial evidence produces a visibly more cautious review and pack trust posture,
|
||||
- review and pack surfaces stay consistent about the same stale or partial burden,
|
||||
- export and download actions no longer imply stronger trust than the underlying artifact supports,
|
||||
- canonical register and overview surfaces reflect the same truth direction as tenant-scoped detail surfaces,
|
||||
- and the hardening is achieved without new persistence or a new reporting subsystem.
|
||||
226
specs/174-evidence-freshness-publication-trust/tasks.md
Normal file
226
specs/174-evidence-freshness-publication-trust/tasks.md
Normal file
@ -0,0 +1,226 @@
|
||||
# Tasks: Evidence Temporal Freshness & Review Publication Trust
|
||||
|
||||
**Input**: Design documents from `/specs/174-evidence-freshness-publication-trust/`
|
||||
**Prerequisites**: `plan.md` (required), `spec.md` (required for user stories), `research.md`, `data-model.md`, `contracts/`
|
||||
|
||||
**Tests**: Tests are REQUIRED for this feature. Use focused Pest coverage in `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php`, `tests/Feature/Evidence/EvidenceOverviewPageTest.php`, `tests/Feature/TenantReview/TenantReviewLifecycleTest.php`, `tests/Feature/TenantReview/TenantReviewRegisterTest.php`, `tests/Feature/ReviewPack/ReviewPackResourceTest.php`, and existing truth-support fixtures.
|
||||
**Operations**: This feature reuses existing evidence snapshot, tenant review, and review pack generation flows and their current `OperationRun` types. No new `OperationRun` creation, lifecycle transition, notification, or `summary_counts` producer work is introduced.
|
||||
**RBAC**: Existing tenant entitlement, workspace entitlement, and capability gating must remain unchanged. Tests must preserve deny-as-not-found behavior for non-entitled users and manage-action capability gating for view-only users.
|
||||
**Operator Surfaces**: Evidence snapshot detail, tenant review detail, review pack detail, evidence overview, and the canonical review register must stay operator-first, with freshness, completeness, publication readiness, and next step visible by default where relevant.
|
||||
**Filament UI Action Surfaces**: No new actions are introduced. Existing list inspect affordances, inline safe shortcuts, destructive action placement, and confirmation behavior must remain intact while truth semantics become stricter.
|
||||
**Filament UI UX-001**: Existing Infolist and table layouts remain; this feature hardens top-level trust and caveat semantics rather than creating new screens.
|
||||
**Badges**: Freshness, completeness, publication-readiness, and artifact-truth semantics must continue to use centralized badge domains and the existing governance truth partial.
|
||||
|
||||
**Organization**: Tasks are grouped by user story so each story can be implemented and tested as an independent increment after the shared truth scaffolding is in place.
|
||||
|
||||
## Phase 1: Setup (Shared Test Scaffolding)
|
||||
|
||||
**Purpose**: Prepare reusable stale and partial evidence fixtures that all stories can build on.
|
||||
|
||||
- [X] T001 Extend shared stale and partial governance artifact fixture builders in `tests/Feature/Concerns/BuildsGovernanceArtifactTruthFixtures.php`
|
||||
- [X] T002 [P] Add or refine stale evidence seeding helpers used by evidence and review tests in `tests/Pest.php`
|
||||
|
||||
---
|
||||
|
||||
## Phase 2: Foundational (Blocking Truth Propagation Prerequisite)
|
||||
|
||||
**Purpose**: Tighten the shared trust-propagation seam before any surface-specific story work begins.
|
||||
|
||||
**⚠️ CRITICAL**: No user story work should begin until this phase is complete.
|
||||
|
||||
- [X] T003 Refactor shared freshness-source and evidence-burden inputs used by evidence, review, and pack truth envelopes in `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` without introducing a new resolver layer
|
||||
- [X] T004 [P] Preserve source-derived stale semantics and required-section blocker behavior without adding a new freshness engine in `app/Services/Evidence/EvidenceCompletenessEvaluator.php` and `app/Services/TenantReviews/TenantReviewReadinessGate.php`
|
||||
|
||||
**Checkpoint**: The central truth seam is ready for story-specific stale and publication hardening without introducing a second freshness framework.
|
||||
|
||||
---
|
||||
|
||||
## Phase 3: User Story 1 - Detect Stale Evidence Before Reusing It (Priority: P1) 🎯 MVP
|
||||
|
||||
**Goal**: Make stale evidence visible on snapshot, review, pack, and evidence-overview surfaces before operators reuse the artifact.
|
||||
|
||||
**Independent Test**: Seed fresh and stale evidence snapshots with the same structural completeness and verify that snapshot, linked review, linked pack, and evidence-overview rows downgrade only for the stale case.
|
||||
|
||||
### Tests for User Story 1
|
||||
|
||||
- [X] T005 [P] [US1] Add fresh-versus-stale snapshot detail assertions in `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php`
|
||||
- [X] T006 [P] [US1] Add stale-evidence overview row assertions in `tests/Feature/Evidence/EvidenceOverviewPageTest.php`
|
||||
- [X] T007 [P] [US1] Add stale-evidence trust assertions for linked reviews and packs in `tests/Feature/TenantReview/TenantReviewLifecycleTest.php` and `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
|
||||
### Implementation for User Story 1
|
||||
|
||||
- [X] T008 [US1] Surface stale snapshot truth and next-step guidance on tenant evidence detail in `app/Filament/Resources/EvidenceSnapshotResource.php` and `app/Filament/Resources/EvidenceSnapshotResource/Pages/ViewEvidenceSnapshot.php`
|
||||
- [X] T009 [US1] Surface stale-evidence burden on tenant review detail without changing action topology in `app/Filament/Resources/TenantReviewResource.php` and `app/Filament/Resources/TenantReviewResource/Pages/ViewTenantReview.php`
|
||||
- [X] T010 [US1] Surface stale-evidence burden on review pack list and detail before download in `app/Filament/Resources/ReviewPackResource.php` and `app/Filament/Resources/ReviewPackResource/Pages/ViewReviewPack.php`
|
||||
- [X] T011 [US1] Keep canonical evidence freshness rows aligned with snapshot detail in `app/Filament/Pages/Monitoring/EvidenceOverview.php` and `resources/views/filament/pages/monitoring/evidence-overview.blade.php`
|
||||
- [X] T012 [US1] Run the focused stale-evidence verification pack in `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php`, `tests/Feature/Evidence/EvidenceOverviewPageTest.php`, `tests/Feature/TenantReview/TenantReviewLifecycleTest.php`, and `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
|
||||
**Checkpoint**: Operators can now tell when evidence is stale before relying on snapshots, reviews, packs, or evidence-overview rows.
|
||||
|
||||
---
|
||||
|
||||
## Phase 4: User Story 2 - Distinguish Internal-Use Reviews From Publishable Reviews (Priority: P1)
|
||||
|
||||
**Goal**: Make partial or stale review evidence degrade review and pack publication posture into internal-only or cautionary states instead of looking publishable.
|
||||
|
||||
**Independent Test**: Render reviews and packs built from complete evidence, stale evidence, and partial evidence and verify that only the strongest case appears publishable.
|
||||
|
||||
### Tests for User Story 2
|
||||
|
||||
- [X] T013 [P] [US2] Add partial-evidence and stale-publication-readiness assertions for tenant reviews in `tests/Feature/TenantReview/TenantReviewLifecycleTest.php`
|
||||
- [X] T014 [P] [US2] Add internal-only versus publishable pack assertions and download caveat coverage in `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
|
||||
### Implementation for User Story 2
|
||||
|
||||
- [X] T015 [US2] Tighten tenant review publication-readiness, next-step, and explanatory trust semantics for stale or partial evidence in `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` and `app/Filament/Resources/TenantReviewResource.php`
|
||||
- [X] T016 [US2] Tighten review pack publication-readiness and source-review caveat semantics for stale or partial evidence in `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` and `app/Filament/Resources/ReviewPackResource.php`
|
||||
- [X] T017 [US2] Keep the shared governance truth partial explicit about freshness versus publication readiness without adding page-local status language in `resources/views/filament/infolists/entries/governance-artifact-truth.blade.php`
|
||||
- [X] T018 [US2] Verify review and pack detail surfaces stay consistent about internal-only versus publishable trust in `tests/Feature/TenantReview/TenantReviewLifecycleTest.php` and `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
|
||||
**Checkpoint**: Review and pack surfaces now distinguish internal-use artifacts from publishable artifacts and no longer imply publication safety from mere downloadability or status alone.
|
||||
|
||||
---
|
||||
|
||||
## Phase 5: User Story 3 - Recover The Evidence Basis Across Review Surfaces (Priority: P2)
|
||||
|
||||
**Goal**: Keep canonical review and evidence summary surfaces aligned with the tenant-scoped truth they summarize.
|
||||
|
||||
**Independent Test**: Seed tenants with mixed freshness and review readiness, then verify that the review register and evidence overview rows match the corresponding detail-page trust direction and preserve tenant-safe drill-through.
|
||||
|
||||
### Tests for User Story 3
|
||||
|
||||
- [X] T019 [P] [US3] Add stale and partial canonical review-register alignment assertions in `tests/Feature/TenantReview/TenantReviewRegisterTest.php`
|
||||
- [X] T020 [P] [US3] Add cross-surface drill-through, no-current-review next-step, and tenant-safe evidence-overview alignment assertions in `tests/Feature/Evidence/EvidenceOverviewPageTest.php` and `tests/Feature/TenantReview/TenantReviewRegisterTest.php`
|
||||
|
||||
### Implementation for User Story 3
|
||||
|
||||
- [X] T021 [US3] Align canonical review-register artifact truth, publication, and next-step rows with tenant review detail in `app/Filament/Pages/Reviews/ReviewRegister.php`
|
||||
- [X] T022 [US3] Preserve tenant-prefilter continuity, truthful drill-through, and the fresh-evidence-with-no-current-review next step between overview, register, and tenant detail surfaces in `app/Filament/Pages/Monitoring/EvidenceOverview.php` and `app/Filament/Pages/Reviews/ReviewRegister.php`
|
||||
- [X] T023 [US3] Keep tenant-scoped snapshot, review, and pack resources consistent with canonical summary language in `app/Filament/Resources/EvidenceSnapshotResource.php`, `app/Filament/Resources/TenantReviewResource.php`, and `app/Filament/Resources/ReviewPackResource.php`
|
||||
- [X] T024 [US3] Run the focused canonical-summary alignment verification pack in `tests/Feature/TenantReview/TenantReviewRegisterTest.php` and `tests/Feature/Evidence/EvidenceOverviewPageTest.php`
|
||||
|
||||
**Checkpoint**: Canonical summary surfaces now carry the same trust direction as the tenant-scoped detail pages they summarize.
|
||||
|
||||
---
|
||||
|
||||
## Phase 6: Polish & Cross-Cutting Concerns
|
||||
|
||||
**Purpose**: Final consistency, authorization non-regression, formatting, and focused verification across all stories.
|
||||
|
||||
- [X] T025 [P] Review and align operator-facing truth copy across the shared presenter and truth partial in `app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php` and `resources/views/filament/infolists/entries/governance-artifact-truth.blade.php`
|
||||
- [X] T026 [P] Add manage-action and tenant-entitlement non-regression coverage for touched evidence, review, and pack surfaces in `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php`, `tests/Feature/TenantReview/TenantReviewLifecycleTest.php`, and `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
- [X] T027 Run formatting for touched files using `vendor/bin/sail bin pint --dirty --format agent`
|
||||
- [X] T028 Run the final focused verification pack from `specs/174-evidence-freshness-publication-trust/quickstart.md`, including the SC-174-001 10-second manual scan validation, the shared list-surface review checklist in `docs/product/standards/list-surface-review-checklist.md`, the DB-only render and lightweight canonical-row-derivation guardrails in `specs/174-evidence-freshness-publication-trust/plan.md`, and the existing action run-launch semantics in `app/Filament/Resources/EvidenceSnapshotResource.php`, `app/Filament/Resources/TenantReviewResource.php`, and `app/Filament/Resources/ReviewPackResource.php`, against `tests/Feature/Evidence/EvidenceSnapshotResourceTest.php`, `tests/Feature/Evidence/EvidenceOverviewPageTest.php`, `tests/Feature/TenantReview/TenantReviewLifecycleTest.php`, `tests/Feature/TenantReview/TenantReviewRegisterTest.php`, and `tests/Feature/ReviewPack/ReviewPackResourceTest.php`
|
||||
|
||||
---
|
||||
|
||||
## Dependencies & Execution Order
|
||||
|
||||
### Phase Dependencies
|
||||
|
||||
- **Setup (Phase 1)**: Starts immediately and prepares shared stale and partial fixtures.
|
||||
- **Foundational (Phase 2)**: Depends on Setup and blocks all story work until the central truth propagation seam is tightened.
|
||||
- **User Story 1 (Phase 3)**: Starts after Foundational and delivers the MVP stale-evidence visibility across key surfaces.
|
||||
- **User Story 2 (Phase 4)**: Starts after Foundational; it can build on User Story 1 or proceed immediately after the presenter seam is stable, but should follow US1 for the cleanest rollout.
|
||||
- **User Story 3 (Phase 5)**: Starts after Foundational and depends on tightened truth semantics from earlier phases to align canonical rows.
|
||||
- **Polish (Phase 6)**: Starts after the desired user stories are complete.
|
||||
|
||||
### User Story Dependencies
|
||||
|
||||
- **User Story 1 (P1)**: Depends only on the shared truth propagation seam from Phase 2.
|
||||
- **User Story 2 (P1)**: Depends on the shared truth propagation seam from Phase 2 and benefits from the stale-surface work in US1.
|
||||
- **User Story 3 (P2)**: Depends on the shared truth propagation seam from Phase 2 and should consume the tightened truth semantics delivered by US1 and US2.
|
||||
|
||||
### Within Each User Story
|
||||
|
||||
- Shared fixture work must land before story-specific tests rely on new stale or partial scenarios.
|
||||
- Tests should be updated before or alongside the related implementation tasks and must fail before the behavior change is considered complete.
|
||||
- `ArtifactTruthPresenter` changes should land before downstream Filament resource and page copy cleanup for the same story.
|
||||
- Focused story-level test runs should complete before moving to the next story.
|
||||
|
||||
### Parallel Opportunities
|
||||
|
||||
- `T001` and `T002` can run in parallel once the shared stale and partial scenario matrix is agreed.
|
||||
- `T005`, `T006`, and `T007` can run in parallel for User Story 1.
|
||||
- `T013` and `T014` can run in parallel for User Story 2.
|
||||
- `T019` and `T020` can run in parallel for User Story 3.
|
||||
- `T025` and `T026` can run in parallel once implementation work is complete.
|
||||
|
||||
---
|
||||
|
||||
## Parallel Example: User Story 1
|
||||
|
||||
```bash
|
||||
# Story 1 tests in parallel:
|
||||
Task: T005 tests/Feature/Evidence/EvidenceSnapshotResourceTest.php
|
||||
Task: T006 tests/Feature/Evidence/EvidenceOverviewPageTest.php
|
||||
Task: T007 tests/Feature/TenantReview/TenantReviewLifecycleTest.php and tests/Feature/ReviewPack/ReviewPackResourceTest.php
|
||||
|
||||
# Story 1 implementation split after truth propagation is stable:
|
||||
Task: T008 app/Filament/Resources/EvidenceSnapshotResource.php and app/Filament/Resources/EvidenceSnapshotResource/Pages/ViewEvidenceSnapshot.php
|
||||
Task: T009 app/Filament/Resources/TenantReviewResource.php and app/Filament/Resources/TenantReviewResource/Pages/ViewTenantReview.php
|
||||
Task: T010 app/Filament/Resources/ReviewPackResource.php and app/Filament/Resources/ReviewPackResource/Pages/ViewReviewPack.php
|
||||
```
|
||||
|
||||
## Parallel Example: User Story 2
|
||||
|
||||
```bash
|
||||
# Story 2 tests in parallel:
|
||||
Task: T013 tests/Feature/TenantReview/TenantReviewLifecycleTest.php
|
||||
Task: T014 tests/Feature/ReviewPack/ReviewPackResourceTest.php
|
||||
|
||||
# Story 2 implementation split after failing assertions are in place:
|
||||
Task: T015 app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php and app/Filament/Resources/TenantReviewResource.php
|
||||
Task: T016 app/Support/Ui/GovernanceArtifactTruth/ArtifactTruthPresenter.php and app/Filament/Resources/ReviewPackResource.php
|
||||
```
|
||||
|
||||
## Parallel Example: User Story 3
|
||||
|
||||
```bash
|
||||
# Story 3 tests in parallel:
|
||||
Task: T019 tests/Feature/TenantReview/TenantReviewRegisterTest.php
|
||||
Task: T020 tests/Feature/Evidence/EvidenceOverviewPageTest.php and tests/Feature/TenantReview/TenantReviewRegisterTest.php
|
||||
|
||||
# Story 3 implementation split after row-level truth expectations are clear:
|
||||
Task: T021 app/Filament/Pages/Reviews/ReviewRegister.php
|
||||
Task: T022 app/Filament/Pages/Monitoring/EvidenceOverview.php and app/Filament/Pages/Reviews/ReviewRegister.php
|
||||
```
|
||||
|
||||
---
|
||||
|
||||
## Implementation Strategy
|
||||
|
||||
### MVP First (User Story 1 Only)
|
||||
|
||||
1. Complete Phase 1: Setup.
|
||||
2. Complete Phase 2: Foundational.
|
||||
3. Complete Phase 3: User Story 1.
|
||||
4. **STOP and VALIDATE**: Verify stale evidence is visible across snapshot, linked review, linked pack, and evidence overview surfaces.
|
||||
5. Deploy or demo if the MVP confidence level is sufficient.
|
||||
|
||||
### Incremental Delivery
|
||||
|
||||
1. Complete Setup + Foundational so the central truth seam is stable.
|
||||
2. Add User Story 1 and validate stale-evidence visibility.
|
||||
3. Add User Story 2 and validate internal-only versus publishable trust.
|
||||
4. Add User Story 3 and validate canonical summary alignment.
|
||||
5. Finish with cross-cutting copy, authorization non-regression, formatting, and focused verification.
|
||||
|
||||
### Parallel Team Strategy
|
||||
|
||||
With multiple developers:
|
||||
|
||||
1. Complete Setup + Foundational together.
|
||||
2. Once Foundational is done:
|
||||
- Developer A: User Story 1
|
||||
- Developer B: User Story 2
|
||||
- Developer C: User Story 3
|
||||
3. Reconcile in Phase 6 with shared copy, authorization non-regression, formatting, and final focused tests.
|
||||
|
||||
---
|
||||
|
||||
## Notes
|
||||
|
||||
- [P] tasks indicate different files and no dependency on incomplete predecessor tasks.
|
||||
- The same touched file may appear in multiple stories because each story hardens a different user-visible outcome on the same existing surface.
|
||||
- No task introduces a new persistence model, a new abstraction layer, or a new reporting subsystem.
|
||||
@ -0,0 +1,194 @@
|
||||
<?php
|
||||
|
||||
declare(strict_types=1);
|
||||
|
||||
use App\Filament\Resources\EvidenceSnapshotResource;
|
||||
use App\Filament\Resources\ReviewPackResource;
|
||||
use App\Filament\Resources\TenantReviewResource;
|
||||
use App\Models\Tenant;
|
||||
use App\Support\TenantReviewCompletenessState;
|
||||
use App\Support\TenantReviewStatus;
|
||||
use App\Support\Workspaces\WorkspaceContext;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
pest()->browser()->timeout(15_000);
|
||||
|
||||
it('smokes tenant-scoped evidence freshness and publication trust surfaces', function (): void {
|
||||
$staleTenant = Tenant::factory()->create(['name' => 'Browser Smoke Stale Tenant']);
|
||||
[$user, $staleTenant] = createUserWithTenant(tenant: $staleTenant, role: 'owner');
|
||||
|
||||
$partialTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $staleTenant->workspace_id,
|
||||
'name' => 'Browser Smoke Partial Tenant',
|
||||
]);
|
||||
createUserWithTenant(tenant: $partialTenant, user: $user, role: 'owner');
|
||||
|
||||
$staleSnapshot = seedStaleTenantReviewEvidence($staleTenant);
|
||||
$partialSnapshot = seedPartialTenantReviewEvidence($partialTenant);
|
||||
|
||||
$partialReview = $this->makeArtifactTruthReview(
|
||||
tenant: $partialTenant,
|
||||
user: $user,
|
||||
snapshot: $partialSnapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Ready->value,
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$staleReview = $this->makeArtifactTruthReview(
|
||||
tenant: $staleTenant,
|
||||
user: $user,
|
||||
snapshot: $staleSnapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Published->value,
|
||||
'published_at' => now(),
|
||||
'published_by_user_id' => (int) $user->getKey(),
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$stalePack = $this->makeArtifactTruthReviewPack(
|
||||
tenant: $staleTenant,
|
||||
user: $user,
|
||||
snapshot: $staleSnapshot,
|
||||
review: $staleReview,
|
||||
summaryOverrides: [
|
||||
'review_status' => TenantReviewStatus::Published->value,
|
||||
'review_completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
);
|
||||
|
||||
$this->actingAs($user)->withSession([
|
||||
WorkspaceContext::SESSION_KEY => (int) $staleTenant->workspace_id,
|
||||
]);
|
||||
session()->put(WorkspaceContext::SESSION_KEY, (int) $staleTenant->workspace_id);
|
||||
|
||||
visit(EvidenceSnapshotResource::getUrl('view', ['record' => $staleSnapshot], tenant: $staleTenant))
|
||||
->waitForText('Artifact truth')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Stale')
|
||||
->assertSee('Refresh the stale evidence before relying on this snapshot');
|
||||
|
||||
visit(TenantReviewResource::tenantScopedUrl('view', ['record' => $partialReview], $partialTenant))
|
||||
->waitForText('Artifact truth')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Complete the evidence basis before publishing this review');
|
||||
|
||||
visit(ReviewPackResource::getUrl('index', tenant: $staleTenant))
|
||||
->waitForText('Artifact truth')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Refresh the source review before sharing this pack')
|
||||
->assertSee('Download');
|
||||
|
||||
visit(ReviewPackResource::getUrl('view', ['record' => $stalePack], tenant: $staleTenant))
|
||||
->waitForText('Artifact truth')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Refresh the source review before sharing this pack')
|
||||
->assertSee('Download');
|
||||
});
|
||||
|
||||
it('smokes canonical evidence and review trust surfaces', function (): void {
|
||||
$staleTenant = Tenant::factory()->create(['name' => 'Browser Canonical Stale Tenant']);
|
||||
[$user, $staleTenant] = createUserWithTenant(tenant: $staleTenant, role: 'owner');
|
||||
|
||||
$partialTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $staleTenant->workspace_id,
|
||||
'name' => 'Browser Canonical Partial Tenant',
|
||||
]);
|
||||
createUserWithTenant(tenant: $partialTenant, user: $user, role: 'owner');
|
||||
|
||||
$freshTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $staleTenant->workspace_id,
|
||||
'name' => 'Browser Canonical Fresh Tenant',
|
||||
]);
|
||||
createUserWithTenant(tenant: $freshTenant, user: $user, role: 'owner');
|
||||
|
||||
$staleSnapshot = $this->makeStaleArtifactTruthEvidenceSnapshot($staleTenant);
|
||||
$freshSnapshot = $this->makeArtifactTruthEvidenceSnapshot($freshTenant);
|
||||
$partialSnapshot = seedPartialTenantReviewEvidence($partialTenant);
|
||||
|
||||
$this->makeArtifactTruthReview(
|
||||
tenant: $staleTenant,
|
||||
user: $user,
|
||||
snapshot: $staleSnapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Published->value,
|
||||
'published_at' => now(),
|
||||
'published_by_user_id' => (int) $user->getKey(),
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$this->makeArtifactTruthReview(
|
||||
tenant: $partialTenant,
|
||||
user: $user,
|
||||
snapshot: $partialSnapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Ready->value,
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$this->actingAs($user)->withSession([
|
||||
WorkspaceContext::SESSION_KEY => (int) $staleTenant->workspace_id,
|
||||
]);
|
||||
session()->put(WorkspaceContext::SESSION_KEY, (int) $staleTenant->workspace_id);
|
||||
|
||||
visit(route('admin.evidence.overview'))
|
||||
->waitForText('Browser Canonical Stale Tenant')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Browser Canonical Fresh Tenant')
|
||||
->assertSee('Refresh the stale evidence before relying on this snapshot')
|
||||
->assertSee('Create a current review from this evidence snapshot');
|
||||
|
||||
visit('/admin/reviews')
|
||||
->waitForText('Browser Canonical Stale Tenant')
|
||||
->assertNoJavaScriptErrors()
|
||||
->assertSee('Browser Canonical Partial Tenant')
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Refresh the evidence basis before publishing this review')
|
||||
->assertSee('Complete the evidence basis before publishing this review')
|
||||
->assertDontSee('Publishable');
|
||||
});
|
||||
@ -45,6 +45,40 @@ protected function makeArtifactTruthEvidenceSnapshot(
|
||||
return EvidenceSnapshot::query()->create(array_replace($defaults, $snapshotOverrides));
|
||||
}
|
||||
|
||||
protected function makeStaleArtifactTruthEvidenceSnapshot(
|
||||
Tenant $tenant,
|
||||
array $snapshotOverrides = [],
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$snapshot = $this->makeArtifactTruthEvidenceSnapshot($tenant, $snapshotOverrides, $summaryOverrides);
|
||||
|
||||
return $this->restateArtifactTruthEvidenceSnapshot(
|
||||
$snapshot,
|
||||
EvidenceCompletenessState::Stale,
|
||||
array_replace([
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => 2,
|
||||
], $summaryOverrides),
|
||||
);
|
||||
}
|
||||
|
||||
protected function makePartialArtifactTruthEvidenceSnapshot(
|
||||
Tenant $tenant,
|
||||
array $snapshotOverrides = [],
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$snapshot = $this->makeArtifactTruthEvidenceSnapshot($tenant, $snapshotOverrides, $summaryOverrides);
|
||||
|
||||
return $this->restateArtifactTruthEvidenceSnapshot(
|
||||
$snapshot,
|
||||
EvidenceCompletenessState::Partial,
|
||||
array_replace([
|
||||
'missing_dimensions' => 1,
|
||||
'stale_dimensions' => 0,
|
||||
], $summaryOverrides),
|
||||
);
|
||||
}
|
||||
|
||||
protected function makeArtifactTruthReview(
|
||||
Tenant $tenant,
|
||||
User $user,
|
||||
@ -146,4 +180,47 @@ protected function makeArtifactTruthRun(
|
||||
|
||||
return OperationRun::factory()->create(array_replace($defaults, $attributes));
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array<string, mixed> $summaryOverrides
|
||||
*/
|
||||
private function restateArtifactTruthEvidenceSnapshot(
|
||||
EvidenceSnapshot $snapshot,
|
||||
EvidenceCompletenessState $completenessState,
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$summary = is_array($snapshot->summary) ? $snapshot->summary : [];
|
||||
|
||||
$summary = array_replace($summary, match ($completenessState) {
|
||||
EvidenceCompletenessState::Stale => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => max(1, (int) ($summary['stale_dimensions'] ?? 1)),
|
||||
],
|
||||
EvidenceCompletenessState::Partial => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => max(1, (int) ($summary['missing_dimensions'] ?? 1)),
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
EvidenceCompletenessState::Missing => [
|
||||
'dimension_count' => (int) ($summary['dimension_count'] ?? 0),
|
||||
'missing_dimensions' => max(1, (int) ($summary['missing_dimensions'] ?? 1)),
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
EvidenceCompletenessState::Complete => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
});
|
||||
|
||||
$summary = array_replace_recursive($summary, $summaryOverrides);
|
||||
|
||||
$snapshot->forceFill([
|
||||
'completeness_state' => $completenessState->value,
|
||||
'summary' => $summary,
|
||||
])->save();
|
||||
|
||||
return $snapshot->fresh();
|
||||
}
|
||||
}
|
||||
|
||||
@ -10,8 +10,9 @@
|
||||
use App\Support\Workspaces\WorkspaceContext;
|
||||
use Filament\Facades\Filament;
|
||||
use Illuminate\Foundation\Testing\RefreshDatabase;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(RefreshDatabase::class);
|
||||
uses(RefreshDatabase::class, BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
it('shows only authorized tenant rows on the workspace evidence overview', function (): void {
|
||||
$tenantA = Tenant::factory()->create();
|
||||
@ -91,3 +92,30 @@
|
||||
->assertSee(EvidenceSnapshotResource::getUrl('view', ['record' => $snapshots[(int) $tenantB->getKey()]], tenant: $tenantB), false)
|
||||
->assertDontSee(EvidenceSnapshotResource::getUrl('view', ['record' => $snapshots[(int) $tenantA->getKey()]], tenant: $tenantA), false);
|
||||
});
|
||||
|
||||
it('shows stale evidence burden and a create-review next step on the overview', function (): void {
|
||||
$staleTenant = Tenant::factory()->create(['name' => 'Stale Tenant']);
|
||||
[$user, $staleTenant] = createUserWithTenant(tenant: $staleTenant, role: 'owner');
|
||||
|
||||
$freshTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $staleTenant->workspace_id,
|
||||
'name' => 'Fresh Tenant',
|
||||
]);
|
||||
createUserWithTenant(tenant: $freshTenant, user: $user, role: 'owner');
|
||||
|
||||
$staleSnapshot = $this->makeStaleArtifactTruthEvidenceSnapshot($staleTenant);
|
||||
$freshSnapshot = $this->makeArtifactTruthEvidenceSnapshot($freshTenant);
|
||||
|
||||
Filament::setTenant(null, true);
|
||||
|
||||
$this->actingAs($user)
|
||||
->withSession([WorkspaceContext::SESSION_KEY => (int) $staleTenant->workspace_id])
|
||||
->get(route('admin.evidence.overview'))
|
||||
->assertOk()
|
||||
->assertSee($staleTenant->name)
|
||||
->assertSee($freshTenant->name)
|
||||
->assertSee('Refresh the stale evidence before relying on this snapshot')
|
||||
->assertSee('Create a current review from this evidence snapshot')
|
||||
->assertSee(EvidenceSnapshotResource::getUrl('view', ['record' => $staleSnapshot], tenant: $staleTenant), false)
|
||||
->assertSee(EvidenceSnapshotResource::getUrl('view', ['record' => $freshSnapshot], tenant: $freshTenant), false);
|
||||
});
|
||||
|
||||
@ -21,8 +21,9 @@
|
||||
use Illuminate\Support\Facades\Gate;
|
||||
use Illuminate\Support\Facades\Queue;
|
||||
use Livewire\Livewire;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(RefreshDatabase::class);
|
||||
uses(RefreshDatabase::class, BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
function seedEvidenceDomain(Tenant $tenant): void
|
||||
{
|
||||
@ -172,6 +173,30 @@ function seedEvidenceDomain(Tenant $tenant): void
|
||||
->assertSee('Refresh evidence before using this snapshot');
|
||||
});
|
||||
|
||||
it('shows stale evidence snapshots as cautionary while fresh snapshots remain current', function (): void {
|
||||
$freshTenant = Tenant::factory()->create();
|
||||
[$user, $freshTenant] = createUserWithTenant(tenant: $freshTenant, role: 'owner');
|
||||
$staleTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $freshTenant->workspace_id,
|
||||
]);
|
||||
createUserWithTenant(tenant: $staleTenant, user: $user, role: 'owner');
|
||||
|
||||
$freshSnapshot = $this->makeArtifactTruthEvidenceSnapshot($freshTenant);
|
||||
$staleSnapshot = $this->makeStaleArtifactTruthEvidenceSnapshot($staleTenant);
|
||||
|
||||
$this->actingAs($user)
|
||||
->get(EvidenceSnapshotResource::getUrl('view', ['record' => $freshSnapshot], tenant: $freshTenant))
|
||||
->assertOk()
|
||||
->assertSee('No action needed')
|
||||
->assertDontSee('Refresh the stale evidence before relying on this snapshot');
|
||||
|
||||
$this->actingAs($user)
|
||||
->get(EvidenceSnapshotResource::getUrl('view', ['record' => $staleSnapshot], tenant: $staleTenant))
|
||||
->assertOk()
|
||||
->assertSee('Stale')
|
||||
->assertSee('Refresh the stale evidence before relying on this snapshot');
|
||||
});
|
||||
|
||||
it('renders readable evidence dimension summaries and keeps raw json available', function (): void {
|
||||
$tenant = Tenant::factory()->create();
|
||||
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
||||
|
||||
@ -21,8 +21,9 @@
|
||||
use Illuminate\Support\Facades\Queue;
|
||||
use Illuminate\Support\Facades\Storage;
|
||||
use Livewire\Livewire;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(RefreshDatabase::class);
|
||||
uses(RefreshDatabase::class, BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
beforeEach(function (): void {
|
||||
Storage::fake('exports');
|
||||
@ -366,6 +367,103 @@ function seedReviewPackEvidence(Tenant $tenant): EvidenceSnapshot
|
||||
->assertSee('Open the source review before sharing this pack');
|
||||
});
|
||||
|
||||
it('shows internal-only caveats for packs generated from stale source evidence before download', function (): void {
|
||||
$tenant = Tenant::factory()->create();
|
||||
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
||||
|
||||
$snapshot = seedStaleTenantReviewEvidence($tenant);
|
||||
$review = $this->makeArtifactTruthReview(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
reviewOverrides: [
|
||||
'status' => 'published',
|
||||
'published_at' => now(),
|
||||
'published_by_user_id' => (int) $user->getKey(),
|
||||
'completeness_state' => 'complete',
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$pack = $this->makeArtifactTruthReviewPack(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
review: $review,
|
||||
summaryOverrides: [
|
||||
'review_status' => 'published',
|
||||
'review_completeness_state' => 'complete',
|
||||
],
|
||||
);
|
||||
|
||||
$tenant->makeCurrent();
|
||||
Filament::setTenant($tenant, true);
|
||||
|
||||
Livewire::actingAs($user)
|
||||
->test(ListReviewPacks::class)
|
||||
->assertTableActionVisible('download', $pack)
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Refresh the source review before sharing this pack');
|
||||
|
||||
$this->actingAs($user)
|
||||
->get(ReviewPackResource::getUrl('view', ['record' => $pack], tenant: $tenant))
|
||||
->assertOk()
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Download')
|
||||
->assertSee('Refresh the source review before sharing this pack');
|
||||
});
|
||||
|
||||
it('keeps packs from partial evidence internal only instead of publishable', function (): void {
|
||||
$tenant = Tenant::factory()->create();
|
||||
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
||||
|
||||
$snapshot = seedPartialTenantReviewEvidence($tenant);
|
||||
$review = $this->makeArtifactTruthReview(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
reviewOverrides: [
|
||||
'status' => 'ready',
|
||||
'completeness_state' => 'complete',
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$pack = $this->makeArtifactTruthReviewPack(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
review: $review,
|
||||
summaryOverrides: [
|
||||
'review_status' => 'ready',
|
||||
'review_completeness_state' => 'complete',
|
||||
],
|
||||
);
|
||||
|
||||
$this->actingAs($user)
|
||||
->get(ReviewPackResource::getUrl('view', ['record' => $pack], tenant: $tenant))
|
||||
->assertOk()
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Complete the source review before sharing this pack')
|
||||
->assertDontSee('Publishable');
|
||||
});
|
||||
|
||||
it('shows download header action on view page for a ready pack', function (): void {
|
||||
$tenant = Tenant::factory()->create();
|
||||
[$user, $tenant] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
||||
|
||||
@ -60,8 +60,6 @@
|
||||
->get(ReviewPackResource::getUrl('view', ['record' => $pack], tenant: $tenant))
|
||||
->assertOk()
|
||||
->assertSee('Artifact truth')
|
||||
->assertSee('Publishable')
|
||||
->assertSee('No action needed')
|
||||
->assertSee('#'.$review->getKey())
|
||||
->assertSee('Review status');
|
||||
});
|
||||
|
||||
@ -4,8 +4,12 @@
|
||||
|
||||
use App\Services\TenantReviews\TenantReviewLifecycleService;
|
||||
use App\Services\TenantReviews\TenantReviewReadinessGate;
|
||||
use App\Support\TenantReviewCompletenessState;
|
||||
use App\Support\TenantReviewStatus;
|
||||
use App\Support\Ui\GovernanceArtifactTruth\ArtifactTruthPresenter;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
it('blocks publication when required review sections are missing from the anchored evidence basis', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
||||
@ -35,7 +39,24 @@
|
||||
|
||||
it('publishes ready tenant reviews and archives them without mutating the published evidence history', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
||||
$review = composeTenantReviewForTest($tenant, $user);
|
||||
$review = $this->makeArtifactTruthReview(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $this->makeArtifactTruthEvidenceSnapshot($tenant),
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Ready->value,
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$published = app(TenantReviewLifecycleService::class)->publish($review, $user);
|
||||
$publishedAt = $published->published_at?->toIso8601String();
|
||||
@ -58,3 +79,68 @@
|
||||
->and($archivedTruth->publicationReadiness)->toBe('internal_only')
|
||||
->and($archivedTruth->nextStepText())->toBe('No action needed');
|
||||
});
|
||||
|
||||
it('keeps stale published reviews internal only even when the lifecycle status is published', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
||||
$snapshot = seedStaleTenantReviewEvidence($tenant);
|
||||
|
||||
$review = $this->makeArtifactTruthReview(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Published->value,
|
||||
'published_at' => now(),
|
||||
'published_by_user_id' => (int) $user->getKey(),
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$truth = app(ArtifactTruthPresenter::class)->forTenantReview($review);
|
||||
|
||||
expect($truth->freshnessState)->toBe('stale')
|
||||
->and($truth->publicationReadiness)->toBe('internal_only')
|
||||
->and($truth->primaryLabel)->toBe('Internal only')
|
||||
->and($truth->nextStepText())->toBe('Refresh the evidence basis before publishing this review');
|
||||
});
|
||||
|
||||
it('downgrades structurally ready reviews with partial evidence to internal only', function (): void {
|
||||
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
||||
$snapshot = seedPartialTenantReviewEvidence($tenant);
|
||||
|
||||
$review = $this->makeArtifactTruthReview(
|
||||
tenant: $tenant,
|
||||
user: $user,
|
||||
snapshot: $snapshot,
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Ready->value,
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$truth = app(ArtifactTruthPresenter::class)->forTenantReview($review);
|
||||
|
||||
expect($truth->contentState)->toBe('partial')
|
||||
->and($truth->freshnessState)->toBe('current')
|
||||
->and($truth->publicationReadiness)->toBe('internal_only')
|
||||
->and($truth->primaryLabel)->toBe('Internal only')
|
||||
->and($truth->nextStepText())->toBe('Complete the evidence basis before publishing this review');
|
||||
});
|
||||
|
||||
@ -5,8 +5,13 @@
|
||||
use App\Filament\Pages\Reviews\ReviewRegister;
|
||||
use App\Models\Tenant;
|
||||
use App\Models\User;
|
||||
use App\Support\TenantReviewCompletenessState;
|
||||
use App\Support\TenantReviewStatus;
|
||||
use App\Support\Workspaces\WorkspaceContext;
|
||||
use Livewire\Livewire;
|
||||
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
||||
|
||||
uses(BuildsGovernanceArtifactTruthFixtures::class);
|
||||
|
||||
it('lists only entitled tenant reviews in the canonical review register and filters by tenant', function (): void {
|
||||
$tenantA = Tenant::factory()->create(['name' => 'Alpha Tenant']);
|
||||
@ -59,3 +64,66 @@
|
||||
->assertSee('No review records match this view')
|
||||
->assertSee('Clear filters');
|
||||
});
|
||||
|
||||
it('keeps stale and partial review rows aligned with tenant review detail trust', function (): void {
|
||||
$staleTenant = Tenant::factory()->create(['name' => 'Stale Tenant']);
|
||||
[$user, $staleTenant] = createUserWithTenant(tenant: $staleTenant, role: 'owner');
|
||||
|
||||
$partialTenant = Tenant::factory()->create([
|
||||
'workspace_id' => (int) $staleTenant->workspace_id,
|
||||
'name' => 'Partial Tenant',
|
||||
]);
|
||||
createUserWithTenant(tenant: $partialTenant, user: $user, role: 'owner');
|
||||
|
||||
$staleReview = $this->makeArtifactTruthReview(
|
||||
tenant: $staleTenant,
|
||||
user: $user,
|
||||
snapshot: seedStaleTenantReviewEvidence($staleTenant),
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Published->value,
|
||||
'published_at' => now(),
|
||||
'published_by_user_id' => (int) $user->getKey(),
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$partialReview = $this->makeArtifactTruthReview(
|
||||
tenant: $partialTenant,
|
||||
user: $user,
|
||||
snapshot: seedPartialTenantReviewEvidence($partialTenant),
|
||||
reviewOverrides: [
|
||||
'status' => TenantReviewStatus::Ready->value,
|
||||
'completeness_state' => TenantReviewCompletenessState::Complete->value,
|
||||
],
|
||||
summaryOverrides: [
|
||||
'publish_blockers' => [],
|
||||
'section_state_counts' => [
|
||||
'complete' => 6,
|
||||
'partial' => 0,
|
||||
'missing' => 0,
|
||||
'stale' => 0,
|
||||
],
|
||||
],
|
||||
);
|
||||
|
||||
$this->actingAs($user);
|
||||
setAdminPanelContext();
|
||||
session()->put(WorkspaceContext::SESSION_KEY, (int) $staleTenant->workspace_id);
|
||||
|
||||
Livewire::actingAs($user)
|
||||
->test(ReviewRegister::class)
|
||||
->assertCanSeeTableRecords([$staleReview, $partialReview])
|
||||
->assertSee('Internal only')
|
||||
->assertSee('Refresh the evidence basis before publishing this review')
|
||||
->assertSee('Complete the evidence basis before publishing this review')
|
||||
->assertDontSee('Publishable');
|
||||
});
|
||||
|
||||
122
tests/Pest.php
122
tests/Pest.php
@ -16,6 +16,7 @@
|
||||
use App\Services\Graph\GraphClientInterface;
|
||||
use App\Services\TenantReviews\TenantReviewService;
|
||||
use App\Services\Tenants\TenantActionPolicySurface;
|
||||
use App\Support\Evidence\EvidenceCompletenessState;
|
||||
use App\Support\Evidence\EvidenceSnapshotStatus;
|
||||
use App\Support\Providers\ProviderConnectionType;
|
||||
use App\Support\Providers\ProviderConsentStatus;
|
||||
@ -569,6 +570,70 @@ function seedTenantReviewEvidence(
|
||||
return $snapshot->load('items');
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array<string, mixed> $permissionPayload
|
||||
* @param array<string, mixed> $rolePayload
|
||||
*/
|
||||
function seedStaleTenantReviewEvidence(
|
||||
Tenant $tenant,
|
||||
array $permissionPayload = [],
|
||||
array $rolePayload = [],
|
||||
int $findingCount = 3,
|
||||
int $driftCount = 1,
|
||||
int $operationRunCount = 1,
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$snapshot = seedTenantReviewEvidence(
|
||||
tenant: $tenant,
|
||||
permissionPayload: $permissionPayload,
|
||||
rolePayload: $rolePayload,
|
||||
findingCount: $findingCount,
|
||||
driftCount: $driftCount,
|
||||
operationRunCount: $operationRunCount,
|
||||
);
|
||||
|
||||
return restateTenantReviewEvidenceSnapshot(
|
||||
$snapshot,
|
||||
EvidenceCompletenessState::Stale,
|
||||
array_replace([
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => 2,
|
||||
], $summaryOverrides),
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array<string, mixed> $permissionPayload
|
||||
* @param array<string, mixed> $rolePayload
|
||||
*/
|
||||
function seedPartialTenantReviewEvidence(
|
||||
Tenant $tenant,
|
||||
array $permissionPayload = [],
|
||||
array $rolePayload = [],
|
||||
int $findingCount = 3,
|
||||
int $driftCount = 1,
|
||||
int $operationRunCount = 1,
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$snapshot = seedTenantReviewEvidence(
|
||||
tenant: $tenant,
|
||||
permissionPayload: $permissionPayload,
|
||||
rolePayload: $rolePayload,
|
||||
findingCount: $findingCount,
|
||||
driftCount: $driftCount,
|
||||
operationRunCount: $operationRunCount,
|
||||
);
|
||||
|
||||
return restateTenantReviewEvidenceSnapshot(
|
||||
$snapshot,
|
||||
EvidenceCompletenessState::Partial,
|
||||
array_replace([
|
||||
'missing_dimensions' => 1,
|
||||
'stale_dimensions' => 0,
|
||||
], $summaryOverrides),
|
||||
);
|
||||
}
|
||||
|
||||
function composeTenantReviewForTest(Tenant $tenant, User $user, ?EvidenceSnapshot $snapshot = null): TenantReview
|
||||
{
|
||||
$snapshot ??= seedTenantReviewEvidence($tenant);
|
||||
@ -586,6 +651,63 @@ function composeTenantReviewForTest(Tenant $tenant, User $user, ?EvidenceSnapsho
|
||||
return $review->refresh();
|
||||
}
|
||||
|
||||
/**
|
||||
* @param array<string, mixed> $summaryOverrides
|
||||
*/
|
||||
function restateTenantReviewEvidenceSnapshot(
|
||||
EvidenceSnapshot $snapshot,
|
||||
EvidenceCompletenessState $completenessState,
|
||||
array $summaryOverrides = [],
|
||||
): EvidenceSnapshot {
|
||||
$summary = is_array($snapshot->summary) ? $snapshot->summary : [];
|
||||
|
||||
$summary = array_replace($summary, match ($completenessState) {
|
||||
EvidenceCompletenessState::Stale => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => max(1, (int) ($summary['stale_dimensions'] ?? 1)),
|
||||
],
|
||||
EvidenceCompletenessState::Partial => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => max(1, (int) ($summary['missing_dimensions'] ?? 1)),
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
EvidenceCompletenessState::Missing => [
|
||||
'dimension_count' => (int) ($summary['dimension_count'] ?? 0),
|
||||
'missing_dimensions' => max(1, (int) ($summary['missing_dimensions'] ?? 1)),
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
EvidenceCompletenessState::Complete => [
|
||||
'dimension_count' => max(1, (int) ($summary['dimension_count'] ?? 5)),
|
||||
'missing_dimensions' => 0,
|
||||
'stale_dimensions' => 0,
|
||||
],
|
||||
});
|
||||
|
||||
$summary = array_replace_recursive($summary, $summaryOverrides);
|
||||
|
||||
$snapshot->forceFill([
|
||||
'completeness_state' => $completenessState->value,
|
||||
'summary' => $summary,
|
||||
])->save();
|
||||
|
||||
$primaryItem = $snapshot->items()->where('required', true)->orderBy('sort_order')->first();
|
||||
|
||||
if ($primaryItem !== null) {
|
||||
$primaryItem->forceFill([
|
||||
'state' => $completenessState->value,
|
||||
'measured_at' => $completenessState === EvidenceCompletenessState::Stale
|
||||
? now()->subDays(45)
|
||||
: ($primaryItem->measured_at ?? now()),
|
||||
'freshness_at' => $completenessState === EvidenceCompletenessState::Stale
|
||||
? now()->subDays(45)
|
||||
: ($primaryItem->freshness_at ?? now()),
|
||||
])->save();
|
||||
}
|
||||
|
||||
return $snapshot->fresh('items');
|
||||
}
|
||||
|
||||
function setTenantPanelContext(Tenant $tenant): void
|
||||
{
|
||||
$tenant->makeCurrent();
|
||||
|
||||
Loading…
Reference in New Issue
Block a user