ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity

feat: add shared diff presentation foundation #170

Merged
ahmido merged 1 commits from 141-shared-diff-presentation-foundation into dev 2026-03-14 12:32:10 +00:00
Conversation 0 Commits 1 Files Changed 35 +2551 -1
ahmido commented 2026-03-14 12:31:44 +00:00
Owner
Copy Link

Summary

  • add a shared diff presentation layer under app/Support/Diff with deterministic row classification, summary derivation, and value stringification
  • centralize diff-state badge semantics through BadgeCatalog with a dedicated DiffRowStatusBadge
  • add reusable Filament diff partials, focused Pest coverage, and the full SpecKit artifact set for spec 141

Testing

  • vendor/bin/sail artisan test --compact tests/Unit/Support/Diff/DiffRowStatusTest.php tests/Unit/Support/Diff/DiffRowTest.php tests/Unit/Support/Diff/DiffPresenterTest.php tests/Unit/Support/Diff/ValueStringifierTest.php tests/Unit/Badges/DiffRowStatusBadgeTest.php tests/Feature/Support/Diff/SharedDiffSummaryPartialTest.php tests/Feature/Support/Diff/SharedDiffRowPartialTest.php tests/Feature/Support/Diff/SharedInlineListDiffPartialTest.php
  • vendor/bin/sail bin pint --dirty --format agent

Filament / Livewire Contract

  • Livewire v4.0+ compliance: unchanged and respected; this feature adds presentation support only within the existing Filament v5 / Livewire v4 stack
  • Provider registration: unchanged; no panel/provider changes were required, so bootstrap/providers.php remains the correct registration location
  • Global search: unchanged; no Resource or global-search behavior was added or modified
  • Destructive actions: none introduced in this feature
  • Asset strategy: no new registered Filament assets; shared Blade partials rely on the existing asset pipeline and standard deploy step for php artisan filament:assets when assets change generally
  • Testing coverage: presenter, DTOs, stringifier, badge semantics, summary partial, row partial, and inline-list partial are covered by focused Pest unit and feature tests

Notes

  • Spec checklist status is complete for specs/141-shared-diff-presentation-foundation/checklists/requirements.md
  • This PR preserves specialized diff renderers and documents incremental adoption rather than forcing migration in the same change
## Summary - add a shared diff presentation layer under `app/Support/Diff` with deterministic row classification, summary derivation, and value stringification - centralize diff-state badge semantics through `BadgeCatalog` with a dedicated `DiffRowStatusBadge` - add reusable Filament diff partials, focused Pest coverage, and the full SpecKit artifact set for spec 141 ## Testing - `vendor/bin/sail artisan test --compact tests/Unit/Support/Diff/DiffRowStatusTest.php tests/Unit/Support/Diff/DiffRowTest.php tests/Unit/Support/Diff/DiffPresenterTest.php tests/Unit/Support/Diff/ValueStringifierTest.php tests/Unit/Badges/DiffRowStatusBadgeTest.php tests/Feature/Support/Diff/SharedDiffSummaryPartialTest.php tests/Feature/Support/Diff/SharedDiffRowPartialTest.php tests/Feature/Support/Diff/SharedInlineListDiffPartialTest.php` - `vendor/bin/sail bin pint --dirty --format agent` ## Filament / Livewire Contract - Livewire v4.0+ compliance: unchanged and respected; this feature adds presentation support only within the existing Filament v5 / Livewire v4 stack - Provider registration: unchanged; no panel/provider changes were required, so `bootstrap/providers.php` remains the correct registration location - Global search: unchanged; no Resource or global-search behavior was added or modified - Destructive actions: none introduced in this feature - Asset strategy: no new registered Filament assets; shared Blade partials rely on the existing asset pipeline and standard deploy step for `php artisan filament:assets` when assets change generally - Testing coverage: presenter, DTOs, stringifier, badge semantics, summary partial, row partial, and inline-list partial are covered by focused Pest unit and feature tests ## Notes - Spec checklist status is complete for `specs/141-shared-diff-presentation-foundation/checklists/requirements.md` - This PR preserves specialized diff renderers and documents incremental adoption rather than forcing migration in the same change
ahmido added 1 commit 2026-03-14 12:31:45 +00:00
ahmido merged commit 0b5cadc234 into dev 2026-03-14 12:32:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ahmido/TenantAtlas#170
No description provided.
Delete Branch "141-shared-diff-presentation-foundation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?