ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity

feat: harden findings workflow and audit backstop #181

Merged
ahmido merged 1 commits from 151-findings-workflow-backstop into dev 2026-03-18 12:57:25 +00:00
Conversation 0 Commits 1 Files Changed 39 +3321 -247
ahmido commented 2026-03-18 12:56:29 +00:00
Owner
Copy Link

Summary

  • harden finding lifecycle changes behind the canonical FindingWorkflowService gateway
  • route automated resolve and reopen flows through the same audited workflow path
  • tighten tenant and workspace scope checks on finding actions and audit visibility
  • add focused spec artifacts, workflow regression coverage, automation coverage, and audit visibility tests
  • update legacy finding model tests to use the workflow service after direct lifecycle mutators were removed

Testing

  • vendor/bin/sail bin pint --dirty --format agent
  • focused findings and audit slices passed during implementation
  • vendor/bin/sail artisan test --compact tests/Feature/Models/FindingResolvedTest.php
  • full repository suite passed: 2757 passed, 8 skipped, 14448 assertions

Notes

  • Livewire v4.0+ compliance preserved
  • no new Filament assets or panel providers introduced; provider registration remains in bootstrap/providers.php
  • findings stay on existing Filament action surfaces, with destructive actions still confirmation-gated
  • no global search behavior was changed for findings resources
## Summary - harden finding lifecycle changes behind the canonical `FindingWorkflowService` gateway - route automated resolve and reopen flows through the same audited workflow path - tighten tenant and workspace scope checks on finding actions and audit visibility - add focused spec artifacts, workflow regression coverage, automation coverage, and audit visibility tests - update legacy finding model tests to use the workflow service after direct lifecycle mutators were removed ## Testing - `vendor/bin/sail bin pint --dirty --format agent` - focused findings and audit slices passed during implementation - `vendor/bin/sail artisan test --compact tests/Feature/Models/FindingResolvedTest.php` - full repository suite passed: `2757 passed`, `8 skipped`, `14448 assertions` ## Notes - Livewire v4.0+ compliance preserved - no new Filament assets or panel providers introduced; provider registration remains in `bootstrap/providers.php` - findings stay on existing Filament action surfaces, with destructive actions still confirmation-gated - no global search behavior was changed for findings resources
ahmido added 1 commit 2026-03-18 12:56:30 +00:00
ahmido merged commit ec71c2d4e7 into dev 2026-03-18 12:57:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ahmido/TenantAtlas#181
No description provided.
Delete Branch "151-findings-workflow-backstop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?