ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity

Refactor: remove compare job legacy drift path #235

Merged
ahmido merged 1 commits from 205-compare-job-cleanup into dev 2026-04-14 21:54:38 +00:00
Conversation 0 Commits 1 Files Changed 19 +1198 -882
ahmido commented 2026-04-14 21:51:52 +00:00
Owner
Copy Link

Summary

  • remove the dead legacy drift-computation path from CompareBaselineToTenantJob so the strategy-driven compare engine is the only execution path left in the orchestration file
  • tighten compare guard and regression coverage around strategy selection, strategy execution context, findings, gaps, and no-drift outcomes
  • fix the repo-wide suite blockers uncovered during validation by making the governance taxonomy registry test-double compatible and aligning the capture capability guard test with current unsupported-scope behavior
  • add the Spec 205 planning artifacts and mark the implementation tasks complete

Verification

  • cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent
  • cd apps/platform && ./vendor/bin/sail artisan test --compact tests --stop-on-failure
    • result: 3659 passed, 8 skipped (21016 assertions)
  • browser smoke test passed on the Baseline Compare landing surface via the local smoke-login flow

Notes

  • no Filament resource, panel, global search, destructive action, or asset registration behavior was changed
  • provider registration remains unchanged in apps/platform/bootstrap/providers.php
  • the compare path remains strategy-driven and Livewire v4 / Filament v5 assumptions are unchanged
## Summary - remove the dead legacy drift-computation path from `CompareBaselineToTenantJob` so the strategy-driven compare engine is the only execution path left in the orchestration file - tighten compare guard and regression coverage around strategy selection, strategy execution context, findings, gaps, and no-drift outcomes - fix the repo-wide suite blockers uncovered during validation by making the governance taxonomy registry test-double compatible and aligning the capture capability guard test with current unsupported-scope behavior - add the Spec 205 planning artifacts and mark the implementation tasks complete ## Verification - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests --stop-on-failure` - result: `3659 passed, 8 skipped (21016 assertions)` - browser smoke test passed on the Baseline Compare landing surface via the local smoke-login flow ## Notes - no Filament resource, panel, global search, destructive action, or asset registration behavior was changed - provider registration remains unchanged in `apps/platform/bootstrap/providers.php` - the compare path remains strategy-driven and Livewire v4 / Filament v5 assumptions are unchanged
ahmido added 1 commit 2026-04-14 21:51:52 +00:00
ahmido merged commit bb72a54e84 into dev 2026-04-14 21:54:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ahmido/TenantAtlas#235
No description provided.
Delete Branch "205-compare-job-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?