ahmido/TenantAtlas
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects 1 Releases Wiki Activity

fix(platform): resolve review and tenant review conflicts #314

Merged
ahmido merged 1 commits from platform-dev-session-1777625644 into platform-dev 2026-05-01 08:56:23 +00:00
Conversation 0 Commits 1 Files Changed 3 +15 -68
ahmido commented 2026-05-01 08:55:40 +00:00
Owner
Copy Link

Resolves the targeted Review / Evidence conflict set on top of platform-dev without introducing new features.

Included scope:

  • keep platform-dev as the newer product truth for Customer Review Workspace and Review / Evidence surfaces
  • retain the stable evidence_proof surface where still needed
  • update the outdated TenantReview creation expectation to the current 7-section review structure

Validation run locally:

  • ./vendor/bin/sail artisan test --compact --filter=CustomerReviewWorkspace
  • ./vendor/bin/sail artisan test --compact --filter=EvidenceSnapshot
  • ./vendor/bin/sail artisan test --compact --filter=ReviewPack
  • ./vendor/bin/sail artisan test --compact --filter=TenantReview
  • ./vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewCreationTest.php
  • ./vendor/bin/sail bin pint --dirty --format agent

Follow-up integration path after merge:

platform-dev -> dev.

Resolves the targeted Review / Evidence conflict set on top of `platform-dev` without introducing new features. Included scope: - keep `platform-dev` as the newer product truth for Customer Review Workspace and Review / Evidence surfaces - retain the stable `evidence_proof` surface where still needed - update the outdated TenantReview creation expectation to the current 7-section review structure Validation run locally: - `./vendor/bin/sail artisan test --compact --filter=CustomerReviewWorkspace` - `./vendor/bin/sail artisan test --compact --filter=EvidenceSnapshot` - `./vendor/bin/sail artisan test --compact --filter=ReviewPack` - `./vendor/bin/sail artisan test --compact --filter=TenantReview` - `./vendor/bin/sail artisan test --compact tests/Feature/TenantReview/TenantReviewCreationTest.php` - `./vendor/bin/sail bin pint --dirty --format agent` Follow-up integration path after merge: `platform-dev` -> `dev`.
ahmido added 1 commit 2026-05-01 08:55:40 +00:00
fix(platform): resolve review and tenant review conflicts
Some checks failed
PR Fast Feedback / fast-feedback (pull_request) Failing after 20m7s
Details
b8b1d26a41
ahmido merged commit eae06bfe05 into platform-dev 2026-05-01 08:56:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ahmido/TenantAtlas#314
No description provided.
Delete Branch "platform-dev-session-1777625644"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?