set('graph.client_id', 'platform-client-id'); $tenant = Tenant::factory()->create([ 'tenant_id' => 'platform-like-tenant-id', 'app_client_id' => null, 'app_client_secret' => null, ]); $connection = ProviderConnection::factory()->platform()->create([ 'tenant_id' => (int) $tenant->getKey(), 'workspace_id' => (int) $tenant->workspace_id, 'provider' => 'microsoft', 'entra_tenant_id' => 'platform-like-tenant-id', ]); $result = app(ProviderConnectionClassifier::class)->classify($connection); expect($result->suggestedConnectionType)->toBe(ProviderConnectionType::Platform) ->and($result->reviewRequired)->toBeFalse() ->and($result->metadata())->toMatchArray([ 'legacy_identity_classification_source' => 'migration_scan', 'legacy_identity_review_required' => false, 'legacy_identity_result' => 'platform', 'effective_app' => [ 'app_id' => 'platform-client-id', 'source' => 'platform_config', ], ]); }); it('classifies a credential-backed legacy connection as dedicated', function (): void { $tenant = Tenant::factory()->create([ 'tenant_id' => 'dedicated-like-tenant-id', 'app_client_id' => null, 'app_client_secret' => null, ]); $connection = ProviderConnection::factory()->platform()->create([ 'tenant_id' => (int) $tenant->getKey(), 'workspace_id' => (int) $tenant->workspace_id, 'provider' => 'microsoft', 'entra_tenant_id' => 'dedicated-like-tenant-id', ]); ProviderCredential::factory()->create([ 'provider_connection_id' => (int) $connection->getKey(), 'source' => null, 'payload' => [ 'client_id' => 'legacy-dedicated-client-id', 'client_secret' => 'legacy-dedicated-secret', ], ]); $result = app(ProviderConnectionClassifier::class)->classify($connection); expect($result->suggestedConnectionType)->toBe(ProviderConnectionType::Dedicated) ->and($result->reviewRequired)->toBeFalse() ->and($result->metadata())->toMatchArray([ 'legacy_identity_result' => 'dedicated', 'effective_app' => [ 'app_id' => 'legacy-dedicated-client-id', 'source' => 'dedicated_credential', ], ]); }); it('flags contradictory legacy identity as review required', function (): void { $tenant = Tenant::factory()->create([ 'tenant_id' => 'hybrid-tenant-id', 'app_client_id' => 'legacy-tenant-client-id', 'app_client_secret' => 'legacy-tenant-secret', ]); $connection = ProviderConnection::factory()->platform()->create([ 'tenant_id' => (int) $tenant->getKey(), 'workspace_id' => (int) $tenant->workspace_id, 'provider' => 'microsoft', 'entra_tenant_id' => 'hybrid-tenant-id', 'consent_status' => 'granted', 'verification_status' => 'healthy', 'status' => 'connected', ]); ProviderCredential::factory()->create([ 'provider_connection_id' => (int) $connection->getKey(), 'source' => null, 'payload' => [ 'client_id' => 'dedicated-client-id', 'client_secret' => 'dedicated-client-secret', ], ]); $result = app(ProviderConnectionClassifier::class)->classify($connection); expect($result->suggestedConnectionType)->toBe(ProviderConnectionType::Dedicated) ->and($result->reviewRequired)->toBeTrue() ->and($result->metadata())->toMatchArray([ 'legacy_identity_review_required' => true, 'legacy_identity_result' => 'dedicated', 'effective_app' => [ 'app_id' => null, 'source' => 'review_required', ], ]) ->and($result->signals)->toMatchArray([ 'tenant_client_id' => 'legacy-tenant-client-id', 'credential_client_id' => 'dedicated-client-id', 'consent_status' => 'granted', 'verification_status' => 'healthy', 'status' => 'connected', ]); });