Summary Adds a tenant-scoped Entra Groups “Directory Cache” to enable DB-only group name resolution across the app (no render-time Graph calls), plus sync runs + observability. What’s included • Entra Groups cache • New entra_groups storage (tenant-scoped) for group metadata (no memberships). • Retention semantics: groups become stale / retained per spec (no hard delete on first miss). • Group Sync Runs • New “Group Sync Runs” UI (list + detail) with tenant isolation (403 on cross-tenant access). • Manual “Sync Groups” action: creates/reuses a run, dispatches job, DB notification with “View run” link. • Scheduled dispatcher command wired in console.php. • DB-only label resolution (US3) • Shared EntraGroupLabelResolver with safe fallback Unresolved (…last8) and UUID guarding. • Refactors to prefer cached names (no typeahead / no live Graph) in: • Tenant RBAC group selects • Policy version assignments widget • Restore results + restore wizard group mapping labels Safety / Guardrails • No render-time Graph calls: fail-hard guard test verifies UI paths don’t call GraphClientInterface during page render. • Tenant isolation & authorization: policies + scoped queries enforced (cross-tenant access returns 403, not 404). • Data minimization: only group metadata is cached (no membership/owners). Tests / Verification • Added/updated tests under tests/Feature/DirectoryGroups and tests/Unit/DirectoryGroups: • Start sync → run record + job dispatch + upserts • Retention purge semantics • Scheduled dispatch wiring • Render-time Graph guard • UI/resource access isolation • Ran: • ./vendor/bin/pint --dirty • ./vendor/bin/sail artisan test tests/Feature/DirectoryGroups • ./vendor/bin/sail artisan test tests/Unit/DirectoryGroups Notes / Follow-ups • UI polish remains (picker/lookup UX, consistent progress widget/toasts across modules, navigation grouping). • pr-gate checklist still has non-blocking open items (mostly UX/ops polish); requirements gate is green. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #57
212 lines
7.9 KiB
PHP
212 lines
7.9 KiB
PHP
<?php
|
|
|
|
namespace App\Filament\Resources;
|
|
|
|
use App\Filament\Resources\EntraGroupResource\Pages;
|
|
use App\Models\EntraGroup;
|
|
use App\Models\Tenant;
|
|
use BackedEnum;
|
|
use Filament\Actions;
|
|
use Filament\Infolists\Components\TextEntry;
|
|
use Filament\Infolists\Components\ViewEntry;
|
|
use Filament\Resources\Resource;
|
|
use Filament\Schemas\Components\Section;
|
|
use Filament\Schemas\Schema;
|
|
use Filament\Tables;
|
|
use Filament\Tables\Filters\SelectFilter;
|
|
use Filament\Tables\Table;
|
|
use Illuminate\Database\Eloquent\Builder;
|
|
use UnitEnum;
|
|
|
|
class EntraGroupResource extends Resource
|
|
{
|
|
protected static bool $isScopedToTenant = false;
|
|
|
|
protected static ?string $model = EntraGroup::class;
|
|
|
|
protected static string|BackedEnum|null $navigationIcon = 'heroicon-o-user-group';
|
|
|
|
protected static string|UnitEnum|null $navigationGroup = 'Directory';
|
|
|
|
protected static ?string $navigationLabel = 'Groups';
|
|
|
|
public static function form(Schema $schema): Schema
|
|
{
|
|
return $schema;
|
|
}
|
|
|
|
public static function infolist(Schema $schema): Schema
|
|
{
|
|
return $schema
|
|
->schema([
|
|
Section::make('Group')
|
|
->schema([
|
|
TextEntry::make('display_name')->label('Name'),
|
|
TextEntry::make('entra_id')->label('Entra ID')->copyable(),
|
|
TextEntry::make('type')
|
|
->badge()
|
|
->state(fn (EntraGroup $record): string => static::groupTypeLabel(static::groupType($record))),
|
|
TextEntry::make('security_enabled')->label('Security')->badge(),
|
|
TextEntry::make('mail_enabled')->label('Mail')->badge(),
|
|
TextEntry::make('last_seen_at')->label('Last seen')->dateTime()->placeholder('—'),
|
|
])
|
|
->columns(2)
|
|
->columnSpanFull(),
|
|
|
|
Section::make('Raw groupTypes')
|
|
->schema([
|
|
ViewEntry::make('group_types')
|
|
->label('')
|
|
->view('filament.infolists.entries.snapshot-json')
|
|
->state(fn (EntraGroup $record) => $record->group_types ?? [])
|
|
->columnSpanFull(),
|
|
])
|
|
->columnSpanFull(),
|
|
]);
|
|
}
|
|
|
|
public static function table(Table $table): Table
|
|
{
|
|
return $table
|
|
->defaultSort('display_name')
|
|
->modifyQueryUsing(function (Builder $query): Builder {
|
|
$tenantId = Tenant::current()?->getKey();
|
|
|
|
return $query->when($tenantId, fn (Builder $q) => $q->where('tenant_id', $tenantId));
|
|
})
|
|
->columns([
|
|
Tables\Columns\TextColumn::make('display_name')->label('Name')->searchable(),
|
|
Tables\Columns\TextColumn::make('entra_id')->label('Entra ID')->copyable()->toggleable(),
|
|
Tables\Columns\TextColumn::make('type')
|
|
->label('Type')
|
|
->badge()
|
|
->state(fn (EntraGroup $record): string => static::groupTypeLabel(static::groupType($record)))
|
|
->color(fn (EntraGroup $record): string => static::groupTypeColor(static::groupType($record))),
|
|
Tables\Columns\TextColumn::make('last_seen_at')->since()->label('Last seen'),
|
|
])
|
|
->filters([
|
|
SelectFilter::make('stale')
|
|
->label('Stale')
|
|
->options([
|
|
'1' => 'Stale',
|
|
'0' => 'Fresh',
|
|
])
|
|
->query(function (Builder $query, array $data): Builder {
|
|
$value = $data['value'] ?? null;
|
|
|
|
if ($value === null || $value === '') {
|
|
return $query;
|
|
}
|
|
|
|
$stalenessDays = (int) config('directory_groups.staleness_days', 30);
|
|
$cutoff = now('UTC')->subDays(max(1, $stalenessDays));
|
|
|
|
if ((string) $value === '1') {
|
|
return $query->where(function (Builder $q) use ($cutoff): void {
|
|
$q->whereNull('last_seen_at')
|
|
->orWhere('last_seen_at', '<', $cutoff);
|
|
});
|
|
}
|
|
|
|
return $query->where('last_seen_at', '>=', $cutoff);
|
|
}),
|
|
|
|
SelectFilter::make('group_type')
|
|
->label('Type')
|
|
->options([
|
|
'security' => 'Security',
|
|
'microsoft365' => 'Microsoft 365',
|
|
'mail' => 'Mail-enabled',
|
|
'unknown' => 'Unknown',
|
|
])
|
|
->query(function (Builder $query, array $data): Builder {
|
|
$value = (string) ($data['value'] ?? '');
|
|
|
|
if ($value === '') {
|
|
return $query;
|
|
}
|
|
|
|
return match ($value) {
|
|
'microsoft365' => $query->whereJsonContains('group_types', 'Unified'),
|
|
'security' => $query
|
|
->where('security_enabled', true)
|
|
->where(function (Builder $q): void {
|
|
$q->whereNull('group_types')
|
|
->orWhereJsonDoesntContain('group_types', 'Unified');
|
|
}),
|
|
'mail' => $query
|
|
->where('mail_enabled', true)
|
|
->where(function (Builder $q): void {
|
|
$q->whereNull('group_types')
|
|
->orWhereJsonDoesntContain('group_types', 'Unified');
|
|
}),
|
|
'unknown' => $query
|
|
->where(function (Builder $q): void {
|
|
$q->whereNull('group_types')
|
|
->orWhereJsonDoesntContain('group_types', 'Unified');
|
|
})
|
|
->where('security_enabled', false)
|
|
->where('mail_enabled', false),
|
|
default => $query,
|
|
};
|
|
}),
|
|
])
|
|
->actions([
|
|
Actions\ViewAction::make(),
|
|
])
|
|
->bulkActions([]);
|
|
}
|
|
|
|
public static function getEloquentQuery(): Builder
|
|
{
|
|
return parent::getEloquentQuery()->latest('id');
|
|
}
|
|
|
|
public static function getPages(): array
|
|
{
|
|
return [
|
|
'index' => Pages\ListEntraGroups::route('/'),
|
|
'view' => Pages\ViewEntraGroup::route('/{record}'),
|
|
];
|
|
}
|
|
|
|
private static function groupType(EntraGroup $record): string
|
|
{
|
|
$groupTypes = $record->group_types;
|
|
|
|
if (is_array($groupTypes) && in_array('Unified', $groupTypes, true)) {
|
|
return 'microsoft365';
|
|
}
|
|
|
|
if ($record->security_enabled) {
|
|
return 'security';
|
|
}
|
|
|
|
if ($record->mail_enabled) {
|
|
return 'mail';
|
|
}
|
|
|
|
return 'unknown';
|
|
}
|
|
|
|
private static function groupTypeLabel(string $type): string
|
|
{
|
|
return match ($type) {
|
|
'microsoft365' => 'Microsoft 365',
|
|
'security' => 'Security',
|
|
'mail' => 'Mail-enabled',
|
|
default => 'Unknown',
|
|
};
|
|
}
|
|
|
|
private static function groupTypeColor(string $type): string
|
|
{
|
|
return match ($type) {
|
|
'microsoft365' => 'info',
|
|
'security' => 'success',
|
|
'mail' => 'warning',
|
|
default => 'gray',
|
|
};
|
|
}
|
|
}
|