ahmido
bc846d7c5c
Summary Adds a tenant-scoped Entra Groups “Directory Cache” to enable DB-only group name resolution across the app (no render-time Graph calls), plus sync runs + observability. What’s included • Entra Groups cache • New entra_groups storage (tenant-scoped) for group metadata (no memberships). • Retention semantics: groups become stale / retained per spec (no hard delete on first miss). • Group Sync Runs • New “Group Sync Runs” UI (list + detail) with tenant isolation (403 on cross-tenant access). • Manual “Sync Groups” action: creates/reuses a run, dispatches job, DB notification with “View run” link. • Scheduled dispatcher command wired in console.php. • DB-only label resolution (US3) • Shared EntraGroupLabelResolver with safe fallback Unresolved (…last8) and UUID guarding. • Refactors to prefer cached names (no typeahead / no live Graph) in: • Tenant RBAC group selects • Policy version assignments widget • Restore results + restore wizard group mapping labels Safety / Guardrails • No render-time Graph calls: fail-hard guard test verifies UI paths don’t call GraphClientInterface during page render. • Tenant isolation & authorization: policies + scoped queries enforced (cross-tenant access returns 403, not 404). • Data minimization: only group metadata is cached (no membership/owners). Tests / Verification • Added/updated tests under tests/Feature/DirectoryGroups and tests/Unit/DirectoryGroups: • Start sync → run record + job dispatch + upserts • Retention purge semantics • Scheduled dispatch wiring • Render-time Graph guard • UI/resource access isolation • Ran: • ./vendor/bin/pint --dirty • ./vendor/bin/sail artisan test tests/Feature/DirectoryGroups • ./vendor/bin/sail artisan test tests/Unit/DirectoryGroups Notes / Follow-ups • UI polish remains (picker/lookup UX, consistent progress widget/toasts across modules, navigation grouping). • pr-gate checklist still has non-blocking open items (mostly UX/ops polish); requirements gate is green. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #57
115 lines
3.7 KiB
PHP
115 lines
3.7 KiB
PHP
<?php
|
|
|
|
use App\Filament\Resources\EntraGroupResource;
|
|
use App\Filament\Resources\EntraGroupResource\Pages\ListEntraGroups;
|
|
use App\Models\EntraGroup;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Illuminate\Support\Collection;
|
|
use Livewire\Livewire;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
test('cached groups can be listed, searched, and filtered (DB-only)', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$otherTenant = Tenant::factory()->create();
|
|
|
|
$stalenessDays = (int) config('directory_groups.staleness_days', 30);
|
|
|
|
EntraGroup::query()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'entra_id' => '00000000-0000-0000-0000-000000000001',
|
|
'display_name' => 'Alpha Team',
|
|
'group_types' => null,
|
|
'security_enabled' => true,
|
|
'mail_enabled' => false,
|
|
'last_seen_at' => now(),
|
|
]);
|
|
|
|
EntraGroup::query()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'entra_id' => '00000000-0000-0000-0000-000000000002',
|
|
'display_name' => 'Beta Unified',
|
|
'group_types' => ['Unified'],
|
|
'security_enabled' => false,
|
|
'mail_enabled' => true,
|
|
'last_seen_at' => now()->subDays(max(1, $stalenessDays) + 1),
|
|
]);
|
|
|
|
EntraGroup::query()->create([
|
|
'tenant_id' => $otherTenant->getKey(),
|
|
'entra_id' => '00000000-0000-0000-0000-000000000003',
|
|
'display_name' => 'Other Tenant Group',
|
|
'group_types' => null,
|
|
'security_enabled' => true,
|
|
'mail_enabled' => false,
|
|
'last_seen_at' => now(),
|
|
]);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$extractNames = function ($livewire): Collection {
|
|
$records = $livewire->instance()->getTableRecords();
|
|
|
|
$items = method_exists($records, 'items') ? collect($records->items()) : collect($records);
|
|
|
|
return $items->pluck('display_name');
|
|
};
|
|
|
|
$names = $extractNames(Livewire::test(ListEntraGroups::class));
|
|
expect($names)->toContain('Alpha Team');
|
|
expect($names)->toContain('Beta Unified');
|
|
expect($names)->not->toContain('Other Tenant Group');
|
|
|
|
$names = $extractNames(
|
|
Livewire::test(ListEntraGroups::class)
|
|
->set('tableSearch', 'Beta')
|
|
);
|
|
expect($names)->toContain('Beta Unified');
|
|
expect($names)->not->toContain('Alpha Team');
|
|
|
|
$names = $extractNames(
|
|
Livewire::test(ListEntraGroups::class)
|
|
->set('tableFilters.stale.value', 1)
|
|
);
|
|
expect($names)->toContain('Beta Unified');
|
|
expect($names)->not->toContain('Alpha Team');
|
|
|
|
$names = $extractNames(
|
|
Livewire::test(ListEntraGroups::class)
|
|
->set('tableFilters.group_type.value', 'security')
|
|
);
|
|
expect($names)->toContain('Alpha Team');
|
|
expect($names)->not->toContain('Beta Unified');
|
|
});
|
|
|
|
test('group detail is tenant-scoped and cross-tenant access is forbidden (403)', function () {
|
|
$tenantA = Tenant::factory()->create();
|
|
$tenantB = Tenant::factory()->create();
|
|
|
|
$groupB = EntraGroup::query()->create([
|
|
'tenant_id' => $tenantB->getKey(),
|
|
'entra_id' => '00000000-0000-0000-0000-000000000099',
|
|
'display_name' => 'Tenant B Group',
|
|
'group_types' => null,
|
|
'security_enabled' => true,
|
|
'mail_enabled' => false,
|
|
'last_seen_at' => now(),
|
|
]);
|
|
|
|
$user = User::factory()->create();
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$tenantA->getKey() => ['role' => 'owner'],
|
|
$tenantB->getKey() => ['role' => 'owner'],
|
|
]);
|
|
|
|
$this->actingAs($user)
|
|
->get(EntraGroupResource::getUrl('view', ['record' => $groupB], tenant: $tenantA))
|
|
->assertForbidden();
|
|
});
|