ahmido
38d9826f5e
Implements workspace-first enforcement and UX: - Workspace selected before tenant flows; /admin routes into choose-workspace/choose-tenant - Tenant lists and default tenant selection are scoped to current workspace - Workspaces UI is tenantless at /admin/workspaces Security hardening: - Workspaces can never have 0 owners (blocks last-owner removal/demotion) - Blocked attempts are audited with action_id=workspace_membership.last_owner_blocked + required metadata - Optional break-glass recovery page to re-assign workspace owner (audited) Tests: - Added/updated Pest feature tests covering redirects, scoping, tenantless workspaces, last-owner guards, and break-glass recovery. Notes: - Filament v5 strict Page property signatures respected in RepairWorkspaceOwners. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #86
97 lines
3.2 KiB
PHP
97 lines
3.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\AuditLog;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Models\WorkspaceMembership;
|
|
use App\Services\Auth\WorkspaceMembershipManager;
|
|
use App\Support\Auth\WorkspaceRole;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('blocks demoting the last remaining workspace owner and audits it', function () {
|
|
$workspace = Workspace::factory()->create();
|
|
|
|
$actor = User::factory()->create();
|
|
$target = User::factory()->create();
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => $workspace->getKey(),
|
|
'user_id' => $actor->getKey(),
|
|
'role' => WorkspaceRole::Manager->value,
|
|
]);
|
|
|
|
$targetMembership = WorkspaceMembership::factory()->create([
|
|
'workspace_id' => $workspace->getKey(),
|
|
'user_id' => $target->getKey(),
|
|
'role' => WorkspaceRole::Owner->value,
|
|
]);
|
|
|
|
$manager = app(WorkspaceMembershipManager::class);
|
|
|
|
expect(fn () => $manager->changeRole($workspace, $actor, $targetMembership, WorkspaceRole::Manager->value))
|
|
->toThrow(DomainException::class, 'You cannot demote the last remaining owner.');
|
|
|
|
$targetMembership->refresh();
|
|
expect($targetMembership->role)->toBe(WorkspaceRole::Owner->value);
|
|
|
|
$audit = AuditLog::query()
|
|
->where('workspace_id', $workspace->getKey())
|
|
->where('action', 'workspace_membership.last_owner_blocked')
|
|
->where('status', 'blocked')
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($audit)->not->toBeNull();
|
|
expect($audit->metadata)->toMatchArray([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
'actor_user_id' => (int) $actor->getKey(),
|
|
'target_user_id' => (int) $target->getKey(),
|
|
'attempted_role' => WorkspaceRole::Manager->value,
|
|
]);
|
|
});
|
|
|
|
it('blocks removing the last remaining workspace owner and audits it', function () {
|
|
$workspace = Workspace::factory()->create();
|
|
|
|
$actor = User::factory()->create();
|
|
$target = User::factory()->create();
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => $workspace->getKey(),
|
|
'user_id' => $actor->getKey(),
|
|
'role' => WorkspaceRole::Manager->value,
|
|
]);
|
|
|
|
$targetMembership = WorkspaceMembership::factory()->create([
|
|
'workspace_id' => $workspace->getKey(),
|
|
'user_id' => $target->getKey(),
|
|
'role' => WorkspaceRole::Owner->value,
|
|
]);
|
|
|
|
$manager = app(WorkspaceMembershipManager::class);
|
|
|
|
expect(fn () => $manager->removeMember($workspace, $actor, $targetMembership))
|
|
->toThrow(DomainException::class, 'You cannot remove the last remaining owner.');
|
|
|
|
expect(WorkspaceMembership::query()->whereKey($targetMembership->getKey())->exists())->toBeTrue();
|
|
|
|
$audit = AuditLog::query()
|
|
->where('workspace_id', $workspace->getKey())
|
|
->where('action', 'workspace_membership.last_owner_blocked')
|
|
->where('status', 'blocked')
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($audit)->not->toBeNull();
|
|
expect($audit->metadata)->toMatchArray([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
'actor_user_id' => (int) $actor->getKey(),
|
|
'target_user_id' => (int) $target->getKey(),
|
|
'attempted_action' => 'remove',
|
|
]);
|
|
});
|