Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
151 lines
4.9 KiB
PHP
151 lines
4.9 KiB
PHP
<?php
|
|
|
|
namespace App\Services\BackupScheduling;
|
|
|
|
use App\Jobs\RunBackupScheduleJob;
|
|
use App\Models\BackupSchedule;
|
|
use App\Models\Tenant;
|
|
use App\Services\Intune\AuditLogger;
|
|
use App\Services\OperationRunService;
|
|
use App\Support\OperationRunType;
|
|
use Carbon\CarbonImmutable;
|
|
use Illuminate\Support\Facades\Bus;
|
|
use Illuminate\Support\Facades\Log;
|
|
|
|
class BackupScheduleDispatcher
|
|
{
|
|
public function __construct(
|
|
private readonly ScheduleTimeService $scheduleTimeService,
|
|
private readonly AuditLogger $auditLogger,
|
|
private readonly OperationRunService $operationRunService,
|
|
) {}
|
|
|
|
/**
|
|
* Dispatch due schedules.
|
|
*
|
|
* No catch-up policy: we only dispatch if the current minute-slot is due.
|
|
*
|
|
* @return array{created_runs:int, skipped_runs:int, scanned_schedules:int}
|
|
*/
|
|
public function dispatchDue(?array $tenantIdentifiers = null): array
|
|
{
|
|
$nowUtc = CarbonImmutable::now('UTC');
|
|
|
|
$schedulesQuery = BackupSchedule::query()
|
|
->where('is_enabled', true)
|
|
->whereHas('tenant', fn ($query) => $query->where('status', 'active'))
|
|
->with('tenant');
|
|
|
|
if (is_array($tenantIdentifiers) && ! empty($tenantIdentifiers)) {
|
|
$schedulesQuery->whereIn('tenant_id', $this->resolveTenantIds($tenantIdentifiers));
|
|
}
|
|
|
|
$createdRuns = 0;
|
|
$skippedRuns = 0;
|
|
$scannedSchedules = 0;
|
|
|
|
foreach ($schedulesQuery->cursor() as $schedule) {
|
|
$scannedSchedules++;
|
|
|
|
$slot = $this->scheduleTimeService->nextRunFor($schedule, $nowUtc->subMinute());
|
|
|
|
if ($slot === null) {
|
|
$schedule->forceFill(['next_run_at' => null])->saveQuietly();
|
|
|
|
continue;
|
|
}
|
|
|
|
if ($slot->greaterThan($nowUtc)) {
|
|
if (! $schedule->next_run_at || ! $schedule->next_run_at->equalTo($slot)) {
|
|
$schedule->forceFill(['next_run_at' => $slot])->saveQuietly();
|
|
}
|
|
|
|
continue;
|
|
}
|
|
|
|
$scheduledFor = $slot->startOfMinute();
|
|
|
|
$operationRun = $this->operationRunService->ensureRunWithIdentityStrict(
|
|
tenant: $schedule->tenant,
|
|
type: OperationRunType::BackupScheduleExecute->value,
|
|
identityInputs: [
|
|
'backup_schedule_id' => (int) $schedule->id,
|
|
'scheduled_for' => $scheduledFor->toDateTimeString(),
|
|
],
|
|
context: [
|
|
'backup_schedule_id' => (int) $schedule->id,
|
|
'scheduled_for' => $scheduledFor->toDateTimeString(),
|
|
'trigger' => 'scheduled',
|
|
],
|
|
);
|
|
|
|
if (! $operationRun->wasRecentlyCreated) {
|
|
$skippedRuns++;
|
|
|
|
Log::debug('Backup schedule operation already dispatched for slot.', [
|
|
'schedule_id' => $schedule->id,
|
|
'scheduled_for' => $scheduledFor->toDateTimeString(),
|
|
'operation_run_id' => $operationRun->getKey(),
|
|
]);
|
|
|
|
$schedule->forceFill([
|
|
'next_run_at' => $this->scheduleTimeService->nextRunFor($schedule, $nowUtc),
|
|
])->saveQuietly();
|
|
|
|
continue;
|
|
}
|
|
|
|
$createdRuns++;
|
|
|
|
$this->auditLogger->log(
|
|
tenant: $schedule->tenant,
|
|
action: 'backup_schedule.run_dispatched',
|
|
context: [
|
|
'metadata' => [
|
|
'backup_schedule_id' => $schedule->id,
|
|
'operation_run_id' => $operationRun->getKey(),
|
|
'scheduled_for' => $scheduledFor->toDateTimeString(),
|
|
],
|
|
],
|
|
resourceType: 'operation_run',
|
|
resourceId: (string) $operationRun->getKey(),
|
|
status: 'success'
|
|
);
|
|
|
|
$schedule->forceFill([
|
|
'next_run_at' => $this->scheduleTimeService->nextRunFor($schedule, $nowUtc),
|
|
])->saveQuietly();
|
|
|
|
Bus::dispatch(new RunBackupScheduleJob(0, $operationRun, (int) $schedule->id));
|
|
}
|
|
|
|
return [
|
|
'created_runs' => $createdRuns,
|
|
'skipped_runs' => $skippedRuns,
|
|
'scanned_schedules' => $scannedSchedules,
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @param array<int, string> $tenantIdentifiers
|
|
* @return array<int>
|
|
*/
|
|
private function resolveTenantIds(array $tenantIdentifiers): array
|
|
{
|
|
$tenantIds = [];
|
|
|
|
foreach ($tenantIdentifiers as $identifier) {
|
|
$tenant = Tenant::query()
|
|
->where('status', 'active')
|
|
->forTenant($identifier)
|
|
->first();
|
|
|
|
if ($tenant) {
|
|
$tenantIds[] = $tenant->id;
|
|
}
|
|
}
|
|
|
|
return array_values(array_unique($tenantIds));
|
|
}
|
|
}
|