ahmido
d6e7de597a
Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
43 lines
1.7 KiB
PHP
43 lines
1.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Support\Badges\BadgeCatalog;
|
|
use App\Support\Badges\BadgeDomain;
|
|
|
|
it('maps operation run status values to canonical badge semantics', function (): void {
|
|
$queued = BadgeCatalog::spec(BadgeDomain::OperationRunStatus, 'queued');
|
|
expect($queued->label)->toBe('Queued');
|
|
expect($queued->color)->toBe('warning');
|
|
|
|
$running = BadgeCatalog::spec(BadgeDomain::OperationRunStatus, 'running');
|
|
expect($running->label)->toBe('Running');
|
|
expect($running->color)->toBe('info');
|
|
|
|
$completed = BadgeCatalog::spec(BadgeDomain::OperationRunStatus, 'completed');
|
|
expect($completed->label)->toBe('Completed');
|
|
expect($completed->color)->toBe('gray');
|
|
});
|
|
|
|
it('maps operation run outcome values to canonical badge semantics', function (): void {
|
|
$pending = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'pending');
|
|
expect($pending->label)->toBe('Pending');
|
|
expect($pending->color)->toBe('gray');
|
|
|
|
$succeeded = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'succeeded');
|
|
expect($succeeded->label)->toBe('Succeeded');
|
|
expect($succeeded->color)->toBe('success');
|
|
|
|
$partial = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'partially_succeeded');
|
|
expect($partial->label)->toBe('Partially succeeded');
|
|
expect($partial->color)->toBe('warning');
|
|
|
|
$blocked = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'blocked');
|
|
expect($blocked->label)->toBe('Blocked');
|
|
expect($blocked->color)->toBe('warning');
|
|
|
|
$failed = BadgeCatalog::spec(BadgeDomain::OperationRunOutcome, 'failed');
|
|
expect($failed->label)->toBe('Failed');
|
|
expect($failed->color)->toBe('danger');
|
|
});
|