Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
91 lines
3.1 KiB
PHP
91 lines
3.1 KiB
PHP
<?php
|
|
|
|
use App\Jobs\EntraGroupSyncJob;
|
|
use App\Models\EntraGroup;
|
|
use App\Services\Directory\EntraGroupSyncService;
|
|
use App\Services\Graph\GraphClientInterface;
|
|
use App\Services\Graph\GraphResponse;
|
|
use App\Services\Intune\AuditLogger;
|
|
use App\Services\OperationRunService;
|
|
|
|
it('sync job upserts groups and updates run counters', function () {
|
|
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
EntraGroup::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'entra_id' => '11111111-1111-1111-1111-111111111111',
|
|
'display_name' => 'Old Name',
|
|
'last_seen_at' => now('UTC')->subDays(10),
|
|
]);
|
|
|
|
$mock = \Mockery::mock(GraphClientInterface::class);
|
|
$mock->shouldReceive('request')
|
|
->twice()
|
|
->andReturn(
|
|
new GraphResponse(success: true, data: [
|
|
'value' => [
|
|
[
|
|
'id' => '11111111-1111-1111-1111-111111111111',
|
|
'displayName' => 'New Name',
|
|
'groupTypes' => ['Unified'],
|
|
'securityEnabled' => false,
|
|
'mailEnabled' => true,
|
|
],
|
|
],
|
|
'@odata.nextLink' => 'https://graph.microsoft.com/v1.0/groups?$skiptoken=abc',
|
|
], status: 200),
|
|
new GraphResponse(success: true, data: [
|
|
'value' => [
|
|
[
|
|
'id' => '22222222-2222-2222-2222-222222222222',
|
|
'displayName' => 'Second Group',
|
|
'groupTypes' => [],
|
|
'securityEnabled' => true,
|
|
'mailEnabled' => false,
|
|
],
|
|
],
|
|
], status: 200),
|
|
);
|
|
|
|
app()->instance(GraphClientInterface::class, $mock);
|
|
|
|
/** @var OperationRunService $opService */
|
|
$opService = app(OperationRunService::class);
|
|
$opRun = $opService->ensureRun(
|
|
tenant: $tenant,
|
|
type: 'entra_group_sync',
|
|
inputs: ['selection_key' => 'groups-v1:all'],
|
|
initiator: $user,
|
|
);
|
|
|
|
$job = new EntraGroupSyncJob(
|
|
tenantId: (int) $tenant->getKey(),
|
|
selectionKey: 'groups-v1:all',
|
|
slotKey: null,
|
|
runId: null,
|
|
operationRun: $opRun,
|
|
);
|
|
|
|
$job->handle(app(EntraGroupSyncService::class), app(AuditLogger::class));
|
|
|
|
$opRun->refresh();
|
|
|
|
expect($opRun->status)->toBe('completed')
|
|
->and($opRun->outcome)->toBe('succeeded')
|
|
->and($opRun->summary_counts['processed'] ?? null)->toBe(2)
|
|
->and($opRun->summary_counts['updated'] ?? null)->toBe(2)
|
|
->and($opRun->summary_counts['failed'] ?? null)->toBe(0);
|
|
|
|
expect(EntraGroup::query()->where('tenant_id', $tenant->getKey())->count())->toBe(2);
|
|
|
|
$updated = EntraGroup::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('entra_id', '11111111-1111-1111-1111-111111111111')
|
|
->first();
|
|
|
|
expect($updated)->not->toBeNull()
|
|
->and($updated->display_name)->toBe('New Name')
|
|
->and($updated->mail_enabled)->toBeTrue();
|
|
});
|