ahmido
cd811cff4f
## Summary - replace broad substring-based masking with a shared exact/path-based secret classifier and workspace-scoped fingerprint hashing - persist protected snapshot metadata on `policy_versions` and keep secret-only changes visible in compare, drift, restore, review, verification, and ops surfaces - add Spec 120 artifacts, audit documentation, and focused Pest regression coverage for snapshot, audit, verification, review-pack, and notification behavior ## Validation - `vendor/bin/sail artisan test --compact tests/Feature/Intune/PolicySnapshotRedactionTest.php tests/Feature/Intune/PolicySnapshotFingerprintIsolationTest.php tests/Feature/ReviewPack/ReviewPackRedactionIntegrityTest.php tests/Feature/OpsUx/OperationRunNotificationRedactionTest.php tests/Feature/Verification/VerificationReportViewerDbOnlyTest.php` - `vendor/bin/sail bin pint --dirty --format agent` ## Spec / checklist status | Checklist | Total | Completed | Incomplete | Status | |-----------|-------|-----------|------------|--------| | requirements.md | 16 | 16 | 0 | ✓ PASS | - `tasks.md`: T001-T032 complete - `tasks.md`: T033 manual quickstart validation is still open and noted for follow-up ## Filament / platform notes - Livewire v4 compliance is unchanged - no panel provider changes; `bootstrap/providers.php` remains the registration location - no new globally searchable resources were introduced, so global search requirements are unchanged - no new destructive Filament actions were added - no new Filament assets were added; no `filament:assets` deployment change is required ## Testing coverage touched - snapshot persistence and fingerprint isolation - compare/drift protected-change evidence - audit, verification, review-pack, ops-failure, and notification sanitization - viewer/read-only Filament presentation updates Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #146
49 lines
1.5 KiB
PHP
49 lines
1.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\AuditLog;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Services\Audit\WorkspaceAuditLogger;
|
|
|
|
it('redacts secret-like fields in workspace audit metadata', function (): void {
|
|
$workspace = Workspace::factory()->create();
|
|
$actor = User::factory()->create();
|
|
|
|
/** @var WorkspaceAuditLogger $logger */
|
|
$logger = app(WorkspaceAuditLogger::class);
|
|
|
|
$logger->log(
|
|
workspace: $workspace,
|
|
action: 'test.redaction',
|
|
context: [
|
|
'metadata' => [
|
|
'access_token' => 'super-secret-token',
|
|
'client_secret' => 'super-secret-secret',
|
|
'passwordMinimumLength' => 12,
|
|
'nested' => [
|
|
'Authorization' => 'Bearer abc.def.ghi',
|
|
'safe' => 'ok',
|
|
],
|
|
],
|
|
],
|
|
actor: $actor,
|
|
status: 'success',
|
|
resourceType: 'workspace',
|
|
resourceId: (string) $workspace->getKey(),
|
|
);
|
|
|
|
$log = AuditLog::query()
|
|
->where('workspace_id', (int) $workspace->getKey())
|
|
->where('action', 'test.redaction')
|
|
->latest('id')
|
|
->firstOrFail();
|
|
|
|
expect($log->metadata['access_token'] ?? null)->toBe('[REDACTED]');
|
|
expect($log->metadata['client_secret'] ?? null)->toBe('[REDACTED]');
|
|
expect($log->metadata['passwordMinimumLength'] ?? null)->toBe(12);
|
|
expect($log->metadata['nested']['Authorization'] ?? null)->toBe('[REDACTED]');
|
|
expect($log->metadata['nested']['safe'] ?? null)->toBe('ok');
|
|
});
|