ahmido
da1adbdeb5
Implements Spec 119 (Drift Golden Master Cutover): - Baseline Compare is the only drift writer (`source = baseline.compare`). - Drift findings now store diff-compatible `evidence_jsonb` (summary.kind, baseline/current policy_version_id refs, fidelity + provenance). - Findings UI renders one-sided diffs for `missing_policy`/`unexpected_policy` when a single ref exists; otherwise shows explicit “diff unavailable”. - Removes legacy drift generator runtime (jobs/services/UI) and related tests. - Adds one-time migration to delete legacy drift findings (`finding_type=drift` where source is null or != baseline.compare). - Scopes baseline capture & landing duplicate warnings to latest completed inventory sync. - Canonicalizes compliance `scheduledActionsForRule` drift signal and keeps legacy snapshots comparable. Tests: - `vendor/bin/sail artisan test --compact` (full suite per tasks) - Focused pack: BaselinePolicyVersionResolverTest, BaselineCompareDriftEvidenceContractTest, DriftFindingDiffUnavailableTest, LegacyDriftFindingsCleanupMigrationTest, ComplianceNoncomplianceActionsDriftTest Notes: - Livewire v4+ / Filament v5 compatible (no legacy APIs). - No new external dependencies. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #144
36 lines
1.2 KiB
PHP
36 lines
1.2 KiB
PHP
<?php
|
|
|
|
use App\Models\Finding;
|
|
|
|
it('deletes legacy drift findings and keeps baseline compare drift findings', function (): void {
|
|
$legacyNullSource = Finding::factory()->create([
|
|
'finding_type' => Finding::FINDING_TYPE_DRIFT,
|
|
'source' => null,
|
|
]);
|
|
|
|
$legacyOtherSource = Finding::factory()->create([
|
|
'finding_type' => Finding::FINDING_TYPE_DRIFT,
|
|
'source' => 'legacy.drift',
|
|
]);
|
|
|
|
$baselineCompareFinding = Finding::factory()->create([
|
|
'finding_type' => Finding::FINDING_TYPE_DRIFT,
|
|
'source' => 'baseline.compare',
|
|
]);
|
|
|
|
$nonDriftFinding = Finding::factory()->permissionPosture()->create();
|
|
|
|
$migrationPath = base_path('database/migrations/2026_03_05_000001_delete_legacy_drift_findings.php');
|
|
|
|
expect(file_exists($migrationPath))->toBeTrue();
|
|
|
|
$migration = require $migrationPath;
|
|
|
|
$migration->up();
|
|
|
|
expect(Finding::query()->whereKey($legacyNullSource->getKey())->exists())->toBeFalse();
|
|
expect(Finding::query()->whereKey($legacyOtherSource->getKey())->exists())->toBeFalse();
|
|
expect(Finding::query()->whereKey($baselineCompareFinding->getKey())->exists())->toBeTrue();
|
|
expect(Finding::query()->whereKey($nonDriftFinding->getKey())->exists())->toBeTrue();
|
|
});
|