ahmido
da1adbdeb5
Implements Spec 119 (Drift Golden Master Cutover): - Baseline Compare is the only drift writer (`source = baseline.compare`). - Drift findings now store diff-compatible `evidence_jsonb` (summary.kind, baseline/current policy_version_id refs, fidelity + provenance). - Findings UI renders one-sided diffs for `missing_policy`/`unexpected_policy` when a single ref exists; otherwise shows explicit “diff unavailable”. - Removes legacy drift generator runtime (jobs/services/UI) and related tests. - Adds one-time migration to delete legacy drift findings (`finding_type=drift` where source is null or != baseline.compare). - Scopes baseline capture & landing duplicate warnings to latest completed inventory sync. - Canonicalizes compliance `scheduledActionsForRule` drift signal and keeps legacy snapshots comparable. Tests: - `vendor/bin/sail artisan test --compact` (full suite per tasks) - Focused pack: BaselinePolicyVersionResolverTest, BaselineCompareDriftEvidenceContractTest, DriftFindingDiffUnavailableTest, LegacyDriftFindingsCleanupMigrationTest, ComplianceNoncomplianceActionsDriftTest Notes: - Livewire v4+ / Filament v5 compatible (no legacy APIs). - No new external dependencies. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #144
77 lines
2.5 KiB
PHP
77 lines
2.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\BaselineProfile;
|
|
use App\Models\Finding;
|
|
use App\Models\OperationRun;
|
|
use App\Services\Baselines\BaselineAutoCloseService;
|
|
use Carbon\CarbonImmutable;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
afterEach(function (): void {
|
|
CarbonImmutable::setTestNow();
|
|
});
|
|
|
|
it('auto-resolves open baseline compare drift findings not detected in the latest run as no_longer_drifting', function (): void {
|
|
[, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
$profile = BaselineProfile::factory()->active()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
]);
|
|
|
|
$scopeKey = 'baseline_profile:'.$profile->getKey();
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => 'baseline_compare',
|
|
]);
|
|
|
|
$observedAt = CarbonImmutable::parse('2026-02-25T00:00:00Z');
|
|
CarbonImmutable::setTestNow($observedAt);
|
|
|
|
$staleFinding = Finding::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'finding_type' => Finding::FINDING_TYPE_DRIFT,
|
|
'source' => 'baseline.compare',
|
|
'scope_key' => $scopeKey,
|
|
'fingerprint' => 'drift-stale',
|
|
'recurrence_key' => 'drift-stale',
|
|
'status' => Finding::STATUS_NEW,
|
|
'resolved_at' => null,
|
|
'resolved_reason' => null,
|
|
]);
|
|
|
|
$seenFinding = Finding::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'finding_type' => Finding::FINDING_TYPE_DRIFT,
|
|
'source' => 'baseline.compare',
|
|
'scope_key' => $scopeKey,
|
|
'fingerprint' => 'drift-seen',
|
|
'recurrence_key' => 'drift-seen',
|
|
'status' => Finding::STATUS_NEW,
|
|
]);
|
|
|
|
$resolvedCount = app(BaselineAutoCloseService::class)->resolveStaleFindings(
|
|
tenant: $tenant,
|
|
baselineProfileId: (int) $profile->getKey(),
|
|
seenFingerprints: ['drift-seen'],
|
|
currentOperationRunId: (int) $run->getKey(),
|
|
);
|
|
|
|
expect($resolvedCount)->toBe(1);
|
|
|
|
$staleFinding->refresh();
|
|
$seenFinding->refresh();
|
|
|
|
expect($staleFinding->status)->toBe(Finding::STATUS_RESOLVED)
|
|
->and($staleFinding->resolved_reason)->toBe('no_longer_drifting')
|
|
->and($staleFinding->resolved_at?->toIso8601String())->toBe($observedAt->toIso8601String())
|
|
->and((int) $staleFinding->current_operation_run_id)->toBe((int) $run->getKey());
|
|
|
|
expect($seenFinding->status)->toBe(Finding::STATUS_NEW);
|
|
});
|