ahmido
a4f5c4f122
## Summary - standardize Filament table defaults across resources, relation managers, widgets, custom pages, and picker tables - add shared pagination profiles, calm default column visibility, explicit empty states, and session persistence on designated critical resource lists - complete Spec 125 artifacts, regression tests, and dashboard widget follow-up for lazy loading, sortable columns, and toggleable detail columns ## Verification - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=BaselineCompareNow` - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=TableStandardsBaseline` - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=TableDetailVisibility` - `docker exec tenantatlas-laravel.test-1 php artisan test --compact --filter=FilamentTableRiskExceptions` - full suite run completed: `2017 passed, 10 failed, 8 skipped` - manual browser QA completed on the tenant dashboard for lazy loading, sortable widget columns, toggleable hidden status columns, badges, and pagination ## Known Failures The full suite still has 10 pre-existing failures unrelated to this branch: - `Tests\\Unit\\OpsUx\\SummaryCountsNormalizerTest` - `Tests\\Feature\\BackupWithAssignmentsConsistencyTest` (2 tests) - `Tests\\Feature\\BaselineDriftEngine\\CaptureBaselineContentTest` - `Tests\\Feature\\BaselineDriftEngine\\CompareContentEvidenceTest` - `Tests\\Feature\\BaselineDriftEngine\\ResolverTest` - `Tests\\Feature\\Filament\\TenantDashboardDbOnlyTest` - `Tests\\Feature\\Operations\\ReconcileAdapterRunsJobTrackingTest` - `Tests\\Feature\\ReviewPack\\ReviewPackRbacTest` - `Tests\\Feature\\Verification\\VerificationReportRedactionTest` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #152
43 lines
1.9 KiB
PHP
43 lines
1.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
it('documents the approved no-search and query-risk exceptions in the table standard', function (): void {
|
|
$contents = file_get_contents(base_path('docs/ui/filament-table-standard.md'));
|
|
|
|
expect($contents)->toBeString();
|
|
expect($contents)->toContain('RecentDriftFindings');
|
|
expect($contents)->toContain('RecentOperations');
|
|
expect($contents)->toContain('Directory/Workspaces');
|
|
expect($contents)->toContain('InventoryCoverage');
|
|
expect($contents)->toContain('Picker tables keep workflow-local search only');
|
|
});
|
|
|
|
it('keeps computed workspace health metrics out of sortable and searchable columns', function (): void {
|
|
$contents = file_get_contents(base_path('app/Filament/System/Pages/Directory/Workspaces.php'));
|
|
|
|
expect($contents)->toBeString();
|
|
|
|
$healthBlockMatched = preg_match("/TextColumn::make\\('health'\\)(.*?)(?:TextColumn::make\\('failed_runs_24h'\\)|->recordUrl)/s", $contents, $healthMatches);
|
|
$failedRunsBlockMatched = preg_match("/TextColumn::make\\('failed_runs_24h'\\)(.*?)(?:->recordUrl|->emptyStateHeading)/s", $contents, $failedRunsMatches);
|
|
|
|
expect($healthBlockMatched)->toBe(1);
|
|
expect($failedRunsBlockMatched)->toBe(1);
|
|
expect($healthMatches[1] ?? '')->not->toContain('->searchable(');
|
|
expect($healthMatches[1] ?? '')->not->toContain('->sortable(');
|
|
expect($failedRunsMatches[1] ?? '')->not->toContain('->searchable(');
|
|
expect($failedRunsMatches[1] ?? '')->not->toContain('->sortable(');
|
|
});
|
|
|
|
it('keeps dashboard widgets as glance surfaces instead of searchable workbenches', function (): void {
|
|
foreach ([
|
|
'app/Filament/Widgets/Dashboard/RecentDriftFindings.php',
|
|
'app/Filament/Widgets/Dashboard/RecentOperations.php',
|
|
] as $relativePath) {
|
|
$contents = file_get_contents(base_path($relativePath));
|
|
|
|
expect($contents)->toBeString();
|
|
expect($contents)->not->toContain('->searchable(');
|
|
}
|
|
});
|