## Summary - add Intune RBAC Role Definition baseline scope support, capture references, compare classification, findings evidence, and landing/detail UI labels - keep Intune Role Assignments explicitly excluded from baseline compare scope, summaries, findings, and restore messaging - add focused Pest coverage for baseline scope selection, capture, compare behavior, recurrence, isolation, findings rendering, inventory anchoring, and RBAC summaries ## Verification - `vendor/bin/sail bin pint --dirty --format agent` - `vendor/bin/sail artisan test --compact tests/Unit/Inventory/InventoryPolicyTypeMetaBaselineSupportTest.php tests/Unit/Baselines/BaselinePolicyVersionResolverTest.php tests/Unit/Baselines/BaselineScopeTest.php tests/Unit/IntuneRoleDefinitionNormalizerTest.php tests/Feature/Baselines/BaselineCaptureRbacRoleDefinitionsTest.php tests/Feature/Baselines/BaselineCompareRbacRoleDefinitionsTest.php tests/Feature/Baselines/BaselineCompareDriftEvidenceContractRbacTest.php tests/Feature/Baselines/BaselineCompareCoverageGuardTest.php tests/Feature/Baselines/BaselineCompareCrossTenantMatchTest.php tests/Feature/Baselines/BaselineCompareFindingRecurrenceKeyTest.php tests/Feature/Baselines/BaselineCompareWhyNoFindingsReasonCodeTest.php tests/Feature/Filament/BaselineProfileFoundationScopeTest.php tests/Feature/Filament/BaselineSnapshotRbacRoleDefinitionsTest.php tests/Feature/Filament/BaselineCompareLandingRbacLabelsTest.php tests/Feature/Filament/FindingViewRbacEvidenceTest.php tests/Feature/Findings/FindingRecurrenceTest.php tests/Feature/Findings/DriftStaleAutoResolveTest.php tests/Feature/Inventory/InventorySyncButtonTest.php tests/Feature/Inventory/InventorySyncServiceTest.php tests/Feature/RunAuthorizationTenantIsolationTest.php` - result: `71 passed (467 assertions)` ## Filament / Platform Notes - Livewire compliance: unchanged and compatible with Livewire v4.0+ - Provider registration: no panel/provider changes; `bootstrap/providers.php` remains the registration location - Global search: no new globally searchable resource added; existing global search behavior is unchanged - Destructive actions: no new destructive actions introduced; existing confirmed actions remain unchanged - Assets: no new Filament assets introduced; deploy asset handling remains unchanged, including `php artisan filament:assets` - Testing plan covered: baseline profile scope, snapshot detail, compare job, findings recurrence, findings detail, compare landing labels, inventory sync anchoring, and tenant isolation Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #156
79 lines
2.5 KiB
PHP
79 lines
2.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Services\Baselines;
|
|
|
|
use App\Services\Drift\DriftHasher;
|
|
use App\Support\Baselines\BaselineSubjectKey;
|
|
|
|
/**
|
|
* Computes the snapshot_identity_hash for baseline snapshot content dedupe.
|
|
*
|
|
* The identity hash is a sha256 over normalized snapshot items, enabling
|
|
* detection of "nothing changed" when capturing the same inventory state.
|
|
*/
|
|
final class BaselineSnapshotIdentity
|
|
{
|
|
public function __construct(
|
|
private readonly DriftHasher $hasher,
|
|
private readonly InventoryMetaContract $metaContract,
|
|
) {}
|
|
|
|
/**
|
|
* Compute identity hash over a set of snapshot items.
|
|
*
|
|
* Each item is represented as an associative array with:
|
|
* - policy_type, subject_key, baseline_hash
|
|
*
|
|
* @param array<int, array{policy_type: string, subject_key: ?string, baseline_hash: string}> $items
|
|
*/
|
|
public function computeIdentity(array $items): string
|
|
{
|
|
if ($items === []) {
|
|
return hash('sha256', '[]');
|
|
}
|
|
|
|
$normalized = array_map(
|
|
fn (array $item): string => implode('|', [
|
|
trim((string) ($item['policy_type'] ?? '')),
|
|
trim((string) ($item['subject_key'] ?? '')),
|
|
trim((string) ($item['baseline_hash'] ?? '')),
|
|
]),
|
|
$items,
|
|
);
|
|
|
|
sort($normalized, SORT_STRING);
|
|
|
|
return hash('sha256', implode("\n", $normalized));
|
|
}
|
|
|
|
public function subjectKey(string $policyType, ?string $displayName = null, ?string $subjectExternalId = null): ?string
|
|
{
|
|
return BaselineSubjectKey::forPolicy($policyType, $displayName, $subjectExternalId);
|
|
}
|
|
|
|
public function workspaceSafeSubjectExternalId(string $policyType, ?string $displayName = null, ?string $subjectExternalId = null): ?string
|
|
{
|
|
return BaselineSubjectKey::workspaceSafeSubjectExternalIdForPolicy($policyType, $displayName, $subjectExternalId);
|
|
}
|
|
|
|
/**
|
|
* Compute a stable content hash for a single inventory item's metadata.
|
|
*
|
|
* Hashes ONLY the Spec 116 meta contract output (not the full meta_jsonb payload).
|
|
*
|
|
* @param array<string, mixed> $metaJsonb
|
|
*/
|
|
public function hashItemContent(string $policyType, string $subjectExternalId, array $metaJsonb): string
|
|
{
|
|
$contract = $this->metaContract->build(
|
|
policyType: $policyType,
|
|
subjectExternalId: $subjectExternalId,
|
|
metaJsonb: $metaJsonb,
|
|
);
|
|
|
|
return $this->hasher->hashNormalized($contract);
|
|
}
|
|
}
|