ahmido
891f177311
## Summary - route the context-bar `Switch workspace` link to the canonical chooser flow instead of workspace management - add focused regression coverage for topbar switching, management separation, and chooser redirect semantics - add Spec 121 artifacts (`spec`, `plan`, `research`, `data-model`, `contracts`, `quickstart`, `tasks`, checklist) ## Validation - `vendor/bin/sail artisan test --compact tests/Feature/Monitoring/HeaderContextBarTest.php tests/Feature/Workspaces/WorkspaceSwitchUserMenuTest.php tests/Feature/Workspaces/ChooseWorkspacePageTest.php tests/Feature/Workspaces/WorkspaceNavigationHubTest.php tests/Feature/Workspaces/EnsureWorkspaceSelectedMiddlewareTest.php tests/Feature/Workspaces/ChooseWorkspaceRedirectsToChooseTenantTest.php` - `vendor/bin/sail bin pint --dirty --format agent` ## Notes - base branch: `dev` - branch: `121-workspace-switch-fix` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #147
58 lines
1.9 KiB
PHP
58 lines
1.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\ChooseWorkspace;
|
|
use App\Models\User;
|
|
use App\Models\Workspace;
|
|
use App\Models\WorkspaceMembership;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('keeps workspace switching out of sidebar navigation while management stays on its dedicated admin path', function (): void {
|
|
$user = User::factory()->create();
|
|
|
|
$workspace = Workspace::factory()->create();
|
|
$secondaryWorkspace = Workspace::factory()->create();
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => $workspace->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'role' => 'owner',
|
|
]);
|
|
|
|
WorkspaceMembership::factory()->create([
|
|
'workspace_id' => $secondaryWorkspace->getKey(),
|
|
'user_id' => $user->getKey(),
|
|
'role' => 'operator',
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$response = $this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $workspace->getKey()])
|
|
->get('/admin/operations')
|
|
->assertOk();
|
|
|
|
$response->assertSee('Switch workspace')
|
|
->assertSee(ChooseWorkspace::getUrl(panel: 'admin').'?choose=1', false);
|
|
|
|
$panel = Filament::getCurrentOrDefaultPanel();
|
|
|
|
$navigationItems = collect($panel->getNavigationItems());
|
|
$labels = $navigationItems
|
|
->map(static fn ($item): string => $item->getLabel())
|
|
->all();
|
|
$manageWorkspaces = $navigationItems
|
|
->first(static fn ($item): bool => $item->getLabel() === 'Manage workspaces');
|
|
|
|
expect($labels)->not->toContain('Switch workspace');
|
|
expect($labels)->toContain('Manage workspaces');
|
|
expect($labels)->not->toContain('Workspaces');
|
|
expect($manageWorkspaces)->not->toBeNull();
|
|
expect($manageWorkspaces->getUrl())->toBe(route('filament.admin.resources.workspaces.index'));
|
|
});
|