## Summary
- add a canonical queued execution legitimacy contract for actor-bound and system-authority operation runs
- enforce legitimacy before queued jobs transition runs to running across provider, inventory, restore, bulk, sync, and scheduled backup flows
- surface blocked execution outcomes consistently in Monitoring, notifications, audit data, and the tenantless operation viewer
- add Spec 149 artifacts and focused Pest coverage for legitimacy decisions, middleware ordering, blocked presentation, retry behavior, and cross-family adoption
## Testing
- vendor/bin/sail artisan test --compact tests/Unit/Operations/QueuedExecutionLegitimacyGateTest.php
- vendor/bin/sail artisan test --compact tests/Feature/Operations/QueuedExecutionMiddlewareOrderingTest.php
- vendor/bin/sail artisan test --compact tests/Feature/Verification/ProviderExecutionReauthorizationTest.php
- vendor/bin/sail artisan test --compact tests/Feature/Operations/RunInventorySyncExecutionReauthorizationTest.php
- vendor/bin/sail artisan test --compact tests/Feature/Operations/ExecuteRestoreRunExecutionReauthorizationTest.php
- vendor/bin/sail artisan test --compact tests/Feature/Operations/SystemRunBlockedExecutionNotificationTest.php
- vendor/bin/sail artisan test --compact tests/Feature/Operations/BulkOperationExecutionReauthorizationTest.php
- vendor/bin/sail artisan test --compact tests/Feature/Operations/QueuedExecutionRetryReauthorizationTest.php
- vendor/bin/sail artisan test --compact tests/Feature/Operations/QueuedExecutionContractMatrixTest.php
- vendor/bin/sail artisan test --compact tests/Feature/Operations/OperationRunBlockedExecutionPresentationTest.php
- vendor/bin/sail artisan test --compact tests/Feature/Operations/QueuedExecutionAuditTrailTest.php
- vendor/bin/sail artisan test --compact tests/Feature/Operations/TenantlessOperationRunViewerTest.php
- vendor/bin/sail bin pint --dirty --format agent
## Manual validation
- validated queued provider execution blocking for tenant operability drift in the integrated browser on /admin/operations and /admin/operations/{run}
- validated 404 vs 403 route behavior for non-membership vs in-scope capability denial
- validated initiator-null blocked system-run behavior without creating a user terminal notification
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #179
130 lines
4.1 KiB
PHP
130 lines
4.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Jobs\Operations\BulkOperationWorkerJob;
|
|
use App\Models\OperationRun;
|
|
use App\Services\OperationRunService;
|
|
use App\Services\Operations\QueuedExecutionLegitimacyGate;
|
|
use App\Support\Operations\ExecutionAuthorityMode;
|
|
use App\Support\Operations\ExecutionDenialReasonCode;
|
|
use App\Support\Operations\QueuedExecutionContext;
|
|
use App\Support\Operations\QueuedExecutionLegitimacyDecision;
|
|
|
|
function runQueuedRetryJobThroughMiddleware(object $job, Closure $terminal): mixed
|
|
{
|
|
$pipeline = array_reduce(
|
|
array_reverse($job->middleware()),
|
|
fn (Closure $next, object $middleware): Closure => fn (object $job): mixed => $middleware->handle($job, $next),
|
|
$terminal,
|
|
);
|
|
|
|
return $pipeline($job);
|
|
}
|
|
|
|
it('re-evaluates legitimacy on each bulk worker retry attempt', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$run = app(OperationRunService::class)->ensureRun(
|
|
tenant: $tenant,
|
|
type: 'policy.delete',
|
|
inputs: [
|
|
'target_scope' => [
|
|
'entra_tenant_id' => (string) ($tenant->tenant_id ?? $tenant->external_id),
|
|
],
|
|
],
|
|
initiator: $user,
|
|
);
|
|
|
|
$job = new class((int) $tenant->getKey(), (int) $user->getKey(), 'policy-123', $run) extends BulkOperationWorkerJob
|
|
{
|
|
protected function process(OperationRunService $runs): void {}
|
|
};
|
|
|
|
$context = new QueuedExecutionContext(
|
|
run: $run,
|
|
operationType: 'policy.delete',
|
|
workspaceId: (int) $tenant->workspace_id,
|
|
tenant: $tenant,
|
|
initiator: $user,
|
|
authorityMode: ExecutionAuthorityMode::ActorBound,
|
|
requiredCapability: 'tenant.manage',
|
|
providerConnectionId: null,
|
|
targetScope: [
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'provider_connection_id' => null,
|
|
],
|
|
);
|
|
|
|
$allowDecision = QueuedExecutionLegitimacyDecision::allow(
|
|
context: $context,
|
|
checks: [
|
|
'workspace_scope' => 'passed',
|
|
'tenant_scope' => 'passed',
|
|
'capability' => 'passed',
|
|
'tenant_operability' => 'passed',
|
|
'execution_prerequisites' => 'not_applicable',
|
|
],
|
|
);
|
|
|
|
$denyDecision = QueuedExecutionLegitimacyDecision::deny(
|
|
context: $context,
|
|
checks: [
|
|
'workspace_scope' => 'passed',
|
|
'tenant_scope' => 'passed',
|
|
'capability' => 'failed',
|
|
'tenant_operability' => 'passed',
|
|
'execution_prerequisites' => 'not_applicable',
|
|
],
|
|
reasonCode: ExecutionDenialReasonCode::MissingCapability,
|
|
metadata: [
|
|
'required_capability' => 'tenant.manage',
|
|
],
|
|
);
|
|
|
|
app()->instance(QueuedExecutionLegitimacyGate::class, new class($allowDecision, $denyDecision)
|
|
{
|
|
private int $callCount = 0;
|
|
|
|
public function __construct(
|
|
private readonly QueuedExecutionLegitimacyDecision $allowDecision,
|
|
private readonly QueuedExecutionLegitimacyDecision $denyDecision,
|
|
) {}
|
|
|
|
public function evaluate(OperationRun $run): QueuedExecutionLegitimacyDecision
|
|
{
|
|
return $this->callCount++ === 0 ? $this->allowDecision : $this->denyDecision;
|
|
}
|
|
});
|
|
|
|
$executionCount = 0;
|
|
|
|
runQueuedRetryJobThroughMiddleware(
|
|
$job,
|
|
function () use (&$executionCount): string {
|
|
$executionCount++;
|
|
|
|
return 'attempt-1';
|
|
},
|
|
);
|
|
|
|
$blockedResponse = runQueuedRetryJobThroughMiddleware(
|
|
$job,
|
|
function () use (&$executionCount): string {
|
|
$executionCount++;
|
|
|
|
return 'attempt-2';
|
|
},
|
|
);
|
|
|
|
$run->refresh();
|
|
|
|
expect($executionCount)->toBe(1)
|
|
->and($blockedResponse)->toBeNull()
|
|
->and($run->status)->toBe('completed')
|
|
->and($run->outcome)->toBe('blocked')
|
|
->and($run->context['reason_code'] ?? null)->toBe('missing_capability')
|
|
->and($run->context['execution_legitimacy']['checks']['capability'] ?? null)->toBe('failed');
|
|
});
|