## Summary
- centralize tenant operability into a lane-aware, actor-aware policy boundary
- align selector eligibility, administrative discoverability, remembered context, tenant-bound routes, and canonical run viewers
- add focused Pest coverage plus Spec 148 artifacts and final polish task completion
## Validation
- `vendor/bin/sail artisan test --compact tests/Unit/Tenants/TenantOperabilityServiceTest.php tests/Unit/Tenants/TenantOperabilityOutcomeTest.php tests/Feature/Workspaces/ChooseTenantPageTest.php tests/Feature/Workspaces/SelectTenantControllerTest.php tests/Feature/TenantRBAC/ArchivedTenantRouteAccessTest.php tests/Feature/TenantRBAC/TenantRouteDenyAsNotFoundTest.php tests/Feature/Operations/TenantlessOperationRunViewerTest.php tests/Feature/OpsUx/OperateHubShellTest.php tests/Feature/Rbac/TenantLifecycleActionVisibilityTest.php tests/Feature/TenantRBAC/TenantSwitcherScopeTest.php tests/Feature/Rbac/TenantResourceAuthorizationTest.php tests/Feature/Filament/ManagedTenantsLandingLifecycleTest.php tests/Feature/Filament/TenantGlobalSearchLifecycleScopeTest.php tests/Feature/Onboarding/OnboardingDraftLifecycleTest.php tests/Feature/Onboarding/OnboardingDraftAuthorizationTest.php`
- `vendor/bin/sail bin pint --dirty --format agent`
- manual browser smoke checks on `/admin/choose-tenant`, `/admin/tenants`, `/admin/onboarding`, `/admin/onboarding/{draft}`, and `/admin/operations/{run}`
## Filament / platform notes
- Livewire v4 compliance preserved
- panel provider registration unchanged in `bootstrap/providers.php`
- Tenant resource global search remains backed by existing view/edit pages and is now separated from active-only selector eligibility
- destructive actions remain action closures with confirmation and authorization enforcement
- no asset pipeline changes and no new `filament:assets` deployment requirement
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #177
302 lines
10 KiB
PHP
302 lines
10 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Pages\ChooseWorkspace;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
|
|
it('renders the tenant context picker on tenantless Monitoring → Operations', function (): void {
|
|
$tenant = Tenant::factory()->create(['status' => 'active']);
|
|
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
$workspaceName = $tenant->workspace?->name;
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$response = $this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
|
|
WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY => [
|
|
(string) $tenant->workspace_id => (int) $tenant->getKey(),
|
|
],
|
|
])
|
|
->get('/admin/operations')
|
|
->assertOk()
|
|
->assertSee($workspaceName ?? 'Select workspace')
|
|
->assertSee('Search tenants…')
|
|
->assertSee('Switch workspace')
|
|
->assertSee('admin/select-tenant')
|
|
->assertSee('Clear tenant scope')
|
|
->assertSee($tenant->getFilamentName());
|
|
|
|
$content = $response->getContent();
|
|
|
|
expect($content)->not->toBeFalse();
|
|
expect(
|
|
preg_match('/<a[^>]+href="([^"]+)"[^>]*>\s*Switch workspace\s*<\/a>/i', (string) $content, $matches)
|
|
)->toBe(1);
|
|
expect($matches[1] ?? null)->toBe(ChooseWorkspace::getUrl(panel: 'admin').'?choose=1');
|
|
expect($matches[1] ?? null)->not->toContain('/admin/workspaces');
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
|
|
])
|
|
->post(route('admin.select-tenant'), ['tenant_id' => (int) $tenant->getKey()])
|
|
->assertRedirect();
|
|
});
|
|
|
|
it('disables the tenant picker when no workspace is active (Global Mode)', function (): void {
|
|
$user = \App\Models\User::factory()->create();
|
|
$workspace = \App\Models\Workspace::factory()->create();
|
|
\App\Models\WorkspaceMembership::factory()->create([
|
|
'workspace_id' => (int) $workspace->getKey(),
|
|
'user_id' => (int) $user->getKey(),
|
|
'role' => 'owner',
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
session()->forget(WorkspaceContext::SESSION_KEY);
|
|
|
|
$this->actingAs($user)
|
|
->get('/admin/workspaces')
|
|
->assertOk()
|
|
->assertSee('Select workspace')
|
|
->assertSee('Select tenant')
|
|
->assertSee('Choose a workspace first.')
|
|
->assertDontSee('Search tenants…');
|
|
});
|
|
|
|
it('renders the tenant indicator read-only on tenant-scoped pages (Filament tenant menu is primary)', function (): void {
|
|
$tenant = Tenant::factory()->create(['status' => 'active']);
|
|
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
|
|
])
|
|
->get(route('filament.admin.resources.tenants.index', filamentTenantRouteParams($tenant)))
|
|
->assertOk()
|
|
->assertSee($tenant->getFilamentName())
|
|
->assertDontSee('Search tenants…')
|
|
->assertDontSee('admin/select-tenant')
|
|
->assertDontSee('Clear tenant scope');
|
|
});
|
|
|
|
it('renders the routed tenant as read-only context on tenant resource view pages', function (): void {
|
|
$currentTenant = Tenant::factory()->create([
|
|
'status' => 'active',
|
|
'name' => 'YPTW2',
|
|
'environment' => 'dev',
|
|
]);
|
|
[$user, $currentTenant] = createUserWithTenant($currentTenant, role: 'owner');
|
|
|
|
$routedTenant = Tenant::factory()->create([
|
|
'status' => Tenant::STATUS_ONBOARDING,
|
|
'workspace_id' => (int) $currentTenant->workspace_id,
|
|
'name' => 'Test',
|
|
'environment' => 'dev',
|
|
]);
|
|
|
|
createUserWithTenant($routedTenant, $user, role: 'owner');
|
|
|
|
Filament::setTenant($currentTenant, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $currentTenant->workspace_id,
|
|
WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY => [
|
|
(string) $currentTenant->workspace_id => (int) $currentTenant->getKey(),
|
|
],
|
|
])
|
|
->get(route('filament.admin.resources.tenants.view', ['record' => $routedTenant]))
|
|
->assertOk()
|
|
->assertSee($routedTenant->getFilamentName())
|
|
->assertSee('Switch tenant')
|
|
->assertDontSee('Search tenants…')
|
|
->assertDontSee('admin/select-tenant')
|
|
->assertDontSee('Clear tenant scope');
|
|
});
|
|
|
|
it('filters the header tenant picker to tenants the user can access', function (): void {
|
|
$tenantA = Tenant::factory()->create(['status' => 'active']);
|
|
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner', workspaceRole: 'readonly');
|
|
|
|
$tenantB = Tenant::factory()->create([
|
|
'status' => 'active',
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
'name' => 'ZZZ-UNAUTHORIZED-TENANT-NAME-12345',
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id,
|
|
])
|
|
->get('/admin/operations')
|
|
->assertOk()
|
|
->assertSee($tenantA->getFilamentName())
|
|
->assertDontSee($tenantB->getFilamentName());
|
|
});
|
|
|
|
it('keeps the header tenant picker limited to tenant-entitled active tenants for workspace owners', function (): void {
|
|
$tenantA = Tenant::factory()->create(['status' => 'active']);
|
|
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner', workspaceRole: 'owner');
|
|
|
|
$tenantB = Tenant::factory()->create([
|
|
'status' => 'active',
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
'name' => 'ZZZ-UNASSIGNED-TENANT-NAME-12345',
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id,
|
|
])
|
|
->get('/admin/operations')
|
|
->assertOk()
|
|
->assertSee($tenantA->getFilamentName())
|
|
->assertDontSee($tenantB->getFilamentName());
|
|
});
|
|
|
|
it('hides onboarding tenants from the header tenant picker even for workspace owners', function (): void {
|
|
$tenantA = Tenant::factory()->create([
|
|
'status' => 'active',
|
|
'name' => 'YPTW2',
|
|
'environment' => 'other',
|
|
]);
|
|
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner', workspaceRole: 'owner');
|
|
|
|
$onboardingTenant = Tenant::factory()->create([
|
|
'status' => Tenant::STATUS_ONBOARDING,
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
'name' => 'YPTW2',
|
|
'environment' => 'dev',
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id,
|
|
])
|
|
->get('/admin/operations')
|
|
->assertOk()
|
|
->assertSee($tenantA->getFilamentName())
|
|
->assertDontSee($onboardingTenant->getFilamentName());
|
|
});
|
|
|
|
it('does not implicitly switch tenant when opening canonical operation deep links', function (): void {
|
|
$tenantA = Tenant::factory()->create(['status' => 'active']);
|
|
[$user, $tenantA] = createUserWithTenant($tenantA, role: 'owner');
|
|
|
|
$tenantB = Tenant::factory()->create([
|
|
'status' => 'active',
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
]);
|
|
|
|
$user->tenants()->syncWithoutDetaching([
|
|
$tenantB->getKey() => ['role' => 'owner'],
|
|
]);
|
|
|
|
$runA = OperationRun::factory()->create([
|
|
'tenant_id' => (int) $tenantA->getKey(),
|
|
'workspace_id' => (int) $tenantA->workspace_id,
|
|
'type' => 'policy.sync',
|
|
'initiator_name' => 'TenantA',
|
|
]);
|
|
|
|
OperationRun::factory()->create([
|
|
'tenant_id' => (int) $tenantB->getKey(),
|
|
'workspace_id' => (int) $tenantB->workspace_id,
|
|
'type' => 'inventory_sync',
|
|
'initiator_name' => 'TenantB',
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id,
|
|
])
|
|
->get(route('admin.operations.view', ['run' => (int) $runA->getKey()]))
|
|
->assertOk();
|
|
|
|
expect(Filament::getTenant())->toBeNull();
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenantA->workspace_id,
|
|
])
|
|
->get('/admin/operations')
|
|
->assertOk()
|
|
->assertSee('Policy sync')
|
|
->assertSee('Inventory sync')
|
|
->assertSee('TenantA')
|
|
->assertSee('TenantB');
|
|
});
|
|
|
|
it('shows explicit mismatch context on canonical run pages while keeping the current header tenant label', function (): void {
|
|
$runTenant = Tenant::factory()->create([
|
|
'name' => 'Run Tenant',
|
|
]);
|
|
[$user, $runTenant] = createUserWithTenant($runTenant, role: 'owner');
|
|
|
|
$currentTenant = Tenant::factory()->create([
|
|
'name' => 'Current Tenant',
|
|
'workspace_id' => (int) $runTenant->workspace_id,
|
|
]);
|
|
|
|
createUserWithTenant($currentTenant, $user, role: 'owner');
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'tenant_id' => (int) $runTenant->getKey(),
|
|
'workspace_id' => (int) $runTenant->workspace_id,
|
|
'type' => 'policy.sync',
|
|
]);
|
|
|
|
Filament::setTenant($currentTenant, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $runTenant->workspace_id,
|
|
])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('Tenant scope: Current Tenant')
|
|
->assertSee('Current tenant context differs from this run')
|
|
->assertSee('Run tenant: Run Tenant.');
|
|
});
|
|
|
|
it('shows canonical workspace framing on canonical run pages with no selected tenant context', function (): void {
|
|
$tenant = Tenant::factory()->create([
|
|
'name' => 'Workspace Tenant',
|
|
]);
|
|
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'type' => 'policy.sync',
|
|
]);
|
|
|
|
Filament::setTenant(null, true);
|
|
|
|
$this->actingAs($user)
|
|
->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
|
|
])
|
|
->get(route('admin.operations.view', ['run' => (int) $run->getKey()]))
|
|
->assertOk()
|
|
->assertSee('All tenants')
|
|
->assertSee('Canonical workspace view')
|
|
->assertSee('No tenant context is currently selected.');
|
|
});
|