ahmido
0a1377c5f5
## Summary - add Spec 288 no-legacy route/helper and provider-core/role-authority guard coverage - extend the pinned Spec 281 and Spec 285 browser smokes plus lane/report classification wording for classification-only fallout handling - add the Spec 288 artifact package and contributor-facing quality-gate guidance while keeping Package Execution deferred to Spec 289 ## Validation - `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && REPO_ROOT="$(git rev-parse --show-toplevel)" && (cd "$REPO_ROOT/apps/platform" && ./vendor/bin/sail artisan test --compact tests/Feature/Guards/Spec288NoLegacyRouteAndHelperGuardTest.php tests/Feature/Guards/Spec288ProviderCoreAndRoleAuthorityGuardTest.php tests/Feature/Guards/AdminWorkspaceRoutesGuardTest.php tests/Feature/Guards/ProviderBoundaryPlatformCoreGuardTest.php tests/Feature/ProviderConnections/LegacyRedirectTest.php tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/Spec080WorkspaceManagedTenantAdminMigrationTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php tests/Feature/Filament/ManagedEnvironmentAccessScopeManagementTest.php tests/Feature/Guards/BrowserLaneIsolationTest.php tests/Feature/Guards/CiLaneFailureClassificationContractTest.php tests/Feature/Guards/CiHeavyBrowserWorkflowContractTest.php tests/Unit/Auth/NoRoleStringChecksTest.php)` - `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && REPO_ROOT="$(git rev-parse --show-toplevel)" && (cd "$REPO_ROOT/apps/platform" && ./vendor/bin/sail artisan test --compact tests/Browser/Spec281ProviderConnectionScopeSmokeTest.php tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php)` - `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && REPO_ROOT="$(git rev-parse --show-toplevel)" && (cd "$REPO_ROOT/apps/platform" && ./vendor/bin/sail bin pint --dirty --format agent)` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #347
95 lines
3.7 KiB
PHP
95 lines
3.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\ProviderConnectionResource;
|
|
use App\Filament\Resources\TenantResource;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\TenantOnboardingSession;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
pest()->browser()->timeout(20_000);
|
|
|
|
it('smokes provider-connection detail and managed-environment related provider summary continuity', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(
|
|
role: 'owner',
|
|
workspaceRole: 'manager',
|
|
ensureDefaultMicrosoftProviderConnection: false,
|
|
);
|
|
|
|
$tenant->forceFill([
|
|
'name' => 'Spec 281 Browser Environment',
|
|
'managed_environment_id' => '88888888-8888-8888-8888-888888888888',
|
|
'status' => ManagedEnvironment::STATUS_ONBOARDING,
|
|
])->save();
|
|
|
|
$connection = ProviderConnection::factory()->consentGranted()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
'display_name' => 'Spec 281 Browser Connection',
|
|
'entra_tenant_id' => '88888888-8888-8888-8888-888888888888',
|
|
'is_default' => true,
|
|
'verification_status' => 'healthy',
|
|
]);
|
|
|
|
$draft = TenantOnboardingSession::query()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'entra_tenant_id' => '88888888-8888-8888-8888-888888888888',
|
|
'current_step' => 'connection',
|
|
'state' => [
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
],
|
|
'started_by_user_id' => (int) $user->getKey(),
|
|
'updated_by_user_id' => (int) $user->getKey(),
|
|
]);
|
|
|
|
$this->actingAs($user)->withSession([
|
|
WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id,
|
|
WorkspaceContext::LAST_TENANT_IDS_SESSION_KEY => [
|
|
(string) $tenant->workspace_id => (int) $tenant->getKey(),
|
|
],
|
|
]);
|
|
|
|
$providerConnectionViewPath = (string) parse_url(ProviderConnectionResource::getUrl('view', [
|
|
'record' => $connection,
|
|
'managed_environment_id' => $tenant->external_id,
|
|
], panel: 'admin'), PHP_URL_PATH);
|
|
$tenantViewPath = (string) parse_url(TenantResource::getUrl('view', ['record' => $tenant], panel: 'admin'), PHP_URL_PATH);
|
|
|
|
visit(ProviderConnectionResource::getUrl('view', [
|
|
'record' => $connection,
|
|
'managed_environment_id' => $tenant->external_id,
|
|
], panel: 'admin'))
|
|
->waitForText('Spec 281 Browser Connection')
|
|
->assertScript("window.location.pathname === '{$providerConnectionViewPath}'", true)
|
|
->assertSee('Target scope')
|
|
->assertSee('Spec 281 Browser Environment')
|
|
->assertSee('Provider context')
|
|
->assertSee('Microsoft tenant ID')
|
|
->assertNoJavaScriptErrors()
|
|
->assertNoConsoleLogs();
|
|
|
|
visit(route('admin.onboarding.draft', ['onboardingDraft' => (int) $draft->getKey()]))
|
|
->waitForText('Provider connection')
|
|
->assertSee('Ready - Spec 281 Browser Environment')
|
|
->assertSee('Spec 281 Browser Environment')
|
|
->assertNoJavaScriptErrors()
|
|
->assertNoConsoleLogs();
|
|
|
|
visit(TenantResource::getUrl('view', ['record' => $tenant], panel: 'admin'))
|
|
->waitForText('Provider connection')
|
|
->assertScript("window.location.pathname === '{$tenantViewPath}'", true)
|
|
->assertSee('Spec 281 Browser Connection')
|
|
->assertSee('Target scope')
|
|
->assertSee('Spec 281 Browser Environment')
|
|
->assertSee('Open Provider Connections')
|
|
->assertNoJavaScriptErrors()
|
|
->assertNoConsoleLogs();
|
|
});
|