ahmido
eceeee9c5c
## Summary - retire the remaining tenant-scoped provider-connection legacy routes and update canonical verification and link behavior - complete the provider target-scope fallback cleanup so neutral shared scope data falls back to the managed environment when the raw connection tenant identifier is blank - stop mirroring workspace roles into managed-environment scope persistence and cut the targeted admin-panel test helpers over to the post-cutover context path - add and update the Spec 287 artifact package and targeted regression coverage for route retirement, provider-core neutralization, workspace-first RBAC, and helper cutover ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/LegacyRedirectTest.php tests/Feature/ProviderConnections/TenantlessListRouteTest.php tests/Feature/ProviderConnections/TenantlessListScopingTest.php tests/Feature/Auth/WorkspaceFirstManagedEnvironmentAccessTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php tests/Feature/Reviews/CustomerReviewWorkspaceLaunchLinksTest.php tests/Feature/Rbac/TriageReviewStateAuthorizationTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec281ProviderConnectionScopeSmokeTest.php tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - Filament remains on Livewire v4 and provider registration stays unchanged in `apps/platform/bootstrap/providers.php`. - No new asset registration or deployment-step changes are included in this slice. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #346
53 lines
2.2 KiB
PHP
53 lines
2.2 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Services\OperationRunService;
|
|
use App\Support\OperationRunOutcome;
|
|
use App\Support\OperationRunStatus;
|
|
use App\Support\Providers\ProviderReasonCodes;
|
|
|
|
it('Spec081 stores blocked operation runs with sanitized reason and link-only next steps', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create();
|
|
$service = app(OperationRunService::class);
|
|
|
|
$run = $service->ensureRunWithIdentity(
|
|
tenant: $tenant,
|
|
type: 'provider.connection.check',
|
|
identityInputs: [
|
|
'provider_connection_id' => 99,
|
|
],
|
|
context: [
|
|
'provider' => 'microsoft',
|
|
'provider_connection_id' => 99,
|
|
'target_scope' => [
|
|
'entra_tenant_id' => $tenant->graphTenantId(),
|
|
],
|
|
],
|
|
);
|
|
|
|
$finalized = $service->finalizeBlockedRun(
|
|
run: $run,
|
|
reasonCode: ProviderReasonCodes::ProviderCredentialMissing,
|
|
nextSteps: [
|
|
['label' => 'Update Credentials', 'url' => '/admin/provider-connections?managed_environment_id=demo'],
|
|
['label' => '', 'url' => '/invalid'],
|
|
],
|
|
message: 'client_secret=super-secret',
|
|
);
|
|
|
|
$finalized->refresh();
|
|
|
|
expect($finalized->status)->toBe(OperationRunStatus::Completed->value)
|
|
->and($finalized->outcome)->toBe(OperationRunOutcome::Blocked->value)
|
|
->and($finalized->context['reason_code'] ?? null)->toBe(ProviderReasonCodes::ProviderCredentialMissing)
|
|
->and(data_get($finalized->context, 'reason_translation.operator_label'))->toBe('Credentials missing')
|
|
->and(data_get($finalized->context, 'reason_translation.short_explanation'))->toContain('credentials required to authenticate')
|
|
->and($finalized->context['next_steps'] ?? [])->toBe([
|
|
['label' => 'Update Credentials', 'url' => '/admin/provider-connections?managed_environment_id=demo'],
|
|
])
|
|
->and($finalized->failure_summary[0]['reason_code'] ?? null)->toBe(ProviderReasonCodes::ProviderCredentialMissing)
|
|
->and((string) ($finalized->failure_summary[0]['message'] ?? ''))->not->toContain('secret');
|
|
});
|