ahmido
5248654691
## Summary - retire remaining legacy tenant-panel runtime assumptions in the Filament admin runtime and route resolution paths - centralize canonical admin environment context handling for shared surfaces instead of relying on deprecated `tenant` panel behavior - harden guard coverage so legacy `/admin/t` and `/admin/tenants` route families cannot regress - update scoped navigation, drillthrough, reference-link, and global-search tests to use the admin panel environment runtime - add the Spec 304 package under `specs/304-tenant-panel-dead-code-retirement/` and document the rollout in the product ledger ## Test Coverage Updated - `AdminSharedSurfacePanelParityTest` - `NoActiveTenantResourceRoutesTest` - `NoLegacyTenantPanelRuntimeTest` - `AdminTenantResolverGuardTest` - `PolicyVersionResolvedReferenceLinksTest` - `EntraGroupGlobalSearchScopeTest` - `OperationsDashboardDrillthroughTest` ## Runtime Notes - remains compliant with Filament v5 on Livewire v4 - no provider registration changes; provider registration location remains `apps/platform/bootstrap/providers.php` - no new globally searchable resource was introduced; existing scoped search assertions were updated only - no destructive actions were added or changed - no asset registration changes; deploy posture for `cd apps/platform && php artisan filament:assets` is unchanged ## Validation - updated tests and docs/spec artifacts were committed in this branch - tests were not re-run in this turn Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #359
55 lines
1.9 KiB
PHP
55 lines
1.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Illuminate\Support\Facades\Route;
|
|
|
|
it('does not register active /admin/t route family product routes', function (): void {
|
|
$legacyRouteUris = collect(Route::getRoutes())
|
|
->map(fn ($route): string => ltrim((string) $route->uri(), '/'))
|
|
->filter(fn (string $uri): bool => preg_match('#^admin/t(?:/|$)#', $uri) === 1)
|
|
->values();
|
|
|
|
expect($legacyRouteUris)->toBeEmpty();
|
|
});
|
|
|
|
it('does not register active /admin/tenants product routes', function (): void {
|
|
$legacyRouteUris = collect(Route::getRoutes())
|
|
->map(fn ($route): string => ltrim((string) $route->uri(), '/'))
|
|
->filter(fn (string $uri): bool => preg_match('#^admin/tenants(?:/|$)#', $uri) === 1)
|
|
->values();
|
|
|
|
expect($legacyRouteUris)->toBeEmpty();
|
|
});
|
|
|
|
it('does not register active tenant resource route names', function (): void {
|
|
$legacyRouteNames = collect(Route::getRoutes())
|
|
->map(fn ($route): ?string => $route->getName())
|
|
->filter(fn (?string $name): bool => is_string($name) && (
|
|
str_starts_with($name, 'filament.tenant.')
|
|
|| str_starts_with($name, 'filament.admin.resources.tenants.')
|
|
))
|
|
->values();
|
|
|
|
expect($legacyRouteNames)->toBeEmpty();
|
|
});
|
|
|
|
it('returns 404 for retired ManagedEnvironmentResource route shapes', function (): void {
|
|
[$user, $tenant] = createMinimalUserWithTenant(role: 'owner');
|
|
|
|
foreach ([
|
|
'/admin/t/'.$tenant->external_id,
|
|
'/admin/t/'.$tenant->external_id.'/inventory-items',
|
|
'/admin/tenants',
|
|
"/admin/tenants/{$tenant->external_id}",
|
|
"/admin/tenants/{$tenant->external_id}/edit",
|
|
"/admin/tenants/{$tenant->external_id}/memberships",
|
|
] as $path) {
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id])
|
|
->get($path)
|
|
->assertNotFound();
|
|
}
|
|
});
|