## Summary - retire the remaining tenant-scoped provider-connection legacy routes and update canonical verification and link behavior - complete the provider target-scope fallback cleanup so neutral shared scope data falls back to the managed environment when the raw connection tenant identifier is blank - stop mirroring workspace roles into managed-environment scope persistence and cut the targeted admin-panel test helpers over to the post-cutover context path - add and update the Spec 287 artifact package and targeted regression coverage for route retirement, provider-core neutralization, workspace-first RBAC, and helper cutover ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ProviderConnections/LegacyRedirectTest.php tests/Feature/ProviderConnections/TenantlessListRouteTest.php tests/Feature/ProviderConnections/TenantlessListScopingTest.php tests/Feature/Auth/WorkspaceFirstManagedEnvironmentAccessTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php tests/Feature/Reviews/CustomerReviewWorkspaceLaunchLinksTest.php tests/Feature/Rbac/TriageReviewStateAuthorizationTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec281ProviderConnectionScopeSmokeTest.php tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - Filament remains on Livewire v4 and provider registration stays unchanged in `apps/platform/bootstrap/providers.php`. - No new asset registration or deployment-step changes are included in this slice. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #346
131 lines
5.4 KiB
PHP
131 lines
5.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\ProviderCredential;
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Services\Providers\ProviderOperationStartGate;
|
|
use App\Support\OperationRunOutcome;
|
|
use App\Support\Providers\ProviderReasonCodes;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('stores neutral target-scope and nested provider context when provider operations start', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create([
|
|
'name' => 'Spec 281 Environment',
|
|
'managed_environment_id' => '44444444-4444-4444-4444-444444444444',
|
|
]);
|
|
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
'entra_tenant_id' => '44444444-4444-4444-4444-444444444444',
|
|
'consent_status' => 'granted',
|
|
]);
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
]);
|
|
|
|
$result = app(ProviderOperationStartGate::class)->start(
|
|
tenant: $tenant,
|
|
connection: $connection,
|
|
operationType: 'provider.connection.check',
|
|
dispatcher: fn (OperationRun $run): null => null,
|
|
);
|
|
|
|
$context = $result->run->fresh()->context;
|
|
|
|
expect($result->status)->toBe('started')
|
|
->and($context['target_scope'] ?? [])->toMatchArray([
|
|
'provider' => 'microsoft',
|
|
'scope_kind' => 'tenant',
|
|
'scope_identifier' => '44444444-4444-4444-4444-444444444444',
|
|
'scope_display_name' => 'Spec 281 Environment',
|
|
])
|
|
->and($context['target_scope'] ?? [])->not->toHaveKey('entra_tenant_id')
|
|
->and($context['provider_context']['details'][0] ?? [])->toMatchArray([
|
|
'detail_key' => 'microsoft_tenant_id',
|
|
'detail_value' => '44444444-4444-4444-4444-444444444444',
|
|
]);
|
|
});
|
|
|
|
it('stores neutral target-scope context when provider starts are blocked before a connection is resolved', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create([
|
|
'name' => 'Blocked Spec 281 Environment',
|
|
'managed_environment_id' => '55555555-5555-5555-5555-555555555555',
|
|
]);
|
|
|
|
$result = app(ProviderOperationStartGate::class)->start(
|
|
tenant: $tenant,
|
|
connection: null,
|
|
operationType: 'provider.connection.check',
|
|
dispatcher: fn (): null => null,
|
|
);
|
|
|
|
$context = $result->run->fresh()->context;
|
|
$report = $context['verification_report'] ?? [];
|
|
$report = is_array($report) ? $report : [];
|
|
$identity = $report['identity'] ?? [];
|
|
$identity = is_array($identity) ? $identity : [];
|
|
$evidence = $report['checks'][0]['evidence'] ?? [];
|
|
$evidence = is_array($evidence) ? $evidence : [];
|
|
|
|
expect($result->status)->toBe('blocked')
|
|
->and($result->run->outcome)->toBe(OperationRunOutcome::Blocked->value)
|
|
->and($context['reason_code'] ?? null)->toBe(ProviderReasonCodes::ProviderConnectionMissing)
|
|
->and($context['target_scope'] ?? [])->toMatchArray([
|
|
'provider' => 'microsoft',
|
|
'scope_kind' => 'tenant',
|
|
'scope_identifier' => '55555555-5555-5555-5555-555555555555',
|
|
])
|
|
->and($context['target_scope'] ?? [])->not->toHaveKey('entra_tenant_id')
|
|
->and($identity['target_scope'] ?? [])->toMatchArray([
|
|
'scope_identifier' => '55555555-5555-5555-5555-555555555555',
|
|
])
|
|
->and($identity)->not->toHaveKey('entra_tenant_id')
|
|
->and(collect($evidence)->contains(
|
|
fn (array $pointer): bool => ($pointer['kind'] ?? null) === 'target_scope_identifier'
|
|
&& ($pointer['value'] ?? null) === '55555555-5555-5555-5555-555555555555',
|
|
))->toBeTrue();
|
|
});
|
|
|
|
it('stores neutral target-scope context when the connection tenant identifier is blank', function (): void {
|
|
$tenant = ManagedEnvironment::factory()->create([
|
|
'name' => 'Fallback start environment',
|
|
'managed_environment_id' => '88888888-8888-8888-8888-888888888888',
|
|
]);
|
|
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
'entra_tenant_id' => '',
|
|
'consent_status' => 'granted',
|
|
]);
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
]);
|
|
|
|
$result = app(ProviderOperationStartGate::class)->start(
|
|
tenant: $tenant,
|
|
connection: $connection,
|
|
operationType: 'provider.connection.check',
|
|
dispatcher: fn (OperationRun $run): null => null,
|
|
);
|
|
|
|
$context = $result->run->fresh()->context;
|
|
|
|
expect($result->status)->toBe('started')
|
|
->and($context['target_scope'] ?? [])->toMatchArray([
|
|
'scope_identifier' => '88888888-8888-8888-8888-888888888888',
|
|
'scope_display_name' => 'Fallback start environment',
|
|
])
|
|
->and($context['provider_context']['details'][0] ?? [])->toMatchArray([
|
|
'detail_key' => 'microsoft_tenant_id',
|
|
'detail_value' => '88888888-8888-8888-8888-888888888888',
|
|
])
|
|
->and($context['target_scope'] ?? [])->not->toHaveKey('entra_tenant_id');
|
|
});
|