ahmido
094fff87b6
## Reopened validation note Baseline Compare residual test failures discovered during the Spec 322 broader regression pass were fixed in Spec 319 because they belong to the Environment-owned Baseline Compare route contract. No runtime code was changed. The affected tests now mount `BaselineCompareLanding` through the explicit environment route-owned helper instead of relying on implicit/remembered context. Validation: - 5 previously failing tests: 5 passed, 42 assertions - additional baseline/action/gap/action-surface tests: 20 passed, 199 assertions - broader Unit/Feature slice: 233 passed, 1826 assertions - pint --dirty: pass - git diff --check: pass Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #382
74 lines
2.7 KiB
PHP
74 lines
2.7 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\BaselineProfileResource\Pages\ViewBaselineProfile;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
use Filament\Facades\Filament;
|
|
use Illuminate\Support\Facades\DB;
|
|
use Livewire\Livewire;
|
|
|
|
it('keeps baseline capture and compare actions capability-gated on the profile detail page', function (): void {
|
|
[$readonlyUser, $tenant] = createUserWithTenant(role: 'readonly');
|
|
[$ownerUser] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
[$profile] = seedActiveBaselineForTenant($tenant);
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenant->workspace_id);
|
|
|
|
Livewire::actingAs($readonlyUser)
|
|
->test(ViewBaselineProfile::class, ['record' => $profile->getKey()])
|
|
->assertActionDisabled('capture')
|
|
->assertActionDisabled('compareNow');
|
|
|
|
Livewire::actingAs($ownerUser)
|
|
->test(ViewBaselineProfile::class, ['record' => $profile->getKey()])
|
|
->assertActionHidden('capture')
|
|
->assertActionEnabled('compareNow');
|
|
});
|
|
|
|
it('keeps tenant compare actions disabled for users without tenant.sync and enabled for owners', function (): void {
|
|
[$readonlyUser, $tenant] = createUserWithTenant(role: 'readonly');
|
|
[$ownerUser] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
seedActiveBaselineForTenant($tenant);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
baselineCompareLandingLivewire($tenant, user: $readonlyUser)
|
|
->assertActionDisabled('compareNow');
|
|
|
|
baselineCompareLandingLivewire($tenant, user: $ownerUser)
|
|
->assertActionEnabled('compareNow');
|
|
});
|
|
|
|
it('keeps legacy-scope capture and compare actions capability-gated on the profile detail page', function (): void {
|
|
[$readonlyUser, $tenant] = createUserWithTenant(role: 'readonly');
|
|
[$ownerUser] = createUserWithTenant(tenant: $tenant, role: 'owner');
|
|
|
|
[$profile] = seedActiveBaselineForTenant($tenant);
|
|
|
|
DB::table('baseline_profiles')
|
|
->where('id', (int) $profile->getKey())
|
|
->update([
|
|
'scope_jsonb' => json_encode([
|
|
'policy_types' => ['deviceConfiguration'],
|
|
'foundation_types' => [],
|
|
], JSON_THROW_ON_ERROR),
|
|
'updated_at' => now(),
|
|
]);
|
|
|
|
session()->put(WorkspaceContext::SESSION_KEY, (int) $tenant->workspace_id);
|
|
|
|
Livewire::actingAs($readonlyUser)
|
|
->test(ViewBaselineProfile::class, ['record' => $profile->getKey()])
|
|
->assertActionDisabled('capture')
|
|
->assertActionDisabled('compareNow');
|
|
|
|
Livewire::actingAs($ownerUser)
|
|
->test(ViewBaselineProfile::class, ['record' => $profile->getKey()])
|
|
->assertActionHidden('capture')
|
|
->assertActionEnabled('compareNow');
|
|
});
|