ahmido
ddf7c15c52
## Summary - move Baseline Compare onto the canonical workspace plus environment owned route instead of workspace-style access - remove legacy environment query and remembered-context fallback paths from the affected Baseline Compare entry points and shell handling - update related navigation, support links, and regression coverage for admin surface scope and managed environment route contracts - add Spec 319 artifacts for the environment-owned surface routing and shell context contract ## Testing - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Filament/BaselineCompareEnvironmentRouteContractTest.php tests/Feature/Filament/BaselineCompareLandingAdminTenantParityTest.php tests/Feature/Filament/BaselineCompareLandingDuplicateNamesBannerTest.php tests/Feature/Filament/BaselineCompareLandingRbacLabelsTest.php tests/Feature/Filament/BaselineCompareLandingStartSurfaceTest.php tests/Feature/Filament/BaselineCompareLandingWhyNoFindingsTest.php tests/Feature/Filament/PanelNavigationSegregationTest.php tests/Feature/Guards/ManagedEnvironmentCanonicalRouteContractTest.php tests/Feature/Navigation/WorkspaceHubRegistryTest.php tests/Feature/Rbac/BaselineCompareMatrixAuthorizationTest.php tests/Feature/Rbac/DriftLandingUiEnforcementTest.php tests/Unit/Tenants/AdminSurfaceScopeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #374
65 lines
2.9 KiB
PHP
65 lines
2.9 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\ManagedEnvironmentResource;
|
|
use App\Models\OperationRun;
|
|
use App\Support\ManagedEnvironmentLinks;
|
|
use App\Support\OperationRunLinks;
|
|
use App\Support\Workspaces\WorkspaceContext;
|
|
|
|
it('generates canonical managed-environment route families only', function (): void {
|
|
[$user, $tenant] = createMinimalUserWithTenant(role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id]);
|
|
|
|
$urls = [
|
|
ManagedEnvironmentLinks::indexUrl($tenant),
|
|
ManagedEnvironmentLinks::viewUrl($tenant),
|
|
ManagedEnvironmentLinks::requiredPermissionsUrl($tenant),
|
|
ManagedEnvironmentLinks::diagnosticsUrl($tenant),
|
|
ManagedEnvironmentLinks::accessScopesUrl($tenant),
|
|
ManagedEnvironmentLinks::baselineCompareUrl($tenant),
|
|
ManagedEnvironmentLinks::operationsUrl($tenant),
|
|
ManagedEnvironmentLinks::providerConnectionsUrl($tenant),
|
|
ManagedEnvironmentResource::getUrl('index'),
|
|
ManagedEnvironmentResource::getUrl('view', ['record' => $tenant]),
|
|
ManagedEnvironmentResource::getUrl('edit', ['record' => $tenant]),
|
|
ManagedEnvironmentResource::getUrl('memberships', ['record' => $tenant]),
|
|
OperationRunLinks::index($tenant),
|
|
];
|
|
|
|
$run = OperationRun::factory()->create([
|
|
'workspace_id' => (int) $tenant->workspace_id,
|
|
'managed_environment_id' => (int) $tenant->getKey(),
|
|
]);
|
|
|
|
$urls[] = OperationRunLinks::tenantlessView($run);
|
|
|
|
foreach ($urls as $url) {
|
|
expect($url)
|
|
->not->toContain('/admin/tenants')
|
|
->not->toContain('/admin/t/');
|
|
}
|
|
|
|
expect(ManagedEnvironmentLinks::viewUrl($tenant))->toContain('/admin/workspaces/')
|
|
->and(ManagedEnvironmentLinks::viewUrl($tenant))->toContain('/environments/'.$tenant->getRouteKey())
|
|
->and(ManagedEnvironmentLinks::requiredPermissionsUrl($tenant))->toEndWith('/required-permissions')
|
|
->and(ManagedEnvironmentLinks::diagnosticsUrl($tenant))->toEndWith('/diagnostics')
|
|
->and(ManagedEnvironmentLinks::accessScopesUrl($tenant))->toEndWith('/access-scopes')
|
|
->and(ManagedEnvironmentLinks::baselineCompareUrl($tenant))->toEndWith('/baseline-compare')
|
|
->and(ManagedEnvironmentLinks::providerConnectionsUrl($tenant))->toContain('/admin/provider-connections?environment_id='.(int) $tenant->getKey())
|
|
->and(OperationRunLinks::index($tenant))->toContain('/admin/workspaces/')
|
|
->and(OperationRunLinks::tenantlessView($run))->toContain('/admin/workspaces/');
|
|
});
|
|
|
|
it('keeps the retired ManagedEnvironmentResource out of global search', function (): void {
|
|
[$user, $tenant] = createMinimalUserWithTenant(role: 'owner');
|
|
|
|
$this->actingAs($user)
|
|
->withSession([WorkspaceContext::SESSION_KEY => (int) $tenant->workspace_id]);
|
|
|
|
expect(ManagedEnvironmentResource::getGlobalSearchResults((string) $tenant->name))->toHaveCount(0);
|
|
});
|