## Summary - stabilize the active spec 293 post-cutover suite baseline around the current admin-panel and workspace-first runtime - align operations, provider, required-permissions, and action-surface expectations to canonical workspace-aware routes - add the monitoring operations workspace-membership guard and update the spec 293 classification artifacts - include the browser smoke screenshots captured during verification ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Filament/PanelNavigationSegregationTest.php tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/OpsUx/CanonicalViewRunLinksTest.php tests/Feature/OpsUx/OperateHubShellTest.php tests/Feature/OpsUx/FailureSanitizationTest.php tests/Feature/OpsUx/NonLeakageWorkspaceOperationsTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Guards/ActionSurfaceContractTest.php tests/Feature/ProviderConnections/NavigationPlacementTest.php tests/Feature/ProviderConnections/ProviderConnectionListAuthorizationTest.php tests/Feature/Verification/VerificationAuthorizationTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Guards/Spec288NoLegacyRouteAndHelperGuardTest.php tests/Feature/Guards/Spec288ProviderCoreAndRoleAuthorityGuardTest.php tests/Feature/Guards/AdminWorkspaceRoutesGuardTest.php tests/Feature/Guards/ProviderBoundaryPlatformCoreGuardTest.php tests/Feature/ProviderConnections/LegacyRedirectTest.php tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/Spec080WorkspaceManagedTenantAdminMigrationTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php tests/Feature/Filament/ManagedEnvironmentAccessScopeManagementTest.php tests/Feature/Guards/BrowserLaneIsolationTest.php tests/Feature/Guards/CiLaneFailureClassificationContractTest.php tests/Feature/Guards/CiHeavyBrowserWorkflowContractTest.php tests/Unit/Auth/NoRoleStringChecksTest.php` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Browser/Spec281ProviderConnectionScopeSmokeTest.php tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - remaining provider/verification failures are classified in `specs/293-post-cutover-suite-stabilization/failure-classification.md` as unrelated existing debt and are not folded into this slice Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #348
64 lines
2.1 KiB
PHP
64 lines
2.1 KiB
PHP
<?php
|
|
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Services\OperationRunService;
|
|
use Illuminate\Notifications\DatabaseNotification;
|
|
|
|
it('sanitizes persisted run failures and terminal notifications', function () {
|
|
$tenant = ManagedEnvironment::factory()->create();
|
|
[$user, $tenant] = createUserWithTenant($tenant, role: 'owner');
|
|
|
|
/** @var OperationRunService $runs */
|
|
$runs = app(OperationRunService::class);
|
|
|
|
$run = $runs->ensureRun(
|
|
tenant: $tenant,
|
|
type: 'test.sanitize',
|
|
inputs: [],
|
|
initiator: $user,
|
|
);
|
|
|
|
$rawBearer = 'Bearer eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.'.str_repeat('A', 90);
|
|
|
|
$runs->updateRun(
|
|
$run,
|
|
status: 'completed',
|
|
outcome: 'failed',
|
|
failures: [[
|
|
'code' => 'graph_forbidden',
|
|
'message' => "Authorization: {$rawBearer} client_secret=supersecret passwordMinimumLength is still readable user=test.user@example.com",
|
|
]],
|
|
);
|
|
|
|
$run->refresh();
|
|
|
|
$failureSummaryJson = json_encode($run->failure_summary, JSON_THROW_ON_ERROR);
|
|
|
|
expect($failureSummaryJson)->not->toContain('client_secret=supersecret');
|
|
expect($failureSummaryJson)->not->toContain($rawBearer);
|
|
expect($failureSummaryJson)->not->toContain('test.user@example.com');
|
|
|
|
expect($run->failure_summary[0]['reason_code'] ?? null)->toBe('provider_permission_denied');
|
|
|
|
$notification = DatabaseNotification::query()
|
|
->where('notifiable_id', $user->getKey())
|
|
->latest('id')
|
|
->first();
|
|
|
|
expect($notification)->not->toBeNull();
|
|
|
|
$notificationJson = json_encode($notification?->data, JSON_THROW_ON_ERROR);
|
|
|
|
expect($notificationJson)->not->toContain('client_secret=supersecret');
|
|
expect($notificationJson)->not->toContain($rawBearer);
|
|
expect($notificationJson)->not->toContain('test.user@example.com');
|
|
expect($notificationJson)->toContain('passwordMinimumLength');
|
|
|
|
$this->actingAs($user)
|
|
->get(route('admin.operations.view', [
|
|
'workspace' => (int) $run->workspace_id,
|
|
'run' => (int) $run->getKey(),
|
|
]))
|
|
->assertSuccessful();
|
|
});
|