ahmido
440e63edff
## Summary
Implements Spec 145 for tenant action taxonomy and lifecycle-safe visibility.
This PR:
- adds a central tenant action policy surface and supporting value objects
- aligns tenant list, detail, edit, onboarding, and widget surfaces around lifecycle-safe actions
- standardizes operator-facing lifecycle wording around View, Resume onboarding, Archive, Restore, and Complete onboarding
- tightens onboarding and tenant lifecycle authorization semantics, including honest 404 vs 403 behavior
- updates related regression coverage and spec artifacts for Spec 145
- fixes follow-on full-suite regressions uncovered during validation, including onboarding browser flows, provider consent fixtures, workspace redirect DI expectations, and critical table/action/UI expectation drift
## Validation
Executed and passed:
- vendor/bin/sail bin pint --dirty --format agent
- vendor/bin/sail artisan test --compact
Result:
- 2581 passed
- 8 skipped
- 13534 assertions
## Notes
- Base branch: dev
- Feature branch commit: a33a41b
- Filament v5 / Livewire v4 compliance preserved
- No panel provider registration changes; Laravel 12 provider registration remains in bootstrap/providers.php
- No new globally searchable resource behavior added in this slice
- Destructive lifecycle actions remain confirmation-gated and authorization-protected
Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #174
90 lines
3.1 KiB
PHP
90 lines
3.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\Policy;
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\ProviderCredential;
|
|
use App\Models\Tenant;
|
|
use App\Services\Graph\GraphClientInterface;
|
|
use App\Services\Graph\GraphLogger;
|
|
use App\Services\Graph\GraphResponse;
|
|
use App\Services\Intune\PolicySyncService;
|
|
|
|
use function Pest\Laravel\mock;
|
|
|
|
function tenantWithDefaultMicrosoftConnectionForPolicySyncReport(array $attributes = []): Tenant
|
|
{
|
|
$tenant = Tenant::factory()->create($attributes + [
|
|
'status' => 'active',
|
|
'app_client_id' => null,
|
|
'app_client_secret' => null,
|
|
]);
|
|
|
|
$connection = ProviderConnection::factory()->consentGranted()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'provider' => 'microsoft',
|
|
'is_default' => true,
|
|
'status' => 'connected',
|
|
'entra_tenant_id' => (string) ($tenant->tenant_id ?: 'tenant-'.$tenant->getKey()),
|
|
]);
|
|
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => (int) $connection->getKey(),
|
|
'type' => 'client_secret',
|
|
'payload' => [
|
|
'client_id' => 'provider-client-'.$tenant->getKey(),
|
|
'client_secret' => 'provider-secret-'.$tenant->getKey(),
|
|
],
|
|
]);
|
|
|
|
return $tenant;
|
|
}
|
|
|
|
it('returns a report with failures when policy list calls fail', function () {
|
|
$tenant = tenantWithDefaultMicrosoftConnectionForPolicySyncReport();
|
|
|
|
$logger = mock(GraphLogger::class);
|
|
$logger->shouldReceive('logRequest')->zeroOrMoreTimes()->andReturnNull();
|
|
$logger->shouldReceive('logResponse')->zeroOrMoreTimes()->andReturnNull();
|
|
|
|
mock(GraphClientInterface::class)
|
|
->shouldReceive('listPolicies')
|
|
->andReturnUsing(function (string $policyType) {
|
|
return match ($policyType) {
|
|
'endpointSecurityPolicy' => new GraphResponse(
|
|
success: false,
|
|
data: [],
|
|
status: 403,
|
|
errors: [['message' => 'Forbidden']],
|
|
meta: ['path' => '/deviceManagement/configurationPolicies'],
|
|
),
|
|
default => new GraphResponse(
|
|
success: true,
|
|
data: [
|
|
['id' => 'scp-1', 'displayName' => 'Settings Catalog', 'technologies' => ['mdm']],
|
|
],
|
|
status: 200,
|
|
),
|
|
};
|
|
});
|
|
|
|
$service = app(PolicySyncService::class);
|
|
|
|
$result = $service->syncPoliciesWithReport($tenant, [
|
|
['type' => 'endpointSecurityPolicy', 'platform' => 'windows'],
|
|
['type' => 'settingsCatalogPolicy', 'platform' => 'windows'],
|
|
]);
|
|
|
|
expect($result)->toHaveKeys(['synced', 'failures']);
|
|
expect($result['synced'])->toBeArray();
|
|
expect($result['failures'])->toBeArray();
|
|
|
|
expect(count($result['synced']))->toBe(1);
|
|
expect(Policy::query()->where('tenant_id', $tenant->id)->count())->toBe(1);
|
|
|
|
expect(count($result['failures']))->toBe(1);
|
|
expect($result['failures'][0]['policy_type'])->toBe('endpointSecurityPolicy');
|
|
expect($result['failures'][0]['status'])->toBe(403);
|
|
});
|