ahmido
4d3fcd28a9
What Implements tenant-scoped backup scheduling end-to-end: schedules CRUD, minute-based dispatch, queued execution, run history, manual “Run now/Retry”, retention (keep last N), and auditability. Key changes Filament UI: Backup Schedules resource with tenant scoping + SEC-002 role gating. Scheduler + queue: tenantpilot:schedules:dispatch command wired in scheduler (runs every minute), creates idempotent BackupScheduleRun records and dispatches jobs. Execution: RunBackupScheduleJob syncs policies, creates immutable backup sets, updates run status, writes audit logs, applies retry/backoff mapping, and triggers retention. Run history: Relation manager + “View” modal rendering run details. UX polish: row actions grouped; bulk actions grouped (run now / retry / delete). Bulk dispatch writes DB notifications (shows in notifications panel). Validation: policy type hard-validation on save; unknown policy types handled safely at runtime (skipped/partial). Tests: comprehensive Pest coverage for CRUD/scoping/validation, idempotency, job outcomes, error mapping, retention, view modal, run-now/retry notifications, bulk delete (incl. operator forbidden). Files / Areas Filament: BackupScheduleResource.php and app/Filament/Resources/BackupScheduleResource/* Scheduling/Jobs: app/Console/Commands/TenantpilotDispatchBackupSchedules.php, app/Jobs/RunBackupScheduleJob.php, app/Jobs/ApplyBackupScheduleRetentionJob.php, console.php Models/Migrations: app/Models/BackupSchedule.php, app/Models/BackupScheduleRun.php, database/migrations/backup_schedules, backup_schedule_runs Notifications: BackupScheduleRunDispatchedNotification.php Specs: specs/032-backup-scheduling-mvp/* (tasks/checklist/quickstart updates) How to test (Sail) Run tests: ./vendor/bin/sail artisan test tests/Feature/BackupScheduling Run formatter: ./vendor/bin/sail php ./vendor/bin/pint --dirty Apply migrations: ./vendor/bin/sail artisan migrate Manual dispatch: ./vendor/bin/sail artisan tenantpilot:schedules:dispatch Notes Uses DB notifications for queued UI actions to ensure they appear in the notifications panel even under queue fakes in tests. Checklist gate for 032 is PASS; tasks updated accordingly. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #34
68 lines
2.1 KiB
PHP
68 lines
2.1 KiB
PHP
<?php
|
|
|
|
use App\Jobs\ApplyBackupScheduleRetentionJob;
|
|
use App\Models\BackupSchedule;
|
|
use App\Models\BackupScheduleRun;
|
|
use App\Models\BackupSet;
|
|
use Filament\Facades\Filament;
|
|
|
|
test('retention keeps last N backup sets per schedule', function () {
|
|
[$user, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
$schedule = BackupSchedule::query()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'name' => 'Nightly',
|
|
'is_enabled' => true,
|
|
'timezone' => 'UTC',
|
|
'frequency' => 'daily',
|
|
'time_of_day' => '01:00:00',
|
|
'days_of_week' => null,
|
|
'policy_types' => ['deviceConfiguration'],
|
|
'include_foundations' => true,
|
|
'retention_keep_last' => 2,
|
|
]);
|
|
|
|
$this->actingAs($user);
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$sets = collect(range(1, 5))->map(function (int $i) use ($tenant): BackupSet {
|
|
return BackupSet::query()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'name' => 'Set '.$i,
|
|
'status' => 'completed',
|
|
'item_count' => 0,
|
|
'completed_at' => now()->subMinutes(10 - $i),
|
|
]);
|
|
});
|
|
|
|
// Oldest → newest
|
|
$scheduledFor = now('UTC')->startOfMinute()->subMinutes(10);
|
|
foreach ($sets as $set) {
|
|
BackupScheduleRun::query()->create([
|
|
'backup_schedule_id' => $schedule->id,
|
|
'tenant_id' => $tenant->id,
|
|
'scheduled_for' => $scheduledFor,
|
|
'status' => BackupScheduleRun::STATUS_SUCCESS,
|
|
'summary' => ['policies_total' => 0, 'policies_backed_up' => 0, 'errors_count' => 0],
|
|
'backup_set_id' => $set->id,
|
|
]);
|
|
$scheduledFor = $scheduledFor->addMinute();
|
|
}
|
|
|
|
ApplyBackupScheduleRetentionJob::dispatchSync($schedule->id);
|
|
|
|
$kept = $sets->take(-2);
|
|
$deleted = $sets->take(3);
|
|
|
|
foreach ($kept as $set) {
|
|
$this->assertDatabaseHas('backup_sets', [
|
|
'id' => $set->id,
|
|
'deleted_at' => null,
|
|
]);
|
|
}
|
|
|
|
foreach ($deleted as $set) {
|
|
$this->assertSoftDeleted('backup_sets', ['id' => $set->id]);
|
|
}
|
|
});
|