ahmido
2bf5de4663
Summary Consolidates the “Tenant Operate Hub” work (Spec 085) and the follow-up adjustments from the 086 session merge into a single branch ready to merge into dev. Primary focus: stabilize Ops/Operate Hub UX flows, tighten/align authorization semantics, and make the full Sail test suite green. Key Changes Ops UX / Verification Readonly members can view verification operation runs (reports) while starting verification remains restricted. Normalized failure reason-code handling and aligned UX expectations with the provider reason-code taxonomy. Onboarding wizard UX “Start verification” CTA is hidden while a verification run is active; “Refresh” is shown during in-progress runs. Treats provider_permission_denied as a blocking reason (while keeping legacy compatibility). Test + fixture hardening Standardized use of default provider connection fixtures in tests where sync/restore flows require it. Fixed multiple Filament URL/tenant-context test cases to avoid 404s and reduce tenancy routing brittleness. Policy sync / restore safety Enrollment configuration type collision classification tests now exercise the real sync path (with required provider connection present). Restore edge-case safety tests updated to reflect current provider-connection requirements. Testing vendor/bin/sail artisan test --compact (green) vendor/bin/sail bin pint --dirty (green) Notes Includes merged 086 session work already (no separate PR needed). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@ebc83aaa-d947-4a08-b88e-bd72ac9645f7.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.fritz.box> Reviewed-on: #103
66 lines
2.0 KiB
PHP
66 lines
2.0 KiB
PHP
<?php
|
|
|
|
use App\Filament\Resources\RestoreRunResource;
|
|
use App\Models\BackupItem;
|
|
use App\Models\BackupSet;
|
|
use App\Models\Tenant;
|
|
|
|
function makeAssignment(string $odataType, string $groupId, ?string $displayName = null): array
|
|
{
|
|
$target = [
|
|
'@odata.type' => $odataType,
|
|
'groupId' => $groupId,
|
|
];
|
|
|
|
if (is_string($displayName) && $displayName !== '') {
|
|
$target['group_display_name'] = $displayName;
|
|
}
|
|
|
|
return ['target' => $target];
|
|
}
|
|
|
|
test('restore wizard create page renders without touching graph', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant($tenant);
|
|
|
|
bindFailHardGraphClient();
|
|
|
|
$this->actingAs($user)
|
|
->get(RestoreRunResource::getUrl('create').'?tenant='.(string) $tenant->external_id)
|
|
->assertOk()
|
|
->assertSee('Create restore run')
|
|
->assertSee('Select Backup Set');
|
|
});
|
|
|
|
test('restore wizard group mapping renders DB-only with manual GUID UX', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
[$user] = createUserWithTenant($tenant);
|
|
|
|
$backupSet = BackupSet::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'name' => 'group-mapping-backup-set',
|
|
]);
|
|
|
|
$groupId = '11111111-2222-3333-4444-555555555555';
|
|
$expectedMasked = '…'.substr($groupId, -8);
|
|
|
|
BackupItem::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'backup_set_id' => $backupSet->getKey(),
|
|
'assignments' => [
|
|
makeAssignment('#microsoft.graph.groupAssignmentTarget', $groupId, 'Example Group'),
|
|
],
|
|
]);
|
|
|
|
bindFailHardGraphClient();
|
|
|
|
$url = RestoreRunResource::getUrl('create').'?backup_set_id='.$backupSet->getKey().'&tenant='.(string) $tenant->external_id;
|
|
|
|
$this->actingAs($user)
|
|
->get($url)
|
|
->assertOk()
|
|
->assertSee($expectedMasked)
|
|
->assertSee('Paste the target Entra ID group Object ID')
|
|
->assertSee('Use SKIP to omit the assignment.');
|
|
});
|