Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
133 lines
4.5 KiB
PHP
133 lines
4.5 KiB
PHP
<?php
|
|
|
|
namespace App\Jobs;
|
|
|
|
use App\Jobs\Middleware\TrackOperationRun;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Services\Directory\EntraGroupSyncService;
|
|
use App\Services\Intune\AuditLogger;
|
|
use App\Services\OperationRunService;
|
|
use App\Support\OperationRunOutcome;
|
|
use Illuminate\Bus\Queueable;
|
|
use Illuminate\Contracts\Queue\ShouldQueue;
|
|
use Illuminate\Foundation\Bus\Dispatchable;
|
|
use Illuminate\Queue\InteractsWithQueue;
|
|
use Illuminate\Queue\SerializesModels;
|
|
use RuntimeException;
|
|
|
|
class EntraGroupSyncJob implements ShouldQueue
|
|
{
|
|
use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
|
|
|
|
public ?OperationRun $operationRun = null;
|
|
|
|
public function __construct(
|
|
public int $tenantId,
|
|
public string $selectionKey,
|
|
public ?string $slotKey = null,
|
|
public ?int $runId = null,
|
|
?OperationRun $operationRun = null
|
|
) {
|
|
$this->operationRun = $operationRun;
|
|
}
|
|
|
|
public function middleware(): array
|
|
{
|
|
return [new TrackOperationRun];
|
|
}
|
|
|
|
public function handle(EntraGroupSyncService $syncService, AuditLogger $auditLogger): void
|
|
{
|
|
if (! $this->operationRun) {
|
|
$this->fail(new RuntimeException('OperationRun context is required for EntraGroupSyncJob.'));
|
|
|
|
return;
|
|
}
|
|
|
|
$tenant = Tenant::query()->find($this->tenantId);
|
|
if (! $tenant instanceof Tenant) {
|
|
throw new RuntimeException('Tenant not found.');
|
|
}
|
|
|
|
/** @var OperationRunService $opService */
|
|
$opService = app(OperationRunService::class);
|
|
|
|
if ($this->operationRun->status === 'queued') {
|
|
$opService->updateRun($this->operationRun, 'running');
|
|
}
|
|
|
|
$auditLogger->log(
|
|
tenant: $tenant,
|
|
action: 'directory_groups.sync.started',
|
|
context: [
|
|
'selection_key' => $this->selectionKey,
|
|
'slot_key' => $this->slotKey,
|
|
],
|
|
actorId: $this->operationRun->user_id,
|
|
status: 'success',
|
|
resourceType: 'operation_run',
|
|
resourceId: (string) $this->operationRun->getKey(),
|
|
);
|
|
|
|
$result = $syncService->sync($tenant, $this->selectionKey);
|
|
|
|
$terminalStatus = 'succeeded';
|
|
|
|
if ($result['error_code'] !== null) {
|
|
$terminalStatus = 'failed';
|
|
} elseif ($result['safety_stop_triggered'] === true) {
|
|
$terminalStatus = 'partial';
|
|
}
|
|
|
|
$opOutcome = match ($terminalStatus) {
|
|
'succeeded' => OperationRunOutcome::Succeeded->value,
|
|
'partial' => OperationRunOutcome::PartiallySucceeded->value,
|
|
default => OperationRunOutcome::Failed->value,
|
|
};
|
|
|
|
$failures = [];
|
|
if (is_string($result['error_code']) && $result['error_code'] !== '') {
|
|
$failures[] = [
|
|
'code' => $result['error_code'],
|
|
'message' => is_string($result['error_summary']) ? $result['error_summary'] : 'Directory groups sync failed.',
|
|
];
|
|
}
|
|
|
|
$opService->updateRun(
|
|
$this->operationRun,
|
|
'completed',
|
|
$opOutcome,
|
|
[
|
|
'total' => (int) $result['items_observed_count'],
|
|
'processed' => (int) $result['items_observed_count'],
|
|
'updated' => (int) $result['items_upserted_count'],
|
|
'failed' => (int) $result['error_count'],
|
|
],
|
|
$failures,
|
|
);
|
|
|
|
$auditLogger->log(
|
|
tenant: $tenant,
|
|
action: $terminalStatus === 'succeeded'
|
|
? 'directory_groups.sync.succeeded'
|
|
: ($terminalStatus === 'partial'
|
|
? 'directory_groups.sync.partial'
|
|
: 'directory_groups.sync.failed'),
|
|
context: [
|
|
'selection_key' => $this->selectionKey,
|
|
'slot_key' => $this->slotKey,
|
|
'pages_fetched' => $result['pages_fetched'],
|
|
'items_observed_count' => $result['items_observed_count'],
|
|
'items_upserted_count' => $result['items_upserted_count'],
|
|
'error_code' => $result['error_code'],
|
|
'error_category' => $result['error_category'],
|
|
],
|
|
actorId: $this->operationRun->user_id,
|
|
status: $terminalStatus === 'failed' ? 'failed' : 'success',
|
|
resourceType: 'operation_run',
|
|
resourceId: (string) $this->operationRun->getKey(),
|
|
);
|
|
}
|
|
}
|