ahmido
f13a4ce409
Implements Spec 110 Ops‑UX Enforcement and applies the repo‑wide “enterprise” standard for operation start + dedup surfaces. Key points - Start surfaces: only ephemeral queued toast (no DB notifications for started/queued/running). - Dedup paths: canonical “already queued” toast. - Progress refresh: dispatch run-enqueued browser event so the global widget updates immediately. - Completion: exactly-once terminal DB notification on completion (per Ops‑UX contract). Tests & formatting - Full suite: 1738 passed, 8 skipped (8477 assertions). - Pint: `vendor/bin/sail bin pint --dirty --format agent` (pass). Notable change - Removed legacy `RunStatusChangedNotification` (replaced by the terminal-only completion notification policy). Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #134
88 lines
2.8 KiB
PHP
88 lines
2.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Jobs\ExecuteRestoreRunJob;
|
|
use App\Models\BackupSet;
|
|
use App\Models\RestoreRun;
|
|
use App\Notifications\OperationRunCompleted;
|
|
use App\Services\Intune\AuditLogger;
|
|
use App\Services\Intune\RestoreService;
|
|
use App\Services\OperationRunService;
|
|
use Filament\Facades\Filament;
|
|
|
|
it('persists exactly one canonical terminal notification for initiated restore execution runs', function (): void {
|
|
[$user, $tenant] = createUserWithTenant(role: 'owner');
|
|
$this->actingAs($user);
|
|
|
|
$tenant->makeCurrent();
|
|
Filament::setTenant($tenant, true);
|
|
|
|
$backupSet = BackupSet::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
]);
|
|
|
|
$restoreRun = RestoreRun::factory()->create([
|
|
'tenant_id' => (int) $tenant->getKey(),
|
|
'backup_set_id' => (int) $backupSet->getKey(),
|
|
'requested_by' => $user->email,
|
|
'status' => 'queued',
|
|
'started_at' => null,
|
|
'completed_at' => null,
|
|
]);
|
|
|
|
/** @var OperationRunService $operationRuns */
|
|
$operationRuns = app(OperationRunService::class);
|
|
$operationRun = $operationRuns->ensureRun(
|
|
tenant: $tenant,
|
|
type: 'restore.execute',
|
|
inputs: [
|
|
'restore_run_id' => (int) $restoreRun->getKey(),
|
|
'backup_set_id' => (int) $backupSet->getKey(),
|
|
'is_dry_run' => (bool) ($restoreRun->is_dry_run ?? false),
|
|
],
|
|
initiator: $user,
|
|
);
|
|
|
|
$operationRun->forceFill([
|
|
'user_id' => (int) $user->getKey(),
|
|
'initiator_name' => $user->name,
|
|
])->save();
|
|
|
|
$this->mock(RestoreService::class, function ($mock) use ($restoreRun): void {
|
|
$mock->shouldReceive('executeForRun')
|
|
->once()
|
|
->andReturnUsing(function () use ($restoreRun): RestoreRun {
|
|
RestoreRun::query()->whereKey($restoreRun->getKey())->update([
|
|
'status' => 'completed',
|
|
'completed_at' => now(),
|
|
]);
|
|
|
|
return RestoreRun::query()->findOrFail($restoreRun->getKey());
|
|
});
|
|
});
|
|
|
|
$job = new ExecuteRestoreRunJob(
|
|
restoreRunId: (int) $restoreRun->getKey(),
|
|
actorEmail: $user->email,
|
|
actorName: $user->name,
|
|
operationRun: $operationRun,
|
|
);
|
|
|
|
expect($user->notifications()->count())->toBe(0);
|
|
|
|
$job->handle(app(RestoreService::class), app(AuditLogger::class));
|
|
|
|
$operationRun->refresh();
|
|
|
|
expect($operationRun->status)->toBe('completed');
|
|
expect($operationRun->outcome)->toBe('succeeded');
|
|
expect($user->notifications()->count())->toBe(1);
|
|
|
|
$this->assertDatabaseHas('notifications', [
|
|
'notifiable_id' => $user->getKey(),
|
|
'notifiable_type' => $user->getMorphClass(),
|
|
'type' => OperationRunCompleted::class,
|
|
]);
|
|
})->group('ops-ux');
|