TenantAtlas/tests/Feature/Operations/AssignmentJobDedupeTest.php
ahmido 03127a670b Spec 096: Ops polish (assignment summaries + dedupe + reconcile tracking + seed DX) (#115)
Implements Spec 096 ops polish bundle:

- Persist durable OperationRun.summary_counts for assignment fetch/restore (final attempt wins)
- Server-side dedupe for assignment jobs (15-minute cooldown + non-canonical skip)
- Track ReconcileAdapterRunsJob via workspace-scoped OperationRun + stable failure codes + overlap prevention
- Seed DX: ensure seeded tenants use UUID v4 external_id and seed satisfies workspace_id NOT NULL constraints

Verification (local / evidence-based):
- `vendor/bin/sail artisan test --compact tests/Feature/Operations/AssignmentRunSummaryCountsTest.php tests/Feature/Operations/AssignmentJobDedupeTest.php tests/Feature/Operations/ReconcileAdapterRunsJobTrackingTest.php tests/Feature/Seed/PoliciesSeederExternalIdTest.php`
- `vendor/bin/sail bin pint --dirty`

Spec artifacts included under `specs/096-ops-polish-assignment-dedupe-system-tracking/` (spec/plan/tasks/checklists).

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #115
2026-02-15 20:49:38 +00:00

183 lines
6.0 KiB
PHP

<?php
use App\Jobs\FetchAssignmentsJob;
use App\Jobs\RestoreAssignmentsJob;
use App\Models\BackupItem;
use App\Models\BackupSet;
use App\Models\RestoreRun;
use App\Models\Tenant;
use App\Services\AssignmentBackupService;
use App\Services\AssignmentRestoreService;
use App\Services\OperationRunService;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Support\Facades\Bus;
uses(RefreshDatabase::class);
test('fetch assignment job dedupes dispatch and execution, and reuses recent completion during cooldown', function (): void {
$tenant = Tenant::factory()->create();
$backupSet = BackupSet::factory()->create([
'tenant_id' => (int) $tenant->getKey(),
]);
$backupItem = BackupItem::factory()->create([
'tenant_id' => (int) $tenant->getKey(),
'backup_set_id' => (int) $backupSet->getKey(),
'policy_type' => 'settingsCatalogPolicy',
'policy_identifier' => 'policy-fetch-dedupe',
'metadata' => [],
]);
Bus::fake();
$firstRun = FetchAssignmentsJob::dispatchTracked(
backupItem: $backupItem,
policyPayload: ['id' => 'policy-fetch-dedupe'],
);
$secondRun = FetchAssignmentsJob::dispatchTracked(
backupItem: $backupItem,
policyPayload: ['id' => 'policy-fetch-dedupe'],
);
expect((int) $firstRun->getKey())->toBe((int) $secondRun->getKey());
Bus::assertDispatched(FetchAssignmentsJob::class, 1);
$assignmentBackupService = \Mockery::mock(AssignmentBackupService::class);
$assignmentBackupService->shouldReceive('enrichWithAssignments')
->once()
->andReturnUsing(function (BackupItem $item): BackupItem {
$metadata = is_array($item->metadata) ? $item->metadata : [];
$metadata['assignments_fetch_failed'] = false;
$item->update([
'metadata' => $metadata,
'assignments' => [['id' => 'assignment-fetch-1']],
]);
return $item->refresh();
});
$firstJob = new FetchAssignmentsJob(
backupItemId: (int) $backupItem->getKey(),
tenantExternalId: (string) $tenant->external_id,
policyExternalId: (string) $backupItem->policy_identifier,
policyPayload: ['id' => 'policy-fetch-dedupe'],
operationRun: $firstRun,
);
$duplicateJob = new FetchAssignmentsJob(
backupItemId: (int) $backupItem->getKey(),
tenantExternalId: (string) $tenant->external_id,
policyExternalId: (string) $backupItem->policy_identifier,
policyPayload: ['id' => 'policy-fetch-dedupe'],
operationRun: $firstRun,
);
$firstJob->handle($assignmentBackupService, app(OperationRunService::class));
$duplicateJob->handle($assignmentBackupService, app(OperationRunService::class));
Bus::fake();
$cooldownRun = FetchAssignmentsJob::dispatchTracked(
backupItem: $backupItem,
policyPayload: ['id' => 'policy-fetch-dedupe'],
);
expect((int) $cooldownRun->getKey())->toBe((int) $firstRun->getKey());
Bus::assertNotDispatched(FetchAssignmentsJob::class);
});
test('restore assignment job dedupes dispatch and execution, and reuses recent completion during cooldown', function (): void {
$tenant = Tenant::factory()->create();
$backupSet = BackupSet::factory()->create([
'tenant_id' => (int) $tenant->getKey(),
]);
$restoreRun = RestoreRun::factory()->create([
'tenant_id' => (int) $tenant->getKey(),
'backup_set_id' => (int) $backupSet->getKey(),
]);
$assignments = [
['id' => 'assignment-1'],
['id' => 'assignment-2'],
];
Bus::fake();
$firstRun = RestoreAssignmentsJob::dispatchTracked(
restoreRunId: (int) $restoreRun->getKey(),
tenant: $tenant,
policyType: 'settingsCatalogPolicy',
policyId: 'policy-restore-dedupe',
assignments: $assignments,
groupMapping: [],
);
$secondRun = RestoreAssignmentsJob::dispatchTracked(
restoreRunId: (int) $restoreRun->getKey(),
tenant: $tenant,
policyType: 'settingsCatalogPolicy',
policyId: 'policy-restore-dedupe',
assignments: $assignments,
groupMapping: [],
);
expect((int) $firstRun->getKey())->toBe((int) $secondRun->getKey());
Bus::assertDispatched(RestoreAssignmentsJob::class, 1);
$assignmentRestoreService = \Mockery::mock(AssignmentRestoreService::class);
$assignmentRestoreService->shouldReceive('restore')
->once()
->andReturn([
'outcomes' => [
['status' => 'success'],
['status' => 'success'],
],
'summary' => [
'success' => 2,
'failed' => 0,
'skipped' => 0,
],
]);
$firstJob = new RestoreAssignmentsJob(
restoreRunId: (int) $restoreRun->getKey(),
tenantId: (int) $tenant->getKey(),
policyType: 'settingsCatalogPolicy',
policyId: 'policy-restore-dedupe',
assignments: $assignments,
groupMapping: [],
foundationMapping: [],
operationRun: $firstRun,
);
$duplicateJob = new RestoreAssignmentsJob(
restoreRunId: (int) $restoreRun->getKey(),
tenantId: (int) $tenant->getKey(),
policyType: 'settingsCatalogPolicy',
policyId: 'policy-restore-dedupe',
assignments: $assignments,
groupMapping: [],
foundationMapping: [],
operationRun: $firstRun,
);
$firstJob->handle($assignmentRestoreService, app(OperationRunService::class));
$duplicateJob->handle($assignmentRestoreService, app(OperationRunService::class));
Bus::fake();
$cooldownRun = RestoreAssignmentsJob::dispatchTracked(
restoreRunId: (int) $restoreRun->getKey(),
tenant: $tenant,
policyType: 'settingsCatalogPolicy',
policyId: 'policy-restore-dedupe',
assignments: $assignments,
groupMapping: [],
);
expect((int) $cooldownRun->getKey())->toBe((int) $firstRun->getKey());
Bus::assertNotDispatched(RestoreAssignmentsJob::class);
});