Implements Spec 087: Legacy Runs Removal (rigorous). ### What changed - Canonicalized run history: **`operation_runs` is the only run system** for inventory sync, Entra group sync, backup schedule execution/retention/purge. - Removed legacy UI surfaces (Filament Resources / relation managers) for legacy run models. - Legacy run URLs now return **404** (no redirects), with RBAC semantics preserved (404 vs 403 as specified). - Canonicalized affected `operation_runs.type` values (dotted → underscore) via migration. - Drift + inventory references now point to canonical operation runs; includes backfills and then drops legacy FK columns. - Drops legacy run tables after cutover. - Added regression guards to prevent reintroducing legacy run tokens or “backfilling” canonical runs from legacy tables. ### Migrations - `2026_02_12_000001..000006_*` canonicalize types, add/backfill operation_run_id references, drop legacy columns, and drop legacy run tables. ### Tests Focused pack for this spec passed: - `tests/Feature/Guards/NoLegacyRunsTest.php` - `tests/Feature/Guards/NoLegacyRunBackfillTest.php` - `tests/Feature/Operations/LegacyRunRoutesNotFoundTest.php` - `tests/Feature/Monitoring/MonitoringOperationsTest.php` - `tests/Feature/Jobs/RunInventorySyncJobTest.php` ### Notes / impact - Destructive cleanup is handled via migrations (drops legacy tables) after code cutover; deploy should run migrations in the same release. Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #106
100 lines
2.7 KiB
PHP
100 lines
2.7 KiB
PHP
<?php
|
|
|
|
use Illuminate\Support\Collection;
|
|
|
|
it('does not contain legacy run references', function () {
|
|
$root = base_path();
|
|
$self = realpath(__FILE__);
|
|
|
|
$directories = [
|
|
$root.'/app',
|
|
$root.'/database',
|
|
$root.'/resources',
|
|
$root.'/routes',
|
|
];
|
|
|
|
$excludedPaths = [
|
|
$root.'/vendor',
|
|
$root.'/storage',
|
|
$root.'/specs',
|
|
$root.'/spechistory',
|
|
$root.'/references',
|
|
$root.'/bootstrap/cache',
|
|
$root.'/database/migrations',
|
|
];
|
|
|
|
$forbiddenPatterns = [
|
|
'/\\bInventorySyncRun\\b/',
|
|
'/\\binventory_sync_runs\\b/',
|
|
'/\\bInventorySyncRunResource\\b/',
|
|
'/\\bEntraGroupSyncRun\\b/',
|
|
'/\\bentra_group_sync_runs\\b/',
|
|
'/\\bEntraGroupSyncRunResource\\b/',
|
|
'/\\bBackupScheduleRun\\b/',
|
|
'/\\bbackup_schedule_runs\\b/',
|
|
'/\\bBackupScheduleRunsRelationManager\\b/',
|
|
];
|
|
|
|
/** @var Collection<int, string> $files */
|
|
$files = collect($directories)
|
|
->filter(fn (string $dir): bool => is_dir($dir))
|
|
->flatMap(function (string $dir): array {
|
|
$iterator = new RecursiveIteratorIterator(
|
|
new RecursiveDirectoryIterator($dir, FilesystemIterator::SKIP_DOTS)
|
|
);
|
|
|
|
$paths = [];
|
|
|
|
foreach ($iterator as $file) {
|
|
if (! $file->isFile()) {
|
|
continue;
|
|
}
|
|
|
|
$paths[] = $file->getPathname();
|
|
}
|
|
|
|
return $paths;
|
|
})
|
|
->filter(function (string $path) use ($excludedPaths, $self): bool {
|
|
if ($self && realpath($path) === $self) {
|
|
return false;
|
|
}
|
|
|
|
foreach ($excludedPaths as $excluded) {
|
|
if (str_starts_with($path, $excluded)) {
|
|
return false;
|
|
}
|
|
}
|
|
|
|
return true;
|
|
})
|
|
->values();
|
|
|
|
$hits = [];
|
|
|
|
foreach ($files as $path) {
|
|
$contents = file_get_contents($path);
|
|
|
|
if (! is_string($contents) || $contents === '') {
|
|
continue;
|
|
}
|
|
|
|
foreach ($forbiddenPatterns as $pattern) {
|
|
if (! preg_match($pattern, $contents)) {
|
|
continue;
|
|
}
|
|
|
|
$lines = preg_split('/\R/', $contents) ?: [];
|
|
|
|
foreach ($lines as $index => $line) {
|
|
if (preg_match($pattern, $line)) {
|
|
$relative = str_replace($root.'/', '', $path);
|
|
$hits[] = $relative.':'.($index + 1).' -> '.trim($line);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
expect($hits)->toBeEmpty('Legacy run references found:\n'.implode("\n", $hits));
|
|
});
|