TenantAtlas/tests/Unit/TenantPermissionCheckClustersTest.php
ahmido 05a604cfb6 Spec 076: Tenant Required Permissions (enterprise remediation UX) (#92)
Implements Spec 076 enterprise remediation UX for tenant required permissions.

Highlights
- Above-the-fold overview (impact + counts) with missing-first experience
- Feature-based grouping, filters/search, copy-to-clipboard for missing app/delegated permissions
- Tenant-scoped deny-as-not-found semantics; DB-only viewing
- Centralized badge semantics (no ad-hoc status mapping)

Testing
- Feature tests for default filters, grouping, copy output, and non-member 404 behavior.

Integration
- Adds deep links from verification checks to the Required permissions page.

Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box>
Reviewed-on: #92
2026-02-05 22:08:51 +00:00

134 lines
4.8 KiB
PHP

<?php
use App\Models\Tenant;
use App\Support\Links\RequiredPermissionsLinks;
use App\Support\Verification\TenantPermissionCheckClusters;
use App\Support\Verification\VerificationCheckStatus;
use Illuminate\Foundation\Testing\RefreshDatabase;
uses(RefreshDatabase::class);
it('marks a cluster as failed and blocking when an application permission is missing', function (): void {
$tenant = Tenant::factory()->create(['external_id' => 'tenant-a']);
$checks = TenantPermissionCheckClusters::buildChecks($tenant, [
[
'key' => 'Directory.Read.All',
'type' => 'application',
'description' => null,
'features' => [],
'status' => 'granted',
'details' => null,
],
[
'key' => 'Group.Read.All',
'type' => 'application',
'description' => null,
'features' => [],
'status' => 'missing',
'details' => null,
],
]);
$directoryCheck = collect($checks)->firstWhere('key', 'permissions.directory_groups');
expect($directoryCheck)->toBeArray();
expect($directoryCheck['status'] ?? null)->toBe(VerificationCheckStatus::Fail->value);
expect($directoryCheck['blocking'] ?? null)->toBeTrue();
expect($directoryCheck['next_steps'][0]['url'] ?? null)
->toBe(RequiredPermissionsLinks::requiredPermissions($tenant));
});
it('marks a cluster as warn and non-blocking when only delegated permissions are missing', function (): void {
$tenant = Tenant::factory()->create(['external_id' => 'tenant-b']);
$checks = TenantPermissionCheckClusters::buildChecks($tenant, [
[
'key' => 'DeviceManagementApps.Read.All',
'type' => 'delegated',
'description' => null,
'features' => [],
'status' => 'missing',
'details' => null,
],
]);
$appsCheck = collect($checks)->firstWhere('key', 'permissions.intune_apps');
expect($appsCheck)->toBeArray();
expect($appsCheck['status'] ?? null)->toBe(VerificationCheckStatus::Warn->value);
expect($appsCheck['blocking'] ?? null)->toBeFalse();
});
it('marks a cluster as skipped when no mapped permissions are present', function (): void {
$tenant = Tenant::factory()->create(['external_id' => 'tenant-c']);
$checks = TenantPermissionCheckClusters::buildChecks($tenant, []);
$rbacCheck = collect($checks)->firstWhere('key', 'permissions.intune_rbac_assignments');
expect($rbacCheck)->toBeArray();
expect($rbacCheck['status'] ?? null)->toBe(VerificationCheckStatus::Skip->value);
});
it('marks a cluster as passed when all mapped permissions are granted', function (): void {
$tenant = Tenant::factory()->create(['external_id' => 'tenant-d']);
$checks = TenantPermissionCheckClusters::buildChecks($tenant, [
[
'key' => 'Directory.Read.All',
'type' => 'application',
'description' => null,
'features' => [],
'status' => 'granted',
'details' => null,
],
[
'key' => 'Group.Read.All',
'type' => 'application',
'description' => null,
'features' => [],
'status' => 'granted',
'details' => null,
],
]);
$directoryCheck = collect($checks)->firstWhere('key', 'permissions.directory_groups');
expect($directoryCheck)->toBeArray();
expect($directoryCheck['status'] ?? null)->toBe(VerificationCheckStatus::Pass->value);
expect($directoryCheck['next_steps'] ?? null)->toBeArray()->toBeEmpty();
});
it('degrades permission clusters to warnings when inventory is not fresh', function (): void {
$tenant = Tenant::factory()->create(['external_id' => 'tenant-e']);
$checks = TenantPermissionCheckClusters::buildChecks(
tenant: $tenant,
permissions: [
[
'key' => 'Directory.Read.All',
'type' => 'application',
'description' => null,
'features' => [],
'status' => 'missing',
'details' => null,
],
],
inventory: [
'fresh' => false,
'reason_code' => 'throttled',
'message' => 'Unable to refresh observed permissions inventory during this run. Retry verification.',
],
);
$adminConsentCheck = collect($checks)->firstWhere('key', 'permissions.admin_consent');
expect($adminConsentCheck)->toBeArray();
expect($adminConsentCheck['status'] ?? null)->toBe(VerificationCheckStatus::Warn->value);
expect($adminConsentCheck['blocking'] ?? null)->toBeFalse();
expect($adminConsentCheck['reason_code'] ?? null)->toBe('throttled');
expect((string) ($adminConsentCheck['message'] ?? ''))->toContain('Unable to refresh observed permissions inventory');
});