PR Body Implements Spec 065 “Tenant RBAC v1” with capabilities-first RBAC, tenant membership scoping (Option 3), and consistent Filament action semantics. Key decisions / rules Tenancy Option 3: tenant switching is tenantless (ChooseTenant), tenant-scoped routes stay scoped, non-members get 404 (not 403). RBAC model: canonical capability registry + role→capability map + Gates for each capability (no role-string checks in UI logic). UX policy: for tenant members lacking permission → actions are visible but disabled + tooltip (avoid click→403). Security still enforced server-side. What’s included Capabilities foundation: Central capability registry (Capabilities::*) Role→capability mapping (RoleCapabilityMap) Gate registration + resolver/manager updates to support tenant-scoped authorization Filament enforcement hardening across the app: Tenant registration & tenant CRUD properly gated Backup/restore/policy flows aligned to “visible-but-disabled” where applicable Provider operations (health check / inventory sync / compliance snapshot) guarded and normalized Directory groups + inventory sync start surfaces normalized Policy version maintenance actions (archive/restore/prune/force delete) gated SpecKit artifacts for 065: spec.md, plan/tasks updates, checklists, enforcement hitlist Security guarantees Non-member → 404 via tenant scoping/membership guards. Member without capability → 403 on execution, even if UI is disabled. No destructive actions execute without proper authorization checks. Tests Adds/updates Pest coverage for: Tenant scoping & membership denial behavior Role matrix expectations (owner/manager/operator/readonly) Filament surface checks (visible/disabled actions, no side effects) Provider/Inventory/Groups run-start authorization Verified locally with targeted vendor/bin/sail artisan test --compact … Deployment / ops notes No new services required. Safe change: behavior is authorization + UI semantics; no breaking route changes intended. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Reviewed-on: #79
112 lines
3.5 KiB
PHP
112 lines
3.5 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Filament\Resources\TenantResource\Pages\ViewTenant;
|
|
use App\Filament\Resources\TenantResource\RelationManagers\TenantMembershipsRelationManager;
|
|
use App\Models\TenantMembership;
|
|
use App\Models\User;
|
|
use Livewire\Livewire;
|
|
|
|
it('allows an owner to add, change role, and remove members', function (): void {
|
|
[$owner, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$tenant->makeCurrent();
|
|
|
|
$member = User::factory()->create(['name' => 'Member User']);
|
|
|
|
Livewire::actingAs($owner)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->callTableAction('add_member', null, [
|
|
'user_id' => $member->getKey(),
|
|
'role' => 'readonly',
|
|
]);
|
|
|
|
$membership = TenantMembership::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('user_id', $member->getKey())
|
|
->first();
|
|
|
|
expect($membership)->not->toBeNull();
|
|
expect($membership?->role)->toBe('readonly');
|
|
|
|
Livewire::actingAs($owner)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->callTableAction('change_role', $membership, [
|
|
'role' => 'manager',
|
|
]);
|
|
|
|
expect($membership?->refresh()->role)->toBe('manager');
|
|
|
|
Livewire::actingAs($owner)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->callTableAction('remove', $membership);
|
|
|
|
expect(TenantMembership::query()->whereKey($membership?->getKey())->exists())->toBeFalse();
|
|
});
|
|
|
|
it('hides membership management actions from non-owners', function (): void {
|
|
[$manager, $tenant] = createUserWithTenant(role: 'manager');
|
|
|
|
$tenant->makeCurrent();
|
|
|
|
$member = User::factory()->create();
|
|
$member->tenants()->syncWithoutDetaching([
|
|
$tenant->getKey() => ['role' => 'readonly'],
|
|
]);
|
|
|
|
$membership = TenantMembership::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('user_id', $member->getKey())
|
|
->firstOrFail();
|
|
|
|
Livewire::actingAs($manager)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->assertTableActionHidden('add_member')
|
|
->assertTableActionHidden('change_role', $membership)
|
|
->assertTableActionHidden('remove', $membership);
|
|
});
|
|
|
|
it('prevents removing or demoting the last owner', function (): void {
|
|
[$owner, $tenant] = createUserWithTenant(role: 'owner');
|
|
|
|
$tenant->makeCurrent();
|
|
|
|
$ownerMembership = TenantMembership::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('user_id', $owner->getKey())
|
|
->firstOrFail();
|
|
|
|
Livewire::actingAs($owner)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->callTableAction('change_role', $ownerMembership, [
|
|
'role' => 'manager',
|
|
]);
|
|
|
|
expect($ownerMembership->refresh()->role)->toBe('owner');
|
|
|
|
Livewire::actingAs($owner)
|
|
->test(TenantMembershipsRelationManager::class, [
|
|
'ownerRecord' => $tenant,
|
|
'pageClass' => ViewTenant::class,
|
|
])
|
|
->callTableAction('remove', $ownerMembership);
|
|
|
|
expect(TenantMembership::query()->whereKey($ownerMembership->getKey())->exists())->toBeTrue();
|
|
});
|