TenantAtlas/apps/platform/tests/Feature/Guards/ConfidenceLaneContractTest.php
ahmido 0d5d1fc9f4 Spec 208: finalize heavy suite segmentation (#241)
## Summary
- add the checked-in Spec 208 heavy-suite classification and family manifest with config-driven lane generation, attribution, and budget reporting
- update Pest grouping, guard coverage, wrapper/report contracts, and spec artifacts for the segmented lane model
- complete the targeted follow-up pass that re-homes the remaining in-scope confidence hotspots into explicit heavy-governance families

## Acceptance
- confidence is repaired and now measures 389.613832s, down from 587.446894s and below the 450s lane budget
- confidence is also slightly below the post-Spec-207 baseline of 394.383441s (delta -4.769609s)
- this closes the central Spec 208 acceptance issue that had kept the spec open

## Intentionally Re-homed Families
- finding-bulk-actions-workflow
- drift-bulk-triage-all-matching
- baseline-profile-start-surfaces
- workspace-settings-slice-management
- findings-workflow-surfaces
- workspace-only-admin-surface-independence

## Explicit Residual Risk
- heavy-governance now measures 318.296962s, above its documented 300s threshold
- the cost was not removed; it was moved into the correct lane and made visible on clearly named heavy families
- this is documented residual debt, not an open Spec 208 failure

## Validation
- focused guard/support validation: 206 passed (3607 assertions)
- lane wrapper/report validation completed for confidence and heavy-governance
- no full-suite run was performed in this pass by request

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #241
2026-04-17 09:53:55 +00:00

72 lines
4.9 KiB
PHP

<?php
declare(strict_types=1);
use Tests\Support\TestLaneManifest;
it('keeps confidence broader than fast-feedback while excluding browser and moved heavy families', function (): void {
$lane = TestLaneManifest::lane('confidence');
$command = TestLaneManifest::buildCommand('confidence');
$configurationPath = TestLaneManifest::laneConfigurationPath('confidence');
$configurationContents = (string) file_get_contents(TestLaneManifest::absolutePath($configurationPath));
expect($lane['parallelMode'])->toBe('required')
->and($lane['includedFamilies'])->toContain('unit', 'ui-light', 'ui-workflow')
->and($lane['excludedFamilies'])->toContain('browser', 'surface-guard', 'discovery-heavy')
->and($lane['budget']['thresholdSeconds'])->toBeLessThan(TestLaneManifest::fullSuiteBaselineSeconds())
->and($command)->toContain('--parallel')
->and($command)->toContain('--configuration='.$configurationPath)
->and($command)->toContain('--testsuite=Lane')
->and($configurationContents)->toContain('tests/Feature/Baselines/BaselineCompareMatrixCompareAllActionTest.php')
->and($configurationContents)->toContain('tests/Feature/Rbac/OnboardingWizardUiEnforcementTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Drift/DriftBulkAcknowledgeAllMatchingConfirmationTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Filament/BaselineActionAuthorizationTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Filament/BaselineProfileCaptureStartSurfaceTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Filament/BaselineProfileCompareStartSurfaceTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Findings/FindingBulkActionsTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Findings/FindingExceptionRenewalTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Findings/FindingsListFiltersTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Findings/FindingWorkflowRowActionsTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Findings/FindingWorkflowViewActionsTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Filament/WorkspaceOnlySurfaceTenantIndependenceTest.php')
->and($configurationContents)->not->toContain('tests/Feature/SettingsFoundation/WorkspaceSettingsManageTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Guards/ActionSurfaceContractTest.php')
->and($configurationContents)->not->toContain('tests/Feature/Filament/PolicyResourceAdminSearchParityTest.php');
});
it('retains only documented ui-light and selected ui-workflow families in confidence discovery', function (): void {
$files = TestLaneManifest::discoverFiles('confidence');
$confidenceFamilies = TestLaneManifest::familiesByTargetLane('confidence');
expect($files)->toContain(
'tests/Feature/Filament/BackupSetAdminTenantParityTest.php',
'tests/Feature/Baselines/BaselineCompareMatrixCompareAllActionTest.php',
'tests/Feature/Baselines/BaselineCompareMatrixBuilderTest.php',
'tests/Feature/Rbac/OnboardingWizardUiEnforcementTest.php',
)
->and($files)->not->toContain(
'tests/Feature/Drift/DriftBulkAcknowledgeAllMatchingConfirmationTest.php',
'tests/Feature/Filament/BaselineActionAuthorizationTest.php',
'tests/Feature/Filament/BaselineProfileCaptureStartSurfaceTest.php',
'tests/Feature/Filament/BaselineProfileCompareStartSurfaceTest.php',
'tests/Feature/Findings/FindingBulkActionsTest.php',
'tests/Feature/Findings/FindingExceptionRenewalTest.php',
'tests/Feature/Findings/FindingsListFiltersTest.php',
'tests/Feature/Findings/FindingWorkflowRowActionsTest.php',
'tests/Feature/Findings/FindingWorkflowViewActionsTest.php',
'tests/Feature/Guards/ActionSurfaceContractTest.php',
'tests/Feature/Filament/PolicyResourceAdminSearchParityTest.php',
'tests/Feature/Filament/PolicyVersionAdminSearchParityTest.php',
'tests/Feature/Filament/WorkspaceOnlySurfaceTenantIndependenceTest.php',
'tests/Feature/Rbac/BackupItemsRelationManagerUiEnforcementTest.php',
'tests/Feature/Rbac/WorkspaceMembershipsRelationManagerUiEnforcementTest.php',
'tests/Feature/SettingsFoundation/WorkspaceSettingsManageTest.php',
'tests/Feature/Filament/TenantReviewHeaderDisciplineTest.php',
'tests/Feature/Filament/PanelNavigationSegregationTest.php',
);
foreach ($confidenceFamilies as $family) {
expect($family['classificationId'])->toBeIn(['ui-light', 'ui-workflow'])
->and(trim((string) ($family['confidenceRationale'] ?? '')))->not->toBe('');
}
});