ahmido
0d5d1fc9f4
## Summary - add the checked-in Spec 208 heavy-suite classification and family manifest with config-driven lane generation, attribution, and budget reporting - update Pest grouping, guard coverage, wrapper/report contracts, and spec artifacts for the segmented lane model - complete the targeted follow-up pass that re-homes the remaining in-scope confidence hotspots into explicit heavy-governance families ## Acceptance - confidence is repaired and now measures 389.613832s, down from 587.446894s and below the 450s lane budget - confidence is also slightly below the post-Spec-207 baseline of 394.383441s (delta -4.769609s) - this closes the central Spec 208 acceptance issue that had kept the spec open ## Intentionally Re-homed Families - finding-bulk-actions-workflow - drift-bulk-triage-all-matching - baseline-profile-start-surfaces - workspace-settings-slice-management - findings-workflow-surfaces - workspace-only-admin-surface-independence ## Explicit Residual Risk - heavy-governance now measures 318.296962s, above its documented 300s threshold - the cost was not removed; it was moved into the correct lane and made visible on clearly named heavy families - this is documented residual debt, not an open Spec 208 failure ## Validation - focused guard/support validation: 206 passed (3607 assertions) - lane wrapper/report validation completed for confidence and heavy-governance - no full-suite run was performed in this pass by request Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #241
42 lines
2.4 KiB
PHP
42 lines
2.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Tests\Support\TestLaneManifest;
|
|
|
|
it('keeps fast-feedback as the default parallel contributor loop with explicit heavy exclusions', function (): void {
|
|
$lane = TestLaneManifest::lane('fast-feedback');
|
|
$command = TestLaneManifest::buildCommand('fast-feedback');
|
|
$configurationPath = TestLaneManifest::laneConfigurationPath('fast-feedback');
|
|
$configurationContents = (string) file_get_contents(TestLaneManifest::absolutePath($configurationPath));
|
|
|
|
expect($lane['defaultEntryPoint'])->toBeTrue()
|
|
->and($lane['parallelMode'])->toBe('required')
|
|
->and($lane['includedFamilies'])->toContain('unit', 'ui-light')
|
|
->and($lane['excludedFamilies'])->toContain('browser', 'surface-guard', 'discovery-heavy')
|
|
->and($lane['budget']['baselineDeltaTargetPercent'])->toBe(50)
|
|
->and(TestLaneManifest::commandRef('fast-feedback'))->toBe('test')
|
|
->and($command)->toContain('--parallel')
|
|
->and($command)->toContain('--configuration='.$configurationPath)
|
|
->and($command)->toContain('--testsuite=Lane')
|
|
->and($configurationContents)->toContain('tests/Feature/Auth/BreakGlassWorkspaceOwnerRecoveryTest.php')
|
|
->and($configurationContents)->not->toContain('tests/Feature/Drift/DriftBulkAcknowledgeAllMatchingConfirmationTest.php')
|
|
->and($configurationContents)->not->toContain('tests/Feature/Findings/FindingBulkActionsTest.php')
|
|
->and($configurationContents)->not->toContain('tests/Feature/Guards/ActionSurfaceContractTest.php')
|
|
->and($configurationContents)->not->toContain('tests/Feature/Filament/PolicyResourceAdminSearchParityTest.php');
|
|
});
|
|
|
|
it('keeps fast-feedback narrower than confidence and rejects broad surface or discovery families', function (): void {
|
|
$fastTargets = TestLaneManifest::discoverFiles('fast-feedback');
|
|
$confidenceTargets = TestLaneManifest::discoverFiles('confidence');
|
|
$validation = TestLaneManifest::validateLanePlacement(
|
|
laneId: 'fast-feedback',
|
|
filePath: 'tests/Feature/Guards/ActionSurfaceContractTest.php',
|
|
);
|
|
|
|
expect($fastTargets)->not->toBeEmpty()
|
|
->and(count($fastTargets))->toBeLessThan(count($confidenceTargets))
|
|
->and($fastTargets)->not->toContain('tests/Feature/Guards/ActionSurfaceContractTest.php')
|
|
->and($validation['valid'])->toBeFalse()
|
|
->and($validation['resolvedClassificationId'])->toBe('surface-guard');
|
|
}); |