ahmido
0d5d1fc9f4
## Summary - add the checked-in Spec 208 heavy-suite classification and family manifest with config-driven lane generation, attribution, and budget reporting - update Pest grouping, guard coverage, wrapper/report contracts, and spec artifacts for the segmented lane model - complete the targeted follow-up pass that re-homes the remaining in-scope confidence hotspots into explicit heavy-governance families ## Acceptance - confidence is repaired and now measures 389.613832s, down from 587.446894s and below the 450s lane budget - confidence is also slightly below the post-Spec-207 baseline of 394.383441s (delta -4.769609s) - this closes the central Spec 208 acceptance issue that had kept the spec open ## Intentionally Re-homed Families - finding-bulk-actions-workflow - drift-bulk-triage-all-matching - baseline-profile-start-surfaces - workspace-settings-slice-management - findings-workflow-surfaces - workspace-only-admin-surface-independence ## Explicit Residual Risk - heavy-governance now measures 318.296962s, above its documented 300s threshold - the cost was not removed; it was moved into the correct lane and made visible on clearly named heavy families - this is documented residual debt, not an open Spec 208 failure ## Validation - focused guard/support validation: 206 passed (3607 assertions) - lane wrapper/report validation completed for confidence and heavy-governance - no full-suite run was performed in this pass by request Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #241
82 lines
4.6 KiB
PHP
82 lines
4.6 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Tests\Support\TestLaneManifest;
|
|
|
|
it('declares the spec 208 five-class catalog with the expected lane semantics', function (): void {
|
|
$classifications = collect(TestLaneManifest::classifications())->keyBy('classificationId');
|
|
|
|
expect($classifications->keys()->all())->toEqualCanonicalizing([
|
|
'ui-light',
|
|
'ui-workflow',
|
|
'surface-guard',
|
|
'discovery-heavy',
|
|
'browser',
|
|
])
|
|
->and($classifications->get('ui-light')['allowedLaneIds'])->toContain('fast-feedback', 'confidence')
|
|
->and($classifications->get('ui-workflow')['defaultLaneId'])->toBe('confidence')
|
|
->and($classifications->get('surface-guard')['forbiddenLaneIds'])->toContain('fast-feedback', 'confidence')
|
|
->and($classifications->get('discovery-heavy')['defaultLaneId'])->toBe('heavy-governance')
|
|
->and($classifications->get('browser')['allowedLaneIds'])->toBe(['browser']);
|
|
});
|
|
|
|
it('keeps the seeded heavy batch out of confidence and inside heavy-governance', function (): void {
|
|
$confidenceFiles = TestLaneManifest::discoverFiles('confidence');
|
|
$heavyFiles = TestLaneManifest::discoverFiles('heavy-governance');
|
|
|
|
expect($confidenceFiles)->not->toContain(
|
|
'tests/Feature/Drift/DriftBulkAcknowledgeAllMatchingConfirmationTest.php',
|
|
'tests/Feature/Filament/BaselineActionAuthorizationTest.php',
|
|
'tests/Feature/Filament/BaselineProfileCaptureStartSurfaceTest.php',
|
|
'tests/Feature/Filament/BaselineProfileCompareStartSurfaceTest.php',
|
|
'tests/Feature/Findings/FindingBulkActionsTest.php',
|
|
'tests/Feature/Findings/FindingExceptionRenewalTest.php',
|
|
'tests/Feature/Findings/FindingsListFiltersTest.php',
|
|
'tests/Feature/Findings/FindingWorkflowRowActionsTest.php',
|
|
'tests/Feature/Findings/FindingWorkflowViewActionsTest.php',
|
|
'tests/Feature/Filament/WorkspaceOnlySurfaceTenantIndependenceTest.php',
|
|
'tests/Feature/Guards/ActionSurfaceContractTest.php',
|
|
'tests/Feature/Filament/PolicyResourceAdminSearchParityTest.php',
|
|
'tests/Feature/Filament/PolicyVersionAdminSearchParityTest.php',
|
|
'tests/Feature/Rbac/BackupItemsRelationManagerUiEnforcementTest.php',
|
|
'tests/Feature/Rbac/WorkspaceMembershipsRelationManagerUiEnforcementTest.php',
|
|
'tests/Feature/SettingsFoundation/WorkspaceSettingsManageTest.php',
|
|
'tests/Feature/Filament/TenantReviewHeaderDisciplineTest.php',
|
|
'tests/Feature/Filament/PanelNavigationSegregationTest.php',
|
|
)
|
|
->and($heavyFiles)->toContain(
|
|
'tests/Feature/Drift/DriftBulkAcknowledgeAllMatchingConfirmationTest.php',
|
|
'tests/Feature/Filament/BaselineActionAuthorizationTest.php',
|
|
'tests/Feature/Filament/BaselineProfileCaptureStartSurfaceTest.php',
|
|
'tests/Feature/Filament/BaselineProfileCompareStartSurfaceTest.php',
|
|
'tests/Feature/Findings/FindingBulkActionsTest.php',
|
|
'tests/Feature/Findings/FindingExceptionRenewalTest.php',
|
|
'tests/Feature/Findings/FindingsListFiltersTest.php',
|
|
'tests/Feature/Findings/FindingWorkflowRowActionsTest.php',
|
|
'tests/Feature/Findings/FindingWorkflowViewActionsTest.php',
|
|
'tests/Feature/Filament/WorkspaceOnlySurfaceTenantIndependenceTest.php',
|
|
'tests/Feature/Guards/ActionSurfaceContractTest.php',
|
|
'tests/Feature/Filament/PolicyResourceAdminSearchParityTest.php',
|
|
'tests/Feature/Filament/PolicyVersionAdminSearchParityTest.php',
|
|
'tests/Feature/Rbac/BackupItemsRelationManagerUiEnforcementTest.php',
|
|
'tests/Feature/Rbac/WorkspaceMembershipsRelationManagerUiEnforcementTest.php',
|
|
'tests/Feature/SettingsFoundation/WorkspaceSettingsManageTest.php',
|
|
'tests/Feature/Filament/TenantReviewHeaderDisciplineTest.php',
|
|
'tests/Feature/Filament/PanelNavigationSegregationTest.php',
|
|
);
|
|
});
|
|
|
|
it('describes mixed-file and wrong-lane placement with actionable output', function (): void {
|
|
$validation = TestLaneManifest::validateLanePlacement(
|
|
laneId: 'confidence',
|
|
filePath: 'tests/Feature/Filament/PolicyResourceAdminSearchParityTest.php',
|
|
);
|
|
|
|
expect($validation['valid'])->toBeFalse()
|
|
->and($validation['resolvedClassificationId'])->toBe('discovery-heavy')
|
|
->and(implode(' ', $validation['reasons']))->toContain('policy-resource-admin-search-parity');
|
|
|
|
expect(TestLaneManifest::describeFilePlacement('tests/Feature/Baselines/BaselineCompareMatrixBuilderTest.php'))
|
|
->toContain('baseline-compare-matrix-workflow', 'ui-workflow', 'Mixed-file');
|
|
}); |