TenantAtlas/apps/platform/tests/Feature/Guards/BrowserLaneIsolationTest.php
ahmido 0a1377c5f5 feat(spec-288): add no-legacy quality gates (#347)
## Summary
- add Spec 288 no-legacy route/helper and provider-core/role-authority guard coverage
- extend the pinned Spec 281 and Spec 285 browser smokes plus lane/report classification wording for classification-only fallout handling
- add the Spec 288 artifact package and contributor-facing quality-gate guidance while keeping Package Execution deferred to Spec 289

## Validation
- `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && REPO_ROOT="$(git rev-parse --show-toplevel)" && (cd "$REPO_ROOT/apps/platform" && ./vendor/bin/sail artisan test --compact tests/Feature/Guards/Spec288NoLegacyRouteAndHelperGuardTest.php tests/Feature/Guards/Spec288ProviderCoreAndRoleAuthorityGuardTest.php tests/Feature/Guards/AdminWorkspaceRoutesGuardTest.php tests/Feature/Guards/ProviderBoundaryPlatformCoreGuardTest.php tests/Feature/ProviderConnections/LegacyRedirectTest.php tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/Spec080WorkspaceManagedTenantAdminMigrationTest.php tests/Feature/Rbac/ProviderConnectionWorkspaceFirstPolicyTest.php tests/Feature/Filament/ManagedEnvironmentAccessScopeManagementTest.php tests/Feature/Guards/BrowserLaneIsolationTest.php tests/Feature/Guards/CiLaneFailureClassificationContractTest.php tests/Feature/Guards/CiHeavyBrowserWorkflowContractTest.php tests/Unit/Auth/NoRoleStringChecksTest.php)`
- `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && REPO_ROOT="$(git rev-parse --show-toplevel)" && (cd "$REPO_ROOT/apps/platform" && ./vendor/bin/sail artisan test --compact tests/Browser/Spec281ProviderConnectionScopeSmokeTest.php tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php)`
- `export PATH="/bin:/usr/bin:/usr/local/bin:$PATH" && REPO_ROOT="$(git rev-parse --show-toplevel)" && (cd "$REPO_ROOT/apps/platform" && ./vendor/bin/sail bin pint --dirty --format agent)`

Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de>
Reviewed-on: #347
2026-05-10 21:24:14 +00:00

78 lines
3.8 KiB
PHP

<?php
declare(strict_types=1);
use Illuminate\Support\Collection;
use Tests\Support\TestLaneManifest;
use Tests\Support\TestLaneBudget;
it('keeps browser tests isolated behind their dedicated lane and class', function (): void {
$lane = TestLaneManifest::lane('browser');
$browserFamily = TestLaneManifest::family('browser-smoke');
$files = new Collection(TestLaneManifest::discoverFiles('browser'));
$validation = TestLaneManifest::validateLanePlacement(
laneId: 'browser',
filePath: 'tests/Browser/Spec190BaselineCompareMatrixSmokeTest.php',
);
$providerScopeValidation = TestLaneManifest::validateLanePlacement(
laneId: 'browser',
filePath: 'tests/Browser/Spec281ProviderConnectionScopeSmokeTest.php',
);
$workspaceRbacValidation = TestLaneManifest::validateLanePlacement(
laneId: 'browser',
filePath: 'tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php',
);
expect($lane['includedFamilies'])->toContain('browser')
->and($lane['defaultEntryPoint'])->toBeFalse()
->and($lane['scopeBoundaryNote'])->toContain('classification-only')
->and($files)->not->toBeEmpty()
->and($files->every(static fn (string $path): bool => str_starts_with($path, 'tests/Browser/')))->toBeTrue()
->and($browserFamily['hotspotFiles'])->toContain(
'tests/Browser/Spec190BaselineCompareMatrixSmokeTest.php',
'tests/Browser/Spec281ProviderConnectionScopeSmokeTest.php',
'tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php',
)
->and($validation['valid'])->toBeTrue()
->and($validation['resolvedClassificationId'])->toBe('browser')
->and($validation['familyId'])->toBe('browser-smoke')
->and($providerScopeValidation['valid'])->toBeTrue()
->and($providerScopeValidation['familyId'])->toBe('browser-smoke')
->and($workspaceRbacValidation['valid'])->toBeTrue()
->and($workspaceRbacValidation['familyId'])->toBe('browser-smoke');
});
it('rejects browser placement in non-browser lanes and keeps the default loops clean', function (): void {
$misplaced = TestLaneManifest::validateLanePlacement(
laneId: 'confidence',
filePath: 'tests/Browser/Spec190BaselineCompareMatrixSmokeTest.php',
);
$configurationPath = TestLaneManifest::laneConfigurationPath('browser');
$configurationContents = (string) file_get_contents(TestLaneManifest::absolutePath($configurationPath));
expect(TestLaneManifest::buildCommand('browser'))->toContain('--configuration='.$configurationPath)
->and($configurationContents)->toContain('tests/Browser/Spec190BaselineCompareMatrixSmokeTest.php')
->and($configurationContents)->toContain('tests/Browser/Spec281ProviderConnectionScopeSmokeTest.php')
->and($configurationContents)->toContain('tests/Browser/Spec285WorkspaceRbacEnvironmentAccessSmokeTest.php')
->and($misplaced['valid'])->toBeFalse()
->and($misplaced['allowance'])->toBe('forbidden');
foreach (TestLaneManifest::discoverFiles('fast-feedback') as $path) {
expect($path)->not->toStartWith('tests/Browser/');
}
foreach (TestLaneManifest::discoverFiles('confidence') as $path) {
expect($path)->not->toStartWith('tests/Browser/');
}
});
it('keeps browser manual and scheduled budget profiles separate from the default contributor loops', function (): void {
$manualProfile = TestLaneBudget::enforcementProfile('browser', 'manual');
$scheduledProfile = TestLaneBudget::enforcementProfile('browser', 'scheduled');
expect($manualProfile['enforcementMode'])->toBe('soft-warn')
->and($scheduledProfile['enforcementMode'])->toBe('trend-only')
->and($manualProfile['effectiveThresholdSeconds'])->toBe(170)
->and($scheduledProfile['effectiveThresholdSeconds'])->toBe(170);
});