## Spec 178 — Operations Lifecycle Alignment & Cross-Surface Truth Consistency Härtet die Run-Lifecycle-Wahrheit und Cross-Surface-Konsistenz über alle zentralen Operator-Flächen hinweg. ### Kern-Änderungen **Lifecycle Truth Alignment** - Einheitliche stale/stuck-Semantik zwischen Tenant-, Workspace-, Admin- und System-Surfaces - `OperationRunFreshnessState` wird konsistent über alle Widgets und Seiten propagiert - Gemeinsame Problem-Klassen-Trennung: `terminal_follow_up` vs. `active_stale_attention` **BulkOperationProgress Freshness** - Overlay zeigt nur noch `healthyActive()` Runs statt alle aktiven Runs - Likely-stale Runs halten das Polling nicht mehr künstlich aktiv - Terminal Runs verschwinden zeitnah aus dem Progress-Overlay **Decision Zone im Run Detail** - Stale/reconciled Attention in der primären Decision-Hierarchie - Klare Antworten: aktiv? stale? reconciled? nächster Schritt? - Artifact-reiche Runs behalten Lifecycle-Truth vor Deep-Diagnostics **Cross-Surface Link-Continuity** - Dashboard → Operations Hub → Run Detail erzählen dieselbe Geschichte - Notifications referenzieren korrekte Problem-Klasse - Workspace/Tenant-Attention verlinken problemklassengerecht **System-Plane Fixes** - `/system/ops/failures` 500-Error behoben (panel-sichere Artifact-URLs) - System-Stuck/Failures zeigen reconciled stale lineage ### Weitere Fixes - Inventory auth guard bereinigt (Gate statt ad-hoc Facades) - Browser-Smoke-Tests stabilisiert (DOM-Assertions statt fragile Klicks) - Test-Assertion-Drift für Verification/Lifecycle-Texte korrigiert ### Test-Ergebnis Full Suite: **3269 passed**, 8 skipped, 0 failed ### Spec-Artefakte - `specs/178-ops-truth-alignment/spec.md` - `specs/178-ops-truth-alignment/plan.md` - `specs/178-ops-truth-alignment/tasks.md` - `specs/178-ops-truth-alignment/research.md` - `specs/178-ops-truth-alignment/data-model.md` - `specs/178-ops-truth-alignment/quickstart.md` - `specs/178-ops-truth-alignment/contracts/operations-truth-alignment.openapi.yaml` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #209
521 lines
19 KiB
PHP
521 lines
19 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Support\OpsUx;
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Support\OperationCatalog;
|
|
use App\Support\OperationRunLinks;
|
|
use App\Support\Operations\OperationRunFreshnessState;
|
|
use App\Support\ReasonTranslation\ReasonPresenter;
|
|
use App\Support\ReasonTranslation\ReasonResolutionEnvelope;
|
|
use App\Support\RedactionIntegrity;
|
|
use App\Support\Ui\DerivedState\DerivedStateFamily;
|
|
use App\Support\Ui\DerivedState\DerivedStateKey;
|
|
use App\Support\Ui\DerivedState\RequestScopedDerivedStateStore;
|
|
use App\Support\Ui\GovernanceArtifactTruth\ArtifactTruthPresenter;
|
|
use App\Support\Ui\OperatorExplanation\OperatorExplanationPattern;
|
|
use Filament\Notifications\Notification as FilamentNotification;
|
|
|
|
final class OperationUxPresenter
|
|
{
|
|
public const int QUEUED_TOAST_DURATION_MS = 4000;
|
|
|
|
public const int FAILURE_MESSAGE_MAX_CHARS = 140;
|
|
|
|
/**
|
|
* Queued intent feedback toast (ephemeral, not persisted).
|
|
*/
|
|
public static function queuedToast(string $operationType): FilamentNotification
|
|
{
|
|
$operationLabel = OperationCatalog::label($operationType);
|
|
|
|
return FilamentNotification::make()
|
|
->title("{$operationLabel} queued")
|
|
->body('Queued for execution. Open the operation for progress and next steps.')
|
|
->info()
|
|
->duration(self::QUEUED_TOAST_DURATION_MS);
|
|
}
|
|
|
|
/**
|
|
* Canonical dedupe feedback when a matching run is already active.
|
|
*/
|
|
public static function alreadyQueuedToast(string $operationType): FilamentNotification
|
|
{
|
|
$operationLabel = OperationCatalog::label($operationType);
|
|
|
|
return FilamentNotification::make()
|
|
->title("{$operationLabel} already queued")
|
|
->body('A matching operation is already queued or running. No action needed unless it stays stuck.')
|
|
->info()
|
|
->duration(self::QUEUED_TOAST_DURATION_MS);
|
|
}
|
|
|
|
/**
|
|
* Terminal DB notification payload.
|
|
*
|
|
* Note: We intentionally return the built Filament notification builder to
|
|
* keep DB formatting consistent with existing Notification classes.
|
|
*/
|
|
public static function terminalDatabaseNotification(OperationRun $run, ?Tenant $tenant = null): FilamentNotification
|
|
{
|
|
$operationLabel = OperationCatalog::label((string) $run->type);
|
|
$presentation = self::terminalPresentation($run);
|
|
$bodyLines = [$presentation['body']];
|
|
|
|
$failureMessage = self::surfaceFailureDetail($run);
|
|
if ($failureMessage !== null) {
|
|
$bodyLines[] = $failureMessage;
|
|
}
|
|
|
|
$guidance = self::surfaceGuidance($run);
|
|
if ($guidance !== null) {
|
|
$bodyLines[] = $guidance;
|
|
}
|
|
|
|
$summary = SummaryCountsNormalizer::renderSummaryLine(is_array($run->summary_counts) ? $run->summary_counts : []);
|
|
if ($summary !== null) {
|
|
$bodyLines[] = $summary;
|
|
}
|
|
|
|
$integritySummary = RedactionIntegrity::noteForRun($run);
|
|
if (is_string($integritySummary) && trim($integritySummary) !== '') {
|
|
$bodyLines[] = trim($integritySummary);
|
|
}
|
|
|
|
$notification = FilamentNotification::make()
|
|
->title("{$operationLabel} {$presentation['titleSuffix']}")
|
|
->body(implode("\n", $bodyLines))
|
|
->status($presentation['status']);
|
|
|
|
if ($tenant instanceof Tenant) {
|
|
$notification->actions([
|
|
\Filament\Actions\Action::make('view')
|
|
->label(OperationRunLinks::openLabel())
|
|
->url(OperationRunUrl::view($run, $tenant)),
|
|
]);
|
|
}
|
|
|
|
return $notification;
|
|
}
|
|
|
|
public static function surfaceGuidance(OperationRun $run): ?string
|
|
{
|
|
return self::memoizeGuidance(
|
|
run: $run,
|
|
variant: 'surface_guidance',
|
|
resolver: fn (): ?string => self::buildSurfaceGuidance($run),
|
|
);
|
|
}
|
|
|
|
public static function surfaceGuidanceFresh(OperationRun $run): ?string
|
|
{
|
|
return self::memoizeGuidance(
|
|
run: $run,
|
|
variant: 'surface_guidance',
|
|
resolver: fn (): ?string => self::buildSurfaceGuidance($run),
|
|
fresh: true,
|
|
);
|
|
}
|
|
|
|
private static function buildSurfaceGuidance(OperationRun $run): ?string
|
|
{
|
|
$uxStatus = OperationStatusNormalizer::toUxStatus($run->status, $run->outcome);
|
|
$reasonEnvelope = self::reasonEnvelope($run);
|
|
$reasonGuidance = app(ReasonPresenter::class)->guidance($reasonEnvelope);
|
|
$operatorExplanationGuidance = self::operatorExplanationGuidance($run);
|
|
$nextStepLabel = self::firstNextStepLabel($run);
|
|
$freshnessState = self::freshnessState($run);
|
|
|
|
if ($freshnessState->isLikelyStale()) {
|
|
return 'This operation is past its lifecycle window. Review worker health and logs before retrying from the start surface.';
|
|
}
|
|
|
|
if ($freshnessState->isReconciledFailed()) {
|
|
return $operatorExplanationGuidance
|
|
?? $reasonGuidance
|
|
?? 'TenantPilot reconciled this operation after lifecycle truth was lost. Review the recorded evidence before retrying.';
|
|
}
|
|
|
|
if (in_array($uxStatus, ['blocked', 'failed', 'partial'], true)) {
|
|
if ($operatorExplanationGuidance !== null) {
|
|
return $operatorExplanationGuidance;
|
|
}
|
|
|
|
if ($reasonGuidance !== null) {
|
|
return $reasonGuidance;
|
|
}
|
|
}
|
|
|
|
if ($uxStatus === 'succeeded' && $operatorExplanationGuidance !== null) {
|
|
return $operatorExplanationGuidance;
|
|
}
|
|
|
|
return match ($uxStatus) {
|
|
'queued' => 'No action needed yet. The operation is waiting for a worker.',
|
|
'running' => 'No action needed yet. The operation is currently in progress.',
|
|
'succeeded' => 'No action needed.',
|
|
'partial' => $nextStepLabel !== null
|
|
? 'Next step: '.$nextStepLabel.'.'
|
|
: (self::requiresFollowUp($run)
|
|
? 'Review the affected items before rerunning.'
|
|
: 'No action needed unless the recorded warnings were unexpected.'),
|
|
'blocked' => $nextStepLabel !== null
|
|
? 'Next step: '.$nextStepLabel.'.'
|
|
: 'Review the blocked prerequisite before retrying.',
|
|
default => $nextStepLabel !== null
|
|
? 'Next step: '.$nextStepLabel.'.'
|
|
: 'Review the operation details before retrying.',
|
|
};
|
|
}
|
|
|
|
public static function surfaceFailureDetail(OperationRun $run): ?string
|
|
{
|
|
return self::memoizeExplanation(
|
|
run: $run,
|
|
variant: 'surface_failure_detail',
|
|
resolver: fn (): ?string => self::buildSurfaceFailureDetail($run),
|
|
);
|
|
}
|
|
|
|
public static function surfaceFailureDetailFresh(OperationRun $run): ?string
|
|
{
|
|
return self::memoizeExplanation(
|
|
run: $run,
|
|
variant: 'surface_failure_detail',
|
|
resolver: fn (): ?string => self::buildSurfaceFailureDetail($run),
|
|
fresh: true,
|
|
);
|
|
}
|
|
|
|
private static function buildSurfaceFailureDetail(OperationRun $run): ?string
|
|
{
|
|
$operatorExplanation = self::governanceOperatorExplanation($run);
|
|
|
|
if (is_string($operatorExplanation?->dominantCauseExplanation) && trim($operatorExplanation->dominantCauseExplanation) !== '') {
|
|
return trim($operatorExplanation->dominantCauseExplanation);
|
|
}
|
|
|
|
$failureMessage = (string) (($run->failure_summary[0]['message'] ?? '') ?? '');
|
|
$sanitizedFailureMessage = self::sanitizeFailureMessage($failureMessage);
|
|
|
|
if ($sanitizedFailureMessage !== null) {
|
|
return $sanitizedFailureMessage;
|
|
}
|
|
|
|
$reasonEnvelope = self::reasonEnvelope($run);
|
|
|
|
if ($reasonEnvelope !== null) {
|
|
return $reasonEnvelope->shortExplanation;
|
|
}
|
|
|
|
if (self::freshnessState($run)->isLikelyStale()) {
|
|
return 'This operation is no longer within its normal lifecycle window and may no longer be progressing.';
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
public static function freshnessState(OperationRun $run): OperationRunFreshnessState
|
|
{
|
|
return $run->freshnessState();
|
|
}
|
|
|
|
public static function problemClass(OperationRun $run): string
|
|
{
|
|
return $run->problemClass();
|
|
}
|
|
|
|
public static function problemClassLabel(OperationRun $run): ?string
|
|
{
|
|
return match (self::problemClass($run)) {
|
|
OperationRun::PROBLEM_CLASS_ACTIVE_STALE_ATTENTION => 'Likely stale active run',
|
|
OperationRun::PROBLEM_CLASS_TERMINAL_FOLLOW_UP => 'Terminal follow-up',
|
|
default => null,
|
|
};
|
|
}
|
|
|
|
public static function staleLineageNote(OperationRun $run): ?string
|
|
{
|
|
if (! $run->hasStaleLineage()) {
|
|
return null;
|
|
}
|
|
|
|
return 'This terminal run was automatically reconciled after stale lifecycle truth was lost.';
|
|
}
|
|
|
|
/**
|
|
* @return array{
|
|
* freshnessState:string,
|
|
* freshnessLabel:?string,
|
|
* problemClass:string,
|
|
* problemClassLabel:?string,
|
|
* isCurrentlyActive:bool,
|
|
* isReconciled:bool,
|
|
* staleLineageNote:?string,
|
|
* primaryNextAction:string,
|
|
* attentionNote:?string
|
|
* }
|
|
*/
|
|
public static function decisionZoneTruth(OperationRun $run): array
|
|
{
|
|
$freshnessState = self::freshnessState($run);
|
|
|
|
return [
|
|
'freshnessState' => $freshnessState->value,
|
|
'freshnessLabel' => self::lifecycleAttentionSummary($run),
|
|
'problemClass' => self::problemClass($run),
|
|
'problemClassLabel' => self::problemClassLabel($run),
|
|
'isCurrentlyActive' => $run->isCurrentlyActive(),
|
|
'isReconciled' => $run->isLifecycleReconciled(),
|
|
'staleLineageNote' => self::staleLineageNote($run),
|
|
'primaryNextAction' => self::surfaceGuidance($run) ?? 'No action needed.',
|
|
'attentionNote' => self::decisionAttentionNote($run),
|
|
];
|
|
}
|
|
|
|
public static function decisionAttentionNote(OperationRun $run): ?string
|
|
{
|
|
return match (self::problemClass($run)) {
|
|
OperationRun::PROBLEM_CLASS_ACTIVE_STALE_ATTENTION => 'Still active: Yes. Automatic reconciliation: No. This run is past its lifecycle window and needs stale-run investigation before retrying.',
|
|
OperationRun::PROBLEM_CLASS_TERMINAL_FOLLOW_UP => $run->hasStaleLineage()
|
|
? 'Still active: No. Automatic reconciliation: Yes. This terminal failure preserves stale-run lineage so operators can recover why the run stopped.'
|
|
: 'Still active: No. Automatic reconciliation: No. This run is terminal and still needs follow-up.',
|
|
default => null,
|
|
};
|
|
}
|
|
|
|
public static function lifecycleAttentionSummary(OperationRun $run): ?string
|
|
{
|
|
return self::memoizeExplanation(
|
|
run: $run,
|
|
variant: 'lifecycle_attention_summary',
|
|
resolver: fn (): ?string => self::buildLifecycleAttentionSummary($run),
|
|
);
|
|
}
|
|
|
|
public static function lifecycleAttentionSummaryFresh(OperationRun $run): ?string
|
|
{
|
|
return self::memoizeExplanation(
|
|
run: $run,
|
|
variant: 'lifecycle_attention_summary',
|
|
resolver: fn (): ?string => self::buildLifecycleAttentionSummary($run),
|
|
fresh: true,
|
|
);
|
|
}
|
|
|
|
private static function buildLifecycleAttentionSummary(OperationRun $run): ?string
|
|
{
|
|
return match (self::freshnessState($run)) {
|
|
OperationRunFreshnessState::LikelyStale => 'Likely stale',
|
|
OperationRunFreshnessState::ReconciledFailed => 'Automatically reconciled',
|
|
default => self::problemClass($run) === OperationRun::PROBLEM_CLASS_TERMINAL_FOLLOW_UP
|
|
? 'Terminal follow-up'
|
|
: null,
|
|
};
|
|
}
|
|
|
|
public static function governanceOperatorExplanation(OperationRun $run): ?OperatorExplanationPattern
|
|
{
|
|
return self::resolveGovernanceOperatorExplanation($run);
|
|
}
|
|
|
|
public static function governanceOperatorExplanationFresh(OperationRun $run): ?OperatorExplanationPattern
|
|
{
|
|
return self::resolveGovernanceOperatorExplanation($run, fresh: true);
|
|
}
|
|
|
|
/**
|
|
* @return array{titleSuffix: string, body: string, status: string}
|
|
*/
|
|
private static function terminalPresentation(OperationRun $run): array
|
|
{
|
|
$uxStatus = OperationStatusNormalizer::toUxStatus($run->status, $run->outcome);
|
|
$reasonEnvelope = self::reasonEnvelope($run);
|
|
$freshnessState = self::freshnessState($run);
|
|
|
|
if ($freshnessState->isReconciledFailed()) {
|
|
return [
|
|
'titleSuffix' => 'was automatically reconciled',
|
|
'body' => $reasonEnvelope?->operatorLabel ?? 'Automatically reconciled after infrastructure failure.',
|
|
'status' => 'danger',
|
|
];
|
|
}
|
|
|
|
return match ($uxStatus) {
|
|
'succeeded' => [
|
|
'titleSuffix' => 'completed successfully',
|
|
'body' => 'Completed successfully.',
|
|
'status' => 'success',
|
|
],
|
|
'partial' => [
|
|
'titleSuffix' => self::requiresFollowUp($run) ? 'needs follow-up' : 'completed with review notes',
|
|
'body' => 'Completed with follow-up.',
|
|
'status' => 'warning',
|
|
],
|
|
'blocked' => [
|
|
'titleSuffix' => 'blocked by prerequisite',
|
|
'body' => $reasonEnvelope?->operatorLabel ?? 'Blocked by prerequisite.',
|
|
'status' => 'warning',
|
|
],
|
|
default => [
|
|
'titleSuffix' => 'execution failed',
|
|
'body' => $reasonEnvelope?->operatorLabel ?? 'Execution failed.',
|
|
'status' => 'danger',
|
|
],
|
|
};
|
|
}
|
|
|
|
private static function requiresFollowUp(OperationRun $run): bool
|
|
{
|
|
if (self::firstNextStepLabel($run) !== null) {
|
|
return true;
|
|
}
|
|
|
|
$counts = SummaryCountsNormalizer::normalize(is_array($run->summary_counts) ? $run->summary_counts : []);
|
|
|
|
return (int) ($counts['failed'] ?? 0) > 0;
|
|
}
|
|
|
|
private static function firstNextStepLabel(OperationRun $run): ?string
|
|
{
|
|
$context = is_array($run->context) ? $run->context : [];
|
|
$nextSteps = $context['next_steps'] ?? null;
|
|
|
|
if (! is_array($nextSteps)) {
|
|
return null;
|
|
}
|
|
|
|
foreach ($nextSteps as $nextStep) {
|
|
if (! is_array($nextStep)) {
|
|
continue;
|
|
}
|
|
|
|
$label = trim((string) ($nextStep['label'] ?? ''));
|
|
|
|
if ($label !== '') {
|
|
return $label;
|
|
}
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
private static function sanitizeFailureMessage(string $failureMessage): ?string
|
|
{
|
|
$failureMessage = trim($failureMessage);
|
|
|
|
if ($failureMessage === '') {
|
|
return null;
|
|
}
|
|
|
|
$failureMessage = RunFailureSanitizer::sanitizeMessage($failureMessage);
|
|
|
|
if (mb_strlen($failureMessage) > self::FAILURE_MESSAGE_MAX_CHARS) {
|
|
$failureMessage = mb_substr($failureMessage, 0, self::FAILURE_MESSAGE_MAX_CHARS - 1).'…';
|
|
}
|
|
|
|
return $failureMessage !== '' ? $failureMessage : null;
|
|
}
|
|
|
|
private static function reasonEnvelope(OperationRun $run): ?ReasonResolutionEnvelope
|
|
{
|
|
return self::memoizeExplanation(
|
|
run: $run,
|
|
variant: 'reason_envelope_notification',
|
|
resolver: fn (): ?ReasonResolutionEnvelope => app(ReasonPresenter::class)->forOperationRun($run, 'notification'),
|
|
);
|
|
}
|
|
|
|
private static function operatorExplanationGuidance(OperationRun $run): ?string
|
|
{
|
|
$operatorExplanation = self::resolveGovernanceOperatorExplanation($run);
|
|
|
|
if (! is_string($operatorExplanation?->nextActionText) || trim($operatorExplanation->nextActionText) === '') {
|
|
return null;
|
|
}
|
|
|
|
$text = trim($operatorExplanation->nextActionText);
|
|
|
|
if (str_ends_with($text, '.')) {
|
|
return $text;
|
|
}
|
|
|
|
return $text === 'No action needed'
|
|
? 'No action needed.'
|
|
: 'Next step: '.$text.'.';
|
|
}
|
|
|
|
private static function resolveGovernanceOperatorExplanation(OperationRun $run, bool $fresh = false): ?OperatorExplanationPattern
|
|
{
|
|
if (! $run->supportsOperatorExplanation()) {
|
|
return null;
|
|
}
|
|
|
|
return self::memoizeExplanation(
|
|
run: $run,
|
|
variant: 'governance_operator_explanation',
|
|
resolver: fn (): ?OperatorExplanationPattern => $fresh
|
|
? app(ArtifactTruthPresenter::class)->forOperationRunFresh($run)?->operatorExplanation
|
|
: app(ArtifactTruthPresenter::class)->forOperationRun($run)?->operatorExplanation,
|
|
fresh: $fresh,
|
|
);
|
|
}
|
|
|
|
private static function memoizeGuidance(
|
|
OperationRun $run,
|
|
string $variant,
|
|
callable $resolver,
|
|
bool $fresh = false,
|
|
): ?string {
|
|
$key = DerivedStateKey::fromModel(DerivedStateFamily::OperationUxGuidance, $run, $variant);
|
|
|
|
/** @var ?string $value */
|
|
$value = $fresh
|
|
? self::derivedStateStore()->resolveFresh(
|
|
$key,
|
|
$resolver,
|
|
DerivedStateFamily::OperationUxGuidance->defaultFreshnessPolicy(),
|
|
DerivedStateFamily::OperationUxGuidance->allowsNegativeResultCache(),
|
|
)
|
|
: self::derivedStateStore()->resolve(
|
|
$key,
|
|
$resolver,
|
|
DerivedStateFamily::OperationUxGuidance->defaultFreshnessPolicy(),
|
|
DerivedStateFamily::OperationUxGuidance->allowsNegativeResultCache(),
|
|
);
|
|
|
|
return $value;
|
|
}
|
|
|
|
private static function memoizeExplanation(
|
|
OperationRun $run,
|
|
string $variant,
|
|
callable $resolver,
|
|
bool $fresh = false,
|
|
): mixed {
|
|
$key = DerivedStateKey::fromModel(DerivedStateFamily::OperationUxExplanation, $run, $variant);
|
|
|
|
return $fresh
|
|
? self::derivedStateStore()->resolveFresh(
|
|
$key,
|
|
$resolver,
|
|
DerivedStateFamily::OperationUxExplanation->defaultFreshnessPolicy(),
|
|
DerivedStateFamily::OperationUxExplanation->allowsNegativeResultCache(),
|
|
)
|
|
: self::derivedStateStore()->resolve(
|
|
$key,
|
|
$resolver,
|
|
DerivedStateFamily::OperationUxExplanation->defaultFreshnessPolicy(),
|
|
DerivedStateFamily::OperationUxExplanation->allowsNegativeResultCache(),
|
|
);
|
|
}
|
|
|
|
private static function derivedStateStore(): RequestScopedDerivedStateStore
|
|
{
|
|
return app(RequestScopedDerivedStateStore::class);
|
|
}
|
|
}
|