## Spec 178 — Operations Lifecycle Alignment & Cross-Surface Truth Consistency Härtet die Run-Lifecycle-Wahrheit und Cross-Surface-Konsistenz über alle zentralen Operator-Flächen hinweg. ### Kern-Änderungen **Lifecycle Truth Alignment** - Einheitliche stale/stuck-Semantik zwischen Tenant-, Workspace-, Admin- und System-Surfaces - `OperationRunFreshnessState` wird konsistent über alle Widgets und Seiten propagiert - Gemeinsame Problem-Klassen-Trennung: `terminal_follow_up` vs. `active_stale_attention` **BulkOperationProgress Freshness** - Overlay zeigt nur noch `healthyActive()` Runs statt alle aktiven Runs - Likely-stale Runs halten das Polling nicht mehr künstlich aktiv - Terminal Runs verschwinden zeitnah aus dem Progress-Overlay **Decision Zone im Run Detail** - Stale/reconciled Attention in der primären Decision-Hierarchie - Klare Antworten: aktiv? stale? reconciled? nächster Schritt? - Artifact-reiche Runs behalten Lifecycle-Truth vor Deep-Diagnostics **Cross-Surface Link-Continuity** - Dashboard → Operations Hub → Run Detail erzählen dieselbe Geschichte - Notifications referenzieren korrekte Problem-Klasse - Workspace/Tenant-Attention verlinken problemklassengerecht **System-Plane Fixes** - `/system/ops/failures` 500-Error behoben (panel-sichere Artifact-URLs) - System-Stuck/Failures zeigen reconciled stale lineage ### Weitere Fixes - Inventory auth guard bereinigt (Gate statt ad-hoc Facades) - Browser-Smoke-Tests stabilisiert (DOM-Assertions statt fragile Klicks) - Test-Assertion-Drift für Verification/Lifecycle-Texte korrigiert ### Test-Ergebnis Full Suite: **3269 passed**, 8 skipped, 0 failed ### Spec-Artefakte - `specs/178-ops-truth-alignment/spec.md` - `specs/178-ops-truth-alignment/plan.md` - `specs/178-ops-truth-alignment/tasks.md` - `specs/178-ops-truth-alignment/research.md` - `specs/178-ops-truth-alignment/data-model.md` - `specs/178-ops-truth-alignment/quickstart.md` - `specs/178-ops-truth-alignment/contracts/operations-truth-alignment.openapi.yaml` Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #209
148 lines
4.8 KiB
PHP
148 lines
4.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Models\OperationRun;
|
|
use App\Models\PlatformUser;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Support\Auth\PlatformCapabilities;
|
|
use App\Support\OperationRunOutcome;
|
|
use App\Support\OperationRunStatus;
|
|
use App\Support\System\SystemOperationRunLinks;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
use Tests\Feature\Concerns\BuildsGovernanceArtifactTruthFixtures;
|
|
|
|
uses(RefreshDatabase::class, BuildsGovernanceArtifactTruthFixtures::class);
|
|
|
|
it('forbids failures page when platform.operations.view is missing', function () {
|
|
$platformUser = PlatformUser::factory()->create([
|
|
'capabilities' => [
|
|
PlatformCapabilities::ACCESS_SYSTEM_PANEL,
|
|
],
|
|
'is_active' => true,
|
|
]);
|
|
|
|
$this->actingAs($platformUser, 'platform')
|
|
->get('/system/ops/failures')
|
|
->assertForbidden();
|
|
});
|
|
|
|
it('prefilters failures page to failed runs', function () {
|
|
$failedRun = OperationRun::factory()->create([
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Failed->value,
|
|
'type' => 'inventory_sync',
|
|
'context' => [
|
|
'reconciliation' => [
|
|
'reconciled_at' => now()->toIso8601String(),
|
|
'reason' => 'run.infrastructure_timeout_or_abandonment',
|
|
'reason_code' => 'run.infrastructure_timeout_or_abandonment',
|
|
'source' => 'failed_callback',
|
|
],
|
|
],
|
|
]);
|
|
|
|
$succeededRun = OperationRun::factory()->create([
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Succeeded->value,
|
|
'type' => 'inventory_sync',
|
|
]);
|
|
|
|
$platformUser = PlatformUser::factory()->create([
|
|
'capabilities' => [
|
|
PlatformCapabilities::ACCESS_SYSTEM_PANEL,
|
|
PlatformCapabilities::OPERATIONS_VIEW,
|
|
],
|
|
'is_active' => true,
|
|
]);
|
|
|
|
$this->actingAs($platformUser, 'platform')
|
|
->get('/system/ops/failures')
|
|
->assertSuccessful()
|
|
->assertSee('Failed operations')
|
|
->assertSee('Show all operations')
|
|
->assertSee('Automatically reconciled')
|
|
->assertSee(SystemOperationRunLinks::view($failedRun))
|
|
->assertDontSee(SystemOperationRunLinks::view($succeededRun));
|
|
});
|
|
|
|
it('renders governance artifact failures without resolving tenant artifact routes on the system panel', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$initiator = User::factory()->create();
|
|
|
|
$evidenceRun = $this->makeArtifactTruthRun(
|
|
tenant: $tenant,
|
|
type: 'tenant.evidence.snapshot.generate',
|
|
attributes: [
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Failed->value,
|
|
'failure_summary' => [
|
|
['code' => 'operation.failed', 'message' => 'Evidence generation failed'],
|
|
],
|
|
],
|
|
);
|
|
|
|
$evidenceSnapshot = $this->makeArtifactTruthEvidenceSnapshot($tenant, [
|
|
'operation_run_id' => (int) $evidenceRun->getKey(),
|
|
]);
|
|
|
|
$reviewRun = $this->makeArtifactTruthRun(
|
|
tenant: $tenant,
|
|
type: 'tenant.review.compose',
|
|
attributes: [
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Failed->value,
|
|
'failure_summary' => [
|
|
['code' => 'operation.failed', 'message' => 'Review composition failed'],
|
|
],
|
|
],
|
|
);
|
|
|
|
$review = $this->makeArtifactTruthReview(
|
|
tenant: $tenant,
|
|
user: $initiator,
|
|
snapshot: $evidenceSnapshot,
|
|
reviewOverrides: [
|
|
'operation_run_id' => (int) $reviewRun->getKey(),
|
|
],
|
|
);
|
|
|
|
$packRun = $this->makeArtifactTruthRun(
|
|
tenant: $tenant,
|
|
type: 'tenant.review_pack.generate',
|
|
attributes: [
|
|
'status' => OperationRunStatus::Completed->value,
|
|
'outcome' => OperationRunOutcome::Failed->value,
|
|
'failure_summary' => [
|
|
['code' => 'operation.failed', 'message' => 'Review pack generation failed'],
|
|
],
|
|
],
|
|
);
|
|
|
|
$this->makeArtifactTruthReviewPack(
|
|
tenant: $tenant,
|
|
user: $initiator,
|
|
snapshot: $evidenceSnapshot,
|
|
review: $review,
|
|
packOverrides: [
|
|
'operation_run_id' => (int) $packRun->getKey(),
|
|
],
|
|
);
|
|
|
|
$platformUser = PlatformUser::factory()->create([
|
|
'capabilities' => [
|
|
PlatformCapabilities::ACCESS_SYSTEM_PANEL,
|
|
PlatformCapabilities::OPERATIONS_VIEW,
|
|
],
|
|
'is_active' => true,
|
|
]);
|
|
|
|
$this->actingAs($platformUser, 'platform')
|
|
->get('/system/ops/failures')
|
|
->assertSuccessful()
|
|
->assertSee('Evidence snapshot generation')
|
|
->assertSee('Review composition')
|
|
->assertSee('Review pack generation');
|
|
});
|