ahmido
1655cc481e
## Summary - migrate provider connections to the canonical three-dimension state model: lifecycle via `is_enabled`, consent via `consent_status`, and verification via `verification_status` - remove legacy provider status and health badge paths, update admin and system directory surfaces, and align onboarding, consent callback, verification, resolver, and mutation flows with the new model - add the Spec 188 artifact set, schema migrations, guard coverage, and expanded provider-state tests across admin, system, onboarding, verification, and rendering paths ## Verification - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/Auth/SystemPanelAuthTest.php tests/Feature/Filament/TenantGlobalSearchLifecycleScopeTest.php tests/Feature/ProviderConnections/ProviderConnectionEnableDisableTest.php tests/Feature/ProviderConnections/ProviderConnectionTruthCleanupSpec179Test.php` - integrated browser smoke: validated admin provider list/detail/edit, tenant provider summary, system directory tenant detail, provider-connection search exclusion, and cleaned up the temporary smoke record afterward ## Filament / implementation notes - Livewire v4.0+ compliance: preserved; this change targets Filament v5 on Livewire v4 and does not introduce older APIs - Provider registration location: unchanged; Laravel 11+ panel providers remain registered in `bootstrap/providers.php` - Globally searchable resources: `ProviderConnectionResource` remains intentionally excluded from global search; tenant global search remains enabled and continues to resolve to view pages - Destructive actions: no new destructive action surface was introduced without confirmation or authorization; existing capability checks continue to gate provider mutations - Asset strategy: unchanged; no new Filament assets were added, so deploy behavior for `php artisan filament:assets` remains unchanged - Testing plan covered: system auth, tenant global search, provider lifecycle enable/disable behavior, and provider truth cleanup cutover behavior Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #219
85 lines
2.9 KiB
PHP
85 lines
2.9 KiB
PHP
<?php
|
|
|
|
use App\Models\ProviderConnection;
|
|
use App\Models\ProviderCredential;
|
|
use App\Models\Tenant;
|
|
use App\Services\Providers\MicrosoftGraphOptionsResolver;
|
|
use App\Services\Providers\ProviderConfigurationRequiredException;
|
|
use App\Support\Providers\ProviderReasonCodes;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
|
|
it('throws when no default provider connection exists', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
$resolver = app(MicrosoftGraphOptionsResolver::class);
|
|
|
|
$call = fn (): array => $resolver->resolveForTenant($tenant);
|
|
|
|
expect($call)->toThrow(ProviderConfigurationRequiredException::class);
|
|
|
|
try {
|
|
$call();
|
|
} catch (ProviderConfigurationRequiredException $exception) {
|
|
expect($exception->reasonCode)->toBe(ProviderReasonCodes::ProviderConnectionMissing);
|
|
expect($exception->provider)->toBe('microsoft');
|
|
expect($exception->tenantId)->toBe((int) $tenant->getKey());
|
|
}
|
|
});
|
|
|
|
it('throws when default provider connection needs consent', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
ProviderConnection::factory()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'workspace_id' => $tenant->workspace_id,
|
|
'provider' => 'microsoft',
|
|
'is_default' => true,
|
|
'consent_status' => 'required',
|
|
]);
|
|
|
|
$resolver = app(MicrosoftGraphOptionsResolver::class);
|
|
|
|
$call = fn (): array => $resolver->resolveForTenant($tenant);
|
|
|
|
expect($call)->toThrow(ProviderConfigurationRequiredException::class);
|
|
|
|
try {
|
|
$call();
|
|
} catch (ProviderConfigurationRequiredException $exception) {
|
|
expect($exception->reasonCode)->toBe(ProviderReasonCodes::ProviderConsentMissing);
|
|
}
|
|
});
|
|
|
|
it('builds graph options from default provider connection credentials', function (): void {
|
|
$tenant = Tenant::factory()->create();
|
|
|
|
$connection = ProviderConnection::factory()->dedicated()->consentGranted()->create([
|
|
'tenant_id' => $tenant->getKey(),
|
|
'workspace_id' => $tenant->workspace_id,
|
|
'provider' => 'microsoft',
|
|
'entra_tenant_id' => 'entra-tenant-id',
|
|
'is_default' => true,
|
|
]);
|
|
|
|
ProviderCredential::factory()->create([
|
|
'provider_connection_id' => $connection->getKey(),
|
|
'type' => 'client_secret',
|
|
'payload' => [
|
|
'client_id' => 'client-id',
|
|
'client_secret' => 'client-secret',
|
|
],
|
|
]);
|
|
|
|
$resolver = app(MicrosoftGraphOptionsResolver::class);
|
|
|
|
$options = $resolver->resolveForTenant($tenant, ['query' => ['a' => 'b']]);
|
|
|
|
expect($options['tenant'])->toBe('entra-tenant-id');
|
|
expect($options['client_id'])->toBe('client-id');
|
|
expect($options['client_secret'])->toBe('client-secret');
|
|
expect($options['client_request_id'])->toBeString()->not->toBeEmpty();
|
|
expect($options['query'])->toBe(['a' => 'b']);
|
|
});
|