## Summary - replace the legacy Tenant and TenantMembership core models with ManagedEnvironment and ManagedEnvironmentMembership - propagate the managed environment naming and key changes across Filament resources, pages, controllers, jobs, models, and supporting runtime paths - add feature 279 spec artifacts and focused managed-environment test coverage for model behavior, route binding, panel context, authorization, and legacy guardrails ## Validation - `cd apps/platform && ./vendor/bin/sail artisan test --compact tests/Feature/ManagedEnvironment/LegacyTenantCoreGuardTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentAuthorizationTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentPanelContextTest.php tests/Feature/ManagedEnvironment/ManagedEnvironmentRouteBindingTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentContextResolverTest.php tests/Unit/ManagedEnvironment/ManagedEnvironmentModelTest.php` - `cd apps/platform && ./vendor/bin/sail bin pint --dirty --format agent` ## Notes - branch pushed from commit `1123b122` - browser smoke test file was added but not run in this pass Co-authored-by: Ahmed Darrazi <ahmed.darrazi@live.de> Reviewed-on: #335
116 lines
3.3 KiB
PHP
116 lines
3.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace App\Support\Concerns;
|
|
|
|
use App\Models\ManagedEnvironment;
|
|
use App\Support\WorkspaceIsolation\WorkspaceIsolationViolation;
|
|
use Illuminate\Database\Eloquent\Model;
|
|
|
|
trait DerivesWorkspaceIdFromTenant
|
|
{
|
|
public static function bootDerivesWorkspaceIdFromTenant(): void
|
|
{
|
|
static::creating(static function (Model $model): void {
|
|
self::enforceWorkspaceBinding($model);
|
|
});
|
|
|
|
static::updating(static function (Model $model): void {
|
|
self::enforceWorkspaceBinding($model);
|
|
});
|
|
}
|
|
|
|
private static function enforceWorkspaceBinding(Model $model): void
|
|
{
|
|
$tenantId = self::resolveTenantId($model);
|
|
|
|
self::ensureTenantIdIsImmutable($model, $tenantId);
|
|
|
|
$tenantWorkspaceId = self::resolveTenantWorkspaceId($model, $tenantId);
|
|
|
|
$workspaceId = $model->getAttribute('workspace_id');
|
|
|
|
if ($workspaceId === null || $workspaceId === '') {
|
|
$model->setAttribute('workspace_id', $tenantWorkspaceId);
|
|
|
|
return;
|
|
}
|
|
|
|
if (! is_numeric($workspaceId)) {
|
|
throw WorkspaceIsolationViolation::workspaceMismatch(
|
|
class_basename($model),
|
|
$tenantId,
|
|
$tenantWorkspaceId,
|
|
0,
|
|
);
|
|
}
|
|
|
|
$workspaceId = (int) $workspaceId;
|
|
|
|
if ($workspaceId !== $tenantWorkspaceId) {
|
|
throw WorkspaceIsolationViolation::workspaceMismatch(
|
|
class_basename($model),
|
|
$tenantId,
|
|
$tenantWorkspaceId,
|
|
$workspaceId,
|
|
);
|
|
}
|
|
}
|
|
|
|
private static function resolveTenantId(Model $model): int
|
|
{
|
|
$tenantId = $model->getAttribute('managed_environment_id');
|
|
|
|
if (! is_numeric($tenantId)) {
|
|
throw WorkspaceIsolationViolation::missingTenantId(class_basename($model));
|
|
}
|
|
|
|
return (int) $tenantId;
|
|
}
|
|
|
|
private static function ensureTenantIdIsImmutable(Model $model, int $tenantId): void
|
|
{
|
|
if (! $model->exists || ! $model->isDirty('managed_environment_id')) {
|
|
return;
|
|
}
|
|
|
|
$originalTenantId = $model->getOriginal('managed_environment_id');
|
|
|
|
if (! is_numeric($originalTenantId)) {
|
|
return;
|
|
}
|
|
|
|
$originalTenantId = (int) $originalTenantId;
|
|
|
|
if ($originalTenantId === $tenantId) {
|
|
return;
|
|
}
|
|
|
|
throw WorkspaceIsolationViolation::tenantImmutable(
|
|
class_basename($model),
|
|
$originalTenantId,
|
|
$tenantId,
|
|
);
|
|
}
|
|
|
|
private static function resolveTenantWorkspaceId(Model $model, int $tenantId): int
|
|
{
|
|
$tenant = $model->relationLoaded('tenant') ? $model->getRelation('tenant') : null;
|
|
|
|
if (! $tenant instanceof ManagedEnvironment || (int) $tenant->getKey() !== $tenantId) {
|
|
$tenant = ManagedEnvironment::query()->withTrashed()->find($tenantId);
|
|
}
|
|
|
|
if (! $tenant instanceof ManagedEnvironment) {
|
|
throw WorkspaceIsolationViolation::tenantNotFound(class_basename($model), $tenantId);
|
|
}
|
|
|
|
if (! is_numeric($tenant->workspace_id)) {
|
|
throw WorkspaceIsolationViolation::tenantWorkspaceMissing(class_basename($model), $tenantId);
|
|
}
|
|
|
|
return (int) $tenant->workspace_id;
|
|
}
|
|
}
|