ahmido
bc846d7c5c
Summary Adds a tenant-scoped Entra Groups “Directory Cache” to enable DB-only group name resolution across the app (no render-time Graph calls), plus sync runs + observability. What’s included • Entra Groups cache • New entra_groups storage (tenant-scoped) for group metadata (no memberships). • Retention semantics: groups become stale / retained per spec (no hard delete on first miss). • Group Sync Runs • New “Group Sync Runs” UI (list + detail) with tenant isolation (403 on cross-tenant access). • Manual “Sync Groups” action: creates/reuses a run, dispatches job, DB notification with “View run” link. • Scheduled dispatcher command wired in console.php. • DB-only label resolution (US3) • Shared EntraGroupLabelResolver with safe fallback Unresolved (…last8) and UUID guarding. • Refactors to prefer cached names (no typeahead / no live Graph) in: • Tenant RBAC group selects • Policy version assignments widget • Restore results + restore wizard group mapping labels Safety / Guardrails • No render-time Graph calls: fail-hard guard test verifies UI paths don’t call GraphClientInterface during page render. • Tenant isolation & authorization: policies + scoped queries enforced (cross-tenant access returns 403, not 404). • Data minimization: only group metadata is cached (no membership/owners). Tests / Verification • Added/updated tests under tests/Feature/DirectoryGroups and tests/Unit/DirectoryGroups: • Start sync → run record + job dispatch + upserts • Retention purge semantics • Scheduled dispatch wiring • Render-time Graph guard • UI/resource access isolation • Ran: • ./vendor/bin/pint --dirty • ./vendor/bin/sail artisan test tests/Feature/DirectoryGroups • ./vendor/bin/sail artisan test tests/Unit/DirectoryGroups Notes / Follow-ups • UI polish remains (picker/lookup UX, consistent progress widget/toasts across modules, navigation grouping). • pr-gate checklist still has non-blocking open items (mostly UX/ops polish); requirements gate is green. Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.local> Reviewed-on: #57
62 lines
1.8 KiB
PHP
62 lines
1.8 KiB
PHP
<?php
|
|
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use App\Services\BulkOperationService;
|
|
use Illuminate\Foundation\Testing\RefreshDatabase;
|
|
|
|
uses(RefreshDatabase::class);
|
|
test('bulk operation service updates progress counters', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$user = User::factory()->create();
|
|
|
|
$service = app(BulkOperationService::class);
|
|
$run = $service->createRun($tenant, $user, 'policy', 'delete', [1, 2, 3], 3);
|
|
|
|
$service->start($run);
|
|
|
|
$service->recordSuccess($run);
|
|
$service->recordSkipped($run);
|
|
$service->recordFailure($run, '3', 'Test failure');
|
|
|
|
$run->refresh();
|
|
|
|
expect($run->status)->toBe('running')
|
|
->and($run->processed_items)->toBe(3)
|
|
->and($run->succeeded)->toBe(1)
|
|
->and($run->skipped)->toBe(1)
|
|
->and($run->failed)->toBe(1)
|
|
->and($run->failures)->toBeArray()
|
|
->and($run->failures)->toHaveCount(1);
|
|
});
|
|
|
|
test('bulk operation run total_items is at least the item_ids count', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$user = User::factory()->create();
|
|
|
|
$service = app(BulkOperationService::class);
|
|
$run = $service->createRun($tenant, $user, 'inventory', 'sync', ['a', 'b', 'c', 'd'], 1);
|
|
|
|
expect($run->total_items)->toBe(4);
|
|
});
|
|
|
|
test('bulk operation completion clamps total_items up to processed_items', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$user = User::factory()->create();
|
|
|
|
$service = app(BulkOperationService::class);
|
|
$run = $service->createRun($tenant, $user, 'inventory', 'sync', ['only-one'], 1);
|
|
|
|
$service->start($run);
|
|
$service->recordSuccess($run);
|
|
$service->recordSuccess($run);
|
|
|
|
$run->refresh();
|
|
expect($run->processed_items)->toBe(2)->and($run->total_items)->toBe(1);
|
|
|
|
$service->complete($run);
|
|
$run->refresh();
|
|
|
|
expect($run->total_items)->toBe(2);
|
|
});
|