Summary Consolidates the “Tenant Operate Hub” work (Spec 085) and the follow-up adjustments from the 086 session merge into a single branch ready to merge into dev. Primary focus: stabilize Ops/Operate Hub UX flows, tighten/align authorization semantics, and make the full Sail test suite green. Key Changes Ops UX / Verification Readonly members can view verification operation runs (reports) while starting verification remains restricted. Normalized failure reason-code handling and aligned UX expectations with the provider reason-code taxonomy. Onboarding wizard UX “Start verification” CTA is hidden while a verification run is active; “Refresh” is shown during in-progress runs. Treats provider_permission_denied as a blocking reason (while keeping legacy compatibility). Test + fixture hardening Standardized use of default provider connection fixtures in tests where sync/restore flows require it. Fixed multiple Filament URL/tenant-context test cases to avoid 404s and reduce tenancy routing brittleness. Policy sync / restore safety Enrollment configuration type collision classification tests now exercise the real sync path (with required provider connection present). Restore edge-case safety tests updated to reflect current provider-connection requirements. Testing vendor/bin/sail artisan test --compact (green) vendor/bin/sail bin pint --dirty (green) Notes Includes merged 086 session work already (no separate PR needed). Co-authored-by: Ahmed Darrazi <ahmeddarrazi@ebc83aaa-d947-4a08-b88e-bd72ac9645f7.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@MacBookPro.fritz.box> Co-authored-by: Ahmed Darrazi <ahmeddarrazi@adsmac.fritz.box> Reviewed-on: #103
63 lines
2.1 KiB
PHP
63 lines
2.1 KiB
PHP
<?php
|
|
|
|
namespace App\Services\Inventory;
|
|
|
|
use App\Models\InventoryItem;
|
|
use App\Models\OperationRun;
|
|
use App\Models\Tenant;
|
|
use App\Services\BackupScheduling\PolicyTypeResolver;
|
|
use Illuminate\Database\Eloquent\Collection;
|
|
|
|
class InventoryMissingService
|
|
{
|
|
public function __construct(
|
|
private readonly InventorySelectionHasher $selectionHasher,
|
|
private readonly PolicyTypeResolver $policyTypeResolver,
|
|
) {}
|
|
|
|
/**
|
|
* @param array<string, mixed> $selectionPayload
|
|
* @return array{latestRun: OperationRun|null, missing: Collection<int, InventoryItem>, lowConfidence: bool}
|
|
*/
|
|
public function missingForSelection(Tenant $tenant, array $selectionPayload): array
|
|
{
|
|
$normalized = $this->selectionHasher->normalize($selectionPayload);
|
|
$normalized['policy_types'] = $this->policyTypeResolver->filterRuntime($normalized['policy_types']);
|
|
$selectionHash = $this->selectionHasher->hash($normalized);
|
|
|
|
$latestRun = OperationRun::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->where('type', 'inventory.sync')
|
|
->where('status', 'completed')
|
|
->where('context->selection_hash', $selectionHash)
|
|
->orderByDesc('completed_at')
|
|
->orderByDesc('id')
|
|
->first();
|
|
|
|
if (! $latestRun) {
|
|
return [
|
|
'latestRun' => null,
|
|
'missing' => InventoryItem::query()->whereRaw('1 = 0')->get(),
|
|
'lowConfidence' => true,
|
|
];
|
|
}
|
|
|
|
$missingQuery = InventoryItem::query()
|
|
->where('tenant_id', $tenant->getKey())
|
|
->whereIn('policy_type', $normalized['policy_types'])
|
|
->where(function ($query) use ($latestRun): void {
|
|
$query
|
|
->whereNull('last_seen_operation_run_id')
|
|
->orWhere('last_seen_operation_run_id', '!=', $latestRun->getKey());
|
|
});
|
|
|
|
$lowConfidence = $latestRun->outcome !== 'succeeded';
|
|
|
|
return [
|
|
'latestRun' => $latestRun,
|
|
'missing' => $missingQuery->get(),
|
|
'lowConfidence' => $lowConfidence,
|
|
];
|
|
}
|
|
}
|